pacioli 0.0.5 → 0.0.6

data/lib/pacioli/company.rb

@@ -43,34 +43,30 @@ module Pacioli
       self.companyable = companyable_object
     end
 
-    def add_asset_account(options={})
-      account = AssetAccount.create!(options)
+    def add_account(account)
       self.accounts << account
+      CompanyValidator.for(self).execute
       account
     end
 
+    def add_asset_account(options={})
+      add_account AssetAccount.new(options)
+    end
+
     def add_equity_account(options={})
-      account = EquityAccount.create!(options)
-      self.accounts << account
-      account
+      add_account EquityAccount.new(options)
     end
 
     def add_liability_account(options={})
-      account = LiabilityAccount.create!(options)
-      self.accounts << account
-      account
+      add_account LiabilityAccount.new(options)
     end
 
     def add_income_account(options={})
-      account = IncomeAccount.create!(options)
-      self.accounts << account
-      account
+      add_account IncomeAccount.new(options)
     end
 
     def add_expense_account(options={})
-      account = ExpenseAccount.create!(options)
-      self.accounts << account
-      account
+      add_account ExpenseAccount.new(options)
     end
 
     def record_journal_entry(&block)

data/lib/pacioli/exception.rb

@@ -1,4 +1,5 @@
 module Pacioli
   class AccountsNotBalancedException < Exception; end
   class PostingRuleNotBalancedException < Exception; end
+  class CompanyAccountException < Exception; end
 end

data/lib/pacioli/validations/company_validator.rb

@@ -0,0 +1,20 @@
+module Pacioli
+  class CompanyValidator
+    attr_accessor :company
+
+    def self.for(company)
+      validator = new
+      validator.company = company
+      validator
+    end
+
+    def execute
+      validate_accounts
+    end
+
+    def validate_accounts
+      accounts = self.company.accounts.map(&:name)
+      raise Pacioli::CompanyAccountException, "The company has multiple accounts with the same name: '#{accounts.detect{ |e| accounts.count(e) > 1 }}' already exists" unless accounts.detect{ |e| accounts.count(e) > 1 }.nil?
+    end
+  end
+end

data/lib/pacioli/version.rb

@@ -1,3 +1,3 @@
 module Pacioli
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/lib/pacioli.rb

@@ -32,3 +32,4 @@ require "pacioli/exception"
 
 require "pacioli/validations/journal_entry_validator"
 require "pacioli/validations/posting_rule_validator"
+require "pacioli/validations/company_validator"

data/spec/lib/pacioli/account_spec.rb

@@ -38,6 +38,14 @@ describe Pacioli::Account do
       account.should be_income
     end
 
+    it "should raise an error when trying to add multiple accounts with the same name" do
+      @company.add_income_account name: "Sales"
+      lambda {
+        @company.add_income_account name: "Sales"
+      }.should raise_error(Pacioli::CompanyAccountException, "The company has multiple accounts with the same name: 'Sales' already exists")
+      
+    end
+
   end
   
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pacioli
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2013-01-17 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70108660640340 !ruby/object:Gem::Requirement
+  requirement: &70282124011920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70108660640340
+  version_requirements: *70282124011920
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70108660639840 !ruby/object:Gem::Requirement
+  requirement: &70282124011420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70108660639840
+  version_requirements: *70282124011420
 - !ruby/object:Gem::Dependency
   name: i18n
-  requirement: &70108660639420 !ruby/object:Gem::Requirement
+  requirement: &70282124011000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70108660639420
+  version_requirements: *70282124011000
 - !ruby/object:Gem::Dependency
   name: combustion
-  requirement: &70108660638880 !ruby/object:Gem::Requirement
+  requirement: &70282124010460 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,7 +54,7 @@ dependencies:
         version: 0.3.1
   type: :development
   prerelease: false
-  version_requirements: *70108660638880
+  version_requirements: *70282124010460
 description: A double-entry bookkeeping system for Ruby on Rails
 email:
 - jeffmess@gmail.com
@@ -86,6 +86,7 @@ files:
 - lib/pacioli/liability_account.rb
 - lib/pacioli/posting_rule.rb
 - lib/pacioli/transaction.rb
+- lib/pacioli/validations/company_validator.rb
 - lib/pacioli/validations/journal_entry_validator.rb
 - lib/pacioli/validations/posting_rule_validator.rb
 - lib/pacioli/version.rb