p8-metric_fu 0.8.0.16 → 0.8.2

data/README

@@ -23,13 +23,13 @@ You must have Rcov and Flog installed to get coverage and flog reports.  Metric_
 ****Usage****
 
 Out of the box metrics provides these tasks:
-rake metrics:all                  # Generate coverage, cyclomatic complexity, flog, flay, railroad and churn reports
+rake metrics:all                  
+rake metrics:all_with_migrate     # Useful for continuous integration
 rake metrics:churn                # Which files change the most
 rake metrics:coverage             # Generate and open coverage report
 rake metrics:coverage:clean       # Delete aggregate coverage data.
 rake metrics:coverage:clobber_do  # Remove rcov products for do
 rake metrics:coverage:do          # RCov task to generate report
-rake metrics:flay                 # Generate code duplication report with flay
 rake metrics:flog:all             # Generate and open flog report
 rake metrics:flog:clean           # Delete aggregate flog data.
 rake metrics:flog:controllers     # Flog code in app/controllers
@@ -37,12 +37,8 @@ rake metrics:flog:custom          # Generate a flog report from specified direct
 rake metrics:flog:helpers         # Flog code in app/helpers
 rake metrics:flog:lib             # Flog code in lib
 rake metrics:flog:models          # Flog code in app/models
-rake metrics:reek                 # A code smell report using Reek
 rake metrics:saikuro              # A cyclomatic complexity report using Saikuro
-
-Rails projects also have the following tasks:
-
-rake metrics:stats                 # A stats report
+rake metrics:stats                # A stats report
 
 See below for more detail on the individual tasks.  It's recommended to use CruiseControl.rb to set up a metrics build.  See the CruiseControl.rb online docs for more info on how to set up cc.rb and, once you've got that figured out, change the cruise_config.rb file inside your project to have these lines:
 
@@ -52,78 +48,32 @@ project.scheduler.polling_interval = 24.hours
 Which will check for updates every 24 hours and run all the metrics rake tasks (migrating your test db first).  The output will be visible from an individual build's detail page.
 
 
-****Notes on configuration****
-
-Metric_fu can be customized to your liking by adding the following to your Rakefile
-
-MetricFu::Configuration.run do |config|
-  #define which metrics you want to use
-  config.metrics          = [:coverage, :flog]
-  config.churn    = { :start_date => lambda{ 3.months.ago } }  
-  config.coverage = { :test_files => ['test/**/test_*.rb'] }
-  config.flog     = { :dirs_to_flog => ['cms/app', 'cms/lib']  }
-  config.flay     = { :dirs_to_flay => ['cms/app', 'cms/lib']  }  
-  config.saikuro  = { "--warn_cyclo" => "3", "--error_cyclo" => "4" }
-end
-
-
 ****Notes on metrics:coverage****
 
 When creating a coverage report, metric_fu runs all the tests in the test folder and specs in spec folder using Rcov.
-You can configure the coverage test files pattern:
-  config.coverage[:test_files] = ['test/**/test_*.rb']
-
-The default value is ['test/**/*_test.rb', 'spec/**/*_spec.rb']
 
 
 ****Notes on metrics:saikuro****
 
-Saikuro is bundled with metric_fu so you don't have to install it.  Look at the SAIKURO_README (or the internet) for more documentation on Saikuro.  If you wish to change the options Saikuro is run with, then set this constant in your configuration:
-
-  config.saikuro = { "--warn_cyclo" => "3", "--error_cyclo" => "4" }
-
-config.saikuro is a hash that gets merged with the default options hash.  The above example will set the warn_cyclo to 3 and the error_cyclo to 4 (which is way too low -- it's just an example) instructing Saikuro to flag methods with a higher cyclomatic complexity in it's report.
-
-If you want to have Saikuro look at multiple folders you can put something like this in your configuration:
-
-  config.saikuro = {"--input_directory" => '"cms/app | cms/lib"'}
+Saikuro is bundled with metric_fu so you don't have to install it.  Look at the SAIKURO_README (or the internet) for more documentation on Saikuro.  If you wish to change the options Saikuro is run with, then set this constant in your Rakefile:
+                  
+MetricFu::SAIKURO_OPTIONS = { "--warn_cyclo" => "3", "--error_cyclo" => "4" }
 
+MetricFu::SAIKURO_OPTIONS is a hash that gets merged with the default options hash.  The above example will set the warn_cyclo to 3 and the error_cyclo to 4 (which is way too low -- it's just an example) instructing Saikuro to flag methods with a higher cyclomatic complexity in it's report.
 
-****Notes on metrics:flay****
-
-Flay analyzes ruby code for structural similarities. 
-You can configure which directories need to be flayed.
-The defaults are 'lib' for non Rails projects and ['app', 'lib'] for Rails projects.
-
-  config.flay[:dirs_to_flay] = ['cms/app', 'cms/lib']
+If you want to have Saikuro look at multiple folders you can put something like this in your rakefile:
+MetricFu::SAIKURO_OPTIONS = {"--input_directory" => '"cms/app | cms/lib"'}
 
 
 ****Notes on metrics:flog****
 
 Flog is another way of measuring complexity (or tortured code as the Flog authors like to put it).  You should check out the awesome, and a little scary, Flog website for more info.
-'rake metrics:flog:custom' allows you to specify a custom set of directories to Flog (in your configuration).
-The defaults are 'lib' for non Rails projects and ['app', 'lib'] for Rails projects.
-
-  config.flog[:dirs_to_flog] = ['cms/app', 'cms/lib']
-
-
-****Notes on metrics:reek****
 
-Reek detects common code smells in ruby code.
-You can configure which directories need to be checked.
-The defaults are 'lib' for non Rails projects and ['app', 'lib'] for Rails projects.
+'rake metrics:flog:custom' allows you to specify a custom set of directories to Flog (in your rakefile) like so:
 
-  config.reek[:dirs_to_reek] = ['cms/app', 'cms/lib']
+MetricFu::DIRECTORIES_TO_FLOG = ['cms/app', 'cms/lib']
 
 
-****Notes on metrics:roodi****
-
-Roodi parses your Ruby code and warns you about design issues you have based on the checks that is has configured.
-You can configure which directories need to be checked.
-The defaults are 'lib' for non Rails projects and ['app', 'lib'] for Rails projects.
-
-    config.roodi[:dirs_to_roodi] = ['cms/app', 'cms/lib']
-
 ****Notes on metrics:stats****
 
 This is just 'rake stats' for Rails put into a file.  On my projects I like to be able to look at CruiseControl and get stats about the app at different points in time.
@@ -133,13 +83,17 @@ This is just 'rake stats' for Rails put into a file.  On my projects I like to b
 
 Files that change a lot in your project may be bad a sign.  This task uses "svn log" to identify those files and put them in a report.  The default is to start counting changes from the beginning of your project, which might be too far back so you can change like so:
 
-  config.churn = { :start_date => lambda{ 3.months.ago } }
+MetricFu::CHURN_OPTIONS = { :start_date => lambda{3.months.ago} }
 
 The Proc is there because '3.months.ago' only works when after the Rails Environment is loaded (and Rails extends Fixnum) which I didn't want to do every time you run a rake task.
 
 You can also change the minimum churn count like so:
 
-  config.churn = { :minimum_churn_count => 3 }
+MetricFu::CHURN_OPTIONS = { :minimum_churn_count => 3 }
+
+If you use git, then tell churn about it:
+
+MetricFu::CHURN_OPTIONS = {:scm => :git}
 
 
 ****Thanks****

data/Rakefile

@@ -8,4 +8,4 @@ Spec::Rake::SpecTask.new(:spec) do |t|
   t.spec_files = FileList['spec/**/*_spec.rb']
 end
 
-task :default => [:"metrics:all"]
+task :default => [:"metrics:all"]

data/lib/metric_fu/base.rb

@@ -1,4 +1,3 @@
-require 'erb'
 module MetricFu
 
   TEMPLATE_DIR = File.join(File.dirname(__FILE__), '..', 'templates')
@@ -7,38 +6,23 @@ module MetricFu
 
   if RAILS
     CODE_DIRS = ['app', 'lib']
-    DEFAULT_METRICS = [:coverage, :churn, :flog, :flay, :reek, :roodi, :stats, :saikuro ]
   else
     CODE_DIRS = ['lib']
-    DEFAULT_METRICS = [:coverage, :churn, :flog, :flay, :reek, :roodi, :saikuro ]
-  end 
+  end
 
   module Base
-    
-    ######################################################################
-    # Base class for report Generators
-    #
     class Generator
 
-      def initialize(options={})
-        @base_dir = self.class.metric_dir
-      end
-
-      def self.metric_dir
-        File.join(BASE_DIRECTORY, template_name)        
+      def initialize(base_dir, options={})
+        @base_dir = base_dir
       end
-      
-      def self.template_name
-        self.to_s.split('::').last.downcase
-      end      
 
-      def self.generate_report(options={})
-        FileUtils.mkdir_p(metric_dir, :verbose => false) unless File.directory?(metric_dir)
-        self.new(options).generate_report
+      def self.generate_report(base_dir, options={})
+        self.new(base_dir, options).generate_report
       end
 
-      def save_html(content, file='index.html')
-        open("#{@base_dir}/#{file}", "w") do |f|
+      def save_html(content, file='index')
+        open("#{@base_dir}/#{file}.html", "w") do |f|
           f.puts content
         end
       end
@@ -51,22 +35,11 @@ module MetricFu
         analyze
         html = ERB.new(File.read(template_file)).result(binding)
       end
-      
-      def template_name
-        self.class.template_name
-      end
 
       def template_file
         File.join(MetricFu::TEMPLATE_DIR, "#{template_name}.html.erb")
-      end      
-      
-      ########################
-      # Template methods
-      
-      def inline_css(css)
-	      open(File.join(MetricFu::TEMPLATE_DIR, css)) { |f| f.read }      
       end
-      
+
       def link_to_filename(name, line = nil)
         filename = File.expand_path(name)
         if PLATFORM['darwin']
@@ -75,85 +48,6 @@ module MetricFu
           %{<a href="file://#{filename}">#{name}</a>}
         end
       end
-      
-      def cycle(first_value, second_value, iteration)
-        return first_value if iteration % 2 == 0
-        return second_value
-      end      
-    end
-  end
-  
-  class << self
-    # The Configuration instance used to configure the Rails environment
-    def configuration
-      @@configuration ||= Configuration.new
-    end
-
-    def churn
-      configuration.churn
-    end
-
-    def coverage
-      configuration.coverage
-    end
-
-    def flay
-      configuration.flay
-    end
-
-    def flog
-      configuration.flog
-    end
-
-    def metrics
-      configuration.metrics
-    end
-
-    def open_in_browser?
-      PLATFORM['darwin'] && !ENV['CC_BUILD_ARTIFACTS']
-    end
-    
-    def saikuro
-      configuration.saikuro
-    end
-
-    def reek
-      configuration.reek
-    end    
-
-    def roodi
-      configuration.roodi
-    end
-
-  end
-  
-  class Configuration
-    attr_accessor :churn, :coverage, :flay, :flog, :metrics, :reek, :roodi, :saikuro
-    def initialize
-      raise "Use config.churn instead of MetricFu::CHURN_OPTIONS" if defined? ::MetricFu::CHURN_OPTIONS
-      raise "Use config.flog[:dirs_to_flog] instead of MetricFu::DIRECTORIES_TO_FLOG" if defined? ::MetricFu::DIRECTORIES_TO_FLOG
-      raise "Use config.saikuro instead of MetricFu::SAIKURO_OPTIONS" if defined? ::MetricFu::SAIKURO_OPTIONS      
-      reset      
-    end
-    
-    def self.run()  
-      yield MetricFu.configuration
-    end
-    
-    def reset
-      @churn    =  {}
-      @coverage = { :test_files => ['test/**/*_test.rb', 'spec/**/*_spec.rb'] }
-      @flay     = { :dirs_to_flay => CODE_DIRS}
-      @flog     = { :dirs_to_flog => CODE_DIRS}
-      @reek     = { :dirs_to_reek => CODE_DIRS}
-      @roodi    = { :dirs_to_roodi => CODE_DIRS}
-      @metrics          = DEFAULT_METRICS
-      @saikuro  = {}
-    end
-    
-    def saikuro=(options)
-      raise "saikuro need to be a Hash" unless options.is_a?(Hash)
-      @saikuro = options
     end
   end
 end

data/lib/metric_fu/churn.rb

@@ -1,14 +1,8 @@
 module MetricFu
-  
-  def self.generate_churn_report
-    Churn.generate_report(MetricFu.churn)
-    system("open #{Churn.metric_dir}/index.html") if open_in_browser?
-  end
-  
   class Churn < Base::Generator
 
-    def initialize(options={})
-      @base_dir = File.join(MetricFu::BASE_DIRECTORY, template_name)
+    def initialize(base_dir, options={})
+      @base_dir = base_dir
       if File.exist?(".git")
         @source_control = Git.new(options[:start_date])
       elsif File.exist?(".svn")
@@ -24,6 +18,11 @@ module MetricFu
       @changes = parse_log_for_changes.reject! {|file, change_count| change_count < @minimum_churn_count}
     end
 
+    # should be dynamically read from the class
+    def template_name
+      'churn'
+    end
+
     private
 
     def parse_log_for_changes

data/lib/metric_fu/flay_reporter.rb

@@ -0,0 +1,17 @@
+require 'erb'
+
+module MetricFu
+  class FlayReporter < Base::Generator
+
+    def analyze
+      files_to_flay = MetricFu::CODE_DIRS.map{|dir| Dir[File.join(dir, "**/*.rb")] }
+      output = `flay #{files_to_flay.join(" ")}`
+      @matches = output.chomp.split("\n\n").map{|m| m.split("\n  ") }
+    end
+
+    def template_name
+      'flay'
+    end
+
+  end
+end

data/lib/metric_fu/flog_reporter/base.rb

@@ -0,0 +1,49 @@
+module MetricFu::FlogReporter
+
+  SCORE_FORMAT = "%0.2f"
+
+  class InvalidFlog < RuntimeError
+  end
+
+  class Base
+    MODULE_NAME = "([A-Za-z]+)+"
+    METHOD_NAME = "#([a-z0-9]+_?)+\\??\\!?"
+    SCORE = "\\d+\\.\\d+"
+
+    METHOD_NAME_RE = Regexp.new("#{MODULE_NAME}#{METHOD_NAME}")
+    SCORE_RE = Regexp.new(SCORE)
+
+    METHOD_LINE_RE = Regexp.new("#{MODULE_NAME}#{METHOD_NAME}:\\s\\(#{SCORE}\\)")
+    OPERATOR_LINE_RE = Regexp.new("\\s+(#{SCORE}):\\s(.*)$")
+
+    class << self
+      def cycle(first_value, second_value, iteration)
+        return first_value if iteration % 2 == 0
+        return second_value
+      end
+
+      def parse(text)
+        score = text[/\w+ = (\d+\.\d+)/, 1]
+        return nil unless score
+        page = Page.new(score)
+
+        text.each_line do |method_line|
+          if METHOD_LINE_RE =~ method_line and
+             method_name = method_line[METHOD_NAME_RE] and
+             score = method_line[SCORE_RE]
+             page.scanned_methods << ScannedMethod.new(method_name, score)
+          end
+
+          if OPERATOR_LINE_RE =~ method_line and
+             operator = method_line[OPERATOR_LINE_RE, 2] and
+             score = method_line[SCORE_RE]
+             raise InvalidFlog if page.scanned_methods.empty?
+             page.scanned_methods.last.operators << Operator.new(score, operator)
+          end
+        end
+
+        page
+      end
+    end
+  end
+end

data/lib/metric_fu/flog_reporter/generator.rb

@@ -0,0 +1,39 @@
+module MetricFu::FlogReporter
+  class Generator < MetricFu::Base::Generator
+    def generate_report
+      flog_hashes = []
+      Dir.glob("#{@base_dir}/**/*.txt").each do |filename|
+        begin
+          page = Base.parse(open(filename, "r") { |f| f.read })
+        rescue InvalidFlog
+          puts "Invalid flog for #{filename}"
+          next
+        end
+
+        next unless page
+
+        unless MetricFu::MD5Tracker.file_already_counted?(filename)
+          generate_page(filename, page)
+        end
+        flog_hashes << { :path => File.basename(filename, ".txt") + '.html',
+                 :page => page }
+      end
+
+      generate_index(flog_hashes)
+    end
+
+    def generate_page(filename, page)
+      save_html(page.to_html, File.basename(filename, ".txt"))
+    end
+
+    # should be dynamically read from the class
+    def template_name
+      'flog'
+    end
+
+    def generate_index(flog_hashes)
+      html = ERB.new(File.read(template_file)).result(binding)
+      save_html(html)
+    end
+  end
+end

data/lib/metric_fu/flog_reporter/operator.rb

@@ -0,0 +1,10 @@
+module MetricFu::FlogReporter
+  class Operator
+    attr_accessor :score, :operator
+
+    def initialize(score, operator)
+      @score = score.to_f
+      @operator = operator
+    end
+  end
+end