p3p 1.2.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1efe1a6e863dfcfc6f7150b817ac34356565baac
-  data.tar.gz: a3707c343bcb3148b7c1b4f966ee1ec0930678dd
+  metadata.gz: 3fe7161ea20b91f5643bcb51b021b47063e3bba7
+  data.tar.gz: b0657f69d032e2a580ccbbe838b5dae81834d135
 SHA512:
-  metadata.gz: e72a87707679893d1a54395cdbe7f53c2707e2bdc89d190637da05c3d90c21e046dcde048c18a000a3d66381d28f3eb43fe76814fb4e4a58341901df0ae5b1e3
-  data.tar.gz: 395a8cc7c2ca967b5f639f60e9ff8e3720db698dc43e00144454f9887260f1c1a33c28017be7fe0caee4814f6cf626a26a8c07961009a6ba9c4512e6b889a0de
+  metadata.gz: b47f01017764bee0781788bd79f56a02c769da27428cb3633513d43c4040c31ec356f24938801593306ef6c62560c0a4d26bf120aaae831064c023cefc11a91c
+  data.tar.gz: 93d08285e402a4c29cbfba0038a97866df5f92c4122af85855ff5f1896d5f6fe3e123643a2cee3b20683380c704ee6e8e7d39cfab7d9ae0cfe6275a2728b0055

data/.rspec

@@ -0,0 +1,3 @@
+--color
+--order random
+--format documentation

data/.travis.yml

@@ -0,0 +1,18 @@
+script: rspec --order=random --format=documentation --color
+bundler_args: --without development
+env:
+  global:
+    - JRUBY_OPTS="$JRUBY_OPTS --debug"
+gemfile:
+  - Gemfile
+language: ruby
+rvm:
+  - 2.2.6
+  - 2.3.3
+  - 2.4.0
+  - ruby-head
+matrix:
+  allow_failures:
+    - rvm: ruby-head
+  fast_finish: true
+sudo: false

data/Gemfile

@@ -1,4 +1,12 @@
 source 'https://rubygems.org'
 
-# Specify your gem's dependencies in p3p.gemspec
+gem 'rack', '>= 1.6.2'
+
+group :test do
+  gem 'coveralls', '>= 0.8.19', :require => false
+  gem 'rspec', '~> 3.1'
+  gem 'simplecov', '>= 0.12.0', :require => false
+  gem 'mime-types', '~> 3.1', :platforms => [:jruby, :ruby_18]
+end
+
 gemspec

data/Rakefile

@@ -1 +1,7 @@
 require 'bundler/gem_tasks'
+
+desc "Run RSpec with code coverage"
+task :coverage do
+  `COVERAGE=true rspec`
+  `open coverage/index.html`
+end

data/lib/p3p/version.rb

@@ -1,4 +1,4 @@
 # Gem version information
 module P3P
-  VERSION = '1.2.0'
+  VERSION = '2.0.0'
 end

data/p3p.gemspec

@@ -17,6 +17,5 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ['lib']
 
-  gem.add_dependency 'rack'
-  gem.add_development_dependency 'rspec', '~> 3.1.0'
+  gem.add_dependency 'rack', '>= 1.6.2'
 end

data/spec/configuration_spec.rb

@@ -1,33 +1,29 @@
 require 'spec_helper'
 
-shared_examples 'it returns configured P3P header' do |header, http_verb|
-  it "should return custom P3P headers in the case of a #{http_verb} request" do
-    headers  = {'Content-Type' => 'text/html'}
-    app      = lambda { |_env| [200, headers, []] }
-    request  = Rack::MockRequest.env_for('/', :lint => true, :fatal => true, :method => http_verb)
-    response = P3P::Middleware.new(app).call(request)
+describe P3P::Configuration do
+  subject { P3P::Configuration.new }
+  let(:default_header) { P3P::Configuration::DEFAULT_HEADER }
 
-    expect(response[1]).to include('P3P' => header)
+  describe '::DEFAULT_HEADER' do
+    it 'should contain a default header' do
+      expect(default_header).to_not be_nil
+    end
   end
-end
-
-describe P3P do
-  describe '#configure' do
-    let(:header) { 'Fake p3p header' }
 
-    before do
-      P3P.configure do |config|
-        config.header = @header
-      end
+  describe '.initialize' do
+    it 'should call set_default_header!' do
+      # TODO:  Check call over value
+      expect(subject.header).to eq default_header
     end
+  end
+
+  describe '.set_default_header!' do
+    it 'should set the default header' do
+      subject.header = 'foo'
+      expect(subject.header).to eq 'foo'
 
-    it_should_behave_like 'it returns configured P3P header', @header, 'GET'
-    it_should_behave_like 'it returns configured P3P header', @header, 'POST'
-    it_should_behave_like 'it returns configured P3P header', @header, 'PUT'
-    it_should_behave_like 'it returns configured P3P header', @header, 'DELETE'
-    it_should_behave_like 'it returns configured P3P header', @header, 'HEAD'
-    it_should_behave_like 'it returns configured P3P header', @header, 'OPTIONS'
-    it_should_behave_like 'it returns configured P3P header', @header, 'TRACE'
-    it_should_behave_like 'it returns configured P3P header', @header, 'CONNECT'
+      subject.set_default_header!
+      expect(subject.header).to eq default_header
+    end
   end
 end

data/spec/middleware_spec.rb

@@ -2,34 +2,22 @@ require 'spec_helper'
 
 shared_examples 'it returns P3P headers' do |http_verb|
   it "should return default P3P headers in the case of a #{http_verb} request" do
-    headers  = {'Content-Type' => 'text/html'}
-    app      = lambda { |_env| [200, headers, []] }
-    request  = Rack::MockRequest.env_for('/', :lint => true, :fatal => true, :method => http_verb)
+    p3p_header = Time.now.to_i
+    headers    = {'Content-Type' => 'text/html'}
+    app        = lambda { |_env| [200, headers, []] }
+    request    = Rack::MockRequest.env_for('/', :lint => true, :fatal => true, :method => http_verb)
+
+    P3P.configure { |c| c.header = p3p_header }
+
     response = P3P::Middleware.new(app).call(request)
 
-    expect(response[1]).to include('P3P' => P3P::Configuration::DEFAULT_HEADER)
+    expect(response[1]).to include('P3P' => p3p_header)
   end
-end
+ end
 
 describe P3P::Middleware do
-  describe '.initialize' do
-    it 'should set the default header' do
-      expect_any_instance_of(P3P::Configuration).to receive(:set_default_header!)
-      P3P.configure { |_config| }
-    end
-  end
-
-  describe '.set_default_header!' do
-    it 'should set the default header' do
-      header = 'abc123'
-      default_header = P3P::Configuration::DEFAULT_HEADER
-
-      P3P.configure { |c| c.header = header }
-      expect(P3P.configuration.header).to eq header
-
-      P3P.configuration.set_default_header!
-      expect(P3P.configuration.header).to eq default_header
-    end
+  after do
+    P3P.configuration.set_default_header!
   end
 
   it_should_behave_like 'it returns P3P headers', 'GET'

data/spec/p3p_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe P3P do
+  describe '#configuration' do
+    subject { P3P.configuration }
+
+    it 'should instantiate P3P::Configuration' do
+      expect(subject.class).to eq P3P::Configuration
+    end
+
+    it 'should memoize P3P::Configuration' do
+      expect(subject).to eq P3P.configuration
+    end
+  end
+
+  describe '#configure' do
+    it 'should yield :configuration' do
+      expect { |b| P3P.configure(&b) }.to yield_control
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,12 +1,10 @@
+if ENV['COVERAGE']
+  require 'simplecov'
+  SimpleCov.start
+elsif ENV['CI']
+  require 'coveralls'
+  Coveralls.wear!
+end
+
 require 'rack'
 require 'p3p'
-
-RSpec.configure do |config|
-  config.color = true
-  config.formatter = :documentation
-  config.order = :random
-
-  config.after(:each) do
-    P3P.configuration.set_default_header!
-  end
-end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: p3p
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Tom Milewski
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-19 00:00:00.000000000 Z
+date: 2017-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -16,28 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.6.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.1.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 1.6.2
 description: Inserts P3P header
 email:
 - tmilewski@gmail.com
@@ -46,7 +32,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
 - ".rubocop.yml"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -59,6 +47,7 @@ files:
 - p3p.gemspec
 - spec/configuration_spec.rb
 - spec/middleware_spec.rb
+- spec/p3p_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/tmilewski/p3p
 licenses: []
@@ -79,7 +68,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Inserts P3P headers to allow cookies to be utilized in iframe scenarios with
@@ -87,5 +76,5 @@ summary: Inserts P3P headers to allow cookies to be utilized in iframe scenarios
 test_files:
 - spec/configuration_spec.rb
 - spec/middleware_spec.rb
+- spec/p3p_spec.rb
 - spec/spec_helper.rb
-has_rdoc: