oxy 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9784707b90cf512ed97acba79d0d29d9f0070c69
-  data.tar.gz: d7d65afac275082ca68af9c34cb4f3f5535aca28
+  metadata.gz: 133482c185d5c3b0b85ba9df02736fc0dc7b4f3f
+  data.tar.gz: 4bc927cbc1af9815462035935d5bb1987fe0399b
 SHA512:
-  metadata.gz: da49d443e355df2bc01a9c08929e7d9d43c07ba576d500c75e75be5fe9a2a44b362260f33442c4c90b6a544ddd72ac7d4e431ed5d1491a75fdfaf1dbbd8bba77
-  data.tar.gz: 8a853e8723e0c1779b91ad7d1bc8cb97fbea225f023d62ddc1166a4c24107f027d5c1d2cbec189fe8d533e741ff456de18ad8aabe7c8455ccc670ab26610859d
+  metadata.gz: 1d22d73afebae6a67d779e3805b3e2aa6d606db60ce1ebaec3bfbcf52c581d6f1c26aa6881449059ad278798a1f845c70c554e4fd8716c049be33f92e04ac86f
+  data.tar.gz: 54f3fd0904bd39e1a674700593c153802a0f2cdd81119d5edf20cc74ff6c86ea5ad95032304841e37dedfffcd971d5d03647e286f417cb31c71e79729190b636

data/lib/oxy/middleware/rsvp.rb

@@ -6,6 +6,10 @@ class Oxy::RSVP
   # The set of allowed fields. Requests that do not have fields
   # present in this list will not be eligible to be enqueued.
   ELIGIBLE_FORMS_FIELDS = ['email_address', 'first_name', 'last_name']
+  # Email validation regex
+  EMAIL_REGEX_VALIDATOR = /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\z/i
+  # First and last name allowed string length
+  ALLOWED_STRING_LENGTH = 60
 
   # ctor.
   def initialize(app, logger = $stderr)
@@ -23,6 +27,8 @@ class Oxy::RSVP
       # first ask deflect layer for permission to process the request
       resp = @deflect.call(env)
       return resp if forbidden(resp)
+      # next ask validation layer for permission to process the request
+      # ...
       # enqueue background processing for valid submissions only
       Threaded.enqueue(Subscribe, req.POST, @logger) if valid_form(req.POST)
       # redirect anyways
@@ -38,12 +44,28 @@ private
     resp[0] == 403
   end
 
-  # only request with eligible form fields are valid
+  def validate_email(value)
+    # match or no match?
+    EMAIL_REGEX_VALIDATOR.match?(value)
+  end
+
+  def validate_length(value)
+    value.nil? || value.empty? || value.length <= ALLOWED_STRING_LENGTH
+  end
+
+  # only request with eligible and valid form fields are allowed
   def valid_form(form)
     unless form.all? { |key, _| ELIGIBLE_FORMS_FIELDS.include?(key) }
       @logger.write("[RSVP]: Received an invalid form ~> #{form.inspect}\n")
       return false
     end
+    # validate email address
+    return false unless validate_email(form["email_address"])
+    # validate first name
+    return false unless validate_length(form["first_name"])
+    # validate last name
+    return false unless validate_length(form["last_name"])
+    # form is allowed
     return true
   end
 end

data/lib/oxy/version.rb

@@ -1,3 +1,3 @@
 module Oxy
-  VERSION = "0.1.7"
+  VERSION = "0.1.8"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: oxy
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Pavel Tsurbeleu
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-22 00:00:00.000000000 Z
+date: 2017-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack