oxm 0.1.0 → 0.1.1

data/CHANGELOG.markdown

@@ -1,10 +1,12 @@
+### 0.1.1 / 2011/09/19
+* Bug fix: OXM::Object#compact! incorrectly nilified elements
 ### 0.1.0 / 2011/09/19
 * Disclaimer: Not compatible to the previous versions
-** Removed: OXM::Object#cdata, OXM::Object#text, OXM::Object#text=
-** Added: OXM::Object#content, OXM::Object#content=
-** Changed: OXM::Object#to_s never returns nil
-** Changed: OXM::Object#compact! removes empty elements as well (no text value, no attributes at all)
-** Fix: Allows assignment of nil/empty string as element values
+ * Removed: OXM::Object#cdata, OXM::Object#text, OXM::Object#text=
+ * Added: OXM::Object#content, OXM::Object#content=
+ * Changed: OXM::Object#to_s never returns nil
+ * Changed: OXM::Object#compact! removes empty elements as well (no text value, no attributes at all)
+ * Fix: Allows assignment of nil/empty string as element values
 
 ### 0.0.2 / 2011/09/15
 * OXM::Object#compact! added

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.1.1

data/lib/oxm/object.rb

@@ -130,9 +130,9 @@ module OXM
       @data  = nil
     end
 
-    # @return [Boolean] Return if the element is empty (no text value and no attributes)
+    # @return [Boolean] Return if the element is empty (no text value, no attributes and no child elements)
     def empty?
-      self.to_s.empty? && self.attributes.empty?
+      self.to_s.empty? && self.attributes.empty? && self.elements.empty?
     end
 
   private

data/test/test_oxm.rb

@@ -134,11 +134,16 @@ class TestOxm < Test::Unit::TestCase
         <volume></volume>
         <volume></volume>
       </item>
+      <item dept="nil">
+        <volume><extra></extra></volume>
+        <volume><extra>2</extra></volume>
+        <volume></volume>
+      </item>
     </container>
     EOF
 
     items = OXM.from_xml(str, 'container/item')
-    assert_equal 5, items.length
+    assert_equal 6, items.length
 
     items[0].compact!
     assert_equal Array, items[0].volume.class
@@ -162,5 +167,10 @@ class TestOxm < Test::Unit::TestCase
     assert_raise(NoMethodError) {
       items[4].voll
     }
+
+    items[5].compact!
+    assert_equal Array, items[5].volume.class
+    assert_equal 2, items[5].volume.length
+
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: oxm
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2011-09-19 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
-  requirement: &2160763840 !ruby/object:Gem::Requirement
+  requirement: &2152887260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *2160763840
+  version_requirements: *2152887260
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &2160755540 !ruby/object:Gem::Requirement
+  requirement: &2152885680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: 1.5.0
   type: :runtime
   prerelease: false
-  version_requirements: *2160755540
+  version_requirements: *2152885680
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &2160753840 !ruby/object:Gem::Requirement
+  requirement: &2152884200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *2160753840
+  version_requirements: *2152884200
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &2160752880 !ruby/object:Gem::Requirement
+  requirement: &2152883120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: 1.6.4
   type: :development
   prerelease: false
-  version_requirements: *2160752880
+  version_requirements: *2152883120
 - !ruby/object:Gem::Dependency
   name: rcov
-  requirement: &2160752000 !ruby/object:Gem::Requirement
+  requirement: &2152882320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,7 +65,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160752000
+  version_requirements: *2152882320
 description: A tiny Object-XML-Mapper using Nokogiri SAX parser
 email: junegunn.c@gmail.com
 executables: []
@@ -102,7 +102,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1267901525051297766
+      hash: 723951543129720723
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: