ovirt-engine-sdk 4.1.9 → 4.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 818f63a1a783df790fbf5fc8f254ded435a90ac8
-  data.tar.gz: 2a51cba1a01c8a8c62647ee2c256f3a1684684a4
+  metadata.gz: a13beb0ec3a34430b8b4c88dbca6733bd11ff2df
+  data.tar.gz: 5e7347f6145b8a9427cf4d1acd479d41707794c4
 SHA512:
-  metadata.gz: 9445021acbd41f225e882fe6ef4fc537bd97972ef9c978f0b4ed50c4b91ac53cb6f4ec5b116a7abef4f183b4764a94737fc730453278b094ff86aa7c72fbf5cd
-  data.tar.gz: 43097db69c7d043a11e147a55739e40a37455e4c2738714f451ca4b8f752a375f26be5575042643747fcd848f2639a4e6aa2c96ef4368175667e8d18bec15839
+  metadata.gz: d0f2fb994b048d4928a3291c8c4b77fd4e464ac9906d9782f51f3c44047be82099c132b95a224e1a6c39f7fca4132c4e970027c49edbc1842ff070d20b3fb093
+  data.tar.gz: 7082c6f72b823c3d9adcaa537bb5bd265e7754d5f57b76a920e06f1cd604f61da5623556106b27fbeeb74b37d16ef00edb5f1223aec8843bae7f7416f3e21626

data/CHANGES.adoc

@@ -2,6 +2,27 @@
 
 This document describes the relevant changes between releases of the SDK.
 
+== 4.1.10 / Nov 3 2017
+
+Update to model 4.1.40:
+
+* Add `image` parameter to `HostService.upgrade`
+  https://bugzilla.redhat.com/1488434[#1488434].
+
+New features:
+
+* Add support for cookies.
+
+* Add `connect_timeout` parameter
+  https://bugzilla.redhat.com/1508944[#1508944].
+
+Bug fixes:
+
+* Check the types of the `HttpClient` constructor parameters.
+
+* Require `redhat-rpm-config` for building
+  https://bugzilla.redhat.com/1505427[#1505427].
+
 == 4.1.9 / Oct 13 2017
 
 Update to model 4.1.39:

data/README.adoc

@@ -41,16 +41,41 @@ CentOS:
   gcc \
   libcurl-devel \
   libxml2-devel \
-  ruby-devel
+  redhat-rpm-config \
+  ruby \
+  ruby-devel \
+  rubygems \
+  rubygems-devel
+
+NOTE: The installation of the `ruby`, `ruby-devel`, `rubygems` and
+`rubygems-devel` packages is necessary if you are going to use the Ruby
+version included in your distribution. If you are using tools like
+`rbenv` or `rvm` then this is not necessary.
 
 If you are using distributions like Debian, or Ubuntu:
 
   # apt-get --assume-yes install \
   gcc \
+  libcurl4-openssl-dev \
   libxml2-dev \
-  libcurl-dev \
+  ruby \
   ruby-dev
 
+NOTE: The installation of the `ruby` and `ruby-dev` packages is
+necessary if you are going to use the Ruby version included in your
+distribution. If you are using tools like `rbenv` or `rvm` then this is
+not necessary.
+
+Some Linux distributions, like Debian and Ubuntu, provide multiple
+versions of `libcurl`, compiled with support for different TLS
+libraries: OpenSSL, NSS and GnuTLS. Currently the SDK only supports
+OpenSSL, so make sure that you have that version of `libcurl` installed.
+For example, in Ubuntu 16.04 if you have the NSS version installed, you
+will have to remove it and then install the OpenSSL version:
+
+  # apt-get --assume-yes remove libcurl4-nss-dev
+  # apt-get --assume-yes install libcurl4-openssl-dev
+
 NOTE: The examples above use the `dnf` command, which is the default in
 Fedora 24. In CentOS 7 you may need to use the `yum` command, as `dnf`
 is optional.

data/ext/ovirtsdk4c/ov_http_client.c

@@ -50,7 +50,8 @@ static VALUE PROXY_PASSWORD_SYMBOL;
 static VALUE PROXY_URL_SYMBOL;
 static VALUE PROXY_USERNAME_SYMBOL;
 static VALUE TIMEOUT_SYMBOL;
-static VALUE USERNAME_SYMBOL;
+static VALUE CONNECT_TIMEOUT_SYMBOL;
+static VALUE COOKIES_SYMBOL;
 
 /* Method identifiers: */
 static ID COMPARE_BY_IDENTITY_ID;
@@ -154,6 +155,7 @@ static void ov_http_client_free(void* vptr) {
     /* Release the resources used by libcurl: */
     if (ptr->handle != NULL) {
         curl_multi_cleanup(ptr->handle);
+        curl_share_cleanup(ptr->share);
         ptr->handle = NULL;
     }
 
@@ -162,6 +164,7 @@ static void ov_http_client_free(void* vptr) {
     ov_string_free(ptr->proxy_url);
     ov_string_free(ptr->proxy_username);
     ov_string_free(ptr->proxy_password);
+    ov_string_free(ptr->cookies);
 
     /* Free this object: */
     xfree(ptr);
@@ -186,6 +189,21 @@ static VALUE ov_http_client_alloc(VALUE klass) {
     ov_http_client_object* ptr;
 
     ptr = ALLOC(ov_http_client_object);
+    ptr->handle = NULL;
+    ptr->share = NULL;
+    ptr->log = Qnil;
+    ptr->pending = Qnil;
+    ptr->completed = Qnil;
+    ptr->compress = false;
+    ptr->debug = false;
+    ptr->insecure = false;
+    ptr->ca_file = NULL;
+    ptr->proxy_url = NULL;
+    ptr->proxy_username = NULL;
+    ptr->proxy_password = NULL;
+    ptr->timeout = 0;
+    ptr->connect_timeout = 0;
+    ptr->cookies = NULL;
     return TypedData_Wrap_Struct(klass, &ov_http_client_type, ptr);
 }
 
@@ -466,7 +484,13 @@ static VALUE ov_http_client_initialize(int argc, VALUE* argv, VALUE self) {
 
     /* Get the value of the 'ca_file' parameter: */
     opt = rb_hash_aref(opts, CA_FILE_SYMBOL);
-    ptr->ca_file = ov_string_dup(opt);
+    if (NIL_P(opt)) {
+        ptr->ca_file = NULL;
+    }
+    else {
+        Check_Type(opt, T_STRING);
+        ptr->ca_file = ov_string_dup(opt);
+    }
 
     /* Get the value of the 'insecure' parameter: */
     opt = rb_hash_aref(opts, INSECURE_SYMBOL);
@@ -490,17 +514,45 @@ static VALUE ov_http_client_initialize(int argc, VALUE* argv, VALUE self) {
         ptr->timeout = NUM2INT(opt);
     }
 
+    /* Get the value of the 'connect_timeout' parameter: */
+    opt = rb_hash_aref(opts, CONNECT_TIMEOUT_SYMBOL);
+    if (NIL_P(opt)) {
+        ptr->connect_timeout = 0;
+    }
+    else {
+        Check_Type(opt, T_FIXNUM);
+        ptr->connect_timeout = NUM2INT(opt);
+    }
+
     /* Get the value of the 'proxy_url' parameter: */
     opt = rb_hash_aref(opts, PROXY_URL_SYMBOL);
-    ptr->proxy_url = ov_string_dup(opt);
+    if (NIL_P(opt)) {
+        ptr->proxy_url = NULL;
+    }
+    else {
+        Check_Type(opt, T_STRING);
+        ptr->proxy_url = ov_string_dup(opt);
+    }
 
     /* Get the value of the 'proxy_username' parameter: */
     opt = rb_hash_aref(opts, PROXY_USERNAME_SYMBOL);
-    ptr->proxy_username = ov_string_dup(opt);
+    if (NIL_P(opt)) {
+        ptr->proxy_username = NULL;
+    }
+    else {
+        Check_Type(opt, T_STRING);
+        ptr->proxy_username = ov_string_dup(opt);
+    }
 
     /* Get the value of the 'proxy_password' parameter: */
     opt = rb_hash_aref(opts, PROXY_PASSWORD_SYMBOL);
-    ptr->proxy_password = ov_string_dup(opt);
+    if (NIL_P(opt)) {
+        ptr->proxy_password = NULL;
+    }
+    else {
+        Check_Type(opt, T_STRING);
+        ptr->proxy_password = ov_string_dup(opt);
+    }
 
     /* Get the value of the 'log' parameter: */
     opt = rb_hash_aref(opts, LOG_SYMBOL);
@@ -526,6 +578,20 @@ static VALUE ov_http_client_initialize(int argc, VALUE* argv, VALUE self) {
         connections = NUM2LONG(opt);
     }
 
+   /* Get the value of the 'cookies' parameter. If it is a string it will be used as the path of the file where the
+      cookies will be stored. If it is any other thing it will be treated as a boolean flag indicating if cookies
+      should be enabled but not loaded/saved from/to any file. */
+    opt = rb_hash_aref(opts, COOKIES_SYMBOL);
+    if (TYPE(opt) == T_STRING) {
+        ptr->cookies = ov_string_dup(opt);
+    }
+    else if (RTEST(opt)) {
+        ptr->cookies = ov_string_dup(rb_str_new2(""));
+    }
+    else {
+        ptr->cookies = NULL;
+    }
+
     /* Create the hash that contains the transfers are pending an completed. Both use the identity of the request
        as key. */
     ptr->completed = rb_funcall(rb_hash_new(), COMPARE_BY_IDENTITY_ID, 0);
@@ -534,7 +600,16 @@ static VALUE ov_http_client_initialize(int argc, VALUE* argv, VALUE self) {
     /* Create the libcurl multi handle: */
     ptr->handle = curl_multi_init();
     if (ptr->handle == NULL) {
-        rb_raise(ov_error_class, "Can't create libcurl object");
+        rb_raise(ov_error_class, "Can't create libcurl multi object");
+    }
+
+    /* Create the libcurl share handle in order to share cookie data: */
+    ptr->share = curl_share_init();
+    if (ptr->share == NULL) {
+        rb_raise(ov_error_class, "Can't create libcurl share object");
+    }
+    if (ptr->cookies != NULL) {
+        curl_share_setopt(ptr->share, CURLSHOPT_SHARE, CURL_LOCK_DATA_COOKIE);
     }
 
     /* Enable pipelining: */
@@ -722,6 +797,14 @@ static void ov_http_client_prepare_handle(ov_http_client_object* client_ptr, ov_
     VALUE header;
     VALUE url;
     int timeout;
+    int connect_timeout;
+
+    /* Configure sharing of cookies with other handlers created by the client: */
+    curl_easy_setopt(handle, CURLOPT_SHARE, client_ptr->share);
+    if (client_ptr->cookies != NULL && strlen(client_ptr->cookies) > 0) {
+        curl_easy_setopt(handle, CURLOPT_COOKIEFILE, client_ptr->cookies);
+        curl_easy_setopt(handle, CURLOPT_COOKIEJAR, client_ptr->cookies);
+    }
 
     /* Configure TLS parameters: */
     if (client_ptr->insecure) {
@@ -732,13 +815,20 @@ static void ov_http_client_prepare_handle(ov_http_client_object* client_ptr, ov_
         curl_easy_setopt(handle, CURLOPT_CAINFO, client_ptr->ca_file);
     }
 
-    /* Configure the timeout: */
+    /* Configure the total timeout: */
     timeout = client_ptr->timeout;
     if (!NIL_P(request_ptr->timeout)) {
         timeout = NUM2INT(request_ptr->timeout);
     }
     curl_easy_setopt(handle, CURLOPT_TIMEOUT, timeout);
 
+    /* Configure the connect timeout: */
+    connect_timeout = client_ptr->connect_timeout;
+    if (!NIL_P(request_ptr->connect_timeout)) {
+        connect_timeout = NUM2INT(request_ptr->connect_timeout);
+    }
+    curl_easy_setopt(handle, CURLOPT_CONNECTTIMEOUT, connect_timeout);
+
     /* Configure compression of responses (setting the value to zero length string means accepting all the
        compression types that libcurl supports): */
     if (client_ptr->compress) {
@@ -941,19 +1031,20 @@ void ov_http_client_define(void) {
     rb_define_method(ov_http_client_class, "wait",  ov_http_client_wait,  1);
 
     /* Define the symbols: */
-    CA_FILE_SYMBOL        = ID2SYM(rb_intern("ca_file"));
-    COMPRESS_SYMBOL       = ID2SYM(rb_intern("compress"));
-    CONNECTIONS_SYMBOL    = ID2SYM(rb_intern("connections"));
-    DEBUG_SYMBOL          = ID2SYM(rb_intern("debug"));
-    INSECURE_SYMBOL       = ID2SYM(rb_intern("insecure"));
-    LOG_SYMBOL            = ID2SYM(rb_intern("log"));
-    PASSWORD_SYMBOL       = ID2SYM(rb_intern("password"));
-    PIPELINE_SYMBOL       = ID2SYM(rb_intern("pipeline"));
-    PROXY_PASSWORD_SYMBOL = ID2SYM(rb_intern("proxy_password"));
-    PROXY_URL_SYMBOL      = ID2SYM(rb_intern("proxy_url"));
-    PROXY_USERNAME_SYMBOL = ID2SYM(rb_intern("proxy_username"));
-    TIMEOUT_SYMBOL        = ID2SYM(rb_intern("timeout"));
-    USERNAME_SYMBOL       = ID2SYM(rb_intern("username"));
+    CA_FILE_SYMBOL         = ID2SYM(rb_intern("ca_file"));
+    COMPRESS_SYMBOL        = ID2SYM(rb_intern("compress"));
+    CONNECTIONS_SYMBOL     = ID2SYM(rb_intern("connections"));
+    DEBUG_SYMBOL           = ID2SYM(rb_intern("debug"));
+    INSECURE_SYMBOL        = ID2SYM(rb_intern("insecure"));
+    LOG_SYMBOL             = ID2SYM(rb_intern("log"));
+    PASSWORD_SYMBOL        = ID2SYM(rb_intern("password"));
+    PIPELINE_SYMBOL        = ID2SYM(rb_intern("pipeline"));
+    PROXY_PASSWORD_SYMBOL  = ID2SYM(rb_intern("proxy_password"));
+    PROXY_URL_SYMBOL       = ID2SYM(rb_intern("proxy_url"));
+    PROXY_USERNAME_SYMBOL  = ID2SYM(rb_intern("proxy_username"));
+    TIMEOUT_SYMBOL         = ID2SYM(rb_intern("timeout"));
+    CONNECT_TIMEOUT_SYMBOL = ID2SYM(rb_intern("connect_timeout"));
+    COOKIES_SYMBOL         = ID2SYM(rb_intern("cookies"));
 
     /* Define the method identifiers: */
     COMPARE_BY_IDENTITY_ID = rb_intern("compare_by_identity");

data/ext/ovirtsdk4c/ov_http_client.h

@@ -28,9 +28,12 @@ extern VALUE ov_http_client_class;
 
 /* Content: */
 typedef struct {
-    /* The libcurl multi handle: */
+    /* The libcurl multi handle, used to implement multiple simultaneous requests: */
     CURLM* handle;
 
+    /* The libcurl share handle, used to share cookie data between multiple requests: */
+    CURLSH* share;
+
     /* The logger: */
     VALUE log;
 
@@ -51,6 +54,8 @@ typedef struct {
     char* proxy_username;
     char* proxy_password;
     int timeout;
+    int connect_timeout;
+    char* cookies;
 } ov_http_client_object;
 
 /* Macro to get the pointer: */

data/ext/ovirtsdk4c/ov_http_request.c

@@ -40,6 +40,7 @@ static VALUE TOKEN_SYMBOL;
 static VALUE KERBEROS_SYMBOL;
 static VALUE BODY_SYMBOL;
 static VALUE TIMEOUT_SYMBOL;
+static VALUE CONNECT_TIMEOUT_SYMBOL;
 
 static void ov_http_request_mark(void* vptr) {
     ov_http_request_object* ptr;
@@ -55,6 +56,7 @@ static void ov_http_request_mark(void* vptr) {
     rb_gc_mark(ptr->kerberos);
     rb_gc_mark(ptr->body);
     rb_gc_mark(ptr->timeout);
+    rb_gc_mark(ptr->connect_timeout);
 }
 
 static void ov_http_request_free(void* vptr) {
@@ -83,16 +85,17 @@ static VALUE ov_http_request_alloc(VALUE klass) {
     ov_http_request_object* ptr;
 
     ptr = ALLOC(ov_http_request_object);
-    ptr->method   = Qnil;
-    ptr->url      = Qnil;
-    ptr->query    = Qnil;
-    ptr->headers  = Qnil;
-    ptr->username = Qnil;
-    ptr->password = Qnil;
-    ptr->token    = Qnil;
-    ptr->kerberos = Qnil;
-    ptr->body     = Qnil;
-    ptr->timeout  = Qnil;
+    ptr->method          = Qnil;
+    ptr->url             = Qnil;
+    ptr->query           = Qnil;
+    ptr->headers         = Qnil;
+    ptr->username        = Qnil;
+    ptr->password        = Qnil;
+    ptr->token           = Qnil;
+    ptr->kerberos        = Qnil;
+    ptr->body            = Qnil;
+    ptr->timeout         = Qnil;
+    ptr->connect_timeout = Qnil;
     return TypedData_Wrap_Struct(klass, &ov_http_request_type, ptr);
 }
 
@@ -279,6 +282,24 @@ static VALUE ov_http_request_set_timeout(VALUE self, VALUE value) {
     return Qnil;
 }
 
+static VALUE ov_http_request_get_connect_timeout(VALUE self) {
+    ov_http_request_object* ptr;
+
+    ov_http_request_ptr(self, ptr);
+    return ptr->connect_timeout;
+}
+
+static VALUE ov_http_request_set_connect_timeout(VALUE self, VALUE value) {
+    ov_http_request_object* ptr;
+
+    ov_http_request_ptr(self, ptr);
+    if (!NIL_P(value)) {
+        Check_Type(value, T_FIXNUM);
+    }
+    ptr->connect_timeout = value;
+    return Qnil;
+}
+
 static VALUE ov_http_request_initialize(int argc, VALUE* argv, VALUE self) {
     VALUE opts;
 
@@ -304,6 +325,7 @@ static VALUE ov_http_request_initialize(int argc, VALUE* argv, VALUE self) {
     ov_http_request_set_token(self, rb_hash_aref(opts, TOKEN_SYMBOL));
     ov_http_request_set_body(self, rb_hash_aref(opts, BODY_SYMBOL));
     ov_http_request_set_timeout(self, rb_hash_aref(opts, TIMEOUT_SYMBOL));
+    ov_http_request_set_connect_timeout(self, rb_hash_aref(opts, CONNECT_TIMEOUT_SYMBOL));
 
     return self;
 }
@@ -317,38 +339,41 @@ void ov_http_request_define(void) {
     rb_define_method(ov_http_request_class, "initialize", ov_http_request_initialize, -1);
 
     /* Define the methods: */
-    rb_define_method(ov_http_request_class, "method",    ov_http_request_get_method,   0);
-    rb_define_method(ov_http_request_class, "method=",   ov_http_request_set_method,   1);
-    rb_define_method(ov_http_request_class, "url",       ov_http_request_get_url,      0);
-    rb_define_method(ov_http_request_class, "url=",      ov_http_request_set_url,      1);
-    rb_define_method(ov_http_request_class, "query",     ov_http_request_get_query,    0);
-    rb_define_method(ov_http_request_class, "query=",    ov_http_request_set_query,    1);
-    rb_define_method(ov_http_request_class, "headers",   ov_http_request_get_headers,  0);
-    rb_define_method(ov_http_request_class, "headers=",  ov_http_request_set_headers,  1);
-    rb_define_method(ov_http_request_class, "username",  ov_http_request_get_username, 0);
-    rb_define_method(ov_http_request_class, "username=", ov_http_request_set_username, 1);
-    rb_define_method(ov_http_request_class, "password",  ov_http_request_get_password, 0);
-    rb_define_method(ov_http_request_class, "password=", ov_http_request_set_password, 1);
-    rb_define_method(ov_http_request_class, "token",     ov_http_request_get_token,    0);
-    rb_define_method(ov_http_request_class, "token=",    ov_http_request_set_token,    1);
-    rb_define_method(ov_http_request_class, "kerberos",  ov_http_request_get_kerberos, 0);
-    rb_define_method(ov_http_request_class, "kerberos=", ov_http_request_set_kerberos, 1);
-    rb_define_method(ov_http_request_class, "body",      ov_http_request_get_body,     0);
-    rb_define_method(ov_http_request_class, "body=",     ov_http_request_set_body,     1);
-    rb_define_method(ov_http_request_class, "timeout",   ov_http_request_get_timeout,  0);
-    rb_define_method(ov_http_request_class, "timeout=",  ov_http_request_set_timeout,  1);
+    rb_define_method(ov_http_request_class, "method",           ov_http_request_get_method,          0);
+    rb_define_method(ov_http_request_class, "method=",          ov_http_request_set_method,          1);
+    rb_define_method(ov_http_request_class, "url",              ov_http_request_get_url,             0);
+    rb_define_method(ov_http_request_class, "url=",             ov_http_request_set_url,             1);
+    rb_define_method(ov_http_request_class, "query",            ov_http_request_get_query,           0);
+    rb_define_method(ov_http_request_class, "query=",           ov_http_request_set_query,           1);
+    rb_define_method(ov_http_request_class, "headers",          ov_http_request_get_headers,         0);
+    rb_define_method(ov_http_request_class, "headers=",         ov_http_request_set_headers,         1);
+    rb_define_method(ov_http_request_class, "username",         ov_http_request_get_username,        0);
+    rb_define_method(ov_http_request_class, "username=",        ov_http_request_set_username,        1);
+    rb_define_method(ov_http_request_class, "password",         ov_http_request_get_password,        0);
+    rb_define_method(ov_http_request_class, "password=",        ov_http_request_set_password,        1);
+    rb_define_method(ov_http_request_class, "token",            ov_http_request_get_token,           0);
+    rb_define_method(ov_http_request_class, "token=",           ov_http_request_set_token,           1);
+    rb_define_method(ov_http_request_class, "kerberos",         ov_http_request_get_kerberos,        0);
+    rb_define_method(ov_http_request_class, "kerberos=",        ov_http_request_set_kerberos,        1);
+    rb_define_method(ov_http_request_class, "body",             ov_http_request_get_body,            0);
+    rb_define_method(ov_http_request_class, "body=",            ov_http_request_set_body,            1);
+    rb_define_method(ov_http_request_class, "timeout",          ov_http_request_get_timeout,         0);
+    rb_define_method(ov_http_request_class, "timeout=",         ov_http_request_set_timeout,         1);
+    rb_define_method(ov_http_request_class, "connect_timeout",  ov_http_request_get_connect_timeout, 0);
+    rb_define_method(ov_http_request_class, "connect_timeout=", ov_http_request_set_connect_timeout, 1);
 
     /* Define the symbols for the attributes: */
-    URL_SYMBOL      = ID2SYM(rb_intern("url"));
-    METHOD_SYMBOL   = ID2SYM(rb_intern("method"));
-    QUERY_SYMBOL    = ID2SYM(rb_intern("query"));
-    HEADERS_SYMBOL  = ID2SYM(rb_intern("headers"));
-    USERNAME_SYMBOL = ID2SYM(rb_intern("username"));
-    PASSWORD_SYMBOL = ID2SYM(rb_intern("password"));
-    TOKEN_SYMBOL    = ID2SYM(rb_intern("token"));
-    KERBEROS_SYMBOL = ID2SYM(rb_intern("kerberos"));
-    BODY_SYMBOL     = ID2SYM(rb_intern("body"));
-    TIMEOUT_SYMBOL  = ID2SYM(rb_intern("timeout"));
+    URL_SYMBOL             = ID2SYM(rb_intern("url"));
+    METHOD_SYMBOL          = ID2SYM(rb_intern("method"));
+    QUERY_SYMBOL           = ID2SYM(rb_intern("query"));
+    HEADERS_SYMBOL         = ID2SYM(rb_intern("headers"));
+    USERNAME_SYMBOL        = ID2SYM(rb_intern("username"));
+    PASSWORD_SYMBOL        = ID2SYM(rb_intern("password"));
+    TOKEN_SYMBOL           = ID2SYM(rb_intern("token"));
+    KERBEROS_SYMBOL        = ID2SYM(rb_intern("kerberos"));
+    BODY_SYMBOL            = ID2SYM(rb_intern("body"));
+    TIMEOUT_SYMBOL         = ID2SYM(rb_intern("timeout"));
+    CONNECT_TIMEOUT_SYMBOL = ID2SYM(rb_intern("connect_timeout"));
 
     /* Define the symbols for the HTTP methods: */
     GET_SYMBOL    = ID2SYM(rb_intern("GET"));

data/ext/ovirtsdk4c/ov_http_request.h

@@ -31,16 +31,17 @@ extern VALUE DELETE_SYMBOL;
 
 /* Content: */
 typedef struct {
-    VALUE method;   /* Symbol */
-    VALUE url;      /* String */
-    VALUE query;    /* Hash<String, String> */
-    VALUE headers;  /* Hash<String, String> */
-    VALUE username; /* String */
-    VALUE password; /* String */
-    VALUE token;    /* String */
-    VALUE kerberos; /* Boolean */
-    VALUE body;     /* String */
-    VALUE timeout;  /* Integer */
+    VALUE method;          /* Symbol */
+    VALUE url;             /* String */
+    VALUE query;           /* Hash<String, String> */
+    VALUE headers;         /* Hash<String, String> */
+    VALUE username;        /* String */
+    VALUE password;        /* String */
+    VALUE token;           /* String */
+    VALUE kerberos;        /* Boolean */
+    VALUE body;            /* String */
+    VALUE timeout;         /* Integer */
+    VALUE connect_timeout; /* Integer */
 } ov_http_request_object;
 
 /* Macro to get the pointer: */

data/lib/ovirtsdk4/connection.rb

@@ -75,8 +75,11 @@ module OvirtSDK4
     #   instead of user name and password to obtain the OAuth token.
     #
     # @option opts [Integer] :timeout (0) The maximun total time to wait for the response, in seconds. A value of zero
-    #   (the default) means wait for ever. If the timeout expires before the response is received an exception will be
-    #   raised.
+    #   (the default) means wait for ever. If the timeout expires before the response is received a `TimeoutError`
+    #   exception will be raised.
+    #
+    # @option opts [Integer] :connect_timeout (300) The maximun time to wait for connection establishment, in seconds.
+    #   If the timeout expires before the connection is established a `TimeoutError` exception will be raised.
     #
     # @option opts [Boolean] :compress (true) A boolean flag indicating if the SDK should ask the server to send
     #   compressed responses. Note that this is a hint for the server, and that it may return uncompressed data even
@@ -117,6 +120,7 @@ module OvirtSDK4
       @log = opts[:log]
       @kerberos = opts[:kerberos] || false
       @timeout = opts[:timeout] || 0
+      @connect_timeout = opts[:connect_timeout] || 0
       @compress = opts[:compress] || true
       @proxy_url = opts[:proxy_url]
       @proxy_username = opts[:proxy_username]
@@ -156,6 +160,7 @@ module OvirtSDK4
         debug: @debug,
         log: @log,
         timeout: @timeout,
+        connect_timeout: @connect_timeout,
         compress: @compress,
         proxy_url: @proxy_url,
         proxy_username: @proxy_username,

data/lib/ovirtsdk4/services.rb

@@ -1103,8 +1103,13 @@ module OvirtSDK4
     # ----
     # <affinity_group>
     #   <name>AF_GROUP_001</name>
-    #   <positive>true</positive>
-    #   <enforcing>true</enforcing>
+    #   <hosts_rule>
+    #     <enforcing>true</enforcing>
+    #     <positive>true</positive>
+    #   </hosts_rule>
+    #   <vms_rule>
+    #     <enabled>false</enabled>
+    #   </vms_rule>
     # </affinity_group>
     # ----
     # 
@@ -11582,7 +11587,7 @@ module OvirtSDK4
     # Retrieves the list of image transfers that are currently
     # being performed.
     # 
-    # The order of the returned list of image transfers isn't guaranteed.
+    # The order of the returned list of image transfers is not guaranteed.
     # 
     # @param opts [Hash] Additional options.
     # 
@@ -17764,7 +17769,40 @@ module OvirtSDK4
     private_constant :ADD
     
     # 
-    # Adds a new `limit`.
+    # Adds a storage limit to a specified quota.
+    # 
+    # To create a 100GiB storage limit for all storage domains in a data center, send a request like this:
+    # 
+    # [source]
+    # ----
+    # POST /ovirt-engine/api/datacenters/123/quotas/456/quotastoragelimits
+    # ----
+    # 
+    # With a request body like this:
+    # 
+    # [source,xml]
+    # ----
+    # <quota_storage_limit>
+    #   <limit>100</limit>
+    # </quota_storage_limit>
+    # ----
+    # 
+    # To create a 50GiB storage limit for a storage domain with the ID `000`, send a request like this:
+    # 
+    # [source]
+    # ----
+    # POST /ovirt-engine/api/datacenters/123/quotas/456/quotastoragelimits
+    # ----
+    # 
+    # With a request body like this:
+    # 
+    # [source,xml]
+    # ----
+    # <quota_storage_limit>
+    #   <limit>50</limit>
+    #   <storage_domain id="000"/>
+    # </quota_storage_limit>
+    # ----
     # 
     # @param limit [QuotaStorageLimit] The `limit` to add.
     # 
@@ -17794,11 +17832,11 @@ module OvirtSDK4
     # 
     # Returns the list of storage limits configured for the quota.
     # 
-    # The order of the returned list of storage limits isn't guaranteed.
+    # The order of the returned list of storage limits is not guaranteed.
     # 
     # @param opts [Hash] Additional options.
     # 
-    # @option opts [Integer] :max Sets the maximum number of limits to return. If not specified all the limits are returned.
+    # @option opts [Integer] :max Sets the maximum number of limits to return. If not specified, all the limits are returned.
     # 
     # @option opts [Hash] :headers ({}) Additional HTTP headers.
     # 
@@ -20212,7 +20250,9 @@ module OvirtSDK4
     end
     
     # 
-    # Executes the `is_attached` method.
+    # Used for querying if the storage domain is already attached to a data center using
+    # the is_attached boolean field, which is part of the storage server. IMPORTANT:
+    # Executing this API will cause the host to disconnect from the storage domain.
     # 
     # @param opts [Hash] Additional options.
     # 
@@ -20265,7 +20305,7 @@ module OvirtSDK4
     # 
     # @param opts [Hash] Additional options.
     # 
-    # @option opts [Array<LogicalUnit>] :logical_units The logical units that needs to be reduced from the storage domain.
+    # @option opts [Array<LogicalUnit>] :logical_units The logical units that need to be reduced from the storage domain.
     # 
     # @option opts [Hash] :headers ({}) Additional HTTP headers.
     # 
@@ -20286,7 +20326,7 @@ module OvirtSDK4
     # After increasing the size of the underlying LUN on the storage server,
     # the user can refresh the LUN size.
     # This action forces a rescan of the provided LUNs and
-    # updates the database with the new size if required.
+    # updates the database with the new size, if required.
     # 
     # For example, in order to refresh the size of two LUNs send a request like this:
     # 
@@ -20339,20 +20379,20 @@ module OvirtSDK4
     # Removes the storage domain.
     # 
     # Without any special parameters, the storage domain is detached from the system and removed from the database. The
-    # storage domain can then be imported to the same or different setup, with all the data on it. If the storage isn't
-    # accessible the operation will fail.
+    # storage domain can then be imported to the same or to a different setup, with all the data on it. If the storage is
+    # not accessible the operation will fail.
     # 
-    # If the `destroy` parameter is `true` then the operation will always succeed, even if the storage isn't
+    # If the `destroy` parameter is `true` then the operation will always succeed, even if the storage is not
     # accessible, the failure is just ignored and the storage domain is removed from the database anyway.
     # 
     # If the `format` parameter is `true` then the actual storage is formatted, and the metadata is removed from the
-    # LUN or directory, so it can no longer be imported to the same or a different setup.
+    # LUN or directory, so it can no longer be imported to the same or to a different setup.
     # 
     # @param opts [Hash] Additional options.
     # 
     # @option opts [Boolean] :async Indicates if the remove should be performed asynchronously.
     # @option opts [Boolean] :destroy Indicates if the operation should succeed, and the storage domain removed from the database, even if the
-    #   storage isn't accessible.
+    #   storage is not accessible.
     #   
     #   [source]
     #   ----
@@ -20360,6 +20400,7 @@ module OvirtSDK4
     #   ----
     #   
     #   This parameter is optional, and the default value is `false`.
+    #   When the value of `destroy` is `true` the `host` parameter will be ignored.
     # @option opts [Boolean] :format Indicates if the actual storage should be formatted, removing all the metadata from the underlying LUN or
     #   directory:
     #   
@@ -20369,10 +20410,13 @@ module OvirtSDK4
     #   ----
     #   
     #   This parameter is optional, and the default value is `false`.
-    # @option opts [String] :host Indicates what host should be used to remove the storage domain.
+    # @option opts [String] :host Indicates which host should be used to remove the storage domain.
     #   
-    #   This parameter is mandatory, and it can contain the name or the identifier of the host. For example, to use
-    #   the host named `myhost` to remove the storage domain with identifier `123` send a request like this:
+    #   This parameter is mandatory, except if the `destroy` parameter is included and its value is `true`, in that
+    #   case the `host` parameter will be ignored.
+    #   
+    #   The value should contain the name or the identifier of the host. For example, to use the host named `myhost`
+    #   to remove the storage domain with identifier `123` send a request like this:
     #   
     #   [source]
     #   ----
@@ -20400,9 +20444,9 @@ module OvirtSDK4
     # 
     # Updates a storage domain.
     # 
-    # Not all of the <<types/storage_domain,StorageDomain>>'s attributes are updatable post-creation. Those that can be
+    # Not all of the <<types/storage_domain,StorageDomain>>'s attributes are updatable after creation. Those that can be
     # updated are: `name`, `description`, `comment`, `warning_low_space_indicator`, `critical_space_action_blocker` and
-    # `wipe_after_delete` (note that changing the `wipe_after_delete` attribute will not change the wipe after delete
+    # `wipe_after_delete.` (Note that changing the `wipe_after_delete` attribute will not change the wipe after delete
     # property of disks that already exist).
     # 
     # To update the `name` and `wipe_after_delete` attributes of a storage domain with an identifier `123`, send a
@@ -20447,9 +20491,9 @@ module OvirtSDK4
     # This operation forces the update of the `OVF_STORE`
     # of this storage domain.
     # 
-    # The `OVF_STORE` is a disk image that contains the meta-data
+    # The `OVF_STORE` is a disk image that contains the metadata
     # of virtual machines and disks that reside in the
-    # storage domain. This meta-data is used in case the
+    # storage domain. This metadata is used in case the
     # domain is imported or exported to or from a different
     # data center or a different installation.
     # 
@@ -20497,7 +20541,7 @@ module OvirtSDK4
     end
     
     # 
-    # Locates the `disks` service.
+    # Reference to the service that manages the disks available in the storage domain.
     # 
     # @return [DisksService] A reference to `disks` service.
     # 
@@ -32551,6 +32595,10 @@ module OvirtSDK4
     # 
     # @option opts [Boolean] :async Indicates if the upgrade should be performed asynchronously.
     # 
+    # @option opts [String] :image The image parameter specifies path to image, which is used
+    #   for upgrade. This parameter is used only to upgrade Vintage
+    #   Node hosts and it's not relevant for other hosts types.
+    # 
     # @option opts [Hash] :headers ({}) Additional HTTP headers.
     # 
     # @option opts [Hash] :query ({}) Additional URL query parameters.

data/lib/ovirtsdk4/version.rb

@@ -16,5 +16,5 @@
 
 
 module OvirtSDK4
-  VERSION = '4.1.9'.freeze
+  VERSION = '4.1.10'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ovirt-engine-sdk
 version: !ruby/object:Gem::Version
-  version: 4.1.9
+  version: 4.1.10
 platform: ruby
 authors:
 - Juan Hernandez
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-13 00:00:00.000000000 Z
+date: 2017-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake