overridable 0.3.1 → 0.3.2

data/VERSION

@@ -1 +1 @@
-0.3.1
+0.3.2

data/lib/overridable.rb

@@ -163,10 +163,15 @@ module Overridable
 
         old_verbose, $VERBOSE = $VERBOSE, nil # supress warnings
         methods.each { |m|
+          scope = private_instance_methods(false).include?(m.name) ?
+            :private :
+            protected_instance_methods(false).include?(m.name) ?
+            :protected : :public
           remove_method m.name
           mod.send :define_method, m.name do |*args, &blk|
             m.bind(self).call(*args, &blk)
           end
+          mod.send scope, m.name
         }
         $VERBOSE = old_verbose
       end

data/test/overridable_test.rb

@@ -161,4 +161,34 @@ context "a classes with some methods defined in it" do
     end
   end
 
+  context "there are also some protected and private methods in it." do
+    setup {
+      topic.class_eval {
+        protected
+        def protected_method; end
+        private
+        def private_method; end
+      }
+      topic
+    }
+
+    context "Call overrides on these protected and private methods, it should not change their scope." do
+      setup {
+        topic.class_eval {
+          include Overridable
+          overrides :protected_method, :private_method
+        }
+        topic
+      }
+
+      should("raise exception when call protected_method outside the class.") {
+        topic.new.protected_method
+      }.raises(NoMethodError, /protected method `protected_method' called/)
+
+      should("raise exception when call private_method outside the class.") {
+        topic.new.private_method
+      }.raises(NoMethodError, /private method `private_method' called/)
+    end
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: overridable
 version: !ruby/object:Gem::Version 
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors: 
 - "\xE6\xA2\x81\xE6\x99\xBA\xE6\x95\x8F(Gimi Liang)"