overcommit 0.41.0 → 0.42.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 27b302156918dca6c24185cf0cbb4c88ee1ff17a
-  data.tar.gz: c537a8ca33fbeaa4aeb0aa73cb47fa6a23beac80
+  metadata.gz: e46e06664c4b84241863650f3b1c0d0316f9c66b
+  data.tar.gz: 16c1e91603f5c6e3aef1316cd4a1aaeb60998eef
 SHA512:
-  metadata.gz: a1c4c0011bb62eea08e898950211af0fa16053067dca6e91c50f06193b889492c5f71c035015e321af3ad35b6b742f49324b205ce4db7de5f337a64cc1fca968
-  data.tar.gz: d550e63d8fc852da8503657c99041304d850dc45936044e16294f7ed72d05d793493059eaf0e357e51cfdf608ea43ecf4a2d435c322bc3e9efa1d1e2bbb1f4e9
+  metadata.gz: 7629c771c3a572032c7036af72799a0b3127fca7386d804c3fdb8609c766134853385564faa7c49296b86add33f7fe2de3ee339cdd814868c7f7cdc4142cd4f2
+  data.tar.gz: db1da032a04d2673e2b10875ea9e0e3fa9b0b6a7afe4af780ad5eb32f6e94b3f0531636d642ffb451cb01a850a7405178a7de248b8bbb7dea7307a5f91ad5753

data/config/default.yml

@@ -184,15 +184,42 @@ PreCommit:
     description: 'Check for case-insensitivity conflicts'
     quiet: true
 
+  ChamberCompare:
+    enabled: false
+    description: 'Check that settings are equivalent between namespaces'
+    required_executable: 'chamber'
+    flags: ['compare']
+    install_command: 'gem install chamber'
+    namespaces:
+      - ['development']
+      - ['test']
+      - ['production']
+    exclusions: []
+    include: &chamber_settings_files
+      - 'config/settings*.yml'
+      - 'config/settings*.yml.erb'
+      - 'config/settings/**/*.yml'
+      - 'config/settings/**/*.yml.erb'
+      - 'settings*.yml'
+      - 'settings*.yml.erb'
+      - 'settings/**/*.yml'
+      - 'settings/**/*.yml.erb'
+
   ChamberSecurity:
     enabled: false
     description: 'Check that settings have been secured with Chamber'
     required_executable: 'chamber'
     flags: ['secure', '--files']
     install_command: 'gem install chamber'
-    include:
-      - 'config/settings.yml'
-      - 'config/settings/**/*.yml'
+    include: *chamber_settings_files
+
+  ChamberVerification:
+    enabled: false
+    description: 'Verify that all settings changes have been approved'
+    required_executable: 'chamber'
+    flags: ['sign', '--verify']
+    install_command: 'gem install chamber'
+    include: *chamber_settings_files
 
   CoffeeLint:
     enabled: false
@@ -415,7 +442,7 @@ PreCommit:
 
   Mdl:
     enabled: false
-    description: 'Analyze with mdl'
+    description: 'Analyze markdown files with mdl'
     required_executable: 'mdl'
     install_command: 'gem install mdl'
     include: '**/*.md'
@@ -427,6 +454,14 @@ PreCommit:
     required_executable: 'grep'
     flags: ['-IHn', "^<<<<<<<[ \t]"]
 
+  PuppetMetadataJsonLint:
+    enabled: false
+    description: 'Checking module metadata'
+    flags: ['--strict-license', '--strict-dependencies', '--fail-on-warning']
+    include: 'metadata.json'
+    required_executable: 'metadata-json-lint'
+    install_command: 'gem install metadata-json-lint'
+
   NginxTest:
     enabled: false
     description: 'Test nginx configs'
@@ -463,6 +498,14 @@ PreCommit:
     flags: ['--standard=PSR2', '--report=csv']
     include: '**/*.php'
 
+  PhpStan:
+    description: 'Analyze with phpstan'
+    enabled: false
+    command: 'phpstan'
+    flags: ['analyze', '--errorFormat=raw']
+    include:
+      - '**/*.php'
+
   Pronto:
     enabled: false
     description: 'Analyzing with pronto'
@@ -558,6 +601,13 @@ PreCommit:
       - '**/Gemfile'
       - '**/Rakefile'
 
+  RstLint:
+    enabled: false
+    description: 'Analyze reStructuredText files with rst-lint'
+    required_executable: 'rst-lint'
+    install_command: 'pip install restructuredtext_lint'
+    include: '**/*.rst'
+
   RuboCop:
     enabled: false
     description: 'Analyze with RuboCop'
@@ -763,6 +813,15 @@ PostCheckout:
       - 'Gemfile.lock'
       - '*.gemspec'
 
+  ComposerInstall:
+    enabled: false
+    description: 'Install composer dependencies'
+    requires_files: true
+    required_executable: 'composer'
+    install_command: 'curl -sS https://getcomposer.org/installer | sudo php -- --install-dir=/usr/local/bin --filename=composer'
+    flags: ['install']
+    include: 'composer.json'
+
   IndexTags:
     enabled: false
     description: 'Generate tags file from source'
@@ -785,6 +844,16 @@ PostCheckout:
     quiet: true
     recursive: false
 
+  YarnInstall:
+    enabled: false
+    description: 'Install Yarn dependencies'
+    requires_files: true
+    required_executable: 'yarn'
+    flags: ['install']
+    include:
+      - 'package.json'
+      - 'yarn.lock'
+
 # Hooks that run after a commit is created.
 PostCommit:
   ALL:
@@ -820,6 +889,15 @@ PostCommit:
     install_command: 'npm install --save-dev commitplease'
     flags: ['-1']
 
+  ComposerInstall:
+    enabled: false
+    description: 'Install composer dependencies'
+    requires_files: true
+    required_executable: 'composer'
+    install_command: 'curl -sS https://getcomposer.org/installer | sudo php -- --install-dir=/usr/local/bin --filename=composer'
+    flags: ['install']
+    include: 'composer.json'
+
   GitGuilt:
     enabled: false
     description: 'Calculate changes in blame since last commit'
@@ -850,6 +928,16 @@ PostCommit:
     quiet: true
     recursive: false
 
+  YarnInstall:
+    enabled: false
+    description: 'Install Yarn dependencies'
+    requires_files: true
+    required_executable: 'yarn'
+    flags: ['install']
+    include:
+      - 'package.json'
+      - 'yarn.lock'
+
 # Hooks that run after `git merge` executes successfully (no merge conflicts).
 PostMerge:
   ALL:
@@ -877,6 +965,15 @@ PostMerge:
       - 'Gemfile.lock'
       - '*.gemspec'
 
+  ComposerInstall:
+    enabled: false
+    description: 'Install composer dependencies'
+    requires_files: true
+    required_executable: 'composer'
+    install_command: 'curl -sS https://getcomposer.org/installer | sudo php -- --install-dir=/usr/local/bin --filename=composer'
+    flags: ['install']
+    include: 'composer.json'
+
   IndexTags:
     enabled: false
     description: 'Generate tags file from source'
@@ -899,6 +996,16 @@ PostMerge:
     quiet: true
     recursive: false
 
+  YarnInstall:
+    enabled: false
+    description: 'Install Yarn dependencies'
+    requires_files: true
+    required_executable: 'yarn'
+    flags: ['install']
+    include:
+      - 'package.json'
+      - 'yarn.lock'
+
 # Hooks that run after a commit is modified by an amend or rebase.
 PostRewrite:
   ALL:
@@ -926,6 +1033,15 @@ PostRewrite:
       - 'Gemfile.lock'
       - '*.gemspec'
 
+  ComposerInstall:
+    enabled: false
+    description: 'Install composer dependencies'
+    requires_files: true
+    required_executable: 'composer'
+    install_command: 'curl -sS https://getcomposer.org/installer | sudo php -- --install-dir=/usr/local/bin --filename=composer'
+    flags: ['install']
+    include: 'composer.json'
+
   IndexTags:
     enabled: false
     description: 'Generate tags file from source'
@@ -948,6 +1064,16 @@ PostRewrite:
     quiet: true
     recursive: false
 
+  YarnInstall:
+    enabled: false
+    description: 'Install Yarn dependencies'
+    requires_files: true
+    required_executable: 'yarn'
+    flags: ['install']
+    include:
+      - 'package.json'
+      - 'yarn.lock'
+
 # Hooks that run during `git push`, after remote refs have been updated but
 # before any objects have been transferred.
 PrePush:

data/lib/overcommit/cli.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit'
 require 'optparse'
 
@@ -27,6 +29,9 @@ module Overcommit
       when :run_all
         run_all
       end
+    rescue Overcommit::Exceptions::ConfigurationSignatureChanged => ex
+      puts ex
+      exit 78 # EX_CONFIG
     rescue Overcommit::Exceptions::HookContextLoadError => ex
       puts ex
       exit 64 # EX_USAGE

data/lib/overcommit/configuration_loader.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yaml'
 
 module Overcommit
@@ -68,7 +70,9 @@ module Overcommit
       end
 
       config
-    rescue => error
+    rescue Overcommit::Exceptions::ConfigurationSignatureChanged
+      raise
+    rescue StandardError => error
       raise Overcommit::Exceptions::ConfigurationError,
             "Unable to load configuration from '#{file}': #{error}",
             error.backtrace

data/lib/overcommit/configuration_validator.rb

@@ -95,7 +95,7 @@ module Overcommit
       errors = []
 
       Overcommit::Utils.supported_hook_type_classes.each do |hook_type|
-        hash.fetch(hook_type, {}).each do |hook_name, _|
+        hash.fetch(hook_type, {}).each_key do |hook_name|
           next if hook_name == 'ALL'
 
           unless hook_name =~ /\A[A-Za-z0-9]+\z/
@@ -175,3 +175,4 @@ module Overcommit
     end
   end
 end
+# rubocop:enable Metrics/ClassLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength, Metrics/LineLength

data/lib/overcommit/git_config.rb

@@ -13,7 +13,7 @@ module Overcommit
 
     def hooks_path
       path = `git config --get core.hooksPath`.chomp
-      return File.join(Overcommit::Utils.repo_root, '.git', 'hooks') if path.empty?
+      return File.join(Overcommit::Utils.git_dir, 'hooks') if path.empty?
       File.absolute_path(path)
     end
   end

data/lib/overcommit/hook/post_checkout/composer_install.rb

@@ -0,0 +1,11 @@
+require 'overcommit/hook/shared/composer_install'
+
+module Overcommit::Hook::PostCheckout
+  # Runs `composer install` when a change is detected in the repository's
+  # dependencies.
+  #
+  # @see {Overcommit::Hook::Shared::ComposerInstall}
+  class ComposerInstall < Base
+    include Overcommit::Hook::Shared::ComposerInstall
+  end
+end

data/lib/overcommit/hook/post_checkout/yarn_install.rb

@@ -0,0 +1,11 @@
+require 'overcommit/hook/shared/yarn_install'
+
+module Overcommit::Hook::PostCheckout
+  # Runs `yarn install` when a change is detected in the repository's
+  # dependencies.
+  #
+  # @see {Overcommit::Hook::Shared::YarnInstall}
+  class YarnInstall < Base
+    include Overcommit::Hook::Shared::YarnInstall
+  end
+end

data/lib/overcommit/hook/post_commit/composer_install.rb

@@ -0,0 +1,11 @@
+require 'overcommit/hook/shared/composer_install'
+
+module Overcommit::Hook::PostCommit
+  # Runs `composer install` when a change is detected in the repository's
+  # dependencies.
+  #
+  # @see {Overcommit::Hook::Shared::ComposerInstall}
+  class ComposerInstall < Base
+    include Overcommit::Hook::Shared::ComposerInstall
+  end
+end

data/lib/overcommit/hook/post_commit/yarn_install.rb

@@ -0,0 +1,11 @@
+require 'overcommit/hook/shared/yarn_install'
+
+module Overcommit::Hook::PostCommit
+  # Runs `yarn install` when a change is detected in the repository's
+  # dependencies.
+  #
+  # @see {Overcommit::Hook::Shared::YarnInstall}
+  class YarnInstall < Base
+    include Overcommit::Hook::Shared::YarnInstall
+  end
+end

data/lib/overcommit/hook/post_merge/composer_install.rb

@@ -0,0 +1,11 @@
+require 'overcommit/hook/shared/composer_install'
+
+module Overcommit::Hook::PostMerge
+  # Runs `composer install` when a change is detected in the repository's
+  # dependencies.
+  #
+  # @see {Overcommit::Hook::Shared::ComposerInstall}
+  class ComposerInstall < Base
+    include Overcommit::Hook::Shared::ComposerInstall
+  end
+end

data/lib/overcommit/hook/post_merge/yarn_install.rb

@@ -0,0 +1,11 @@
+require 'overcommit/hook/shared/yarn_install'
+
+module Overcommit::Hook::PostMerge
+  # Runs `yarn install` when a change is detected in the repository's
+  # dependencies.
+  #
+  # @see {Overcommit::Hook::Shared::YarnInstall}
+  class YarnInstall < Base
+    include Overcommit::Hook::Shared::YarnInstall
+  end
+end

data/lib/overcommit/hook/post_rewrite/composer_install.rb

@@ -0,0 +1,11 @@
+require 'overcommit/hook/shared/composer_install'
+
+module Overcommit::Hook::PostRewrite
+  # Runs `composer install` when a change is detected in the repository's
+  # dependencies.
+  #
+  # @see {Overcommit::Hook::Shared::ComposerInstall}
+  class ComposerInstall < Base
+    include Overcommit::Hook::Shared::ComposerInstall
+  end
+end

data/lib/overcommit/hook/post_rewrite/yarn_install.rb

@@ -0,0 +1,11 @@
+require 'overcommit/hook/shared/yarn_install'
+
+module Overcommit::Hook::PostRewrite
+  # Runs `yarn install` when a change is detected in the repository's
+  # dependencies.
+  #
+  # @see {Overcommit::Hook::Shared::YarnInstall}
+  class YarnInstall < Base
+    include Overcommit::Hook::Shared::YarnInstall
+  end
+end

data/lib/overcommit/hook/pre_commit/bundle_audit.rb

@@ -7,7 +7,8 @@ module Overcommit::Hook::PreCommit
 
     def run
       # Ignore if Gemfile.lock is not tracked by git
-      ignored_files = execute(%w[git ls-files -o -i --exclude-standard]).stdout.split("\n")
+      ignored_files = execute(%W[git ls-files -o -i --exclude-standard -- #{LOCK_FILE}]).
+                      stdout.split("\n")
       return :pass if ignored_files.include?(LOCK_FILE)
 
       result = execute(command)

data/lib/overcommit/hook/pre_commit/chamber_compare.rb

@@ -0,0 +1,41 @@
+module Overcommit::Hook::PreCommit
+  # Runs `chamber compare` against a configurable set of namespaces.
+  #
+  # @see https://github.com/thekompanee/chamber/wiki/Git-Commit-Hooks#chamber-compare-pre-commit-hook
+  # rubocop:disable Metrics/MethodLength
+  class ChamberCompare < Base
+    def run
+      config['namespaces'].each_index do |index|
+        first  = config['namespaces'][index]
+        second = config['namespaces'][index + 1]
+
+        next unless second
+
+        result = execute(
+                   command,
+                   args: [
+                           "--first=#{first.join(' ')}",
+                           "--second=#{second.join(' ')}",
+                         ],
+                 )
+
+        unless result.stdout.empty?
+          trimmed_result = result.stdout.split("\n")
+          5.times { trimmed_result.shift }
+          trimmed_result = trimmed_result.join("\n")
+
+          return [
+                   :warn,
+                   "It appears your namespace settings between #{first} and " \
+                   "#{second} are not in sync:\n\n#{trimmed_result}\n\n" \
+                   "Run: chamber compare --first=#{first.join(' ')} " \
+                   "--second=#{second.join(' ')}",
+                 ]
+        end
+      end
+
+      :pass
+    end
+  end
+  # rubocop:enable Metrics/MethodLength
+end

data/lib/overcommit/hook/pre_commit/chamber_verification.rb

@@ -0,0 +1,34 @@
+module Overcommit::Hook::PreCommit
+  # Runs `chamber sign --verify`.
+  #
+  # @see https://github.com/thekompanee/chamber/wiki/Git-Commit-Hooks#chamber-verification-pre-commit-hook
+  # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+  class ChamberVerification < Base
+    def run
+      approver_name  = config.fetch('approver_name', 'your approver')
+      approver_email = config['approver_email'] ? " (#{config['approver_email']})" : nil
+
+      result = execute(command)
+
+      return :pass if result.stdout.empty? && result.stderr.empty?
+      return :pass if result.stderr =~ /no signature key was found/
+
+      output = [
+        result.stdout.empty? ? nil : result.stdout,
+        result.stderr.empty? ? nil : result.stderr,
+      ].
+        compact.
+        join("\n\n")
+
+      output = "\n\n#{output}" unless output.empty?
+
+      [
+        :warn,
+        "One or more of your settings files does not match the signature.\n" \
+        "Talk to #{approver_name}#{approver_email} about getting them " \
+        "approved.#{output}",
+      ]
+    end
+  end
+  # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+end

data/lib/overcommit/hook/pre_commit/go_lint.rb

@@ -4,8 +4,15 @@ module Overcommit::Hook::PreCommit
   # @see https://github.com/golang/lint
   class GoLint < Base
     def run
-      result = execute(command, args: applicable_files)
-      output = result.stdout + result.stderr
+      output = ''
+
+      # golint doesn't accept multiple file arguments if
+      # they belong to different packages
+      applicable_files.each do |gofile|
+        result = execute(command, args: Array(gofile))
+        output += result.stdout + result.stderr
+      end
+
       # Unfortunately the exit code is always 0
       return :pass if output.empty?
 

data/lib/overcommit/hook/pre_commit/license_finder.rb

@@ -1,6 +1,6 @@
 module Overcommit::Hook::PreCommit
   # Runs LicenseFinder if any of your package manager declaration files have changed
-  # See more about LicenseFinder at https://github.com/pivotal/LicenseFinde
+  # See more about LicenseFinder at https://github.com/pivotal/LicenseFinder
   class LicenseFinder < Base
     def run
       result = execute(command)

data/lib/overcommit/hook/pre_commit/line_endings.rb

@@ -53,7 +53,8 @@ module Overcommit::Hook::PreCommit
       raise 'Unable to access git tree' unless result.success?
 
       result.stdout.split("\0").map do |file_info|
-        i, _w, _attr, path = file_info.split
+        info, path = file_info.split("\t")
+        i = info.split.first
         next if i == 'l/-text' # ignore binary files
         next if i == "l/#{eol}"
         path

data/lib/overcommit/hook/pre_commit/mdl.rb

@@ -3,7 +3,7 @@ module Overcommit::Hook::PreCommit
   #
   # @see https://github.com/mivok/markdownlint
   class Mdl < Base
-    MESSAGE_REGEX = /^(?<file>(?:\w:)?[^:]+):(?<line>\d+)/
+    MESSAGE_REGEX = /^(?<file>(?:\w:)?[^:]+):(?<line>\d+):\s(?<msg>.+)/
 
     def run
       result = execute(command, args: applicable_files)

data/lib/overcommit/hook/pre_commit/php_stan.rb

@@ -0,0 +1,28 @@
+module Overcommit::Hook::PreCommit
+  # Runs `phpstan` against any modified PHP files.
+  # For running `phpstan` with Laravel, it requires setup with `ide_helper`.
+  #
+  # References:
+  # https://github.com/phpstan/phpstan/issues/239
+  # https://gist.github.com/edmondscommerce/89695c9cd2584fefdf540fb1c528d2c2
+  class PhpStan < Base
+    MESSAGE_REGEX = /^(?<file>.+)\:(?<line>\d+)\:(?<message>.+)/
+
+    def run
+      messages = []
+
+      result = execute(command, args: applicable_files)
+
+      unless result.success?
+        messages += result.stdout.lstrip.split("\n")
+      end
+
+      return :pass if messages.empty?
+
+      extract_messages(
+        messages,
+        MESSAGE_REGEX
+      )
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/puppet_metadata_json_lint.rb

@@ -0,0 +1,27 @@
+module Overcommit::Hook::PreCommit
+  #
+  # Run's the Puppet metadata linter. It has support for adding options
+  # in the .overcommit.yaml
+  #
+  # @see https://voxpupuli.org/blog/2014/11/06/linting-metadata-json/
+  #
+  class PuppetMetadataJsonLint < Base
+    MESSAGE_REGEX = /\((?<type>.*)\).*/
+
+    MESSAGE_TYPE_CATEGORIZER = lambda do |type|
+      type == 'WARN' ? :warning : :error
+    end
+
+    def run
+      result = execute(command, args: applicable_files)
+      output = result.stdout.chomp.gsub(/^"|"$/, '')
+      return :pass if result.success? && output.empty?
+
+      extract_messages(
+        output.split("\n"),
+        MESSAGE_REGEX,
+        MESSAGE_TYPE_CATEGORIZER
+      )
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/rails_best_practices.rb

@@ -8,7 +8,7 @@ module Overcommit
         ERROR_REGEXP = /^(?<file>(?:\w:)?[^:]+):(?<line>\d+)\s-\s(?<type>.+)/
 
         def run
-          result = execute(command)
+          result = execute(command, args: applicable_files)
 
           return :pass if result.success?
           return [:fail, result.stderr] unless result.stderr.empty?

data/lib/overcommit/hook/pre_commit/rst_lint.rb

@@ -0,0 +1,25 @@
+module Overcommit::Hook::PreCommit
+  # Runs `rst-lint` against any modified reStructuredText files
+  #
+  # @see https://github.com/twolfson/restructuredtext-lint
+  class RstLint < Base
+    MESSAGE_REGEX = /
+    ^(?<type>INFO|WARNING|ERROR|SEVERE)(?<file>(?:\w:)?[^:]+):(?<line>\d+)\s(?<msg>.+)
+    /x
+
+    def run
+      result = execute(command, args: applicable_files)
+      output = result.stdout.chomp
+
+      return :pass if result.success?
+      return [:fail, result.stderr] unless result.stderr.empty?
+
+      # example message:
+      # WARNING README.rst:7 Title underline too short.
+      extract_messages(
+        output.split("\n"),
+        MESSAGE_REGEX
+      )
+    end
+  end
+end

data/lib/overcommit/hook/shared/composer_install.rb

@@ -0,0 +1,13 @@
+module Overcommit::Hook::Shared
+  # Shared code used by all ComposerInstall hooks. Runs `composer install` when
+  # a change is detected in the repository's dependencies.
+  #
+  # @see https://getcomposer.org/
+  module ComposerInstall
+    def run
+      result = execute(command)
+      return :fail, result.stdout unless result.success?
+      :pass
+    end
+  end
+end

data/lib/overcommit/hook/shared/yarn_install.rb

@@ -0,0 +1,13 @@
+module Overcommit::Hook::Shared
+  # Shared code used by all YarnInstall hooks. Runs `yarn install` when a change
+  # is detected in the repository's dependencies.
+  #
+  # @see https://yarnpkg.com/
+  module YarnInstall
+    def run
+      result = execute(command)
+      return :fail, result.stderr unless result.success?
+      :pass
+    end
+  end
+end

data/lib/overcommit/hook_context/pre_push.rb

@@ -17,6 +17,12 @@ module Overcommit::HookContext
       end
     end
 
+    def modified_files
+      @modified_files ||= Overcommit::GitRepo.modified_files(
+        refs: "#{pushed_refs[0].remote_sha1}..#{pushed_refs[0].local_sha1}"
+      )
+    end
+
     PushedRef = Struct.new(:local_ref, :local_sha1, :remote_ref, :remote_sha1) do
       def forced?
         !(created? || deleted? || overwritten_commits.empty?)

data/lib/overcommit/hook_runner.rb

@@ -156,7 +156,7 @@ module Overcommit
       rescue Overcommit::Exceptions::MessageProcessingError => ex
         status = :fail
         output = ex.message
-      rescue => ex
+      rescue StandardError => ex
         status = :fail
         output = "Hook raised unexpected error\n#{ex.message}\n#{ex.backtrace.join("\n")}"
       end

data/lib/overcommit/hook_signer.rb

@@ -32,25 +32,27 @@ module Overcommit
           # Otherwise this is an ad hoc hook using an existing hook script
           hook_config = @config.for_hook(@hook_name, @context.hook_class_name)
 
-          command = Array(hook_config['command'] ||
-                          hook_config['required_executable'])
+          command = Array(hook_config['command'] || hook_config['required_executable'])
 
-          unless !@config.verify_signatures? || signable_file?(command.first)
+          if @config.verify_signatures? &&
+            signable_file?(command.first) &&
+            !Overcommit::GitRepo.tracked?(command.first)
             raise Overcommit::Exceptions::InvalidHookDefinition,
-                  'Hook must specify a `required_executable` or `command` that ' \
-                  'is tracked by git (i.e. is a path relative to the root ' \
-                  'of the repository) so that it can be signed'
+                  'Hook specified a `required_executable` or `command` that ' \
+                  'is a path relative to the root of the repository, and so ' \
+                  'must be tracked by Git in order to be signed'
           end
 
-          File.join(Overcommit::Utils.repo_root, command.first)
+          File.join(Overcommit::Utils.repo_root, command.first.to_s)
         end
       end
     end
 
     def signable_file?(file)
+      return unless file
       sep = Overcommit::OS.windows? ? '\\' : File::SEPARATOR
-      file.start_with?(".#{sep}") &&
-        Overcommit::GitRepo.tracked?(file)
+      file.start_with?(".#{sep}") ||
+        file.start_with?(Overcommit::Utils.repo_root)
     end
 
     # Return whether the signature for this hook has changed since it was last
@@ -85,7 +87,12 @@ module Overcommit
                             dup.
                             tap { |config| IGNORED_CONFIG_KEYS.each { |k| config.delete(k) } }
 
-      Digest::SHA256.hexdigest(hook_contents + hook_config.to_s)
+      content_to_sign =
+        if signable_file?(hook_path) && Overcommit::GitRepo.tracked?(hook_path)
+          hook_contents
+        end
+
+      Digest::SHA256.hexdigest(content_to_sign.to_s + hook_config.to_s)
     end
 
     def hook_contents

data/lib/overcommit/printer.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 require 'monitor'
 
 module Overcommit

data/lib/overcommit/subprocess.rb

@@ -36,7 +36,7 @@ module Overcommit
         if options[:input]
           begin
             process.io.stdin.puts(options[:input])
-          rescue # rubocop:disable Lint/HandleExceptions
+          rescue StandardError # rubocop:disable Lint/HandleExceptions
             # Silently ignore if the standard input stream of the spawned
             # process is closed before we get a chance to write to it. This
             # happens on JRuby a lot.

data/lib/overcommit/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module Overcommit
-  VERSION = '0.41.0'.freeze
+  VERSION = '0.42.0'.freeze
 end

data/template-dir/hooks/commit-msg

@@ -107,7 +107,7 @@ rescue Overcommit::Exceptions::ConfigurationSignatureChanged => error
   exit 1
 rescue Overcommit::Exceptions::InvalidHookSignature
   exit 1
-rescue => error
+rescue StandardError => error
   puts error.message
   puts error.backtrace
   puts "Report this bug at #{Overcommit::BUG_REPORT_URL}"

data/template-dir/hooks/overcommit-hook

@@ -107,7 +107,7 @@ rescue Overcommit::Exceptions::ConfigurationSignatureChanged => error
   exit 1
 rescue Overcommit::Exceptions::InvalidHookSignature
   exit 1
-rescue => error
+rescue StandardError => error
   puts error.message
   puts error.backtrace
   puts "Report this bug at #{Overcommit::BUG_REPORT_URL}"

data/template-dir/hooks/post-checkout

@@ -107,7 +107,7 @@ rescue Overcommit::Exceptions::ConfigurationSignatureChanged => error
   exit 1
 rescue Overcommit::Exceptions::InvalidHookSignature
   exit 1
-rescue => error
+rescue StandardError => error
   puts error.message
   puts error.backtrace
   puts "Report this bug at #{Overcommit::BUG_REPORT_URL}"

data/template-dir/hooks/post-commit

@@ -107,7 +107,7 @@ rescue Overcommit::Exceptions::ConfigurationSignatureChanged => error
   exit 1
 rescue Overcommit::Exceptions::InvalidHookSignature
   exit 1
-rescue => error
+rescue StandardError => error
   puts error.message
   puts error.backtrace
   puts "Report this bug at #{Overcommit::BUG_REPORT_URL}"

data/template-dir/hooks/post-merge

@@ -107,7 +107,7 @@ rescue Overcommit::Exceptions::ConfigurationSignatureChanged => error
   exit 1
 rescue Overcommit::Exceptions::InvalidHookSignature
   exit 1
-rescue => error
+rescue StandardError => error
   puts error.message
   puts error.backtrace
   puts "Report this bug at #{Overcommit::BUG_REPORT_URL}"

data/template-dir/hooks/post-rewrite

@@ -107,7 +107,7 @@ rescue Overcommit::Exceptions::ConfigurationSignatureChanged => error
   exit 1
 rescue Overcommit::Exceptions::InvalidHookSignature
   exit 1
-rescue => error
+rescue StandardError => error
   puts error.message
   puts error.backtrace
   puts "Report this bug at #{Overcommit::BUG_REPORT_URL}"

data/template-dir/hooks/pre-commit

@@ -107,7 +107,7 @@ rescue Overcommit::Exceptions::ConfigurationSignatureChanged => error
   exit 1
 rescue Overcommit::Exceptions::InvalidHookSignature
   exit 1
-rescue => error
+rescue StandardError => error
   puts error.message
   puts error.backtrace
   puts "Report this bug at #{Overcommit::BUG_REPORT_URL}"

data/template-dir/hooks/pre-push

@@ -107,7 +107,7 @@ rescue Overcommit::Exceptions::ConfigurationSignatureChanged => error
   exit 1
 rescue Overcommit::Exceptions::InvalidHookSignature
   exit 1
-rescue => error
+rescue StandardError => error
   puts error.message
   puts error.backtrace
   puts "Report this bug at #{Overcommit::BUG_REPORT_URL}"

data/template-dir/hooks/pre-rebase

@@ -107,7 +107,7 @@ rescue Overcommit::Exceptions::ConfigurationSignatureChanged => error
   exit 1
 rescue Overcommit::Exceptions::InvalidHookSignature
   exit 1
-rescue => error
+rescue StandardError => error
   puts error.message
   puts error.backtrace
   puts "Report this bug at #{Overcommit::BUG_REPORT_URL}"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: overcommit
 version: !ruby/object:Gem::Version
-  version: 0.41.0
+  version: 0.42.0
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-25 00:00:00.000000000 Z
+date: 2018-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: childprocess
@@ -83,29 +83,37 @@ files:
 - lib/overcommit/hook/post_checkout/base.rb
 - lib/overcommit/hook/post_checkout/bower_install.rb
 - lib/overcommit/hook/post_checkout/bundle_install.rb
+- lib/overcommit/hook/post_checkout/composer_install.rb
 - lib/overcommit/hook/post_checkout/index_tags.rb
 - lib/overcommit/hook/post_checkout/npm_install.rb
 - lib/overcommit/hook/post_checkout/submodule_status.rb
+- lib/overcommit/hook/post_checkout/yarn_install.rb
 - lib/overcommit/hook/post_commit/base.rb
 - lib/overcommit/hook/post_commit/bower_install.rb
 - lib/overcommit/hook/post_commit/bundle_install.rb
 - lib/overcommit/hook/post_commit/commitplease.rb
+- lib/overcommit/hook/post_commit/composer_install.rb
 - lib/overcommit/hook/post_commit/git_guilt.rb
 - lib/overcommit/hook/post_commit/index_tags.rb
 - lib/overcommit/hook/post_commit/npm_install.rb
 - lib/overcommit/hook/post_commit/submodule_status.rb
+- lib/overcommit/hook/post_commit/yarn_install.rb
 - lib/overcommit/hook/post_merge/base.rb
 - lib/overcommit/hook/post_merge/bower_install.rb
 - lib/overcommit/hook/post_merge/bundle_install.rb
+- lib/overcommit/hook/post_merge/composer_install.rb
 - lib/overcommit/hook/post_merge/index_tags.rb
 - lib/overcommit/hook/post_merge/npm_install.rb
 - lib/overcommit/hook/post_merge/submodule_status.rb
+- lib/overcommit/hook/post_merge/yarn_install.rb
 - lib/overcommit/hook/post_rewrite/base.rb
 - lib/overcommit/hook/post_rewrite/bower_install.rb
 - lib/overcommit/hook/post_rewrite/bundle_install.rb
+- lib/overcommit/hook/post_rewrite/composer_install.rb
 - lib/overcommit/hook/post_rewrite/index_tags.rb
 - lib/overcommit/hook/post_rewrite/npm_install.rb
 - lib/overcommit/hook/post_rewrite/submodule_status.rb
+- lib/overcommit/hook/post_rewrite/yarn_install.rb
 - lib/overcommit/hook/pre_commit/author_email.rb
 - lib/overcommit/hook/pre_commit/author_name.rb
 - lib/overcommit/hook/pre_commit/base.rb
@@ -115,7 +123,9 @@ files:
 - lib/overcommit/hook/pre_commit/bundle_check.rb
 - lib/overcommit/hook/pre_commit/bundle_outdated.rb
 - lib/overcommit/hook/pre_commit/case_conflicts.rb
+- lib/overcommit/hook/pre_commit/chamber_compare.rb
 - lib/overcommit/hook/pre_commit/chamber_security.rb
+- lib/overcommit/hook/pre_commit/chamber_verification.rb
 - lib/overcommit/hook/pre_commit/coffee_lint.rb
 - lib/overcommit/hook/pre_commit/credo.rb
 - lib/overcommit/hook/pre_commit/css_lint.rb
@@ -152,8 +162,10 @@ files:
 - lib/overcommit/hook/pre_commit/pep8.rb
 - lib/overcommit/hook/pre_commit/php_cs.rb
 - lib/overcommit/hook/pre_commit/php_lint.rb
+- lib/overcommit/hook/pre_commit/php_stan.rb
 - lib/overcommit/hook/pre_commit/pronto.rb
 - lib/overcommit/hook/pre_commit/puppet_lint.rb
+- lib/overcommit/hook/pre_commit/puppet_metadata_json_lint.rb
 - lib/overcommit/hook/pre_commit/pycodestyle.rb
 - lib/overcommit/hook/pre_commit/pydocstyle.rb
 - lib/overcommit/hook/pre_commit/pyflakes.rb
@@ -163,6 +175,7 @@ files:
 - lib/overcommit/hook/pre_commit/rails_schema_up_to_date.rb
 - lib/overcommit/hook/pre_commit/rake_target.rb
 - lib/overcommit/hook/pre_commit/reek.rb
+- lib/overcommit/hook/pre_commit/rst_lint.rb
 - lib/overcommit/hook/pre_commit/rubo_cop.rb
 - lib/overcommit/hook/pre_commit/ruby_lint.rb
 - lib/overcommit/hook/pre_commit/scalariform.rb
@@ -197,10 +210,12 @@ files:
 - lib/overcommit/hook/pre_rebase/merged_commits.rb
 - lib/overcommit/hook/shared/bower_install.rb
 - lib/overcommit/hook/shared/bundle_install.rb
+- lib/overcommit/hook/shared/composer_install.rb
 - lib/overcommit/hook/shared/index_tags.rb
 - lib/overcommit/hook/shared/npm_install.rb
 - lib/overcommit/hook/shared/rake_target.rb
 - lib/overcommit/hook/shared/submodule_status.rb
+- lib/overcommit/hook/shared/yarn_install.rb
 - lib/overcommit/hook_context.rb
 - lib/overcommit/hook_context/base.rb
 - lib/overcommit/hook_context/commit_msg.rb
@@ -251,7 +266,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2'
+      version: '2.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -259,7 +274,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Git hook manager