overcommit 0.3.2 → 0.4.0

data/config/templates.yml

@@ -6,6 +6,7 @@ default:
       - release_note
     pre_commit:
       - causes_email
+      - image_optimization
       - restricted_paths
       - test_history
 all:

data/lib/overcommit/plugins/pre_commit/image_optimization.rb

@@ -0,0 +1,50 @@
+module Overcommit::GitHook
+  class ImageOptimization < HookSpecificCheck
+    include HookRegistry
+    file_types :gif, :jpeg, :jpg, :png
+
+    def run_check
+      begin
+        require 'image_optim'
+      rescue LoadError
+        return :warn, "'image_optim' gem not installed -- run `gem install image_optim`"
+      end
+
+      optimized_images =
+        begin
+          ImageSet.new(staged.map(&:original_path)).
+            optimize_with(ImageOptim.new(:pngout => false))
+
+        rescue ImageOptim::BinNotFoundError => e
+          return :stop,
+            "#{e.message}. The image_optim gem is dependendent on this binary. " <<
+            "See https://github.com/toy/image_optim for more info."
+        end
+
+      if optimized_images.any?
+        return :bad,
+          "Optimized #{optimized_images.map(&:to_s).inspect}. " <<
+            " Please add them to your commit."
+      else
+        return :good
+      end
+    end
+
+    class ImageSet
+      attr_reader :image_paths
+
+      def initialize(image_paths)
+        @image_paths ||= image_paths
+      end
+
+      def optimize_with(image_optim)
+        results =
+          image_optim.optimize_images!(image_paths) do |path, was_optimized|
+            path if was_optimized
+          end
+
+        results.compact
+      end
+    end
+  end
+end

data/lib/overcommit/utils.rb

@@ -50,7 +50,7 @@ module Overcommit
       # Get a list of staged Added, Copied, or Modified files (ignore renames
       # and deletions, since there should be nothing to check).
       def modified_files
-        `git diff --cached --name-only --diff-filter=ACM`.split "\n"
+        `git diff --cached --name-only --diff-filter=ACM --ignore-submodules=all`.split "\n"
       end
 
     private

data/lib/overcommit/version.rb

@@ -1,3 +1,3 @@
 module Overcommit
-  VERSION = '0.3.2'
+  VERSION = '0.4.0'
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: overcommit
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 15
   prerelease: false
   segments: 
   - 0
-  - 3
-  - 2
-  version: 0.3.2
+  - 4
+  - 0
+  version: 0.4.0
 platform: ruby
 authors: 
 - Causes Engineering
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-10-28 00:00:00 -07:00
+date: 2013-11-06 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -34,6 +34,22 @@ dependencies:
         version: 2.13.0
   type: :development
   version_requirements: *id001
+- !ruby/object:Gem::Dependency 
+  name: image_optim
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        hash: 57
+        segments: 
+        - 0
+        - 9
+        - 1
+        version: 0.9.1
+  type: :development
+  version_requirements: *id002
 description: Overcommit is a utility to install and extend Git hooks
 email: eng@causes.com
 executables: 
@@ -62,6 +78,7 @@ files:
 - lib/overcommit/plugins/pre_commit/causes_email.rb
 - lib/overcommit/plugins/pre_commit/author_name.rb
 - lib/overcommit/plugins/pre_commit/whitespace.rb
+- lib/overcommit/plugins/pre_commit/image_optimization.rb
 - lib/overcommit/plugins/pre_commit/python_flake8.rb
 - lib/overcommit/plugins/pre_commit/coffee_lint.rb
 - lib/overcommit/plugins/pre_commit/test_history.rb