overcommit 0.38.0 → 0.39.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6acb06db375fab15a3e54993b9dce2027bb50a4e
-  data.tar.gz: 4738cd572e644f626e42100ff6e147e2d2f217fb
+  metadata.gz: 6e248dab5322fa00f20964aba130b5d37c4b9572
+  data.tar.gz: e67e895aad71be1c47474edf5a37f30100a5378a
 SHA512:
-  metadata.gz: 18b93d2fca87325466f71ba3109852734549bf4f5126b430fa2d8a01cac5ed0b7b7c47e22cea709fc5cc80c2843ce86fcf2cfbc29ecca42b5a01546827493a37
-  data.tar.gz: 9ceca9e9ae9e08ac83fcd9f50e869c6549f67468643bfbfdaec6ff82575c47d8caba9f99bff5a96a8146cd981a2df9cbc7e22192d4e5f3eb573fe8ce62103a27
+  metadata.gz: d01920e348b991fe2675a92d5f6b54ce3fc2691f9ffca7f22344be10c5ee3116a03e9137838c3944c01a5cc73b8a5f256a979e8b56214c202aa24d751e853796
+  data.tar.gz: e2fae65ea2dd8f37ffa1dfcf9ade533f74069413ca05aeb9382c1233400441fa95738cb302547a0f7fd7ce60e371ae9b1e2003ef4d671a241ad6221f6f724171

data/config/default.yml

@@ -906,6 +906,12 @@ PrePush:
     required_executable: 'pytest'
     install_command: 'pip install -U pytest'
 
+  PythonNose:
+    enabled: false
+    description: 'Run nose test suite'
+    required_executable: 'nosetests'
+    install_command: 'pip install -U nose'
+
   RSpec:
     enabled: false
     description: 'Run RSpec test suite'
@@ -939,6 +945,10 @@ PrePush:
     flags: ['--exit-on-warn', '--quiet', '--summary']
     install_command: 'gem install brakeman'
 
+  GitLfs:
+    enabled: false
+    description: 'Upload files tracked by Git LFS'
+
 # Hooks that run during `git rebase`, before any commits are rebased.
 # If a hook fails, the rebase is aborted.
 PreRebase:

data/lib/overcommit/git_repo.rb

@@ -106,7 +106,8 @@ module Overcommit
     # @return [Array<String>] list of absolute file paths
     def list_files(paths = [], options = {})
       ref = options[:ref] || 'HEAD'
-      `git ls-tree --name-only #{ref} "#{paths.join('" "')}"`.
+      path_list = paths.empty? ? '' : "\"#{paths.join('" "')}\""
+      `git ls-tree --name-only #{ref} #{path_list}`.
         split(/\n/).
         map { |relative_file| File.expand_path(relative_file) }.
         reject { |file| File.directory?(file) } # Exclude submodule directories

data/lib/overcommit/hook/commit_msg/message_format.rb

@@ -17,11 +17,13 @@ module Overcommit::Hook::CommitMsg
       expected_pattern_message = config['expected_pattern_message']
       sample_message = config['sample_message']
 
-      [
-        'Commit message pattern mismatch.',
-        "Expected : #{expected_pattern_message}",
-        "Sample : #{sample_message}"
-      ].join("\n") unless message =~ /#{pattern}/
+      unless message =~ /#{pattern}/
+        [
+          'Commit message pattern mismatch.',
+          "Expected : #{expected_pattern_message}",
+          "Sample : #{sample_message}"
+        ].join("\n")
+      end
     end
   end
 end

data/lib/overcommit/hook/pre_commit/es_lint.rb

@@ -19,12 +19,15 @@ module Overcommit::Hook::PreCommit
     def run
       result = execute(command, args: applicable_files)
       output = result.stdout.chomp
+      messages = output.split("\n").grep(/Warning|Error/)
+
+      return [:fail, result.stderr] if messages.empty? && !result.success?
       return :pass if result.success? && output.empty?
 
       # example message:
       #   path/to/file.js: line 1, col 0, Error - Error message (ruleName)
       extract_messages(
-        output.split("\n").grep(/Warning|Error/),
+        messages,
         /^(?<file>(?:\w:)?[^:]+):[^\d]+(?<line>\d+).*?(?<type>Error|Warning)/,
         lambda { |type| type.downcase.to_sym }
       )

data/lib/overcommit/hook/pre_push/git_lfs.rb

@@ -0,0 +1,20 @@
+module Overcommit::Hook::PrePush
+  # Invokes Git LFS command that uploads files tracked by Git LFS to the LFS storage
+  #
+  # @see https://git-lfs.github.com/
+  class GitLfs < Base
+    def run
+      unless in_path?('git-lfs')
+        return :warn, 'This repository is configured for Git LFS but \'git-lfs\' ' \
+        "was not found on your path.\nIf you no longer wish to use Git LFS, " \
+        'disable this hook by removing or setting \'enabled: false\' for GitLFS ' \
+        'hook in your .overcommit.yml file'
+      end
+
+      result = execute(['git', 'lfs', 'pre-push', remote_name, remote_url])
+      return :fail, result.stderr unless result.success?
+
+      :pass
+    end
+  end
+end

data/lib/overcommit/hook/pre_push/protected_branches.rb

@@ -21,6 +21,7 @@ module Overcommit::Hook::PrePush
 
     def protected?(remote_ref)
       ref_name = remote_ref[%r{refs/heads/(.*)}, 1]
+      return false if ref_name.nil?
       protected_branch_patterns.any? do |pattern|
         File.fnmatch(pattern, ref_name)
       end

data/lib/overcommit/hook/pre_push/python_nose.rb

@@ -0,0 +1,14 @@
+module Overcommit::Hook::PrePush
+  # Runs `nose` test suite before push
+  #
+  # @see https://nose.readthedocs.io/en/latest/
+  class PythonNose < Base
+    def run
+      result = execute(command)
+      return :pass if result.success?
+
+      output = result.stdout + result.stderr
+      [:fail, output]
+    end
+  end
+end

data/lib/overcommit/hook_context/pre_commit.rb

@@ -126,6 +126,12 @@ module Overcommit::HookContext
       @modified_lines[file]
     end
 
+    # Returns whether the current git branch is empty (has no commits).
+    def initial_commit?
+      return @initial_commit unless @initial_commit.nil?
+      @initial_commit = Overcommit::GitRepo.initial_commit?
+    end
+
     private
 
     # Clears the working tree so that the stash can be applied.
@@ -170,12 +176,6 @@ module Overcommit::HookContext
       modified_files.any?
     end
 
-    # Returns whether the current git branch is empty (has no commits).
-    def initial_commit?
-      return @initial_commit unless @initial_commit.nil?
-      @initial_commit = Overcommit::GitRepo.initial_commit?
-    end
-
     # Stores the modification times for all modified files to make it appear like
     # they never changed.
     #

data/lib/overcommit/hook_context/pre_push.rb

@@ -17,7 +17,7 @@ module Overcommit::HookContext
       end
     end
 
-    PushedRef = Struct.new(:local_ref, :local_sha1, :remote_ref, :remote_sha1) do # rubocop:disable Metrics/BlockLength, Metrics/LineLength
+    PushedRef = Struct.new(:local_ref, :local_sha1, :remote_ref, :remote_sha1) do
       def forced?
         !(created? || deleted? || overwritten_commits.empty?)
       end

data/lib/overcommit/hook_runner.rb

@@ -107,6 +107,9 @@ module Overcommit
 
             # Wait for a signal from another thread to try again
             @resource.wait(@lock)
+          else
+            # Otherwise there are not slots left, so just wait for signal
+            @resource.wait(@lock)
           end
         end
       end

data/lib/overcommit/installer.rb

@@ -36,6 +36,9 @@ module Overcommit
       install_hook_files
       install_starter_config
 
+      # Auto-sign configuration file on install
+      config(verify: false).update_signature!
+
       log.success "Successfully installed hooks into #{@target}"
     end
 
@@ -180,5 +183,10 @@ module Overcommit
       # doesn't exist. Standardize the behavior to return false.
       false
     end
+
+    # Returns the configuration for this repository.
+    def config(options = {})
+      Overcommit::ConfigurationLoader.new(log, options).load_repo_config
+    end
   end
 end

data/lib/overcommit/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module Overcommit
-  VERSION = '0.38.0'.freeze
+  VERSION = '0.39.0'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: overcommit
 version: !ruby/object:Gem::Version
-  version: 0.38.0
+  version: 0.39.0
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-24 00:00:00.000000000 Z
+date: 2017-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: childprocess
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.8
+        version: 0.6.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.8
+        version: 0.6.1
 - !ruby/object:Gem::Dependency
   name: iniparse
   requirement: !ruby/object:Gem::Requirement
@@ -172,9 +172,11 @@ files:
 - lib/overcommit/hook/pre_commit/yaml_syntax.rb
 - lib/overcommit/hook/pre_push/base.rb
 - lib/overcommit/hook/pre_push/brakeman.rb
+- lib/overcommit/hook/pre_push/git_lfs.rb
 - lib/overcommit/hook/pre_push/minitest.rb
 - lib/overcommit/hook/pre_push/protected_branches.rb
 - lib/overcommit/hook/pre_push/pytest.rb
+- lib/overcommit/hook/pre_push/python_nose.rb
 - lib/overcommit/hook/pre_push/r_spec.rb
 - lib/overcommit/hook/pre_push/rake_target.rb
 - lib/overcommit/hook/pre_push/test_unit.rb
@@ -244,9 +246,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Git hook manager
 test_files: []
-has_rdoc: