outbox-rails 0.4.2 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eceec3189f8004a8e9728100dd43265fb209f18f
-  data.tar.gz: 7036c123d5bfdd85443acb520d08203078fd90ab
+  metadata.gz: 5d47ed2e12f0d6f3f445990ae1c7a91b1cb2c31a
+  data.tar.gz: ff619f0020f765892a3b9b746bbb334faa28a6d6
 SHA512:
-  metadata.gz: 160928851f2b7d303ec99f612e6a89cda8c872225c4ed3d582f71f0291617102a63a3790eb9fe6ff1491f3e253df1a4e015b3d9e11544bc75291cc54ecc40b2e
-  data.tar.gz: d38b209ffad1228f25568a55b77a1785641794f90f1f2c6bf952642265c76d3eac70a73c1ef3c919feb75b15d4366272559604b147069c68402a45ad00f7564e
+  metadata.gz: cb4603db03b75639a21d463c54e9633c45eb8f58b30b737ef2b041e26416e2337ebd9dfba1e4ad0227d4ad293eb6d4eae2fec0dbd90c8e5a0a607b49b844062f
+  data.tar.gz: a0ccc712a2ceac94304b251b37887af2059f7c9be26bfeaf7f8956bb6cc465126ff09b1f77cc4740e8776ec478dc007f9ffbfa10ff9f4d5de6f346eadb369ff4

data/.rubocop.yml

@@ -0,0 +1,25 @@
+AllCops:
+  Exclude:
+    - "vendor/**/*"
+    - "lib/generators/*/notifier/templates/*"
+  DisplayCopNames: true
+  DisplayStyleGuide: true
+
+Style/Documentation:
+  Enabled: false
+
+Metrics/BlockLength:
+  Exclude:
+    - "spec/**/*"
+
+Metrics/ClassLength:
+  Max: 150
+
+Metrics/LineLength:
+  Exclude:
+    - "outbox-rails.gemspec"
+  IgnoreCopDirectives: true
+  Max: 100
+
+Metrics/MethodLength:
+  Max: 15

data/.travis.yml

@@ -0,0 +1,10 @@
+sudo: false
+cache: bundler
+language: ruby
+rvm:
+ - 2.2.6
+ - 2.3.3
+ - 2.4.1
+script:
+  - bundle exec rubocop
+  - bundle exec rspec

data/Rakefile

@@ -3,4 +3,4 @@ require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/lib/outbox-rails.rb

@@ -1 +1,2 @@
+# rubocop:disable Style/FileName
 require 'outbox/rails'

data/lib/outbox/notifier.rb

@@ -7,11 +7,11 @@ module Outbox
 
     abstract!
 
-    alias_method :_render_email, :mail
+    alias _render_email mail
     undef :mail
 
     class << self
-      alias_method :defaults, :default
+      alias defaults default
 
       # Returns the name of current notifier. This method is also being used
       # as a path for a view lookup. If this is an anonymous notifier,
@@ -23,10 +23,11 @@ module Outbox
           self.mailer_name = value
         end
       end
-      alias_method :notifier_name=, :notifier_name
+      alias notifier_name= notifier_name
 
       protected
 
+      # rubocop:disable Style/MethodMissing
       def method_missing(method_name, *args) # :nodoc:
         if respond_to?(method_name)
           new(method_name, *args).message
@@ -143,11 +144,11 @@ module Outbox
     end
 
     def assign_body(body, only_message_types = nil)
-      if only_message_types
-        only_message_types = only_message_types.map(&:to_sym)
-      else
-        only_message_types = message_types_without_email
-      end
+      only_message_types = if only_message_types
+                             only_message_types.map(&:to_sym)
+                           else
+                             message_types_without_email
+                           end
       @_message.each_message_type do |message_type, message|
         if message && message.body.nil? && message_type.in?(only_message_types)
           message.body = body

data/lib/outbox/rails/railtie.rb

@@ -13,14 +13,15 @@ module Outbox
 
       initializer 'outbox.config' do |app|
         options = app.config.outbox
-        use_test_client = !!options.delete(:use_test_client)
 
         ActiveSupport.on_load(:outbox) do
-          Outbox::Message.use_test_client if use_test_client
+          Outbox::Message.use_test_client if options.delete(:use_test_client)
 
           options.each do |key, value|
             option_setter = "#{key}="
-            Outbox::Message.public_send(option_setter, value) if Outbox::Message.respond_to?(option_setter)
+            if Outbox::Message.respond_to?(option_setter)
+              Outbox::Message.public_send(option_setter, value)
+            end
           end
         end
       end

data/lib/outbox/rails/version.rb

@@ -1,5 +1,5 @@
 module Outbox
   module Rails
-    VERSION = '0.4.2'
+    VERSION = '0.5.0'.freeze
   end
 end

data/outbox-rails.gemspec

@@ -1,30 +1,31 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'outbox/rails/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = 'outbox-rails'
-  spec.version       = Outbox::Rails::VERSION
-  spec.authors       = ['Pete Browne']
-  spec.email         = ['pete.browne@localmed.com']
-  spec.description   = %q{Rails Railtie for sending email, SMS, and push notifications using the Outbox gem.}
-  spec.summary       = %q{Rails Railtie for sending email, SMS, and push notifications using the Outbox gem.}
-  spec.homepage      = 'https://github.com/localmed/outbox-rails'
-  spec.license       = 'MIT'
+  spec.name = 'outbox-rails'
+  spec.version = Outbox::Rails::VERSION
+  spec.authors = ['Pete Browne']
+  spec.email = ['pete.browne@localmed.com']
+  spec.description = 'Rails Railtie for sending email, SMS, and push notifications using the Outbox gem.'
+  spec.summary = 'Rails Railtie for sending email, SMS, and push notifications using the Outbox gem.'
+  spec.homepage = 'https://github.com/localmed/outbox-rails'
+  spec.license  = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'outbox', '~> 0.2.0'
-  spec.add_runtime_dependency 'rails', ['>= 4.0', '< 5']
+  spec.add_runtime_dependency 'rails', ['>= 4.0', '< 6']
   spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'rspec-rails'
-  spec.add_development_dependency 'rspec_junit_formatter'
+  spec.add_development_dependency 'combustion', '~> 0.6.0'
+  spec.add_development_dependency 'rake', '~> 12.0.0'
+  spec.add_development_dependency 'rspec', '~> 3.5.0'
+  spec.add_development_dependency 'rspec-rails', '~> 3.5.2'
+  spec.add_development_dependency 'rubocop', '~> 0.48.1'
   spec.add_development_dependency 'sqlite3'
-  spec.add_development_dependency 'combustion'
 end

data/spec/internal/app/notifiers/customized_notifier.rb

@@ -1,6 +1,5 @@
 class CustomizedNotifier < Outbox::Notifier
   defaults email: { from: 'noreply@myapp.com' }
 
-  def with_defaults
-  end
+  def with_defaults; end
 end

data/spec/outbox/notifier_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe Outbox::Notifier do
   describe 'calling actions' do
     it 'does not raise error' do
-      expect{BaseNotifier.welcome}.not_to raise_error()
+      expect { BaseNotifier.welcome }.not_to raise_error
     end
 
     it 'returns an Outbox Message' do
@@ -59,12 +59,12 @@ describe Outbox::Notifier do
     it 'handles multipart templates' do
       message = BaseNotifier.implicit_multipart
       expect(message.email.parts.size).to eq(2)
-      part_1 = message.email.parts[0]
-      part_2 = message.email.parts[1]
-      expect(part_1.mime_type).to eq('text/plain')
-      expect(part_1.body.encoded.strip).to eq('TEXT Implicit Multipart')
-      expect(part_2.mime_type).to eq('text/html')
-      expect(part_2.body.encoded.strip).to eq('HTML Implicit Multipart')
+      part1 = message.email.parts[0]
+      part2 = message.email.parts[1]
+      expect(part1.mime_type).to eq('text/plain')
+      expect(part1.body.encoded.strip).to eq('TEXT Implicit Multipart')
+      expect(part2.mime_type).to eq('text/html')
+      expect(part2.body.encoded.strip).to eq('HTML Implicit Multipart')
     end
 
     it 'handles attachments' do
@@ -93,9 +93,9 @@ describe Outbox::Notifier do
     end
 
     it 'raises template errors when sending emails' do
-      expect {
+      expect do
         BaseNotifier.explicit_sms_message
-      }.to raise_error(ActionView::MissingTemplate)
+      end.to raise_error(ActionView::MissingTemplate)
     end
 
     if Rails.version >= '4.1'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: outbox-rails
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.5.0
 platform: ruby
 authors:
 - Pete Browne
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-01 00:00:00.000000000 Z
+date: 2017-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: outbox
@@ -33,7 +33,7 @@ dependencies:
         version: '4.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -43,7 +43,7 @@ dependencies:
         version: '4.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '6'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -59,77 +59,77 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: combustion
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.6.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 12.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 12.0.0
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.5.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.5.0
 - !ruby/object:Gem::Dependency
-  name: rspec_junit_formatter
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.5.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.5.2
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.48.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.48.1
 - !ruby/object:Gem::Dependency
-  name: combustion
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -152,6 +152,8 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -215,7 +217,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.4.5.2
 signing_key: 
 specification_version: 4
 summary: Rails Railtie for sending email, SMS, and push notifications using the Outbox