outbacker 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 75b6426d3f64c62516541550bd341193474249e7
-  data.tar.gz: 57a542ea46bf9c35e4b6e2a353640f78a74f6aea
+  metadata.gz: 0143dd842687048bc2076a78360252ad9302f8d8
+  data.tar.gz: 97490cf634e5ef6851fe836811f02fb7724510c0
 SHA512:
-  metadata.gz: f6c04602dee484578e756c6c8f6c663af69fddd4f398b73a4e386b42ea6ad983405b7e479f492c5c713dd85f3ddd1e73932f7eacaa02f367e226a3d178a238f6
-  data.tar.gz: 71ee9b9aef806fed79fc4f81e1bc37368125f37d877277387e310e731a678fe5c0dfb50616e4e67c0ea88932eeb2d813fcd0b2b40dfd51900eb4e912eaff5fc3
+  metadata.gz: e1672a59a420cf378b496293edda42a88197198e41e759e67cd572ab098cd888b73a119ce8adbcd7b78a65ad5b42679fb86764f39514a54b9b01d14405d3f46e
+  data.tar.gz: 2aac0eaf837d5ca42a91582ef0c412876040e93faa4bbf055a69bc93761e2ad0c7bfda5d591fc9c617cbc0be757331340c8614cf88fd400702dabbc6614f4583

data/.travis.yml

@@ -6,7 +6,6 @@ rvm:
   - 2.0.0
   - 2.1
   - 2.2.2
-  - ruby-head
   - jruby
   - rbx-2
 

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 0.1.2 2015-08-17
+[changed] Change to allow 'and return' syntax following 'outcomes.handle...' in an outbacked method, e.g.: 'outcomes.handle :success and return
+[changed] In OutbackerStub, rename stub method to stub_outbacked_method, add stub_simple_method.
+
 ## 0.1.1 2015-07-27
 [changed] Updated README and examples.
 

data/README.md

@@ -1,9 +1,12 @@
 # Outbacker
 
 [![Build Status](https://travis-ci.org/polypressure/outbacker.svg?branch=master)](https://travis-ci.org/polypressure/outbacker)
-[![Code Climate](https://codeclimate.com/github/polypressure/outbacker/badges/gpa.svg)](https://codeclimate.com/github/polypressure/outbacker)
 [![Test Coverage](https://codeclimate.com/github/polypressure/outbacker/badges/coverage.svg)](https://codeclimate.com/github/polypressure/outbacker/coverage)
+[![Code Climate](https://codeclimate.com/github/polypressure/outbacker/badges/gpa.svg)](https://codeclimate.com/github/polypressure/outbacker)
 [![Gem Version](https://badge.fury.io/rb/outbacker.svg)](http://badge.fury.io/rb/outbacker)
+[![security](https://hakiri.io/github/polypressure/outbacker/master.svg)](https://hakiri.io/github/polypressure/outbacker/master)
+[![Dependency Status](https://gemnasium.com/polypressure/outbacker.svg)](https://gemnasium.com/polypressure/outbacker)
+
 
 Rails developers have long known how important it is to keep controllers "skinny" and free of business logic. Our controllers are supposed to be dumb dispatchers that take results from the model layer and turn them into redirects, flash messages, form re-renderings, session state updates, JSON responses, HTTP status codes, and so on.
 
@@ -301,7 +304,7 @@ require 'test_support/outbacker_stub'
 
 test "user is redirected to the credits purchase page when they lack sufficient credits" do
   calendar_stub = Outbacker::OutbackerStub.new
-  calendar_stub.stub('book_appointment', :insufficient_credits, stubbed_appointment)
+  calendar_stub.stub_outbacked_method('book_appointment', :insufficient_credits, stubbed_appointment)
 
   # This is a method we added to our controller to inject dependencies:
   @controller.inject_calendar(calendar_stub)

data/examples/test/controllers/appointments_controller_test.rb

@@ -21,7 +21,7 @@ class AppointmentsControllerTest < ActionController::TestCase
     # it will have an outcome of :insufficient_credits.
     #
     calendar_stub = Outbacker::OutbackerStub.new
-    calendar_stub.stub('book_appointment', :insufficient_credits, stubbed_appointment)
+    calendar_stub.stub_outbacked_method('book_appointment', :insufficient_credits, stubbed_appointment)
 
     # This is a method we added to our controller to inject dependencies:
     @controller.inject_calendar(calendar_stub)

data/lib/outbacker.rb

@@ -54,6 +54,7 @@ module Outbacker
         outcome_handlers.call(self)
         raise "No outcome handler for outcome #{outcome_key}" unless outcome_handled?
       end
+      true
     end
 
     #

data/lib/outbacker/version.rb

@@ -1,3 +1,3 @@
 module Outbacker
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/lib/test_support/outbacker_stub.rb

@@ -26,11 +26,11 @@ module Outbacker
 
     def initialize(method_name=nil, outcome_key=nil, *block_args)
       if method_name && outcome_key
-        stub(method_name, outcome_key, *block_args)
+        stub_outbacked_method(method_name, outcome_key, *block_args)
       end
     end
 
-    def stub(method_name, outcome_key, *block_args)
+    def stub_outbacked_method(method_name, outcome_key, *block_args)
       define_singleton_method(method_name, ->(*args, &outcome_handlers) {
         with(outcome_handlers) do |outcomes|
           outcomes.handle outcome_key, *block_args
@@ -38,5 +38,11 @@ module Outbacker
       })
     end
 
+    def stub_simple_method(method_name, result)
+      define_singleton_method(method_name) do
+        result
+      end
+    end
+
   end
 end

data/outbacker.gemspec

@@ -22,11 +22,12 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency 'configurations', '~> 2.2.0'
+  spec.add_runtime_dependency 'configurations', '~> 2.2', '>= 2.2.0'
+
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "minitest", "~> 5.5"
-  spec.add_development_dependency "m", "~> 1.3.1"
-  spec.add_development_dependency "simplecov"
-  spec.add_development_dependency "codeclimate-test-reporter"
+  spec.add_development_dependency 'm', '~> 1.3', '>= 1.3.1'
+  spec.add_development_dependency 'simplecov', '~> 0.10', '>= 0.10.0'
+  spec.add_development_dependency 'codeclimate-test-reporter', '~> 0.4', '>= 0.4.7'
 end

data/test/outbacker_stub_test.rb

@@ -6,7 +6,7 @@ class OutbackerStubTest < Minitest::Test
   test "#stub defines the specified method on the stub instance" do
     outbacker_stub = Outbacker::OutbackerStub.new
 
-    outbacker_stub.stub('register_user', :successful_registration, Object.new)
+    outbacker_stub.stub_outbacked_method('register_user', :successful_registration, Object.new)
 
     assert_respond_to outbacker_stub, 'register_user'
   end
@@ -15,7 +15,7 @@ class OutbackerStubTest < Minitest::Test
     outbacker_stub = Outbacker::OutbackerStub.new
     correct_block_executed = false
 
-    outbacker_stub.stub('register_user', :successful_registration, Object.new)
+    outbacker_stub.stub_outbacked_method('register_user', :successful_registration, Object.new)
 
     outbacker_stub.register_user do |on_outcome|
       on_outcome.of(:successful_registration) do |user|
@@ -40,7 +40,7 @@ class OutbackerStubTest < Minitest::Test
     block_arg_2 = Object.new
     block_args_passed = []
 
-    outbacker_stub.stub('register_user', :successful_registration, block_arg_1, block_arg_2)
+    outbacker_stub.stub_outbacked_method('register_user', :successful_registration, block_arg_1, block_arg_2)
 
     outbacker_stub.register_user do |on_outcome|
       on_outcome.of(:successful_registration) do |arg1, arg2|

data/test/outbacker_test.rb

@@ -185,6 +185,14 @@ class OutbackerTest < Minitest::Test
     assert_equal expected_return_values, actual_return_values
   end
 
+  test "can use 'and return' syntax following 'outcomes.handle...' in outbacked method '" do
+    outbacked_domain_object.domain_method_with_chained_return do |on_outcome|
+      on_outcome.of(:outcome_1) do
+        pass "Successfully handled outcome and chained return"
+      end
+    end
+  end
+
 
 
   test "including within a subclass of ActiveRecord raises an exception" do
@@ -301,6 +309,13 @@ class SomeDomainObject
     end
   end
 
+  def domain_method_with_chained_return(&outcome_handlers)
+    with(outcome_handlers) do |outcomes|
+      outcomes.handle :outcome_1 and return
+      fail "Should have returned"
+    end
+  end
+
   def domain_method_with_no_outcome(arg, &outcome_handlers)
     with(outcome_handlers) do |outcomes|
     end

metadata

@@ -1,20 +1,23 @@
 --- !ruby/object:Gem::Specification
 name: outbacker
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Anthony Garcia
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-27 00:00:00.000000000 Z
+date: 2015-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: configurations
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.2'
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.2.0
   type: :runtime
@@ -22,6 +25,9 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.2'
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.2.0
 - !ruby/object:Gem::Dependency
@@ -71,6 +77,9 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.3.1
   type: :development
@@ -78,36 +87,51 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.3.1
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.10'
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.10'
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.4'
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.4.7
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.4'
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.4.7
 description: |2
       A micro library to keep conditional logic out of your Rails
       controllers and help you write more intention-revealing