otis 0.0.5 → 0.0.6

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NjNlNDM2YzIxMTJhOTU3M2QzMjRjMTFjM2ZiOGVhYjc3N2NmYTRmYw==
+    ZGM4ZjdiZmM3YjEyZDYzZGJhODAwMWEyYzU0ODliNmVlNDI4Mjk1OA==
   data.tar.gz: !binary |-
-    NWJmNjRiNDk0YmY3NTdkOTA5NzY2ZjEwOTAyYjk4NTczNGNkYzVjZg==
+    Mzc2M2JhZDE1MTFlYWVkOTJiNzA1ODZlZTYwZDc3MjQyYzNiZmQ0MQ==
 SHA512:
   metadata.gz: !binary |-
-    ZmZlYzU1M2E5MzYxYTg0MmI3NDI4MDBhMzBkNDcwZDUxM2IyNWQxNGRlMWNi
-    NDk1NThmYTVkMjIzNTM4MDZlMDM0YWJjYTBkYjdmNTJkZmNiZDhhZmY4ZmUz
-    NTMzMGFhMzY4ZmJlMGUyZTI4NTJlZDM3ZDRmNWRjMWRjNzk2YTc=
+    NmYxNjFlZWZjNjUwZTE0OTI5ZmUyNDAwYzFhNmYzYTY3MDM5ODk3YWEyMDRi
+    ZWRmYmExNGU1ZTMyZmY2MDM3ZGUxMjhjODQ1MTNiZmRlNGM1ZWM1YTI0NmUw
+    NzFiN2QxNzRmNGY1ZmI3YjQxYmMxZmY3NjA1Yjk3Y2M1MWU3Njg=
   data.tar.gz: !binary |-
-    Yzg3NjgxYTc4YTJlN2MxZGU5Y2M4M2Y4YWE5NzkxN2RhYTgyMzQ3NzZlZjE5
-    MGE5NzZiMTM3YWZhOWYzMGM0OTFkZTJjNzRlZDk2ZTUxOWQzZDM0NWZlOTk0
-    YjhlOTc0ZmEzNzNjMGEzODJkYjE0ZjQwODNlODc1MzY4YzlkZmI=
+    MGM5ZWU3YzljNmRiNDAxNTJkZTFkZjIzMDg2MGViZjFiY2Q4YjlhZTgwZjNk
+    MGY4NmJkN2YyOTMxNjBkYWZmMzZkYjJiMjQzODI5YWU3N2Q5NGNkMzRmMTg4
+    NmFiYzFhZDZiMDhiNmJmNTUzYzMyMzZkNmFjYTdmNDExYmRlOWQ=

data/lib/otis/otis_object.rb

@@ -20,10 +20,47 @@ module Otis
         end
       end
 
+      #
+      # This method allows a dynamic generation a list of node in a parent one.
+      # It differs slightly from Virtus mapping in a way that it guarantess that
+      # a return of a collection is always an array and never a nil object
+      #
       def collection(opts ={})
         collection = opts[:as].to_s
         klass = opts[:of]
-        class_eval %(def #{collection}; @#{collection} ||= Array(@response['#{camelize(collection)}']).map{|c| #{klass}.new(c)}; end)
+        class_eval %(def #{collection}; @#{collection} ||= Array(@response[:#{collection}]).map{|c| #{klass}.new(c)}; end)
+      end
+
+      #
+      # When Savon receives a response with attributes in its tags, it creates
+      # keys that start with '@' sign, which breaks in the Virtus object
+      # transformation.
+      # This method allows the mapping of an attribute that would be originally
+      # ignored by Virtus. See the example below:
+      #
+      # <response duration="123">
+      #    <tag>Foo</tag>
+      # </response>
+      #
+      # In order to create the right mapper, the following needs to be done:
+      #
+      # class YourObject < Otis::Model
+      #   tag_attribute :duration
+      #   attribute :tag
+      # end
+      #
+      # yourObject.tag       # => "Foo"
+      # yourObject.duration  #=> 123
+      #
+      #
+      def tag_attributes(*args)
+        args.each do |m|
+          class_eval %(
+            def #{m}
+              @response[:@#{m}]
+            end
+          )
+        end
       end
 
       private

data/lib/otis/soap_client.rb

@@ -11,7 +11,7 @@ module Otis
 
     protected
     def call(action, options)
-      soap_response = @client.call(action, options.first).body
+      soap_response = @client.call(action, options).body
       soap_response
     end
   end

data/lib/otis/version.rb

@@ -1,3 +1,3 @@
 module Otis
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/spec/lib/otis/otis_object_spec.rb

@@ -3,12 +3,15 @@ require 'spec_helper'
 describe Otis::Object do
 
   describe 'collection' do
-    class Thing; end
+    class Thing < Otis::Model
+      attribute :a
+    end
 
     class TestClass
       include Otis::Object
       collection of: Thing, as: :things
     end
+
     let(:klass) { TestClass.new }
 
     it 'creates the get' do
@@ -20,5 +23,26 @@ describe Otis::Object do
       klass.things << Thing.new
       expect(klass.things.count).to eq(2)
     end
+
+    it 'transforms correctly the collection' do
+      klass = TestClass.new(:things => [{a: 'foo'},  {b: 'bar'}])
+      expect(klass.things.count).to eq(2)
+      expect(klass.things.first.a).to eq('foo')
+    end
   end
+
+  describe 'tag attributes' do
+    class TestAttributeClass < Otis::Model
+      tag_attributes :foo, :bar
+    end
+
+    describe 'dinamic method creation' do
+      it 'reads from the hash removing @' do
+        t = TestAttributeClass.new(:@foo => 'f', :@bar => 'b')
+        t.foo.should == 'f'
+        t.bar.should == 'b'
+      end
+    end
+  end
+
 end

data/spec/lib/otis/soap_client_spec.rb

@@ -23,7 +23,7 @@ describe Otis::SoapClient do
     before { client.stub_chain(:call, :body).and_return(response) }
 
     it 'delegates the call the the client' do
-      client.should_receive(:call).with(:my_call, [:params, []])
+      client.should_receive(:call).with(:my_call, {:params => []})
       MySoapClient.new(routes, double).my_call(params: [])
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: otis
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Thiago Bueno
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-25 00:00:00.000000000 Z
+date: 2014-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler