osdb 0.0.3 → 0.0.4

data/Rakefile

@@ -10,7 +10,7 @@ end
 begin
   require 'echoe'
   
-  Echoe.new('osdb', '0.0.3') do |p|
+  Echoe.new('osdb', '0.0.4') do |p|
     p.description    = "Ruby library to access OSDb services like OpenSubtitles.org"
     p.url            = "http://github.com/byroot/ruby-osdb"
     p.author         = "Jean Boussier"

data/bin/getsub

@@ -85,9 +85,9 @@ end
 def select_sub(subs)
   return subs.first if subs.length == 1
   movies = group_by_movie_name(subs)
-  return movies.values.first.max(&:rating) if movies.length == 1
+  return movies.values.first.max if movies.length == 1
   selected_movie_subs = ask_user_to_identify_movie(movies)
-  selected_movie_subs.max(&:rating)
+  selected_movie_subs.max
 end
 
 movies = ARGV.map{ |path| OSDb::Movie.new(path) }

data/lib/osdb/sub.rb

@@ -10,11 +10,15 @@ module OSDb
       @url = URI.parse(data['SubDownloadLink'])
       @format = data['SubFormat']
       @language = Language.from_iso639_2b(data['SubLanguageID'])
-      @rating = data['SubRating']
+      @rating = data['SubRating'].to_f
       @movie_name = data['MovieName']
       @raw_data = data
     end
     
+    def <=>(other)
+      rating <=> other.rating
+    end
+    
   end
   
 end

data/osdb.gemspec

@@ -2,12 +2,12 @@
 
 Gem::Specification.new do |s|
   s.name = %q{osdb}
-  s.version = "0.0.3"
+  s.version = "0.0.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jean Boussier"]
   s.cert_chain = ["/Users/byroot/.ssh/gem-public_cert.pem"]
-  s.date = %q{2010-10-17}
+  s.date = %q{2010-10-30}
   s.default_executable = %q{getsub}
   s.description = %q{Ruby library to access OSDb services like OpenSubtitles.org}
   s.email = %q{jean.boussier @nospam@ gmail.com}

data/spec/osdb/sub_spec.rb

@@ -2,14 +2,18 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe OSDb::Sub do
   
-  subject do
-    OSDb::Sub.new(
+  before :each do
+    @response = {
       'SubFormat' => 'srt',
       'SubDownloadLink' => 'http://example.com/foo.srt.gz',
-      'SubRating' => 7.89,
+      'SubRating' => '7.89',
       'SubLanguageID' => 'dut',
       'MovieName' => 'Lock, Stock and Two Smoking Barrels'
-    )
+    }
+  end
+  
+  subject do
+    OSDb::Sub.new @response
   end
   
   its(:format) { should == 'srt' }
@@ -22,4 +26,8 @@ describe OSDb::Sub do
   
   its(:movie_name) { should == 'Lock, Stock and Two Smoking Barrels' }
   
+  it 'should be comparable' do
+    [subject, OSDb::Sub.new(@response.merge('SubRating' => '2.45'))].max.should == subject
+  end
+  
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: osdb
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 23
   prerelease: false
   segments: 
   - 0
   - 0
-  - 3
-  version: 0.0.3
+  - 4
+  version: 0.0.4
 platform: ruby
 authors: 
 - Jean Boussier
@@ -36,7 +36,7 @@ cert_chain:
   V/TAGOVlGVotOBnewCUdlw==
   -----END CERTIFICATE-----
 
-date: 2010-10-17 00:00:00 +02:00
+date: 2010-10-30 00:00:00 +02:00
 default_executable: 
 dependencies: []