organ 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8033a1f23ace0b7e8ba5b04ecbf34b842f6bb1bc
-  data.tar.gz: edc103641da1a031b8ffec33070aa49ae88fd13a
+  metadata.gz: bd33328998e87df6ab61e1dc2bd376300c697117
+  data.tar.gz: f5f0a2ae5eb51e58f51272916e3d6fb40e9dbbca
 SHA512:
-  metadata.gz: ce1a123bbb939f0f28efbade808bcefd58a7151fdab8ebbc2588e533d03fb5d3f9c496f2be01a6cd9013ff26286b992b4f60c69d11163e85340bb4e3b8938ab9
-  data.tar.gz: cd965088fc635e7421658cffda80367d80be5d17fc94b64a46e9943e7eb8b14a34386de8c2326df7cfc1973c11f4172c359fb1fe737437ec2b89edd5abdb168d
+  metadata.gz: 8d44b2013528d2fb53af496ab000cbb14cc3d418c30b66a39a9dfb944bcf65c12cb1632b5e5fd8e1fce56d6666b44ff400fe162f9709ccea5424c9f71f6d698a
+  data.tar.gz: c4ae75c498f063defb2cd5baa94a112f23e4f64c04dcaa374f6b65ac25e2730dec0e6c9b6184ac7a1caf15abe240902d534314c952472fe84bcaf7cf0e574000

data/lib/organ.rb

@@ -2,6 +2,6 @@ require_relative "organ/form"
 
 module Organ
 
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 
 end

data/lib/organ/coercer.rb

@@ -1,3 +1,5 @@
+require "date"
+
 module Organ
   module Coercer
 
@@ -124,7 +126,7 @@ module Organ
     #
     # @api semipublic
     def coerce_date(value, options = {})
-      value = coerce(value, String)
+      value = coerce_string(value)
       begin
         Date.strptime(value, "%Y-%m-%d")
       rescue ArgumentError

data/organ.gemspec

@@ -1,20 +1,20 @@
 Gem::Specification.new do |s|
   s.name = "organ"
-  s.version = "0.0.1"
+  s.version = "0.0.2"
   s.summary = "Forms with integrated validations and attribute coercing."
   s.description = "A small library for manipulating form-based data with validations and attributes coercion."
   s.authors = ["Sebastian Borrazas"]
   s.email = ["seba.borrazas@gmail.com"]
   s.homepage = "http://github.com/sborrazas/organ"
+  s.license = "MIT"
 
   s.files = Dir[
     "LICENSE",
-    "CHANGELOG",
     "README.md",
     "Rakefile",
     "lib/**/*.rb",
     "*.gemspec",
-    "test/*.*"
+    "spec/*.*"
   ]
 
   s.require_paths = ["lib"]

data/spec/coercer_spec.rb

@@ -0,0 +1,114 @@
+require_relative "spec_helper"
+
+describe Organ::Coercer do
+  let(:coercer) do
+    Module.new do
+      extend Organ::Coercer
+    end
+  end
+
+  describe "#coerce_string" do
+    describe "when value is truthy" do
+      it "returns a string" do
+        assert_equal("truthy!", coercer.coerce_string("truthy!"))
+      end
+    end
+
+    describe "when value is falsy" do
+      it "returns nil" do
+        assert_nil(coercer.coerce_string(false))
+      end
+    end
+
+    describe "when sending a :trim option to true" do
+      it "returns a string with no trailing spaces" do
+        result = coercer.coerce_string("  \n truthy  ! \n ", :trim => true)
+        assert_equal("truthy !", result)
+      end
+    end
+  end
+
+  describe "#coerce_boolean" do
+    describe "when value is truthy" do
+      it "returns true" do
+        assert_equal(true, coercer.coerce_boolean("truthy"))
+      end
+    end
+
+    describe "when value is falsy" do
+      it "returns false" do
+        assert_equal(false, coercer.coerce_boolean(nil))
+      end
+    end
+  end
+
+  describe "#coerce_array" do
+    describe "when value is an array" do
+      describe "when no :element_type option is given" do
+        it "returns the array" do
+          value = ["1", "2", "3"]
+          assert_equal(value, coercer.coerce_array(value))
+        end
+      end
+
+      describe "when :element_type option is given" do
+        it "coerces the elements inside" do
+          value = ["1", "2", "3"]
+          result = coercer.coerce_array(value, :element_type => :integer)
+          assert_equal([1, 2, 3], result)
+        end
+      end
+    end
+
+    describe "when value is a hash" do
+      it "returns its values" do
+        value = { "1" => 2, "2" => 4 }
+        result = coercer.coerce_array(value)
+        assert_includes(result, 2)
+        assert_includes(result, 4)
+      end
+    end
+
+    describe "when value is not an array or a hash" do
+      it "returns an empty array" do
+        assert_equal([], coercer.coerce_array(nil))
+      end
+    end
+  end
+
+  describe "#coerce_float" do
+    describe "when value doesn't have a float format" do
+      it "returns nil" do
+        assert_nil(coercer.coerce_float("nope"))
+      end
+    end
+
+    describe "when has a float format" do
+      it "returns a float" do
+        values = {
+          ".99" => 0.99,
+          "12.3456" => 12.3456,
+          "5" => 5.0
+        }
+        values.each do |value, expected|
+          assert_equal(expected, coercer.coerce_float(value))
+        end
+      end
+    end
+  end
+
+  describe "#coerce_date" do
+    describe "when value doesn't have a date format" do
+      it "returns nil" do
+        assert_nil(coercer.coerce_date("not a date"))
+      end
+    end
+
+    describe "when value has a date format" do
+      it "returns a date" do
+        assert_equal(Date.civil(2014, 9, 28), coercer.coerce_date("2014-09-28"))
+      end
+    end
+  end
+
+end

data/spec/form_spec.rb

@@ -0,0 +1,122 @@
+require_relative "spec_helper"
+
+describe Organ::Form do
+
+  describe ".attribute" do
+    it "defines an attribute reader" do
+      form_klass = Class.new(Organ::Form) do
+        attribute(:username)
+      end
+      form = form_klass.new(:username => "user")
+
+      assert_equal("user", form.username)
+    end
+
+    describe "if :skip_reader option is true" do
+      it "doesn't define an attribute reader" do
+        form_klass = Class.new(Organ::Form) do
+          attribute(:username, :skip_reader => true)
+        end
+        form = form_klass.new(:username => "user")
+
+        refute(form.respond_to?(:username))
+      end
+    end
+
+    describe "if type is given" do
+      it "coerces the value" do
+        form_klass = Class.new(Organ::Form) do
+          attribute(:username, :type => :fruit)
+
+          def coerce_fruit(value, options = {})
+            "apple"
+          end
+        end
+        form = form_klass.new(:username => "user")
+
+        assert_equal("apple", form.username)
+      end
+    end
+  end
+
+  describe "#set_attributes" do
+    form_klass = Class.new(Organ::Form) do
+      attribute(:username)
+      attribute(:password)
+    end
+
+    it "sets all attributes given" do
+      form = form_klass.new
+      form.set_attributes(:username => "user")
+
+      assert_equal("user", form.username)
+      assert_nil(form.password)
+    end
+  end
+
+  describe "#attributes" do
+    form_klass = Class.new(Organ::Form) do
+      attribute(:username)
+      attribute(:password)
+    end
+
+    it "retrieves all form attributes" do
+      form = form_klass.new(:username => "user")
+      attributes = form.attributes
+
+      assert_equal(2, attributes.size)
+      assert_includes(attributes, :username)
+      assert_includes(attributes, :password)
+    end
+
+  end
+
+  describe "#perform!" do
+    let(:form_klass) do
+      Class.new(Organ::Form) do
+        attribute(:username)
+        attribute(:password)
+
+        def validate
+        end
+
+        def perform
+        end
+      end
+    end
+
+    let(:form) { form_klass.new }
+
+    describe "if no errors during validate or perform" do
+      it "doesn't raise any exceptions" do
+        form.perform!
+        assert(true)
+      end
+    end
+
+    describe "if any errors on validate" do
+      it "raises an error" do
+        def form.validate
+          append_error(:username, :invalid)
+        end
+
+        assert_raises(Organ::ValidationError) do
+          form.perform!
+        end
+      end
+    end
+
+    describe "if any errors on perform" do
+      it "raises an error" do
+        def form.perform
+          append_error(:username, :invalid)
+        end
+
+        assert_raises(Organ::ValidationError) do
+          form.perform!
+        end
+      end
+    end
+
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,3 @@
+require "minitest/spec"
+require "minitest/autorun"
+require "organ"

data/spec/validations_spec.rb

@@ -0,0 +1,161 @@
+require_relative "spec_helper"
+
+describe Organ::Validations do
+  let(:new_errors) { [] }
+  let(:username_value) { nil }
+  let(:validator) do
+    Module.new do
+      extend Organ::Validations
+
+      def self.validate
+      end
+    end
+  end
+
+  before do
+    value = username_value
+    validator.define_singleton_method(:username) { value }
+  end
+
+  describe "#errors" do
+    it "returns an empty hash" do
+      errors = validator.errors
+      assert(errors.empty?)
+    end
+  end
+
+  describe "#valid?" do
+    describe "when no errors added on #validate" do
+      it "is valid" do
+        assert(validator.valid?)
+      end
+    end
+
+    describe "when errors added on #validate" do
+      it "is not valid" do
+        def validator.validate
+          append_error(:username, :invalid)
+        end
+        refute(validator.valid?)
+      end
+    end
+  end
+
+  describe "#append_error" do
+    it "appends an error to the attribute" do
+      validator.append_error(:username, :invalid)
+      assert_equal(1, validator.errors[:username].size)
+    end
+  end
+
+  describe "#validate_presence" do
+    describe "when attribute has nil value" do
+      it "appends an error" do
+        validator.validate_presence(:username)
+        assert_includes(validator.errors[:username], :blank)
+        assert_equal(1, validator.errors[:username].size)
+      end
+    end
+
+    describe "when attribute has empty string value" do
+      let(:username_value) { "" }
+
+      it "appends an error" do
+        validator.validate_presence(:username)
+        assert_includes(validator.errors[:username], :blank)
+        assert_equal(1, validator.errors[:username].size)
+      end
+    end
+  end
+
+  describe "#validate_uniqueness" do
+    describe "when block returns false" do
+      it "appends a :taken error" do
+        validator.validate_uniqueness(:username) { |u| false }
+        assert_includes(validator.errors[:username], :taken)
+        assert_equal(1, validator.errors[:username].size)
+      end
+    end
+  end
+
+  describe "#validate_email_format" do
+    describe "when value is not an email" do
+      let(:username_value) { "not.an@email" }
+
+      it "appends an :invalid error" do
+        validator.validate_email_format(:username)
+        assert_includes(validator.errors[:username], :invalid)
+        assert_equal(1, validator.errors[:username].size)
+      end
+    end
+  end
+
+  describe "#validate_format" do
+    describe "when value does not match the regexp" do
+      let(:username_value) { "ema8l" }
+
+      it "appends an :invalid error" do
+        validator.validate_format(:username, /\A[a-z]+\Z/)
+        assert_includes(validator.errors[:username], :invalid)
+        assert_equal(1, validator.errors[:username].size)
+      end
+    end
+  end
+
+  describe "#validate_length" do
+    describe "when value size is less than the min" do
+      let(:username_value) { "ema8l" }
+
+      it "appends a :too_short error" do
+        validator.validate_length(:username, :min => 8)
+        assert_includes(validator.errors[:username], :too_short)
+        assert_equal(1, validator.errors[:username].size)
+      end
+    end
+
+    describe "when value size is greater than the max" do
+      let(:username_value) { "ema8l" }
+
+      it "appends a :too_long error" do
+        validator.validate_length(:username, :max => 2)
+        assert_includes(validator.errors[:username], :too_long)
+        assert_equal(1, validator.errors[:username].size)
+      end
+    end
+  end
+
+  describe "#validate_inclusion" do
+    describe "when is not included in the list" do
+      let(:username_value) { 1 }
+
+      it "appends a :not_included error" do
+        validator.validate_inclusion(:username, [2, 3])
+        assert_includes(validator.errors[:username], :not_included)
+        assert_equal(1, validator.errors[:username].size)
+      end
+    end
+  end
+
+  describe "#validate_range" do
+    describe "when value is less than the min" do
+      let(:username_value) { 5 }
+
+      it "appends a :less_than error" do
+        validator.validate_range(:username, :min => 8)
+        assert_includes(validator.errors[:username], :less_than)
+        assert_equal(1, validator.errors[:username].size)
+      end
+    end
+
+    describe "when value is greater than the max" do
+      let(:username_value) { 5 }
+
+      it "appends a :greater_than error" do
+        validator.validate_range(:username, :max => 3)
+        assert_includes(validator.errors[:username], :greater_than)
+        assert_equal(1, validator.errors[:username].size)
+      end
+    end
+  end
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: organ
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Sebastian Borrazas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-14 00:00:00.000000000 Z
+date: 2014-09-28 00:00:00.000000000 Z
 dependencies: []
 description: A small library for manipulating form-based data with validations and
   attributes coercion.
@@ -27,8 +27,13 @@ files:
 - lib/organ/validation_error.rb
 - lib/organ/validations.rb
 - organ.gemspec
+- spec/coercer_spec.rb
+- spec/form_spec.rb
+- spec/spec_helper.rb
+- spec/validations_spec.rb
 homepage: http://github.com/sborrazas/organ
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []