order_optimizer 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f25c274ce34a9b081d2ed3430a0b4af3b54e88d026dd1b077feb71ff2b23acb9
-  data.tar.gz: 25156d5709294badef7138c805752c5e57900383a9b8a45ad77a5f9b717a1f04
+  metadata.gz: 5868b03e4f28cfec6001c9e53e61ffba0907c6d626d4ee950596bf4b1f154075
+  data.tar.gz: 739453efda8bcfe9e015f91a47b0cf8945d0c9270fe8f18dc6241a71c5d35e63
 SHA512:
-  metadata.gz: 3f82d09e3a00941e261767fca66212461942c504867426f4e361f74292f03e2caf3770870fdad799e17d4c9d868ebb267382e8616e3a67727c1c68d25cdc544b
-  data.tar.gz: eaea4177612c87687a646a39d4ddf2233109c40cc0ad202e6755f6fd1832b9ac19a89d900d39a81a9079982230ed0bcf4568efc3a342e655e62c2ea9e77589e0
+  metadata.gz: eebd782f5bc6971227292700da42edb7c30a3bca2d19573f65f901311b708aa91fd422ad1ca51a17798d28351e89a020eb1857b7ff7671892874f9e67fbe1429
+  data.tar.gz: d4f80534e745ed6723468c7bf7b49ce5fd5d45fb6db915b756601aa7b00894d10550baeb16bba5da96f4bc24c01e5638ab7ab79ac07ca6eb0bb6576aa4648663

data/.circleci/config.yml

@@ -0,0 +1,63 @@
+version: 2.1
+jobs:
+  test:
+    docker:
+      - image: circleci/ruby:3.0
+
+    working_directory: ~/repo
+
+    steps:
+      - checkout
+
+      - restore_cache:
+          keys:
+            - v1-dependencies-{{ checksum "order_optimizer.gemspec" }}
+            # fallback to using the latest cache if no exact match is found
+            - v1-dependencies-
+
+      - run:
+          name: install dependencies
+          command: bundle install --jobs=4 --retry=3 --path vendor/bundle
+
+      - save_cache:
+          paths:
+            - ./vendor/bundle
+          key: v1-dependencies-{{ checksum "order_optimizer.gemspec" }}
+
+      - run:
+          name: run tests
+          command: bundle exec rake
+
+  publish:
+    docker:
+      - image: circleci/ruby:3.0
+    working_directory: ~/repo
+    steps:
+      - checkout
+      - run:
+          name: Build package
+          command: gem build order_optimizer.gemspec
+      - run:
+          name: Push package
+          command: |
+            VERSION=$(ruby -r "./lib/order_optimizer/version.rb" -e "print OrderOptimizer::VERSION")
+            gem push order_optimizer-${VERSION}.gem
+
+workflows:
+  default:
+    jobs:
+      - test:
+          filters:
+            tags:
+              only: /.*/
+            branches:
+              only: /.*/
+      - publish:
+          context:
+            - rubygems-push
+          requires: [test]
+          filters:
+            tags:
+              only: /^v.*/
+            branches:
+              ignore: /.*/

data/.gitignore

@@ -6,3 +6,4 @@
 /pkg/
 /spec/reports/
 /tmp/
+Gemfile.lock

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # OrderOptimizer Gem Changelog
 
+## 0.4.1 (2021-02-15)
+
+- Fix issue with floating point conversion [#3]
+
 ## 0.4.0 (2020-12-11)
 
 - Add `possible_orders` method to find all possible orders
@@ -18,3 +22,5 @@
 - Add support for discounts when ordering a minimum quantity
 
 ## 0.1.0 First release
+
+[#3]: https://github.com/zaikio/order_optimizer/pull/3

data/README.md

@@ -119,11 +119,22 @@ order_optimizer.possible_orders(required_qty: 10).map(&:skus)
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
-
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/crispymtn/order_optimizer. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at
+https://github.com/zaikio/order_optimizer. This project is intended to be a safe,
+welcoming space for collaboration, and contributors are expected to adhere to the
+[Contributor Covenant](http://contributor-covenant.org) code of conduct.
+
+- Make your changes and submit a pull request for them
+- Make sure to update `CHANGELOG.md`
+
+To release a new version of the gem:
+- Update the version in `lib/order_optimizer/version.rb`
+- Update `CHANGELOG.md` to include the new version and its release date
+- Commit and push your changes
+- Create a [new release on GitHub](https://github.com/zaikio/order_optimizer/releases/new)
+- CircleCI will build the Gem package and push it Rubygems for you
 
 ## License
 
@@ -131,4 +142,4 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the OrderOptimizer project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/crispymtn/order_optimizer/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the OrderOptimizer project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/zaikio/order_optimizer/blob/master/CODE_OF_CONDUCT.md).

data/lib/order_optimizer.rb

@@ -56,7 +56,7 @@ class OrderOptimizer
     count, remainder = quantity.divmod(sku.quantity)
 
     if sku.min_quantity && count * sku.quantity < sku.min_quantity
-      new_count = (sku.min_quantity.to_f / sku.quantity).ceil
+      new_count = (sku.min_quantity / sku.quantity).ceil
       remainder -= (new_count - count) * sku.quantity
       [new_count, [remainder, 0].max]
     else

data/lib/order_optimizer/sku.rb

@@ -4,18 +4,18 @@ class OrderOptimizer
 
     def initialize(id, quantity:, price_per_sku: nil, price_per_unit: nil, min_quantity: nil)
       @id = id
-      @quantity = quantity
-      @min_quantity = min_quantity
-
-      @price_per_unit = BigDecimal(price_per_unit, 2) if price_per_unit
-      @price_per_sku  = BigDecimal(price_per_sku,  2) if price_per_sku
+      @quantity = BigDecimal(quantity, 2)
+      @min_quantity = BigDecimal(min_quantity, 2) if min_quantity
 
       unless price_per_unit || price_per_sku
         raise ':price_per_sku or :price_per_unit must be set'
       end
 
-      @price_per_unit ||= price_per_sku.to_f / quantity
-      @price_per_sku  ||= quantity * price_per_unit
+      @price_per_unit = BigDecimal(price_per_unit, 2) if price_per_unit
+      @price_per_unit ||= BigDecimal(price_per_sku, 2) / quantity
+
+      @price_per_sku = BigDecimal(price_per_sku,  2) if price_per_sku
+      @price_per_sku ||= quantity * price_per_unit
     end
   end
 end

data/lib/order_optimizer/version.rb

@@ -1,3 +1,3 @@
 class OrderOptimizer
-  VERSION = "0.4.0"
+  VERSION = "0.4.1".freeze
 end

data/order_optimizer.gemspec

@@ -7,13 +7,13 @@ Gem::Specification.new do |spec|
   spec.version  = OrderOptimizer::VERSION
 
   spec.authors  = ["crispymtn", "Martin Spickermann", "Maurice Vogel"]
-  spec.email    = ["op@crispymtn.com", "spickermann@gmail.com"]
-  spec.homepage = "https://github.com/crispymtn/order_optimizer"
+  spec.email    = ["op@zaikio.com", "spickermann@gmail.com"]
+  spec.homepage = "https://github.com/zaikio/order_optimizer"
   spec.license  = "MIT"
   spec.summary  = "Helps to optimize orders if the goods are offered in different pack sizes and in different discount levels."
 
 
-  spec.metadata["changelog_uri"] = "https://github.com/crispymtn/order_optimizer/blob/master/CHANGELOG.md"
+  spec.metadata["changelog_uri"] = "https://github.com/zaikio/order_optimizer/blob/master/CHANGELOG.md"
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = spec.homepage
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: order_optimizer
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - crispymtn
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-11 00:00:00.000000000 Z
+date: 2021-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -56,18 +56,18 @@ dependencies:
         version: '0'
 description: 
 email:
-- op@crispymtn.com
+- op@zaikio.com
 - spickermann@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".gitignore"
 - ".travis.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -79,13 +79,13 @@ files:
 - lib/order_optimizer/sku.rb
 - lib/order_optimizer/version.rb
 - order_optimizer.gemspec
-homepage: https://github.com/crispymtn/order_optimizer
+homepage: https://github.com/zaikio/order_optimizer
 licenses:
 - MIT
 metadata:
-  changelog_uri: https://github.com/crispymtn/order_optimizer/blob/master/CHANGELOG.md
-  homepage_uri: https://github.com/crispymtn/order_optimizer
-  source_code_uri: https://github.com/crispymtn/order_optimizer
+  changelog_uri: https://github.com/zaikio/order_optimizer/blob/master/CHANGELOG.md
+  homepage_uri: https://github.com/zaikio/order_optimizer
+  source_code_uri: https://github.com/zaikio/order_optimizer
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -101,7 +101,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.2.3
 signing_key: 
 specification_version: 4
 summary: Helps to optimize orders if the goods are offered in different pack sizes

data/Gemfile.lock

@@ -1,22 +0,0 @@
-PATH
-  remote: .
-  specs:
-    order_optimizer (0.4.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    minitest (5.13.0)
-    rake (13.0.1)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  bundler
-  minitest
-  order_optimizer!
-  rake
-
-BUNDLED WITH
-   2.1.4