order_optimizer 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f7582fc4c48f45ba73759ff312cc21a0bfe7731a5b109eafcb313c2c0930d435
-  data.tar.gz: b10e675e41325916aede4dae3cbbc2f3dddc075bd0f0164daa5f61948c813c9c
+  metadata.gz: f25c274ce34a9b081d2ed3430a0b4af3b54e88d026dd1b077feb71ff2b23acb9
+  data.tar.gz: 25156d5709294badef7138c805752c5e57900383a9b8a45ad77a5f9b717a1f04
 SHA512:
-  metadata.gz: 3b92cd98cbb49a93f5dd152673fca3e44d8ff531a6eae3fd87e1bd44c0bfeaebc02e580c69694da21069450dfae897a0ed641e2fe217b18a93a3d1ead28c4efd
-  data.tar.gz: 1bb4af7ddd21d6bb5ddf22b18ed0b0e099609de555c3350837a84478b516a1f43adf2c0a58e818ca17abd443ce254dc862596661d77f8b5d46937d8f9f5b1a05
+  metadata.gz: 3f82d09e3a00941e261767fca66212461942c504867426f4e361f74292f03e2caf3770870fdad799e17d4c9d868ebb267382e8616e3a67727c1c68d25cdc544b
+  data.tar.gz: eaea4177612c87687a646a39d4ddf2233109c40cc0ad202e6755f6fd1832b9ac19a89d900d39a81a9079982230ed0bcf4568efc3a342e655e62c2ea9e77589e0

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # OrderOptimizer Gem Changelog
 
+## 0.4.0 (2020-12-11)
+
+- Add `possible_orders` method to find all possible orders
+- Fix issues with zero remainders on calculations
+
 ## 0.3.0 (2020-11-23)
 
 - Add `cheapest_exact_order` method to optimize an order with an exact amount

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    order_optimizer (0.3.0)
+    order_optimizer (0.4.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -100,6 +100,21 @@ order_optimizer.cheapest_order(required_qty: 29).skus
 #=> { '20-pack' => 1, '10-discount' => 10 }
 ```
 
+If you're just interested in all possible order combinations:
+
+```ruby
+# Initialize the optimize with a catalog
+order_optimizer = OrderOptimizer.new(
+  '1-pack' => { quantity: 1, price_per_unit: 9 },
+  '10-pack' => { quantity: 10, price_per_unit: 5 },
+)
+
+order_optimizer.possible_orders(required_qty: 11).size
+#=> 3
+order_optimizer.possible_orders(required_qty: 10).map(&:skus)
+#=> [{"10-pack"=>1, "1-pack"=>1}, {"1-pack"=>11}, {"10-pack"=>2}]
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/order_optimizer.rb

@@ -10,18 +10,22 @@ class OrderOptimizer
   end
 
   def cheapest_order(required_qty:)
-    possible_orders(skus: @catalog.skus, required_qty: required_qty).min_by(&:total) ||
+    find_possible_orders(skus: @catalog.skus, required_qty: required_qty).min_by(&:total) ||
       OrderOptimizer::Order.new(required_qty: required_qty)
   end
 
   def cheapest_exact_order(required_qty:)
-    possible_orders(skus: @catalog.skus, required_qty: required_qty).select(&:exact?).min_by(&:total) ||
+    find_possible_orders(skus: @catalog.skus, required_qty: required_qty).select(&:exact?).min_by(&:total) ||
       OrderOptimizer::Order.new(required_qty: required_qty)
   end
 
+  def possible_orders(required_qty:)
+    find_possible_orders(skus: @catalog.skus, required_qty: required_qty).sort_by(&:total)
+  end
+
   private
 
-  def possible_orders(required_qty:, skus:)
+  def find_possible_orders(required_qty:, skus:)
     return [] if required_qty < 1 || skus.empty?
 
     orders = []
@@ -31,7 +35,7 @@ class OrderOptimizer
         count, remainder = count_and_remainder_for_sku(order.missing_qty, sku)
 
         orders << order.dup.add(sku, count: count) unless count.zero?
-        orders << order.dup.add(sku, count: count + 1) if remainder
+        orders << order.dup.add(sku, count: count + 1) unless remainder.zero?
       end
 
       count, remainder = count_and_remainder_for_sku(required_qty, sku)
@@ -40,7 +44,7 @@ class OrderOptimizer
         orders << OrderOptimizer::Order.new(required_qty: required_qty).add(sku, count: count)
       end
 
-      if remainder
+      unless remainder.zero?
         orders << OrderOptimizer::Order.new(required_qty: required_qty).add(sku, count: count + 1)
       end
     end

data/lib/order_optimizer/version.rb

@@ -1,3 +1,3 @@
 class OrderOptimizer
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: order_optimizer
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - crispymtn
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-23 00:00:00.000000000 Z
+date: 2020-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler