orcid_client 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 14d5bdcfdd4434694f41ed0f1790983ea3c93eb9
-  data.tar.gz: e8226e9332e5daf02f8d70df610a0060e306bd2b
+  metadata.gz: eeaf7b53eebf7c7877d24e9fc458a7a6a307032d
+  data.tar.gz: 65e9b253be1606b55d93d8eabddf834a2a10ef7a
 SHA512:
-  metadata.gz: be30a372d8ef68ebf6c77c192e64b4681016e42d7a3fe9461d218d7baaf00be0d3200eb46dc02e6e29e8d416ef2115b24b68a1b47661f3efcc29c64fdabe11ae
-  data.tar.gz: c91d735ed1c063e3b717d421f1bfaf2613d19b10f548fea60f783ed2e6e0f46f806aba0ff586cb273b8914f4a388397d5acbc0afc72dd1f8fbe5aec9d69a34c7
+  metadata.gz: 996e7dcb216b8568c2823c7fdbd11abcc84bba831b46e34e0040b79f38d923f0f921a2313c6f478abdfda8f3c533b34d869766482d9b225cfd8a36edce31b80c
+  data.tar.gz: 87d4e73f8a67f2a670f5d9b4d1757480c2a1a8a2236b29636c7e3cf62f39b1c57cf03779c38728d4640ff5803bf6940875e9a947e79d780e5d15b35ffe1e6abb

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    orcid_client (0.2.2)
+    orcid_client (0.2.3)
       activesupport (~> 4.2, >= 4.2.5)
       builder (~> 3.2, >= 3.2.2)
       dotenv (~> 2.1, >= 2.1.1)
@@ -113,4 +113,4 @@ DEPENDENCIES
   webmock (~> 1.22, >= 1.22.3)
 
 BUNDLED WITH
-   1.14.3
+   1.12.5

data/lib/orcid_client/author.rb

@@ -2,6 +2,11 @@ require 'namae'
 
 module OrcidClient
   module Author
+    def validate_orcid(orcid)
+      orcid = Array(/\A(?:http:\/\/orcid\.org\/)?(\d{4}[[:space:]-]\d{4}[[:space:]-]\d{4}[[:space:]-]\d{3}[0-9X]+)\z/.match(orcid)).last
+      orcid.gsub(/[[:space:]]/, "-") if orcid.present?
+    end
+
     # parse author string into CSL format
     def get_one_author(author)
       return "" if author.blank?
@@ -38,7 +43,7 @@ module OrcidClient
     def get_name_identifier(author)
       name_identifier = author.fetch("nameIdentifier", nil)
       name_identifier_scheme = author.fetch("nameIdentifierScheme", "orcid").downcase
-      if name_identifier.present? && name_identifier_scheme == "orcid"
+      if name_identifier_scheme == "orcid" && name_identifier = validate_orcid(name_identifier)
         "http://orcid.org/#{name_identifier}"
       else
         nil

data/lib/orcid_client/version.rb

@@ -1,3 +1,3 @@
 module OrcidClient
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/lib/orcid_client/work.rb

@@ -101,7 +101,7 @@ module OrcidClient
     def insert_titles(xml)
       if title
         xml.send(:'work:title') do
-          xml.send(:'common:title', title)
+          xml.send(:'common:title', title.truncate(1000, separator: ' '))
         end
       end
 

data/spec/author_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe OrcidClient, vcr: true do
+  let(:doi) { "10.5281/zenodo.59983"}
+  let(:orcid) { "0000-0001-6528-2027" }
+  let(:access_token) { ENV['ACCESS_TOKEN'] }
+  let(:notification_access_token) { ENV['NOTIFICATION_ACCESS_TOKEN'] }
+  let(:put_code) { "740616" }
+  let(:fixture_path) { "spec/fixtures/" }
+
+  subject { OrcidClient::Work.new(doi: doi, orcid: orcid, access_token: access_token, put_code: put_code) }
+
+  context "validate_orcid" do
+    it "validate_orcid" do
+      orcid = "http://orcid.org/0000-0002-2590-225X"
+      response = subject.validate_orcid(orcid)
+      expect(response).to eq("0000-0002-2590-225X")
+    end
+
+    it "validate_orcid id" do
+      orcid = "0000-0002-2590-225X"
+      response = subject.validate_orcid(orcid)
+      expect(response).to eq("0000-0002-2590-225X")
+    end
+
+    it "validate_orcid with spaces" do
+      orcid = "0000 0002 1394 3097"
+      response = subject.validate_orcid(orcid)
+      expect(response).to eq("0000-0002-1394-3097")
+    end
+
+    it "validate_orcid wrong id" do
+      orcid = "0000-0002-1394-309"
+      response = subject.validate_orcid(orcid)
+      expect(response).to be_nil
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: orcid_client
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Martin Fenner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-02 00:00:00.000000000 Z
+date: 2017-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: maremma
@@ -343,6 +343,7 @@ files:
 - resources/record_2.0_rc3/search-2.0_rc3.xsd
 - resources/record_2.0_rc3/work-2.0_rc3.xsd
 - spec/api_spec.rb
+- spec/author_spec.rb
 - spec/external_identifier_spec.rb
 - spec/fixtures/external_identifier.xml
 - spec/fixtures/vcr_cassettes/OrcidClient/external_identifier/delete/should_delete_external_identifier.yml