orcid_client 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 262b026a4b9e0dd390c03f459556f81c7ef2de0a
-  data.tar.gz: 3760397b16157de4abe9ebb05ab4fdfb2c041615
+  metadata.gz: b8243d6eef5bb1d6dfbd86ed6da784a1c78459bc
+  data.tar.gz: 7e39fd99bbef5b60b5d6dfe2b29b071d67626e3a
 SHA512:
-  metadata.gz: 308b88a81d942f42450874db098f850bb9e5fde6140100ba6f9ede0363201521c114249e6495ea6fcc707cca0b669fe1d5a8a04ef43ddbc823f654c97ae0d5cc
-  data.tar.gz: 7a45a1b143a1865108d3a12900d46e5f634cc20f7c3424b2a1dfa0079730757cf711345527c017c55b407547d7a859d9348a9f906d029a1004c7ca4e94368a57
+  metadata.gz: 7dfe0f42fca7d00cb329983e90ddedd69d7de3d9d43363a45959e611f039b0327cf9a404a2c2236e64c14f1be3d79d193fa77356fe0b4aaf16f3ca33e1bc92c1
+  data.tar.gz: 1e81e0e9482e93838514e03ed222e6d58137ba3ab1a1b7dd32fb126b35c0ce8688cf5328ce47331fa61fb6ca2886588847fd223f13af9c5d804fcbc94f41bfb2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    orcid_client (0.1.7)
+    orcid_client (0.1.8)
       activesupport (~> 4.2, >= 4.2.5)
       builder (~> 3.2, >= 3.2.2)
       dotenv (~> 2.1, >= 2.1.1)

data/lib/orcid_client/api.rb

@@ -5,8 +5,7 @@ module OrcidClient
     API_VERSION = "2.0_rc3"
 
     def get_works(options={})
-      response = OpenStruct.new(body: {})
-      return { response.body["errors"] => [{ "title" => "Access token missing" }] } unless access_token.present?
+      return OpenStruct.new(body: { "errors" => [{ "title" => "Access token missing" }] }) unless access_token.present?
 
       orcid_api_url = options[:sandbox] ? 'https://api.sandbox.orcid.org' : 'https://api.orcid.org'
 
@@ -15,8 +14,7 @@ module OrcidClient
     end
 
     def create_work(options={})
-      response = OpenStruct.new(body: {})
-      return { response.body["errors"] => [{ "title" => "Access token missing" }] } unless access_token.present?
+      return OpenStruct.new(body: { "errors" => [{ "title" => "Access token missing" }] }) unless access_token.present?
 
       orcid_api_url = options[:sandbox] ? 'https://api.sandbox.orcid.org' : 'https://api.orcid.org'
 
@@ -28,9 +26,8 @@ module OrcidClient
     end
 
     def update_work(options={})
-      response = OpenStruct.new(body: {})
-      return { response.body["errors"] => [{ "title" => "Access token missing" }] } unless access_token.present?
-      return { response.body["errors"] => [{ "title" => "Put code missing" }] } unless put_code.present?
+      return OpenStruct.new(body: { "errors" => [{ "title" => "Access token missing" }] }) unless access_token.present?
+      return OpenStruct.new(body: { "errors" => [{ "title" => "Put code missing" }] }) unless put_code.present?
 
       orcid_api_url = options[:sandbox] ? 'https://api.sandbox.orcid.org' : 'https://api.orcid.org'
 
@@ -42,9 +39,8 @@ module OrcidClient
     end
 
     def delete_work(options={})
-      response = OpenStruct.new(body: {})
-      return { response.body["errors"] => [{ "title" => "Access token missing" }] } unless access_token.present?
-      return { response.body["errors"] => [{ "title" => "Put code missing" }] } unless put_code.present?
+      return OpenStruct.new(body: { "errors" => [{ "title" => "Access token missing" }] }) unless access_token.present?
+      return OpenStruct.new(body: { "errors" => [{ "title" => "Put code missing" }] }) unless put_code.present?
 
       orcid_api_url = options[:sandbox] ? 'https://api.sandbox.orcid.org' : 'https://api.orcid.org'
 
@@ -66,8 +62,7 @@ module OrcidClient
     end
 
     def create_notification(options={})
-      response = OpenStruct.new(body: {})
-      return { response.body["errors"] => [{ "title" => "Notification access token missing" }] } unless notification_access_token.present?
+      return OpenStruct.new(body: { "errors" => [{ "title" => "Notification access token missing" }] }) unless notification_access_token.present?
 
       orcid_api_url = options[:sandbox] ? 'https://api.sandbox.orcid.org' : 'https://api.orcid.org'
 
@@ -79,9 +74,8 @@ module OrcidClient
     end
 
     def delete_notification(options={})
-      response = OpenStruct.new(body: {})
-      return { response.body["errors"] => [{ "title" => "Notification access token missing" }] } unless notification_access_token.present?
-      return { response.body["errors"] => [{ "title" => "Put code missing" }] } unless put_code.present?
+      return OpenStruct.new(body: { "errors" => [{ "title" => "Notification access token missing" }] }) unless notification_access_token.present?
+      return OpenStruct.new(body: { "errors" => [{ "title" => "Put code missing" }] }) unless put_code.present?
 
       orcid_api_url = options[:sandbox] ? 'https://api.sandbox.orcid.org' : 'https://api.orcid.org'
 
@@ -91,8 +85,8 @@ module OrcidClient
 
     def get_notification(options={})
       response = OpenStruct.new(body: {})
-      return { response.body["errors"] => [{ "title" => "Notification access token missing" }] } unless notification_access_token.present?
-      return { response.body["errors"] => [{ "title" => "Put code missing" }] } unless put_code.present?
+      return OpenStruct.new(body: { "errors" => [{ "title" => "Notification access token missing" }] }) unless notification_access_token.present?
+      return OpenStruct.new(body: { "errors" => [{ "title" => "Put code missing" }] }) unless put_code.present?
 
       orcid_api_url = options[:sandbox] ? 'https://api.sandbox.orcid.org' : 'https://api.orcid.org'
 

data/lib/orcid_client/version.rb

@@ -1,3 +1,3 @@
 module OrcidClient
-  VERSION = "0.1.7"
+  VERSION = "0.1.8"
 end

data/spec/api_spec.rb

@@ -19,6 +19,12 @@ describe OrcidClient, vcr: true do
         expect(response.body["put_code"]).not_to be_blank
         expect(response.status).to eq(201)
       end
+
+      it 'access_token missing' do
+        subject = OrcidClient::Work.new(doi: doi, orcid: orcid, access_token: nil)
+        response = subject.create_work(sandbox: true)
+        expect(response.body).to eq("errors"=>[{"title"=>"Access token missing"}])
+      end
     end
 
     describe 'get' do
@@ -29,6 +35,12 @@ describe OrcidClient, vcr: true do
         work = works.first
         expect(work["external-ids"]).to eq("external-id"=>[{"external-id-type"=>"doi", "external-id-value"=>"10.5167/UZH-19531", "external-id-url"=>nil, "external-id-relationship"=>"SELF"}])
       end
+
+      it 'access_token missing' do
+        subject = OrcidClient::Work.new(doi: doi, orcid: orcid, access_token: nil)
+        response = subject.get_works(sandbox: true)
+        expect(response.body).to eq("errors"=>[{"title"=>"Access token missing"}])
+      end
     end
 
     describe 'put' do
@@ -37,6 +49,12 @@ describe OrcidClient, vcr: true do
         expect(response.body.fetch("data", {}).fetch("work", {}).fetch("put_code", nil)).to eq(put_code)
         expect(response.status).to eq(200)
       end
+
+      it 'access_token missing' do
+        subject = OrcidClient::Work.new(doi: doi, orcid: orcid, access_token: nil)
+        response = subject.update_work(sandbox: true)
+        expect(response.body).to eq("errors"=>[{"title"=>"Access token missing"}])
+      end
     end
 
     describe 'delete' do
@@ -46,6 +64,12 @@ describe OrcidClient, vcr: true do
         expect(response.body["errors"]).to be_nil
         expect(response.status).to eq(204)
       end
+
+      it 'access_token missing' do
+        subject = OrcidClient::Work.new(doi: doi, orcid: orcid, access_token: nil)
+        response = subject.delete_work(sandbox: true)
+        expect(response.body).to eq("errors"=>[{"title"=>"Access token missing"}])
+      end
     end
   end
 
@@ -60,6 +84,12 @@ describe OrcidClient, vcr: true do
         expect(response.body["put_code"]).not_to be_blank
         expect(response.status).to eq(201)
       end
+
+      it 'access_token missing' do
+        subject = OrcidClient::Notification.new(doi: doi, orcid: orcid, notification_access_token: nil)
+        response = subject.create_notification(sandbox: true)
+        expect(response.body).to eq("errors"=>[{"title"=>"Notification access token missing"}])
+      end
     end
 
     describe 'get' do
@@ -70,6 +100,12 @@ describe OrcidClient, vcr: true do
         expect(notification["items"]["item"]).to eq("item_type"=>"work", "item_name"=>"omniauth-orcid: v.1.1.5", "external_id"=>{"external_id_type"=>"DOI", "external_id_value"=>"10.5281/zenodo.59983"})
         expect(response.status).to eq(200)
       end
+
+      it 'access_token missing' do
+        subject = OrcidClient::Notification.new(doi: doi, orcid: orcid, notification_access_token: nil)
+        response = subject.get_notification(sandbox: true)
+        expect(response.body).to eq("errors"=>[{"title"=>"Notification access token missing"}])
+      end
     end
 
     describe 'delete' do
@@ -80,6 +116,12 @@ describe OrcidClient, vcr: true do
         expect(notification["items"]["item"]).to eq("item_type"=>"work", "item_name"=>"omniauth-orcid: v.1.1.5", "external_id"=>{"external_id_type"=>"DOI", "external_id_value"=>"10.5281/zenodo.59983"})
         expect(response.status).to eq(200)
       end
+
+      it 'access_token missing' do
+        subject = OrcidClient::Notification.new(doi: doi, orcid: orcid, notification_access_token: nil)
+        response = subject.delete_notification(sandbox: true)
+        expect(response.body).to eq("errors"=>[{"title"=>"Notification access token missing"}])
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: orcid_client
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Martin Fenner