orcid 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3e40e9249310d879d3d682f31e4ff96c8ddebd5c
-  data.tar.gz: c576d7845d3739142beecfdc6f828255129a9efb
+  metadata.gz: 72fe44a31b834e45dc65efebc06f416ec6452908
+  data.tar.gz: 93a589d4b5992b70e1ca685f1b50b37b9695efe6
 SHA512:
-  metadata.gz: cde6825fe3b611118f56bfc83195794bba75763d57f5d97c2c7f254c0e792db97cd1d6384a1b3c79a61e77a0718df64bde9ddb2e72ddde4d56b1bd2eaa0881c6
-  data.tar.gz: 585614520c7665086f36831ac18dd219693d02ae066bdf5b93e8f397780999503e90c4493eaaa20078ec762959ae8ce7bbebd2613f0c56e25b859d9a360c1a95
+  metadata.gz: c8ce12e869d4935a7e7c563a2b760630a42b8139d3f1fbe8c0d73a66b05d00b4b8be6a7ad1ee97b6baf8744be2606bd39cadf00b7d33c63155c0be9ef77935be
+  data.tar.gz: 04a0d325084d3023aefc595abefe659ce126e57a81aae12d62949c308eec60a00c02bedbee72ccc9e7077795c1084f21ea9a0360adaf0767007ea5892efb6fdb

data/README.md

@@ -60,6 +60,8 @@ if defined?(Orcid)
 end
 ```
 
+**To customize the labels, review the `./config/locales/orcid.en.yml` file.**
+
 ## Registering for an ORCID application profile
 
 Your application which will interface with ORCID must be registered with ORCID.  Note that you will want to register your production

data/app/models/orcid/profile_connection.rb

@@ -4,6 +4,7 @@ module Orcid
   class ProfileConnection
     include Virtus.model
     include ActiveModel::Validations
+    include ActiveModel::Conversion
     extend ActiveModel::Naming
 
     class_attribute :available_query_attribute_names

data/app/views/orcid/profile_connections/_orcid_connector.html.erb

@@ -1,14 +1,22 @@
 <% profile_connection = Orcid::ProfileConnection.new %>
-<p><br />
-<%= link_to "Look up your existing ORCID", orcid.new_profile_connection_path(profile_connection:{text: default_search_text}) %>
-  <span>-OR-</span>
-<%= link_to "Create an ORCID", orcid.new_profile_request_path %>
-</p>
-<p>-OR-</p>
-<%= simple_form_for(profile_connection, as: :profile_connection, url: orcid.profile_connections_path, method: :post) do |f| %>
-    <%= f.input :orcid_profile_id, label: "Enter your existing ORCID (####-####-####-####)", class:"orcid-input" %>
+<% default_search_text = '' unless defined?(default_search_text) %>
+<div class='orcid-connector'>
+  <h3><i class="icon-user"></i> <%= link_to t('orcid.verbose_name'), 'http://orcid.org/' %></h3>
+  <p>
+    <%= link_to t('orcid/profile_connection.look_up_your_existing_orcid', scope: 'helpers.label'), orcid.new_profile_connection_path(profile_connection:{text: default_search_text}) %>
+  </p>
+  <p>
+    <%= link_to t('orcid/profile_connection.create_an_orcid', scope: 'helpers.label'), orcid.new_profile_request_path %>
+  </p>
+  <p>
+  <%= form_for(profile_connection, as: :profile_connection, url: orcid.profile_connections_path, method: :post) do |f| %>
+    <%# Note the `scope: 'helpers.label'` option is the default for the label, but I want to call those specifically out %>
+    <%= f.label :orcid_profile_id, value: t('orcid/profile_connection.connect_button_text', scope: 'helpers.label') %>
+    <%= f.text_field :orcid_profile_id, class:"orcid-input" %>
     <button type="submit" class="search-submit btn btn-primary" id="keyword-search-submit" tabindex="2">
-      <span class="orcid-connect">Connect</span>
+      <span class="orcid-connect"><%= t('orcid/profile_connection.connect_button_text', scope: 'helpers.label') %></span>
     </button>
-<% end %>
+  <% end %>
+  </p>
+</div>
 

data/config/locales/orcid.en.yml

@@ -29,4 +29,12 @@ en:
     connections:
       messages:
         profile_connection_not_found: "Unable to find an existing Orcid Profile connection."
-        verified_profile_connection_exists: "You have already connected and verified your Orcid Profile (%{orcid_profile_id})."
+        verified_profile_connection_exists: "You have already connected and verified your Orcid Profile (%{orcid_profile_id})."
+    verbose_name: Open Researcher and Contributor ID (ORCID)'
+  helpers:
+    label:
+      orcid/profile_connection:
+        orcid_profile_id: "Enter your existing ORCID (####-####-####-####)"
+        create_an_orcid: Create an ORCID
+        look_up_your_existing_orcid: Look up your existing ORCID
+        connect_button_text: Connect

data/lib/orcid/version.rb

@@ -1,3 +1,3 @@
 module Orcid
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/orcid.gemspec

@@ -34,7 +34,6 @@ Gem::Specification.new do |s|
   s.add_dependency 'virtus'
   s.add_dependency 'email_validator'
   s.add_dependency 'simple_form'
-  s.add_dependency 'byebug'
 
   s.add_development_dependency 'sqlite3'
   s.add_development_dependency 'engine_cart'

data/spec/models/orcid/profile_connection_spec.rb

@@ -13,6 +13,7 @@ module Orcid
     }
 
     its(:email) { should eq email }
+    its(:to_model) { should eq subject }
     its(:user) { should eq user }
     its(:persisted?) { should eq false }
     its(:orcid_profile_id) { should be_nil }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: orcid
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Jeremy Friesen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-06 00:00:00.000000000 Z
+date: 2014-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -122,20 +122,6 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement