optify-config 1.4.0-arm64-darwin → 1.4.1-arm64-darwin

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8018ef50ae10f20a6697b078f476cab8cbc3b16e732c835ef0d61977758bbcfd
-  data.tar.gz: d7c3016a5391eb23f9b268d39ddc3672594d0bb9b92df41c4107151c3ef03289
+  metadata.gz: d5323df292e4343c8e96adefab27f4c86fb02144af156f9c68c9d121365186c5
+  data.tar.gz: ab4346606d0624c868cb9bb980f25567f99a0961651b715620b16915ac3b857d
 SHA512:
-  metadata.gz: 25a57e9395f136e20ecded59060653511a622264e49234b6b977368508e6edd7614b3b18cff85c070912b6c1f4867ccc8af2de6b1a9a7feed72a0dcb1709916d
-  data.tar.gz: fd5503dcd1cada4c68bb9263c7214793f58364b6509a0fac8416ca86dc58845e105c2f5ececd14029436607a4feb1bdf8022795ee3c602e60c41adad16ae9ee9
+  metadata.gz: f660032bbb46c1ec49b9eca62cb7f7b07b213c4050c8794bc7b6d493418c281038c7acc2e0ca2bde8de59fbb7b67961c8d39df8f7e64104b80b972dc38a445a0
+  data.tar.gz: 1230db10484560654152e9bfe0bdc41dd0f2d33e8728b23f5998a607ef625a3c7eff6adecb80268261d6e2aca84cbf869a881e706387b921f44490486c58bfe1

data/lib/optify_ruby/provider_module.rb

@@ -11,7 +11,7 @@ module Optify
     #: (Array[String] feature_names) -> Array[String]
     def get_canonical_feature_names(feature_names)
       # Try to optimize a typical case where there are just a few features.
-      # Ideally in production, a single feature that imports many other features is used for the most common scenario.
+      # Ideally in production, a single feature that imports many other features is used for the most common scenarios.
       # Benchmarks show that it is faster to use a loop than to call the Rust implementation which involves making a `Vec<String>` and returning a `Vec<String>`.
       if feature_names.length < 4
         feature_names.map { |feature_name| get_canonical_feature_name(feature_name) }
@@ -93,19 +93,25 @@ module Optify
       end
 
       init unless @cache
-      unless preferences&.skip_feature_name_conversion
-        # When there are just a few names, then it can be faster to convert them one by one in a loop to avoid working with an array in Rust.
-        # When there are over 7 names, then it is faster to convert them with one call to Rust.
-        feature_names = get_canonical_feature_names(feature_names)
-      end
+      feature_names = get_canonical_feature_names(feature_names) unless preferences&.skip_feature_name_conversion
 
       cache_key = [key, feature_names, config_class]
       result = @cache&.fetch(cache_key, NOT_FOUND_IN_CACHE_SENTINEL)
       return result unless result.equal?(NOT_FOUND_IN_CACHE_SENTINEL)
 
-      # TODO: Copy the preferences to avoid mutating the original object.
-      preferences ||= GetOptionsPreferences.new
-      preferences.skip_feature_name_conversion = true
+      # Handle a cache miss.
+
+      # We can avoid converting the features names because they're already converted, if that was desired.
+      if preferences.nil?
+        preferences = GetOptionsPreferences.new
+        preferences.skip_feature_name_conversion = true
+      else
+        # Indeed the copying of preferences could be wasteful, but this only happens on a cache miss
+        # and when no custom preferences are provided.
+        preferences = preferences.dup
+        preferences.skip_feature_name_conversion = true
+      end
+
       result = get_options(key, feature_names, config_class, nil, preferences)
 
       T.must(@cache)[cache_key] = result

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: optify-config
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: arm64-darwin
 authors:
 - Justin D. Harris
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2025-05-09 00:00:00.000000000 Z
+date: 2025-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sorbet-runtime
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.11911
+        version: 0.5.12083
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.11911
+        version: 0.5.12083
 - !ruby/object:Gem::Dependency
   name: rake-compiler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.9
+        version: 1.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.9
+        version: 1.3.0
 - !ruby/object:Gem::Dependency
   name: rbs
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.9.2
+        version: 3.9.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.9.2
+        version: 3.9.3
 - !ruby/object:Gem::Dependency
   name: sorbet
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.11911
+        version: 0.5.12083
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.11911
+        version: 0.5.12083
 - !ruby/object:Gem::Dependency
   name: tapioca
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.6.7
+        version: 3.6.8
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.6.7
+        version: 3.6.8
 description: |-
   Simplifies getting the right configuration options for a process using pre-loaded configurations
     from files to manage options for experiments or flights.