optics-agent 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 75440b51ee6807fa478559568ca0fc7934e38c5f
-  data.tar.gz: 6c7302b7b48ff60c89f92602663b680502318af0
+  metadata.gz: baf3d71a589fb44d4c5334e9536b40bf102776be
+  data.tar.gz: 5d2c8f79f113afb70a170d4464b577b83db45c9a
 SHA512:
-  metadata.gz: d201e91158930766f7efd34210b9af68d4575c658672209363dc8614746577256a66da8e854f5b314b376988f72f65070aa9e898e93dc0e58b4485858d4ba728
-  data.tar.gz: 2593d4184b7766bd232f0d950a004ab70b8556af248c2bda482c1eb7e268b20b9f307c0bcc07dd61192b43821df57d492df24e6258e3d0bbf79f299769940696
+  metadata.gz: c55989f7e56a1f233ca326e848e3869666714a2b0a892adb11c96d985e5331159fa69b23a27aa58332bf2ae155697a6f1b45bf613aad8a7511aa5fd0dcf594d0
+  data.tar.gz: 877b3599a864ddb80e66df0f2c9b95578ececf581dc87136fb8db819f90beb4a4e2b2ea6b9a2c36272f18c7159006c8bf7db2e3bbd6dc67d9c51f87c2512bacc

data/lib/optics-agent/agent.rb

@@ -56,8 +56,15 @@ module OpticsAgent
           debug "running schema job"
           SchemaJob.new.perform(self)
         end
+      end
+    end
 
+    # we call this method on every request to ensure that the reporting thread
+    # is active in the correct process for pre-forking webservers like unicorn
+    def ensure_reporting!
+      unless @reporting_thread_active
         schedule_report
+        @reporting_thread_active = true
       end
     end
 

data/lib/optics-agent/rack-middleware.rb

@@ -12,6 +12,7 @@ module OpticsAgent
 
       # XXX: figure out a way to pass this in here
       agent = OpticsAgent::Agent.instance
+      agent.ensure_reporting!
       agent.debug { "rack-middleware: request started" }
       query = OpticsAgent::Reporting::Query.new
 

data/spec/benchmark/benchmark.rb

@@ -1,3 +1,5 @@
+# Run with ruby -Ilib spec/benchmark/benchmark.rb
+
 require 'benchmark'
 require 'graphql'
 require 'optics-agent'
@@ -7,25 +9,36 @@ require_relative '../support/create_starwars_schema.rb';
 basic_schema = create_starwars_schema
 
 agent = OpticsAgent::Agent.instance
+agent.set_options(disable_reporting: true)
 instrumented_schema = create_starwars_schema
 agent.instrument_schema(instrumented_schema)
 
 # just drop reports on the floor
-null_reporter = {}
-null_reporter.define_singleton_method :report_field, lambda { |x,y,z,w| }
+class BenchmarkRackAgent
+  class Query
+    def report_field(x,y,z,w)
+    end
+  end
+
+  attr_reader :query
+  def initialize
+    @query = Query.new
+  end
+end
+rack_agent = BenchmarkRackAgent.new
 
 query_string = GraphQL::Introspection::INTROSPECTION_QUERY
 
-Benchmark.bm(7) do |x|
+Benchmark.bmbm(4) do |x|
   x.report("No agent") do
-    20.times do
+    1000.times do
       basic_schema.execute(query_string)
     end
   end
   x.report("With agent") do
-    20.times do
+    1000.times do
       instrumented_schema.execute(query_string, context: {
-        optics_agent: { query: null_reporter }
+        optics_agent: rack_agent
       })
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: optics-agent
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - 'Tom Coleman '