optics-agent 0.1.2 → 0.1.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YmZmOWU0ZjllNzk5YzI5ZDU4ZGQ3ZjQ2ZmQzNGQxYTE1OWYyMDFiYw==
+    YjIwMWU1NjYxNGYzNzhhMzk1Y2IwODMxZTE1NjZkYjUwNTY1NTQ5YQ==
   data.tar.gz: !binary |-
-    MzkyZTYyNDJlZjZlNmYwZTk4ODIyMGQyZjk0ZGRjNjE0MzdlZDllMg==
+    MTNkMjcxMjAyNWJlY2E1OTc4NTVkY2NmMTZjMGZiODdkNDg4ZTFkMA==
 SHA512:
   metadata.gz: !binary |-
-    MjZlNTA4NTZjMTRmMDAxMmUzOTgyNGE5YWJlOTM1YjdiNTlmNmZjMTA3MmYw
-    NTAyZWI5OTRjMGMwYThlM2JkY2JhNzE0NmRiODQ4MjQ3ZTUzNDA0Yzc2NDU4
-    Y2VmOGRjYWQyOGNiM2YxZTQ4OTVkM2JjMWE2ZGYxNzRiZDExMDE=
+    OTRkYTZlZDlhMDNmMjQ5OGU5MTliNDVkNWRhYzUzMjIzMDMwNTNjYjQ4NTg2
+    OTNkOWRmOWM1YmE2YWViNzE2MGExZDliNzQwZjcxZjFkYmNmNjA2MGM5OWMz
+    ZjhmOGFmODM2MWFjMDM5Njc3OTU2YzFmMDgyN2FiYmUwMmVmYWI=
   data.tar.gz: !binary |-
-    MmI1NjhiNzI4YTNiOGJkMmY2NGY5ZTYwMTExMmFlMDA1YTAyNWRhMzllYWVm
-    ZDgzMGQzYTM2OTU5MzcxZjIzN2UxODhmYzQ1NDgyZWQ2NDUyMDZiZTRkZGI5
-    OWI2MGMyMWEyNzcyYTM1NThiZmRiNTZjODA5M2YzMmZiYmNjZDY=
+    NWM4ZDQwOGU5MTZjYTVhY2MwZjg4NWQ4MjA5Zjc2OGZjZWUyZTlkMTc2YTI1
+    MTk4YzQzZWEyNGY1YmUwMDUzZTg2Mjg3NTk4MTIyNGNiMjA4ZGNhNjQwYWE1
+    ZGE0ZjEyMTdiNmJlZTM3NDFlN2E3YTEyOTNhZmUyZTJkYzQ4NTM=

data/README.md

@@ -59,12 +59,12 @@ end
 
 ## Rails
 
-The equivalent of the above for Rails is (I welcome better solutions!)
+The equivalent of the above for Rails is:
 
 Create an agent in `config/apllication.rb`, and register the rack middleware:
 
 ```ruby
-module XXXRails
+module YourApplicationRails
   class Application < Rails::Application
     # ...
 
@@ -81,7 +81,7 @@ Register the Graphql middleware when you create your schema:
 Rails.application.config.optics_agent.instrument_schema(YourSchema)
 ```
 
-Add something like this to your `graphql` action:
+Register Optics Agent on the GraphQL context within your `graphql` action as below:
 
 ```ruby
 def create

data/lib/optics-agent/agent.rb

@@ -19,7 +19,6 @@ module OpticsAgent
     def initialize
       @query_queue = []
       @semaphone = Mutex.new
-      ReportJob.perform_in(60, self)
     end
 
     def instrument_schema(schema)
@@ -28,6 +27,11 @@ module OpticsAgent
 
       puts 'scheduling schema job'
       SchemaJob.perform_in(10, self)
+      schedule_report
+    end
+
+    def schedule_report
+      ReportJob.perform_in(60, self)
     end
 
     def add_query(query, rack_env, start_time, end_time)

data/lib/optics-agent/normalization/latency.rb

@@ -6,7 +6,7 @@ module OpticsAgent
 
     # see https://github.com/apollostack/optics-agent/blob/master/docs/histograms.md
     def latency_bucket(micros)
-      bucket = Math.log(micros) / Math.log(1.1)
+      bucket = Math.log([0, micros].max) / Math.log(1.1)
 
       [255, [0, bucket].max].min.ceil.to_i
     end

data/lib/optics-agent/reporting/report_job.rb

@@ -18,7 +18,7 @@ module OpticsAgent::Reporting
       report.decorate_from_schema(agent.schema)
       report.send
 
-      self.class.perform_in(60, agent)
+      agent.schedule_report
     end
   end
 end

data/spec/latency_spec.rb

@@ -14,15 +14,30 @@ describe 'latency helpers' do
   describe 'latency_bucket' do
     it 'returns the right values' do
       tests = [
+        [-1, 0],
+        [0, 0],
+        # 1 nanosecond
+        [0.001, 0],
         [0.1, 0],
         [0.9, 0],
+        [0.999, 0],
+        # 1 microsecond
         [1, 0],
+        [1.001, 1],
         [1.1, 1],
+        [1.101, 2],
         [1.21, 2],
+        [10, 25],
+        [10.834, 25],
+        [10.835, 26],
         [100, 49],
+        # 1 millisecond
         [1000, 73],
+        # 1 second
         [1000 * 1000, 145],
         [1.1**254, 255],
+        # 5 days
+        [5 * 24 * 60 * 60 * 1000 * 1000, 255],
         [1000 * 1000 * 1000 * 1000, 255]
       ]
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: optics-agent
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - ! 'Tom Coleman '