optic14n 2.0.0 → 2.0.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: faf613071e1b6009e6a97058aa8ccc17e537b88e
+  data.tar.gz: 87274484cb0115cae18914eb1ee8edeb070b1ca5
+SHA512:
+  metadata.gz: cde69422152d68439c35298f616876c82d6ed32ec8ae4efb92926326873a8c639f7fed718a7782c2a60b62b2e38f5b7b5585314988fb4863730b41bd41490b6b
+  data.tar.gz: aa2d3e22503736c3e0c86ebc243ddff0d85adf00d381a40fc7639fb9bb9a56dec0e43235c9cec2297479ae4e1d28ee01811ba6228e8ce6766d6e8c7e78d4e357

data/.ruby-version

@@ -0,0 +1,2 @@
+2.3.0
+

data/Gemfile

@@ -4,5 +4,5 @@ source 'https://rubygems.org'
 gemspec
 
 group :test do
-  gem 'rspec'
-end
+  gem 'rspec', '2.14.1'
+end

data/lib/optic14n/version.rb

@@ -1,3 +1,3 @@
 module Optic14n
-  VERSION = '2.0.0'
+  VERSION = '2.0.1'
 end

data/lib/uri/bluri.rb

@@ -79,10 +79,10 @@ module URI
 
     def canonicalize_query!(options)
       allow_all = (options[:allow_query] == :all)
-      allowed_keys = [options[:allow_query]].flatten.compact unless allow_all
+      allowed_keys = [options[:allow_query]].flatten.compact.map(&:to_s) unless allow_all
 
       query_hash.keep_if do |k, _|
-        allow_all || (allowed_keys.include?(k) || allowed_keys.include?(k.to_sym))
+        allow_all || (allowed_keys.include?(k.to_s))
       end
 
       self.query_hash = QueryHash[query_hash.sort_by { |k, _| k }]
@@ -113,4 +113,4 @@ module Kernel
   end
 
   module_function :BLURI
-end
+end

data/spec/c14n_spec.rb

@@ -132,6 +132,35 @@ describe "Paul's tests, translated from Perl" do
           @bluri.query_hash.to_s.should == 'bar&foo'
         end
       end
+
+      describe 'casing of allowed query params' do
+        context 'when the query param contains upper-case letters' do
+          it 'does not preserve the query string, even when it appeared identically in the URL' do
+            BLURI('http://www.example.com/?Foo=bar').canonicalize!(allow_query: 'Foo').to_s.should ==
+                'http://www.example.com'
+          end
+        end
+
+        context 'when the query param is lower-cased' do
+          it 'preserves the query string and lower-cases it' do
+            BLURI('http://www.example.com/?Foo=bar').canonicalize!(allow_query: 'foo').to_s.should ==
+                'http://www.example.com?foo=bar'
+          end
+        end
+      end
+
+      describe 'indifferent specfication of allowed query params' do
+        context 'specifying the allowed query param using either a symbol or a string' do
+          it 'should behave the same' do
+            url = 'http://example.com/some?significant=1&query_params=2'
+
+            using_symbol = BLURI(url).canonicalize!(allow_query: :significant)
+            using_string = BLURI(url).canonicalize!(allow_query: 'significant')
+
+            using_symbol.should == using_string
+          end
+        end
+      end
     end
 
     describe 'degenerate cases' do
@@ -148,6 +177,10 @@ describe "Paul's tests, translated from Perl" do
             canonicalize!(allow_query: :all).
             to_s.should eql('http://example.com/path?%ED=view')
         end
+
+        it 'does not error when there are bad things in query keys when allow_query isn\'t :all' do
+          expect { BLURI('http://some.com/a/path?%E2').canonicalize! }.not_to raise_error
+        end
       end
 
       describe 'failure to canonicalize paths correctly' do

metadata

@@ -1,62 +1,55 @@
 --- !ruby/object:Gem::Specification
 name: optic14n
 version: !ruby/object:Gem::Version
-  version: 2.0.0
-  prerelease: 
+  version: 2.0.1
 platform: ruby
 authors:
 - Russell Garner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-27 00:00:00.000000000 Z
+date: 2016-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: gem_publisher
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.3.0
 description: Canonicalises URLs.
@@ -66,7 +59,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
+- ".ruby-version"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -89,33 +83,26 @@ files:
 homepage: ''
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2602697415991458495
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2602697415991458495
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.5.1
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Specifically, HTTP URLs, for a limited purpose
 test_files:
 - spec/bluri_spec.rb