opium 1.1.5 → 1.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bcecdde21391716e2fa90f3d7e69ed2ab99cec6e
-  data.tar.gz: b424a700e0cd350b3840ddaae829ef3b964776ab
+  metadata.gz: 544c54e1dac7cf8a8adb4f02fc4335c33c9778b7
+  data.tar.gz: 81bab9d1dbd8139fd8c73d830b16476e1e6b42d2
 SHA512:
-  metadata.gz: 3f8768756d6016fad4a9c92065b955dee1b3382d9626a7079782cbb71ad2287653bb1e016fc1cac2ea43c221a0ed9e6126d04d88e30a70dfcb93d367cb1dccb9
-  data.tar.gz: e7def16e2b043a3ce5121fd65d8a08aa7f4ed94a6d45617217e5260b090fcae1f50c9bd87d9c12341bd43db2506e29a35b69b5eaf2e0c5eb08965c37c1fe8886
+  metadata.gz: c6c906d84d6b3499c0c531fda9966e19e06b80c91e31a850b147bc6c11887120ece07ae9c54b931b6b05496adf0fcdbc8aacfa2d78b9284026c974b424cf4449
+  data.tar.gz: c9a2d427d4f7b961382eeed079fd1400ef2304ea2861577f2cf67354657cc462b673c7fe59c9cad4714d307d11296bdabd9b934091e9c9277b7712ce83878da4

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.1.6
+### Resolved Issues
+- #39: `Opium::File#upload` now paramterizes the file name.
+- #38: Added Content-Length and Transfer-Encoding headers to file uploads.
+
 ## 1.1.5
 ### Resolved Issues
 - #37: Callbacks no longer makes `:update` a private method.

data/lib/opium/file.rb

@@ -47,8 +47,8 @@ module Opium
         {}.tap do |result|
           mime_type = options.fetch( :content_type, MimeMagic.by_magic(file) )
           mime_type = MimeMagic.by_path(file) if mime_type == 'application/zip'
-          result[:id] = options[:original_filename] || ::File.basename( file )
-          result[:headers] = { content_type: mime_type.to_s }
+          result[:id] = parameterize_name( options[:original_filename] || ::File.basename( file ) )
+          result[:headers] = { content_type: mime_type.to_s, content_length: file.size.to_s }
           result[:sent_headers] = options[:sent_headers] if options.key? :sent_headers
         end
       end
@@ -60,6 +60,11 @@ module Opium
       def has_keys( object, *keys )
         object.keys.all? {|key| keys.include? key}
       end
+      
+      def parameterize_name( name )
+        without_extension, extension = ::File.basename( name, '.*' ), ::File.extname( name )
+        without_extension.parameterize + extension
+      end
     end
     
     def initialize( attributes = {} )

data/lib/opium/version.rb

@@ -1,3 +1,3 @@
 module Opium
-  VERSION = "1.1.5"
+  VERSION = "1.1.6"
 end

data/spec/opium/file_spec.rb

@@ -43,6 +43,23 @@ describe Opium::File do
       end
     end
     
+    context 'with non-standard characters in filename' do
+      let(:upload_options) { { original_filename: 'chunky&bacon$with cheddar@cheese.jpg' } }
+      
+      it { expect { result }.to_not raise_exception }
+      it 'paramterizes the name' do
+        expect( result.name ).to end_with 'chunky-bacon-with-cheddar-cheese.jpg'
+      end
+    end
+    
+    context 'when executed' do
+      let(:upload_options) { { sent_headers: true } }
+      
+      it { expect { result }.to_not raise_exception }
+      it { expect( result.keys ).to include( 'Content-Length' ) }
+      it { expect( result['Content-Length'] ).to eq gif_file.size.to_s }
+    end
+    
     context 'with a :content_type option' do
       let(:upload_options) { { content_type: 'image/png', sent_headers: true } }
       

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opium
 version: !ruby/object:Gem::Version
-  version: 1.1.5
+  version: 1.1.6
 platform: ruby
 authors:
 - Joshua Bowers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-20 00:00:00.000000000 Z
+date: 2015-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler