opinionated_http 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 70883413762ba2277b74061e20f9fd5faa73fccee8a762595a40793a93ed2689
-  data.tar.gz: 45bf3291006a3577a29f5fd603ad27c34b1d6948c54e67f71efb20862c0af613
+  metadata.gz: cbd58bf8946567e33344521051ead26e88ad8d6d083f820c1528ac644c6ac7ae
+  data.tar.gz: 4dd8282607215174ef3b261f262e9bbbd99396a0f5992df1a6dc652bc58b4008
 SHA512:
-  metadata.gz: eec7f0a191186d29a970284e04dc571a2c8329587a414fa41576852e59d08503928594e14fc8e65f9ebea1570f90e15ad5e878a7b26259eae4adc605e7e9063f
-  data.tar.gz: ac1ce6b6f65d720cf7ddac4d93621c608f609ad1e113ead056e710e0cfe37df70792459940cdd3ca9effe0d8a123e60df11e89cf2a713ab7855c1148ea29e86d
+  metadata.gz: 37c91ccf2069493d1cea1243d5673d3fbbd7e7caed6542eb3b61678e1f4f2f34fd964b5521b17042f297482f42921983a5019c788b5b3de10d6739a1d9569239
+  data.tar.gz: fd93c9925f575faabc06809cd0ed665469cd8e2531c91b9a96446e00b64fb1be1b50c3a065378ea73697a0c42f563a352c234dc42f9b8ac309e5413e2accc253

data/lib/opinionated_http/client.rb

@@ -147,14 +147,8 @@ module OpinionatedHTTP
       http_method = request.method.upcase
       response    =
         begin
-          payload = {}
-          if logger.trace?
-            # payload[:parameters] = parameters
-            payload[:path] = request.path
-          end
-          message = "HTTP #{http_method}: #{action}" if logger.debug?
-
-          logger.benchmark_info(message: message, metric: "#{metric_prefix}/#{action}", payload: payload) do
+          message = "HTTP #{http_method}: #{action} #{request.path}"
+          logger.benchmark_info(message: message, metric: "#{metric_prefix}/#{action}") do
             driver.request(request)
           end
         rescue StandardError => e

data/lib/opinionated_http/request.rb

@@ -51,12 +51,11 @@ module OpinionatedHTTP
     private
 
     def format_body
-      return if body.nil?
-
       case format
       when :json
         headers["Content-Type"] = "application/json"
-        body.to_json unless body.is_a?(String) || body.nil?
+        headers["Accept"]       = "application/json"
+        body.is_a?(String) || body.nil? ? body : body.to_json
       when nil
         body
       else

data/lib/opinionated_http/response.rb

@@ -25,6 +25,10 @@ module OpinionatedHTTP
     def body!
       return body if success?
 
+      exception!
+    end
+
+    def exception!
       error_message = "HTTP #{verb.upcase}: #{action} Failure: (#{code}) #{message}"
       logger.error(message: error_message, metric: "#{metric_prefix}/exception", payload: {body: body})
       raise(error_class, error_message)

data/lib/opinionated_http/version.rb

@@ -1,3 +1,3 @@
 module OpinionatedHTTP
-  VERSION = "0.1.1".freeze
+  VERSION = "0.1.2".freeze
 end

data/test/request_test.rb

@@ -25,7 +25,8 @@ class RequestTest < Minitest::Test
         req = OpinionatedHTTP::Request.new(action: action, path: path, verb: post_verb, format: :json, body: json_request).http_request
 
         assert_equal json_request.to_json, req.body
-        assert_equal "application/json", req["Content-Type"]
+        assert_equal "application/json", req["content-type"], -> { req.to_hash.ai }
+        assert_equal "application/json", req["accept"], -> { req.to_hash.ai }
       end
 
       it "returns a request with supplied headers" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opinionated_http
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Reid Morrison
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-03-15 00:00:00.000000000 Z
+date: 2022-03-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: persistent_http