opinionated_http 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e42aeb5b1a1b2647f48288e3b34b54064b327f72b0cce291ea75a1c0a563eb79
-  data.tar.gz: 533c7d1bf33a594ebb5b910e25a4ebf0b8420d9e5a24d0aac5f99e83e779fbe4
+  metadata.gz: 5c63d8fd6c65797a7afcef26ff0ef72507dcf75f8dbbd4bc93e768cf0ddffc9a
+  data.tar.gz: 0a56d817ad5a0a988886faf17b034df697712c3958719cbcd72558ebb1bd8ee1
 SHA512:
-  metadata.gz: e2555937900d00a7b139a1bee2b76de642065b8b0469aeebb7783934c588bd032dc9b72b211e7ba5b04f06d01f55ece6f7a45d44439f14303c051e71cb4207bc
-  data.tar.gz: c78cfe4681bfe65cba9d570878dcf78328059d5835e9de0cbff7d416d7ee5954cc4d4fd831f459373027bff9cf37f096ad12f5108ae40fd32db5502fd02ebd12
+  metadata.gz: f38a9f47681824038a271244c560639b119ff9ff138210c93eeb2e9d2e0955b05198f0956d5fba2f1b60b965bf4084e8f3aca0b89af759d6ecf78419d9f05903
+  data.tar.gz: 4b882e2ec2025a9d626c1a3e6d52edff1a20db6fb6dc48bc10203f14117bb1856764f373c4a0ca0bd81f97fc75a4798a68a57b2cdeafd1c3ad7d6b36ef93a14d

data/lib/opinionated_http/client.rb

@@ -86,14 +86,14 @@ module OpinionatedHTTP
     def get(action:, path: "/#{action}", **args)
       request  = build_request(path: path, verb: "Get", **args)
       response = request(action: action, request: request)
-      extract_body(response)
+      extract_body(response, 'GET', action)
     end
 
     def post(action:, path: "/#{action}", **args)
       request = build_request(path: path, verb: "Post", **args)
 
       response = request(action: action, request: request)
-      extract_body(response)
+      extract_body(response, 'POST', action)
     end
 
     def build_request(verb:, path:, headers: nil, body: nil, form_data: nil, username: nil, password: nil, parameters: nil)
@@ -164,7 +164,7 @@ module OpinionatedHTTP
       response
     end
 
-    def extract_body(response)
+    def extract_body(response, http_method, action)
       return response.body if response.is_a?(Net::HTTPSuccess)
 
       message = "HTTP #{http_method}: #{action} Failure: (#{response.code}) #{response.message}"

data/lib/opinionated_http/version.rb

@@ -1,3 +1,3 @@
 module OpinionatedHTTP
-  VERSION = "0.0.5".freeze
+  VERSION = "0.0.6".freeze
 end

data/test/client_test.rb

@@ -27,6 +27,16 @@ module OpinionatedHTTP
           end
           assert_equal body, response
         end
+
+        it "fails" do
+          message = "HTTP GET: lookup Failure: (403) Forbidden"
+          error = assert_raises ServiceError do
+            stub_request(Net::HTTPForbidden, 403, "Forbidden", "") do
+              http.get(action: "lookup", parameters: {zip: "12345"})
+            end
+          end
+          assert_equal message, error.message
+        end
       end
 
       describe "post" do
@@ -47,6 +57,29 @@ module OpinionatedHTTP
           end
           assert_equal body, response
         end
+
+        it "fails with body" do
+          message = "HTTP POST: lookup Failure: (403) Forbidden"
+          output  = {zip: "12345", population: 54_321}
+          body    = output.to_json
+          error   = assert_raises ServiceError do
+            stub_request(Net::HTTPForbidden, 403, "Forbidden", "") do
+              http.post(action: "lookup", body: body)
+            end
+          end
+          assert_equal message, error.message
+        end
+
+        it "fails with form data" do
+          output  = {zip: "12345", population: 54_321}
+          message = "HTTP POST: lookup Failure: (403) Forbidden"
+          error   = assert_raises ServiceError do
+            stub_request(Net::HTTPForbidden, 403, "Forbidden", "") do
+              http.post(action: "lookup", form_data: output)
+            end
+          end
+          assert_equal message, error.message
+        end
       end
 
       describe "build_request" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opinionated_http
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Reid Morrison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-29 00:00:00.000000000 Z
+date: 2020-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: persistent_http