openweather2 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 31795559ddff60a2dfc0755965c1449ce32342d8
-  data.tar.gz: 8b7316544bf04460f8f61dfee9113f78165e130f
+  metadata.gz: 159c652dc6409423e69f8f03349370ba4c57f7ac
+  data.tar.gz: e6ce5a96df0a6f8f90ceded6694b313eb41ae245
 SHA512:
-  metadata.gz: fd00fe93e63130132aa6d725b89d42e563445810ef49e242ef1c905ec0e2f1ead6b50129ab4e948f2856963f2d32206dcf0cb2d66289511aa096c2bc3a70a90b
-  data.tar.gz: 0a5d198bf91a3bd9eb4744e5dda30f58a10815421f86092d4653b265b0fd3cf7b5c9ec6972ce52b9082c9d8516c8c61364fa35fa3c745ca28a79d2baec74d5c2
+  metadata.gz: 385f88c0ff9ad4f7481f15446e32aade179ebca69528f7132f6ec327aaa9735688743cce583d3dfebb1be916d8b2b33e0065e69c8c8f8f67f9425ec9d404a3ee
+  data.tar.gz: 728e4f82522b0be04a013ee8cbd543b89666f17490d57b784c8296c24b2a6bd58f2e473df526c783b229ee761c5975e87c7c0f55393ed2c26f9d3f45d7526abc

data/.travis.yml

@@ -0,0 +1,8 @@
+language: ruby
+rvm:
+  - 1.9.3
+  - 2.0.0
+  - 2.1.5
+  - 2.2.1
+
+script: bundle exec rake test

data/README.md

@@ -1,4 +1,4 @@
-# Openweather2
+# Openweather2 [![Gem Version](https://badge.fury.io/rb/openweather2.svg)](http://badge.fury.io/rb/openweather2)
 
 This gem is an abstraction to the OpenWeatherMap API.
 
@@ -53,6 +53,16 @@ Openweather2.weather('london')
 
 ```
 
+Also you can provide a second parameter for the units to convert the temperature to 'metric' or 'imperial'
+
+```ruby
+
+Openweather2.weather('london', 'metric')
+Openweather2.weather('london', 'imperial')
+
+```
+
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/openweather2/client.rb

@@ -1,6 +1,6 @@
-require "uri"
-require "net/http"
-require "json"
+require 'uri'
+require 'net/http'
+require 'json'
 
 module Openweather2
 
@@ -25,22 +25,19 @@ module Openweather2
   end
 
   def weather(city, units = nil)
-    configure_required!
-
-    uri = URI(Openweather2.configuration.endpoint)
-    uri.query = URI.encode_www_form(default_params.merge(:q => city, :units => units))
-    req = Net::HTTP::Get.new(uri.request_uri)
+    check_configuration!
+    uri      = set_request_params(city, units)
+    response = send_request(uri)
+    parse_json(response)
+  end
 
-    http_params = [uri.hostname, uri.port, use_ssl: uri.scheme == 'https']
-    res = Net::HTTP.start(*http_params) do |http|
-      http.request(req)
-    end
+  private
 
-    case res
+  def parse_json(response)
+    case response
     when Net::HTTPSuccess
-      json = JSON.parse(res.body)
+      json = JSON.parse(response.body)
       Openweather2::Weather.new(json)
-
     when Net::HTTPUnprocessableEntity
       raise UnprocessableError, 'Bad URI param!'
     else
@@ -48,16 +45,26 @@ module Openweather2
     end
   end
 
-  private
+  def send_request(uri)
+    req = Net::HTTP::Get.new(uri.request_uri)
+    http_params = [uri.hostname, uri.port, use_ssl: uri.scheme == 'https']
+    Net::HTTP.start(*http_params) {|http| http.request(req)}
+  end
+
+  def set_request_params(city, units)
+    uri = URI(Openweather2.configuration.endpoint)
+    uri.query = URI.encode_www_form(default_params.merge(q: city, units: units))
+    uri
+  end
 
-  def configure_required!
+  def check_configuration!
     if Openweather2.configuration.instance_variables.size < 2
       raise ArgumentError, 'You must configure Openweather2'
     end
   end
   
   def default_params
-    { APPID: Openweather2.configuration.apikey }
+    {APPID: Openweather2.configuration.apikey}
   end
 
 end

data/lib/openweather2/version.rb

@@ -1,3 +1,3 @@
 module Openweather2
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openweather2
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Lucas Ocon
@@ -74,6 +74,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md