openvox-lint 1.0.7 → 1.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4d7e73afd296560df9e4d0aef103a96fd6bf42483db6ceab560e4d8fd3b73813
-  data.tar.gz: 512c4019545161cc37a3e406b1afa3b41499bec7663624b067ee1d263346ceda
+  metadata.gz: abe996811c55331e6e81030b3b421c822f152e7e208767c0ba8154e8d6dfe628
+  data.tar.gz: bbd33e6c54ac940eb8b1a3e64ef511ef7ab6412282c12f48e3739508c3d9222c
 SHA512:
-  metadata.gz: fb51dc826fdbbf0419c0049fcd0ccba8e5310769216bb8e04a82af6beb95f053676a91022927cc1a15f8e90345f43d972b9a3c1c24453e29b3a59800338d62f0
-  data.tar.gz: 4a48731cf89acb78c270cffdbc97cd5273c466bb7990d0f1ee8bc4fbc74799a9f38963f6714430ecd7d1b1228a12f3176d9705c137aa850feb97de439694b70d
+  metadata.gz: 4b1e8359096a9156ef02eb2d18dd5af1171593d0f4c47a1957827a043212185dabd09608786c1df606257ca3b21a183978c084d289c7550f900e863367f8697b
+  data.tar.gz: 54bb7aba3f2afef0d6ba51f0346a8f05b7bf495a944a93af14e89144c2d28008ff09243e469b9330cc715a6200c42ea9172a83cebac57164e21088f3c9117c25

data/CHANGELOG.md

@@ -2,6 +2,83 @@
 
 All notable changes to openvox-lint will be documented in this file.
 
+## [1.0.8] - 2026-03-04
+
+### Fixed
+
+- **CLI: stale configuration on re-invocation**: The global configuration
+  singleton is now reset at the start of every `CLI#run`.  Repeated
+  invocations in the same Ruby process (Vim plugins, guard, Rake loops)
+  no longer inherit stale `disabled_checks`, `only_checks`, or other
+  settings from a previous run.
+
+- **CLI: `--config` flag ignored when local RC exists**: The `-c` /
+  `--config FILE` flag now takes strict priority.  Previously a local
+  `.openvox-lint.rc` would shadow an explicit `--config` path.
+
+- **lint:ignore / lint:endignore block suppression**: Block-style ignore
+  comments now work as documented.  `# lint:ignore:check_name` on its
+  own line opens a suppression block; `# lint:endignore` closes it.
+  All problems on lines between the two comments are suppressed for
+  the named checks.  Inline ignore comments (on the same line as code)
+  continue to work as before.
+
+- **ignore-paths glob matching with relative/absolute prefixes**: The
+  `--ignore-paths` glob patterns (and the defaults `vendor/**/*.pp`,
+  `pkg/**/*.pp`, `spec/**/*.pp`) now match correctly regardless of
+  whether the file was discovered via `./vendor/foo.pp`, `vendor/foo.pp`,
+  or an absolute path.
+
+- **trailing_comma false positives on non-resource braces**: The
+  `trailing_comma` check now only fires inside resource bodies
+  (`name { ... }`).  It no longer produces false positives on `if`,
+  `unless`, `case`, class bodies, or other brace-delimited contexts
+  where a trailing comma is not expected.
+
+- **arrow_alignment / space_before_arrow contradictory warnings**: The
+  `arrow_alignment` check now defers to `space_before_arrow` when the
+  misalignment in a group is caused by the longest key having extra
+  whitespace.  This eliminates contradictory double-warnings on the
+  same resource block.
+
+- **Unterminated strings and regex now reported as errors**: The lexer
+  now raises `OpenvoxLint::Error` when a single-quoted string,
+  double-quoted string, or regex literal is not terminated before
+  end-of-file.  Previously the lexer silently produced a truncated
+  token covering the rest of the file, leading to wrong lint results.
+
+- **Multi-line string tokens now report correct line number**: String
+  tokens that span multiple lines now record the **starting** line
+  number, not the ending line.  Checks that flag these tokens now
+  point to the correct source location.
+
+- **variables_not_enclosed mixed variable handling**: Strings containing
+  both enclosed (`${bar}`) and unenclosed (`$foo`) variables now
+  correctly flag only the unenclosed references.  Previously the
+  entire string was skipped if any `${...}` pattern was present.
+
+- **resource_reference_without_title_capital expanded allowlist**: The
+  function allowlist that prevents false positives on `name[...]`
+  patterns now covers 40+ Puppet built-in and stdlib functions
+  (`each`, `map`, `filter`, `reduce`, `lookup`, `dig`, etc.),
+  not just the original 5.
+
+### Changed
+
+- **duplicate_params / parameter_order: removed dead code**: Both checks
+  contained `.formatting?` guard clauses that could never trigger
+  because they operate on pre-filtered semantic tokens.  The dead code
+  has been removed for clarity.
+
+- **Check registry duplicate warning**: `OpenvoxLint.new_check` now
+  emits a warning to stderr (when `OPENVOX_LINT_DEBUG` is set) if a
+  check name that is already registered is overwritten.  This helps
+  detect accidental name collisions in custom check plugins.
+
+- **Gemfile cleaned up**: Removed duplicate gem declarations that were
+  listed in both the Gemfile `group` block and the gemspec
+  `add_development_dependency` entries.
+
 ## [1.0.7] - 2026-02-25
 
 ### Changed

data/DOCUMENTATION.md

@@ -46,7 +46,7 @@ the lexer token types, the plugin system, and integration guidance.
 
 | Constant | Value | Description |
 |----------|-------|-------------|
-| `VERSION` | `'1.0.4'` | Gem version |
+| `VERSION` | `'1.0.8'` | Gem version |
 
 ### Class Methods
 
@@ -54,8 +54,9 @@ the lexer token types, the plugin system, and integration guidance.
 |--------|---------|-------------|
 | `.configuration` | `Configuration` | Global configuration singleton |
 | `.configure { \|c\| }` | `Configuration` | Yields configuration for block-style setup |
+| `.reset_configuration!` | `Configuration` | Reset configuration to defaults (called by CLI) |
 | `.checks` | `Hash{Symbol => Class}` | Registry of loaded check classes |
-| `.new_check(name, &block)` | `Class` | Register a new check plugin |
+| `.new_check(name, &block)` | `Class` | Register a new check plugin (warns on duplicates) |
 
 ### Exceptions
 
@@ -248,7 +249,6 @@ notify :warning,    # or :error
 | `only_checks` | `Array<Symbol>` | `[]` | Run only these checks |
 | `disabled_checks` | `Array<Symbol>` | `[]` | Skip these checks |
 | `ignore_paths` | `Array<String>` | vendor, pkg, spec | Glob patterns to ignore |
-| `config_file` | `String` | `.openvox-lint.rc` | RC file path |
 | `relative` | `Boolean` | `false` | Use relative paths |
 | `column` | `Boolean` | `true` | Show column numbers |
 | `custom_log_format` | `String\|nil` | `nil` | Custom format string |
@@ -517,20 +517,20 @@ Place the check file in `lib/openvox-lint/plugins/checks/my_check.rb`.
 
 ## File Inventory
 
-| File | Lines | Description |
-|------|-------|-------------|
-| `bin/openvox-lint` | 7 | CLI entry point |
-| `lib/openvox-lint.rb` | 47 | Main module, auto-loader |
-| `lib/openvox-lint/version.rb` | 5 | Version constant |
-| `lib/openvox-lint/configuration.rb` | 59 | Configuration management |
-| `lib/openvox-lint/token.rb` | 38 | Token data structure |
-| `lib/openvox-lint/lexer.rb` | 342 | Puppet/OpenVox lexer |
-| `lib/openvox-lint/check_plugin.rb` | 147 | Base check class |
-| `lib/openvox-lint/checks.rb` | 46 | Check runner |
-| `lib/openvox-lint/report.rb` | 86 | Output formatters |
-| `lib/openvox-lint/linter.rb` | 72 | File orchestrator |
-| `lib/openvox-lint/cli.rb` | 87 | CLI parser |
-| `lib/openvox-lint/plugins/checks/*.rb` | 38 files | Check plugins |
-| `spec/spec_helper.rb` | 41 | Test helper |
-| `spec/unit/lexer_spec.rb` | 85 | Lexer tests |
-| `spec/unit/checks_spec.rb` | 142 | Check tests |
+| File | Description |
+|------|-------------|
+| `bin/openvox-lint` | CLI entry point |
+| `lib/openvox-lint.rb` | Main module, auto-loader |
+| `lib/openvox-lint/version.rb` | Version constant |
+| `lib/openvox-lint/configuration.rb` | Configuration management |
+| `lib/openvox-lint/token.rb` | Token data structure |
+| `lib/openvox-lint/lexer.rb` | Puppet/OpenVox lexer |
+| `lib/openvox-lint/check_plugin.rb` | Base check class |
+| `lib/openvox-lint/checks.rb` | Check runner with lint:ignore support |
+| `lib/openvox-lint/report.rb` | Output formatters |
+| `lib/openvox-lint/linter.rb` | File orchestrator |
+| `lib/openvox-lint/cli.rb` | CLI parser |
+| `lib/openvox-lint/plugins/checks/*.rb` | 38 built-in check plugins |
+| `spec/spec_helper.rb` | Test helper |
+| `spec/unit/lexer_spec.rb` | Lexer tests |
+| `spec/unit/checks_spec.rb` | Check tests |

data/README.md

@@ -1,6 +1,7 @@
 # openvox-lint
 
-![Version](https://img.shields.io/badge/version-1.0.7-blue)
+[![Gem Version](https://img.shields.io/gem/v/openvox-lint)](https://rubygems.org/gems/openvox-lint)
+[![Gem Downloads](https://img.shields.io/gem/dt/openvox-lint)](https://rubygems.org/gems/openvox-lint)
 ![Ruby](https://img.shields.io/badge/ruby-%E2%89%A5%202.5-red)
 ![License](https://img.shields.io/badge/license-Apache%202.0-blue)
 ![Checks](https://img.shields.io/badge/built--in%20checks-38-brightgreen)
@@ -637,6 +638,12 @@ openvox-lint/
 
 ---
 
+## Links
+
+- **RubyGems**: [rubygems.org/gems/openvox-lint](https://rubygems.org/gems/openvox-lint)
+- **GitHub**: [github.com/cvquesty/openvox-lint](https://github.com/cvquesty/openvox-lint)
+- **Issues**: [github.com/cvquesty/openvox-lint/issues](https://github.com/cvquesty/openvox-lint/issues)
+
 ## License
 
 Apache License, Version 2.0. See [LICENSE](LICENSE) for details.

data/lib/openvox-lint/check_plugin.rb

@@ -83,7 +83,8 @@ module OpenvoxLint
       return false if @ignore_comments.empty?
       line = problem[:line]
       @ignore_comments.any? do |ic|
-        ic[:line] == line && (ic[:checks].empty? || ic[:checks].include?(problem[:check].to_s))
+        line >= ic[:start_line] && line <= ic[:end_line] &&
+          (ic[:checks].empty? || ic[:checks].include?(problem[:check].to_s))
       end
     end
 

data/lib/openvox-lint/checks.rb

@@ -30,17 +30,61 @@ module OpenvoxLint
 
     private
 
+    # Parse inline and block-style lint:ignore comments.
+    #
+    # Inline:  # lint:ignore:check_name   — suppresses on the same line
+    # Block:   # lint:ignore:check_name
+    #          ...code...
+    #          # lint:endignore            — suppresses from ignore to endignore
     def parse_ignore_comments
       results = []
+      open_blocks = []  # stack of { start_line:, checks: }
+
       @tokens.each do |tok|
         next unless tok.type == :COMMENT
-        if tok.value =~ /lint:ignore:(.+)/
-          results << { line: tok.line, checks: Regexp.last_match(1).strip.split(/\s*,\s*/) }
+
+        if tok.value =~ /lint:endignore/
+          # Close the most recent open block
+          block = open_blocks.pop
+          if block
+            block[:end_line] = tok.line
+            results << block
+          end
+        elsif tok.value =~ /lint:ignore:(.+)/
+          checks = Regexp.last_match(1).strip.split(/\s*,\s*/)
+          # If there's code on the same line before this comment, treat
+          # it as inline-only (same line).  Otherwise open a block.
+          if inline_ignore?(tok)
+            results << { start_line: tok.line, end_line: tok.line, checks: checks }
+          else
+            open_blocks.push({ start_line: tok.line, end_line: nil, checks: checks })
+          end
         elsif tok.value =~ /lint:ignore\b/
-          results << { line: tok.line, checks: [] }
+          if inline_ignore?(tok)
+            results << { start_line: tok.line, end_line: tok.line, checks: [] }
+          else
+            open_blocks.push({ start_line: tok.line, end_line: nil, checks: [] })
+          end
         end
       end
+
+      # Any unclosed blocks extend to end-of-file
+      open_blocks.each do |block|
+        block[:end_line] = Float::INFINITY
+        results << block
+      end
+
       results
     end
+
+    # An ignore comment is "inline" if there is a non-formatting token
+    # on the same line before it (i.e. it sits at the end of a code line).
+    def inline_ignore?(comment_token)
+      @tokens.any? do |t|
+        t.line == comment_token.line &&
+          t.column < comment_token.column &&
+          !t.formatting?
+      end
+    end
   end
 end

data/lib/openvox-lint/cli.rb

@@ -6,11 +6,12 @@ module OpenvoxLint
   # Command-line interface for openvox-lint.
   class CLI
     def initialize(args = ARGV)
-      @args   = args
-      @config = OpenvoxLint.configuration
+      @args = args
     end
 
     def run
+      OpenvoxLint.reset_configuration!
+      @config = OpenvoxLint.configuration
       parse_options
       load_rc_file
       if @list_checks
@@ -41,7 +42,7 @@ module OpenvoxLint
         opts.on('--only-checks CHECKS', 'Comma-separated checks') { |c| @config.only_checks = c.split(',').map { |s| s.strip.to_sym } }
         opts.on('--ignore-paths PATHS', 'Comma-separated globs') { |p| @config.ignore_paths = p.split(',').map(&:strip) }
         opts.on('--list-checks', 'List available checks') { @list_checks = true }
-        opts.on('-c', '--config FILE', 'Config file path') { |f| @config.config_file = f }
+        opts.on('-c', '--config FILE', 'Config file path') { |f| @explicit_config_file = f }
       end
       remaining = []
       begin
@@ -59,7 +60,15 @@ module OpenvoxLint
     end
 
     def load_rc_file
-      ['.openvox-lint.rc', @config.config_file, File.expand_path('~/.openvox-lint.rc')].each do |path|
+      # Priority: explicit --config flag > local .openvox-lint.rc > ~/.openvox-lint.rc
+      # An explicit --config flag must always win.  The default value of
+      # config_file is nil until the user passes -c / --config.
+      candidates = if @explicit_config_file
+                     [@explicit_config_file]
+                   else
+                     ['.openvox-lint.rc', File.expand_path('~/.openvox-lint.rc')]
+                   end
+      candidates.each do |path|
         next unless path && File.exist?(path)
         @config.load_from_rc(path); break
       end

data/lib/openvox-lint/configuration.rb

@@ -7,13 +7,12 @@ module OpenvoxLint
       log_format: 'text', with_filename: true, fail_on_warnings: false,
       fix: false, only_checks: [], disabled_checks: [],
       ignore_paths: %w[vendor/**/*.pp pkg/**/*.pp spec/**/*.pp],
-      config_file: '.openvox-lint.rc', relative: false, column: true,
-      custom_log_format: nil,
+      relative: false, column: true, custom_log_format: nil,
     }.freeze
 
     attr_accessor :log_format, :with_filename, :fail_on_warnings,
                   :fix, :only_checks, :disabled_checks, :ignore_paths,
-                  :config_file, :relative, :column, :custom_log_format
+                  :relative, :column, :custom_log_format
 
     def initialize
       DEFAULTS.each do |k, v|

data/lib/openvox-lint/lexer.rb

@@ -140,8 +140,9 @@ module OpenvoxLint
     end
 
     def scan_regex
-      start = @pos; start_col = @column
+      start = @pos; start_line = @line; start_col = @column
       @pos += 1; @column += 1
+      terminated = false
       while @pos < @code.length && @code[@pos] != '/'
         if @code[@pos] == '\\'
           @pos += 2; @column += 2
@@ -149,31 +150,41 @@ module OpenvoxLint
           @pos += 1; @column += 1
         end
       end
-      @pos += 1; @column += 1
-      add_token(:REGEX, @code[start...@pos], @line, start_col)
+      if @pos < @code.length
+        @pos += 1; @column += 1; terminated = true
+      end
+      if !terminated
+        raise OpenvoxLint::Error, "unterminated regex starting at line #{start_line}"
+      end
+      add_token(:REGEX, @code[start...@pos], start_line, start_col)
     end
 
     def scan_single_quoted_string
-      start = @pos; start_col = @column
+      start = @pos; start_line = @line; start_col = @column
       @pos += 1; @column += 1
+      terminated = false
       while @pos < @code.length
         if @code[@pos] == '\\'
           @pos += 2; @column += 2
         elsif @code[@pos] == "'"
-          @pos += 1; @column += 1; break
+          @pos += 1; @column += 1; terminated = true; break
         elsif @code[@pos] == "\n"
           @line += 1; @column = 1; @pos += 1
         else
           @pos += 1; @column += 1
         end
       end
-      add_token(:SSTRING, @code[start...@pos], @line, start_col)
+      if !terminated
+        raise OpenvoxLint::Error, "unterminated single-quoted string starting at line #{start_line}"
+      end
+      add_token(:SSTRING, @code[start...@pos], start_line, start_col)
     end
 
     def scan_double_quoted_string
-      start = @pos; start_col = @column
+      start = @pos; start_line = @line; start_col = @column
       @pos += 1; @column += 1
       has_interp = false
+      terminated = false
       while @pos < @code.length
         if @code[@pos] == '\\'
           @pos += 2; @column += 2
@@ -184,15 +195,18 @@ module OpenvoxLint
             @pos += 1; @column += 1
           end
         elsif @code[@pos] == '"'
-          @pos += 1; @column += 1; break
+          @pos += 1; @column += 1; terminated = true; break
         elsif @code[@pos] == "\n"
           @line += 1; @column = 1; @pos += 1
         else
           @pos += 1; @column += 1
         end
       end
+      if !terminated
+        raise OpenvoxLint::Error, "unterminated double-quoted string starting at line #{start_line}"
+      end
       type = has_interp ? :DQSTRING : :STRING
-      add_token(type, @code[start...@pos], @line, start_col)
+      add_token(type, @code[start...@pos], start_line, start_col)
     end
 
     def scan_variable

data/lib/openvox-lint/linter.rb

@@ -64,8 +64,14 @@ module OpenvoxLint
     end
 
     def ignored?(filepath)
+      # Normalize away leading './' so that patterns like 'vendor/**/*.pp'
+      # match regardless of whether the file was discovered as
+      # './vendor/foo.pp' or 'vendor/foo.pp'.
+      normalized = filepath.sub(%r{\A\./}, '')
       @config.ignore_paths.any? do |pat|
-        File.fnmatch?(pat, filepath, File::FNM_PATHNAME | File::FNM_DOTMATCH)
+        File.fnmatch?(pat, normalized, File::FNM_PATHNAME | File::FNM_DOTMATCH) ||
+          File.fnmatch?(pat, filepath, File::FNM_PATHNAME | File::FNM_DOTMATCH) ||
+          File.fnmatch?("**/#{pat}", normalized, File::FNM_PATHNAME | File::FNM_DOTMATCH)
       end
     end
   end

data/lib/openvox-lint/plugins/checks/arrow_alignment.rb

@@ -1,6 +1,11 @@
 # frozen_string_literal: true
 
 # Hash rockets (=>) should be aligned within a resource body.
+#
+# Only fires on groups of 2+ arrows.  Skips groups where the
+# misalignment is caused by the longest key having extra leading
+# whitespace — that case is already reported by the
+# space_before_arrow check to avoid duplicate / contradictory advice.
 OpenvoxLint.new_check(:arrow_alignment) do
   def check
     # Group FARROW tokens by resource (consecutive lines)
@@ -11,8 +16,16 @@ OpenvoxLint.new_check(:arrow_alignment) do
     groups = group_arrows(arrows)
     groups.each do |group|
       next if group.size <= 1
+
+      # If the arrows are already at the same column, nothing to do.
       columns = group.map(&:column)
       max_col = columns.max
+      next if columns.all? { |c| c == max_col }
+
+      # Skip this group if the misalignment is caused by extra space
+      # before the longest-key arrow — space_before_arrow handles that.
+      next if longest_key_has_extra_space?(group)
+
       group.each do |arrow|
         next if arrow.column == max_col
         notify :warning,
@@ -39,4 +52,29 @@ OpenvoxLint.new_check(:arrow_alignment) do
     groups << current unless current.empty?
     groups
   end
+
+  # Returns true when the arrow belonging to the longest key in the
+  # group has more than one space before it.  In that situation the
+  # space_before_arrow check will fire, so arrow_alignment should stay
+  # silent to avoid contradictory advice.
+  def longest_key_has_extra_space?(group)
+    group.each do |arrow|
+      idx = tokens.index(arrow)
+      next unless idx && idx >= 2
+      ws = tokens[idx - 1]
+      next unless ws.type == :WHITESPACE
+      key = tokens[idx - 2]
+      next if key.formatting?
+      # Find the longest key length in the group
+      max_klen = group.map { |a|
+        ai = tokens.index(a)
+        next 0 unless ai && ai >= 2 && tokens[ai - 1].type == :WHITESPACE
+        tokens[ai - 2].value.length
+      }.max
+      if key.value.length == max_klen && ws.value.length > 1
+        return true
+      end
+    end
+    false
+  end
 end

data/lib/openvox-lint/plugins/checks/duplicate_params.rb

@@ -8,9 +8,9 @@ OpenvoxLint.new_check(:duplicate_params) do
       params = res[:param_tokens]
       params.each_with_index do |tok, i|
         next unless tok.type == :NAME
-        # Check if followed by =>
+        # param_tokens are already semantic (non-formatting), so the
+        # next token is directly adjacent.
         j = i + 1
-        j += 1 while j < params.length && params[j].formatting?
         next unless j < params.length && params[j].type == :FARROW
         if seen[tok.value]
           notify :error,

data/lib/openvox-lint/plugins/checks/legacy_facts.rb

@@ -37,7 +37,9 @@ OpenvoxLint.new_check(:legacy_facts) do
   def check
     tokens.each do |tok|
       next unless tok.type == :VARIABLE
-      name = tok.value.sub(/^\$/, '').sub(/\A::/, '')
+      # Strip leading $ and :: prefix, and any trailing : left by the
+      # lexer when a variable is used as a resource title ($fact:).
+      name = tok.value.sub(/^\$/, '').sub(/\A::/, '').chomp(':')
       next unless LEGACY_FACTS.include?(name)
       notify :warning,
         message: "legacy fact '#{name}' — use $facts['...'] structured fact instead (Puppet 8 / OpenVox 8)",

data/lib/openvox-lint/plugins/checks/parameter_order.rb

@@ -8,9 +8,9 @@ OpenvoxLint.new_check(:parameter_order) do
       found_default = false
       params.each_with_index do |tok, i|
         next unless tok.type == :VARIABLE
-        # Look ahead for = (default value)
+        # param_tokens from find_keyword_indexes are already semantic
+        # (non-formatting), so the next token is directly adjacent.
         j = i + 1
-        j += 1 while j < params.length && params[j].formatting?
         has_default = j < params.length && params[j].type == :EQUALS
         if has_default
           found_default = true

data/lib/openvox-lint/plugins/checks/resource_reference_without_title_capital.rb

@@ -3,6 +3,21 @@
 # Resource reference titles must start with a capital letter.
 # e.g. File['/tmp/foo'] not file['/tmp/foo']
 OpenvoxLint.new_check(:resource_reference_without_title_capital) do
+  # Puppet built-in functions and common stdlib functions that accept
+  # bracket/index syntax (name[...]).  These are NOT resource
+  # references and must not be flagged.
+  FUNCTION_ALLOWLIST = %w[
+    split join include contain require
+    each map filter reduce select reject
+    slice flatten any all empty
+    assert_type create_resources defined dig
+    ensure_packages ensure_resource epp fail
+    fqdn_rand generate hiera hiera_array hiera_hash hiera_include
+    inline_epp inline_template lookup match md5 notice
+    realize regsubst sha1 sprintf tag template unique versioncmp
+    with
+  ].freeze
+
   def check
     sem = semantic_tokens
     sem.each_with_index do |tok, i|
@@ -11,8 +26,8 @@ OpenvoxLint.new_check(:resource_reference_without_title_capital) do
       next unless sem[i + 1].type == :LBRACK
       # This is name[...] which should be Name[...] for a resource reference
       next if tok.value =~ /\A[A-Z]/
-      # Skip function calls and normal array access
-      next if %w[split join include contain require].include?(tok.value)
+      # Skip function calls, method calls, and normal array access
+      next if FUNCTION_ALLOWLIST.include?(tok.value)
       notify :warning,
         message: "resource reference '#{tok.value}' must start with a capital letter",
         line: tok.line, column: tok.column

data/lib/openvox-lint/plugins/checks/top_scope_facts.rb

@@ -6,7 +6,9 @@ OpenvoxLint.new_check(:top_scope_facts) do
   def check
     tokens.each do |tok|
       next unless tok.type == :VARIABLE
-      name = tok.value.sub(/^\$/, '')
+      # Strip leading $ and any trailing : left by the lexer when a
+      # variable is used as a resource title ($::fact:).
+      name = tok.value.sub(/^\$/, '').chomp(':')
       next unless name.start_with?('::')
       fact_name = name.sub(/\A::/, '')
       # Skip module-qualified variables (e.g. ::mymodule::param)

data/lib/openvox-lint/plugins/checks/trailing_comma.rb

@@ -1,24 +1,30 @@
 # frozen_string_literal: true
 
 # Resource bodies and parameter lists should end with a trailing comma.
+#
+# Only fires inside resource bodies (NAME { ... }) — not inside
+# conditionals (if/unless/case), class bodies, or other brace contexts
+# where a trailing comma is not expected.
 OpenvoxLint.new_check(:trailing_comma) do
   def check
-    tokens.each_with_index do |tok, i|
-      next unless tok.type == :RBRACE || tok.type == :RPAREN
-      # Find the previous non-whitespace token
-      j = i - 1
-      j -= 1 while j >= 0 && tokens[j].formatting?
-      next if j < 0
-      prev = tokens[j]
-      # Skip if previous is opening brace/paren (empty block) or already a comma
-      next if %i[LBRACE LPAREN COMMA RBRACE].include?(prev.type)
-      # Only flag inside parameter lists and resource bodies
-      next unless prev.type == :SSTRING || prev.type == :STRING || prev.type == :NAME ||
-                  prev.type == :VARIABLE || prev.type == :NUMBER || prev.type == :TRUE ||
-                  prev.type == :FALSE || prev.type == :CLASSREF || prev.type == :RBRACK
+    resource_indexes.each do |res|
+      params = res[:param_tokens]
+      next if params.empty?
+
+      # Find the last non-formatting token in the resource body
+      last = params.reverse_each.find { |t| !t.formatting? }
+      next unless last
+
+      # Already has a trailing comma — nothing to do
+      next if last.type == :COMMA
+
+      # Only flag after value-like tokens (not structural tokens)
+      next unless %i[SSTRING STRING NAME VARIABLE NUMBER TRUE FALSE
+                     CLASSREF RBRACK DQSTRING].include?(last.type)
+
       notify :warning,
         message: 'missing trailing comma after last attribute',
-        line: prev.line, column: prev.column
+        line: last.line, column: last.column
     end
   end
 end

data/lib/openvox-lint/plugins/checks/variables_not_enclosed.rb

@@ -2,18 +2,24 @@
 
 # Variables in double-quoted strings should be enclosed in braces.
 # e.g. "$foo" should be "${foo}"
+#
+# Correctly handles strings with a mix of enclosed and unenclosed
+# variables — e.g. "$foo and ${bar}" flags the unenclosed $foo even
+# though ${bar} is properly enclosed.
 OpenvoxLint.new_check(:variables_not_enclosed) do
   def check
     tokens.each do |tok|
       next unless tok.type == :DQSTRING || tok.type == :STRING
       val = tok.value
-      # Look for $var not followed by { inside double-quoted strings
-      next unless val =~ /\$([a-zA-Z_][a-zA-Z0-9_:]*)/
-      next if val =~ /\$\{/  # already enclosed
-      notify :warning,
-        message: 'variable not enclosed in braces within string',
-        line: tok.line,
-        column: tok.column
+      # Scan for any $var that is NOT preceded by ${ (already enclosed).
+      # We use a negative lookbehind to skip ${...} patterns and only
+      # match bare $varname references.
+      val.scan(/(?<!\$)\$(?!\{)([a-zA-Z_][a-zA-Z0-9_:]*)/) do
+        notify :warning,
+          message: 'variable not enclosed in braces within string',
+          line: tok.line,
+          column: tok.column
+      end
     end
   end
 end

data/lib/openvox-lint/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OpenvoxLint
-  VERSION = '1.0.7'
+  VERSION = '1.0.8'
 end

data/lib/openvox-lint.rb

@@ -29,11 +29,21 @@ module OpenvoxLint
       yield(configuration)
     end
 
+    # Reset the global configuration singleton.  Called at the start of
+    # every CLI run so that repeated invocations in the same Ruby
+    # process (Vim plugins, guard, Rake loops) start clean.
+    def reset_configuration!
+      @configuration = Configuration.new
+    end
+
     def checks
       @checks ||= {}
     end
 
     def new_check(name, &block)
+      if checks.key?(name)
+        $stderr.puts "openvox-lint: warning: check '#{name}' is already registered — overwriting" if ENV['OPENVOX_LINT_DEBUG']
+      end
       klass = Class.new(CheckPlugin, &block)
       klass.instance_variable_set(:@check_name, name)
       checks[name] = klass

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: openvox-lint
 version: !ruby/object:Gem::Version
-  version: 1.0.7
+  version: 1.0.8
 platform: ruby
 authors:
 - Jerald Sheets
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-02-27 00:00:00.000000000 Z
+date: 2026-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -126,7 +126,7 @@ metadata:
   bug_tracker_uri: https://github.com/cvquesty/openvox-lint/issues
   changelog_uri: https://github.com/cvquesty/openvox-lint/blob/main/CHANGELOG.md
   rubygems_mfa_required: 'true'
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -141,8 +141,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3.1
-signing_key: 
+rubygems_version: 3.4.19
+signing_key:
 specification_version: 4
 summary: Check OpenVox/Puppet manifests against the style guide
 test_files: []