opentelemetry-metrics-sdk 0.18.0 → 0.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 30c3d77013ce3c1eae95194915c2bf428d9a34ad2afbd29560dcda6c21a1cbfe
-  data.tar.gz: e265066d90971699173482f848b00259081eaa4b335bb52126148863afa152d8
+  metadata.gz: 3f876db9fe6efa57838509b6ffc7e763f08f752f195169266d47fb5e87d7fba6
+  data.tar.gz: 397d5c293f18de20edb1c939cd750f4149a9944e70cd9b4c1f411559a4488bdd
 SHA512:
-  metadata.gz: 10b82812fae8f1f8727eb8f79532e370435878edc8996337caa9313b6a2af3b183487feb5f5c4fc61fec07d6cd75bbd05fee14eb7aa8331b8168949c075b1698
-  data.tar.gz: d91bc46c7dd8609486a78186947f025390d9bc8e039e142f9e5d5536aaf1199ca6416a6fb28234e80433fded78b2f1a282d9aae888fd8daf779d600bf6c3d23d
+  metadata.gz: e541f4daaa1e6c0228e22d297f18239e743917b16dcd047b9dfd2a87954fa68b0cfb1ba1401ca1274d7183610088790d6e45d9d79325859919673f4c31312083
+  data.tar.gz: cf8568c155bd447989b1082b0dc956d2f75fc7cfa2b333580c5067b4cf72ec01effdef928081f945dad097c6ffe170f2ab2274444cf5ac9780393617ccb1b9cc

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Release History: opentelemetry-metrics-sdk
 
+### v0.19.0 / 2026-09-29
+
+* BREAKING CHANGE: Update api for spec compliance (#2309)
+* ADDED: Update api for spec compliance (#2309)
+* ADDED: Move otlp exporter uri builder to common (#2240)
+* FIXED: Scope shared aggregation state to the owning stream (#2300) (#2314)
+* FIXED: Size exponential histogram exemplars (#2392)
+* FIXED: Accept arbitrary instrument metadata (#2395)
+* FIXED: Prevent readers spanning providers (#2393)
+
 ### v0.18.0 / 2026-09-09
 
 * BREAKING CHANGE: Align with the spec for metrics sdk and metrics otlp exporter (#2301)

data/lib/opentelemetry/sdk/metrics/aggregation/explicit_bucket_histogram.rb

@@ -11,6 +11,8 @@ module OpenTelemetry
         # Contains the implementation of the ExplicitBucketHistogram aggregation
         # https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#explicit-bucket-histogram-aggregation
         class ExplicitBucketHistogram # rubocop:disable Metrics/ClassLength
+          include StreamScopedStorage
+
           OVERFLOW_ATTRIBUTE_SET = { 'otel.metric.overflow' => true }.freeze
           attr_reader :exemplar_reservoir
 
@@ -31,7 +33,7 @@ module OpenTelemetry
             @boundaries = boundaries && !boundaries.empty? ? boundaries.sort : nil
             @record_min_max = record_min_max
             @exemplar_reservoir = exemplar_reservoir || Metrics::Exemplar::AlignedHistogramBucketExemplarReservoir.new(boundaries: @boundaries)
-            @exemplar_reservoir_storage = {}
+            @exemplar_reservoir_storage = new_stream_storage
           end
 
           # Returns the current histogram data points, clearing them for delta temporality.
@@ -41,8 +43,8 @@ module OpenTelemetry
               hdps = data_points.values.map! do |hdp|
                 hdp.start_time_unix_nano = start_time
                 hdp.time_unix_nano = end_time
-                reservoir = @exemplar_reservoir_storage[hdp.attributes]
-                hdp.exemplars = reservoir&.collect(attributes: hdp.attributes, aggregation_temporality: @aggregation_temporality)
+                reservoir = @exemplar_reservoir_storage[data_points][hdp.attributes]
+                hdp.exemplars = reservoir&.collect(attributes: hdp.attributes, aggregation_temporality: @aggregation_temporality.temporality)
                 hdp
               end
               data_points.clear
@@ -52,8 +54,8 @@ module OpenTelemetry
               data_points.values.map! do |hdp|
                 hdp.start_time_unix_nano ||= start_time # Start time of a data point is from the first observation.
                 hdp.time_unix_nano = end_time
-                reservoir = @exemplar_reservoir_storage[hdp.attributes]
-                hdp.exemplars = reservoir&.collect(attributes: hdp.attributes, aggregation_temporality: @aggregation_temporality)
+                reservoir = @exemplar_reservoir_storage[data_points][hdp.attributes]
+                hdp.exemplars = reservoir&.collect(attributes: hdp.attributes, aggregation_temporality: @aggregation_temporality.temporality)
                 hdp = hdp.dup
                 hdp.bucket_counts = hdp.bucket_counts.dup
                 hdp
@@ -71,7 +73,7 @@ module OpenTelemetry
                     create_new_data_point(attributes, data_points)
                   end
 
-            update_histogram_data_point(hdp, amount, exemplar_offer: exemplar_offer)
+            update_histogram_data_point(hdp, amount, data_points, exemplar_offer: exemplar_offer)
             nil
           end
 
@@ -103,8 +105,8 @@ module OpenTelemetry
             )
           end
 
-          def update_histogram_data_point(hdp, amount, exemplar_offer: false)
-            reservior_update(hdp.attributes, amount, exemplar_offer)
+          def update_histogram_data_point(hdp, amount, stream_key, exemplar_offer: false)
+            reservior_update(hdp.attributes, amount, exemplar_offer, stream_key)
 
             if @record_min_max
               hdp.max = amount if amount > hdp.max
@@ -119,12 +121,12 @@ module OpenTelemetry
             hdp.bucket_counts[bucket_index] += 1
           end
 
-          def reservior_update(attributes, amount, exemplar_offer)
-            reservoir = @exemplar_reservoir_storage[attributes]
+          def reservior_update(attributes, amount, exemplar_offer, stream_key)
+            reservoir = @exemplar_reservoir_storage[stream_key][attributes]
             unless reservoir
               reservoir = @exemplar_reservoir.dup
               reservoir.reset
-              @exemplar_reservoir_storage[attributes] = reservoir
+              @exemplar_reservoir_storage[stream_key][attributes] = reservoir
             end
 
             return unless exemplar_offer

data/lib/opentelemetry/sdk/metrics/aggregation/exponential_bucket_histogram.rb

@@ -17,6 +17,8 @@ module OpenTelemetry
       module Aggregation
         # Contains the implementation of the {https://opentelemetry.io/docs/specs/otel/metrics/data-model/#exponentialhistogram ExponentialBucketHistogram} aggregation
         class ExponentialBucketHistogram # rubocop:disable Metrics/ClassLength
+          include StreamScopedStorage
+
           OVERFLOW_ATTRIBUTE_SET = { 'otel.metric.overflow' => true }.freeze
 
           # relate to min max scale: https://opentelemetry.io/docs/specs/otel/metrics/sdk/#support-a-minimum-and-maximum-scale
@@ -29,10 +31,6 @@ module OpenTelemetry
 
           attr_reader :exemplar_reservoir
 
-          # if no reservoir pass from instrument, then use this empty reservoir to avoid no method found error
-          DEFAULT_RESERVOIR = Metrics::Exemplar::SimpleFixedSizeExemplarReservoir.new
-          private_constant :DEFAULT_RESERVOIR
-
           # The default boundaries are calculated based on default max_size and max_scale values
           def initialize(
             aggregation_temporality: ENV.fetch('OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE', :delta),
@@ -53,46 +51,58 @@ module OpenTelemetry
             @size           = validate_size(max_size)
             @scale          = validate_scale(max_scale)
 
-            @exemplar_reservoir = exemplar_reservoir || DEFAULT_RESERVOIR
-            @exemplar_reservoir_storage = {}
+            @exemplar_reservoir = exemplar_reservoir || Metrics::Exemplar::SimpleFixedSizeExemplarReservoir.new(max_size: [20, @size].min)
+            @exemplar_reservoir_storage = new_stream_storage
 
             @mapping = new_mapping(@scale)
 
             # Previous state for cumulative aggregation
-            @previous_positive = {} # nil
-            @previous_negative = {} # nil
-            @previous_min = {} # Float::INFINITY
-            @previous_max = {} # -Float::INFINITY
-            @previous_sum = {} # 0
-            @previous_count = {} # 0
-            @previous_zero_count = {} # 0
-            @previous_scale = {} # nil
-
-            # Cache mappings per attribute set
-            @mappings = {}
-            @previous_mappings = {}
+            @previous_positive = new_stream_storage # nil
+            @previous_negative = new_stream_storage # nil
+            @previous_min = new_stream_storage # Float::INFINITY
+            @previous_max = new_stream_storage # -Float::INFINITY
+            @previous_sum = new_stream_storage # 0
+            @previous_count = new_stream_storage # 0
+            @previous_zero_count = new_stream_storage # 0
+            @previous_scale = new_stream_storage # nil
+
+            @mappings = new_stream_storage
+            @previous_mappings = new_stream_storage
           end
 
           # when aggregation temporality is cumulative, merge and downscale will happen.
           # rubocop:disable-next Metrics/MethodLength
           def collect(start_time, end_time, data_points)
+            stream_key = data_points
+            stream_exemplar_reservoir_storage = @exemplar_reservoir_storage[stream_key]
+
             if @aggregation_temporality.delta?
               # Set timestamps and 'move' data point values to result.
               hdps = data_points.values.map! do |hdp|
                 hdp.start_time_unix_nano = start_time
                 hdp.time_unix_nano = end_time
-                reservoir = @exemplar_reservoir_storage[hdp.attributes]
-                hdp.exemplars = reservoir&.collect(attributes: hdp.attributes, aggregation_temporality: @aggregation_temporality)
+                reservoir = stream_exemplar_reservoir_storage[hdp.attributes]
+                hdp.exemplars = reservoir&.collect(attributes: hdp.attributes, aggregation_temporality: @aggregation_temporality.temporality)
                 hdp
               end
               data_points.clear
-              @mappings.clear
+              @mappings.delete(stream_key)
               hdps
             else
               # CUMULATIVE temporality - merge current data_points to previous data_points
               # and only keep the merged data_points in @previous_*
 
               merged_data_points = {}
+              stream_previous_positive = @previous_positive[stream_key]
+              stream_previous_negative = @previous_negative[stream_key]
+              stream_previous_min = @previous_min[stream_key]
+              stream_previous_max = @previous_max[stream_key]
+              stream_previous_sum = @previous_sum[stream_key]
+              stream_previous_count = @previous_count[stream_key]
+              stream_previous_zero_count = @previous_zero_count[stream_key]
+              stream_previous_scale = @previous_scale[stream_key]
+              stream_mappings = @mappings[stream_key]
+              stream_previous_mappings = @previous_mappings[stream_key]
 
               # this will slow down the operation especially if large amount of data_points present
               # but it should be fine since with cumulative, the data_points are merged into previous_* and not kept in data_points
@@ -108,25 +118,25 @@ module OpenTelemetry
                 current_scale = hdp.scale
 
                 # Setup previous positive, negative bucket and scale based on three different cases
-                @previous_positive[attributes] = current_positive.copy_empty if @previous_positive[attributes].nil?
-                @previous_negative[attributes] = current_negative.copy_empty if @previous_negative[attributes].nil?
-                @previous_scale[attributes] = current_scale if @previous_scale[attributes].nil?
+                stream_previous_positive[attributes] = current_positive.copy_empty if stream_previous_positive[attributes].nil?
+                stream_previous_negative[attributes] = current_negative.copy_empty if stream_previous_negative[attributes].nil?
+                stream_previous_scale[attributes] = current_scale if stream_previous_scale[attributes].nil?
 
                 # Determine minimum scale for merging
-                min_scale = [@previous_scale[attributes], current_scale].min
+                min_scale = [stream_previous_scale[attributes], current_scale].min
 
                 # Calculate ranges for positive and negative buckets
                 low_positive, high_positive = get_low_high_previous_current(
-                  @previous_positive[attributes],
+                  stream_previous_positive[attributes],
                   current_positive,
-                  @previous_scale[attributes],
+                  stream_previous_scale[attributes],
                   current_scale,
                   min_scale
                 )
                 low_negative, high_negative = get_low_high_previous_current(
-                  @previous_negative[attributes],
+                  stream_previous_negative[attributes],
                   current_negative,
-                  @previous_scale[attributes],
+                  stream_previous_scale[attributes],
                   current_scale,
                   min_scale
                 )
@@ -138,79 +148,79 @@ module OpenTelemetry
                 ].min
 
                 # Downscale previous buckets if necessary
-                downscale_change = @previous_scale[attributes] - min_scale
-                downscale(downscale_change, @previous_positive[attributes], @previous_negative[attributes])
+                downscale_change = stream_previous_scale[attributes] - min_scale
+                downscale(downscale_change, stream_previous_positive[attributes], stream_previous_negative[attributes])
 
                 # Merge current buckets into previous buckets (kind like update); it's always :cumulative
-                merge_buckets(@previous_positive[attributes], current_positive, current_scale, min_scale, @aggregation_temporality)
-                merge_buckets(@previous_negative[attributes], current_negative, current_scale, min_scale, @aggregation_temporality)
+                merge_buckets(stream_previous_positive[attributes], current_positive, current_scale, min_scale, @aggregation_temporality)
+                merge_buckets(stream_previous_negative[attributes], current_negative, current_scale, min_scale, @aggregation_temporality)
 
                 # initialize min, max, sum, count, zero_count for first time
-                @previous_min[attributes] = Float::INFINITY if @previous_min[attributes].nil?
-                @previous_max[attributes] = -Float::INFINITY if @previous_max[attributes].nil?
-                @previous_sum[attributes] = 0 if @previous_sum[attributes].nil?
-                @previous_count[attributes] = 0 if @previous_count[attributes].nil?
-                @previous_zero_count[attributes] = 0 if @previous_zero_count[attributes].nil?
+                stream_previous_min[attributes] = Float::INFINITY if stream_previous_min[attributes].nil?
+                stream_previous_max[attributes] = -Float::INFINITY if stream_previous_max[attributes].nil?
+                stream_previous_sum[attributes] = 0 if stream_previous_sum[attributes].nil?
+                stream_previous_count[attributes] = 0 if stream_previous_count[attributes].nil?
+                stream_previous_zero_count[attributes] = 0 if stream_previous_zero_count[attributes].nil?
 
                 # Update aggregated values
-                @previous_min[attributes] = [@previous_min[attributes], current_min].min
-                @previous_max[attributes] = [@previous_max[attributes], current_max].max
-                @previous_sum[attributes] += current_sum
-                @previous_count[attributes] += current_count
-                @previous_zero_count[attributes] += current_zero_count
-                @previous_scale[attributes] = min_scale
+                stream_previous_min[attributes] = [stream_previous_min[attributes], current_min].min
+                stream_previous_max[attributes] = [stream_previous_max[attributes], current_max].max
+                stream_previous_sum[attributes] += current_sum
+                stream_previous_count[attributes] += current_count
+                stream_previous_zero_count[attributes] += current_zero_count
+                stream_previous_scale[attributes] = min_scale
 
                 # Create merged data point
-                reservoir = @exemplar_reservoir_storage[attributes]
+                reservoir = stream_exemplar_reservoir_storage[attributes]
                 merged_hdp = ExponentialHistogramDataPoint.new(
                   attributes,
                   start_time,
                   end_time,
-                  @previous_count[attributes],
-                  @previous_sum[attributes],
-                  @previous_scale[attributes],
-                  @previous_zero_count[attributes],
-                  @previous_positive[attributes].dup,
-                  @previous_negative[attributes].dup,
+                  stream_previous_count[attributes],
+                  stream_previous_sum[attributes],
+                  stream_previous_scale[attributes],
+                  stream_previous_zero_count[attributes],
+                  stream_previous_positive[attributes].dup,
+                  stream_previous_negative[attributes].dup,
                   0, # flags
-                  reservoir&.collect(attributes: attributes, aggregation_temporality: @aggregation_temporality), # exemplars
-                  @previous_min[attributes],
-                  @previous_max[attributes],
+                  reservoir&.collect(attributes: attributes, aggregation_temporality: @aggregation_temporality.temporality), # exemplars
+                  stream_previous_min[attributes],
+                  stream_previous_max[attributes],
                   @zero_threshold
                 )
 
                 merged_data_points[attributes] = merged_hdp
-                @previous_mappings[attributes] = @mappings[attributes] if @mappings[attributes] # Preserve mapping for next collection
+                stream_previous_mappings[attributes] = stream_mappings[attributes] if stream_mappings[attributes] # Preserve mapping for next collection
               end
 
               # when you have no local_data_points, the loop from cumulative aggregation will not run
               # so return last merged data points if exists
-              if data_points.empty? && !@previous_positive.empty?
-                @previous_positive.each_key do |attributes|
-                  reservoir = @exemplar_reservoir_storage[attributes]
+              if data_points.empty? && !stream_previous_positive.empty?
+                stream_previous_positive.each_key do |attributes|
+                  reservoir = stream_exemplar_reservoir_storage[attributes]
                   merged_hdp = ExponentialHistogramDataPoint.new(
                     attributes,
                     start_time,
                     end_time,
-                    @previous_count[attributes],
-                    @previous_sum[attributes],
-                    @previous_scale[attributes],
-                    @previous_zero_count[attributes],
-                    @previous_positive[attributes].dup,
-                    @previous_negative[attributes].dup,
+                    stream_previous_count[attributes],
+                    stream_previous_sum[attributes],
+                    stream_previous_scale[attributes],
+                    stream_previous_zero_count[attributes],
+                    stream_previous_positive[attributes].dup,
+                    stream_previous_negative[attributes].dup,
                     0, # flags
-                    reservoir&.collect(attributes: attributes, aggregation_temporality: @aggregation_temporality), # exemplars
-                    @previous_min[attributes],
-                    @previous_max[attributes],
+                    reservoir&.collect(attributes: attributes, aggregation_temporality: @aggregation_temporality.temporality), # exemplars
+                    stream_previous_min[attributes],
+                    stream_previous_max[attributes],
                     @zero_threshold
                   )
                   merged_data_points[attributes] = merged_hdp
                 end
               end
 
-              # Swap current with previous mappings for next cycle
-              @mappings = @previous_mappings
-              @previous_mappings = {}
+              # Swap current with previous mappings for next cycle, for this stream only
+              @mappings[stream_key] = stream_previous_mappings
+              @previous_mappings[stream_key] = {}
 
               # clear data_points since the data is merged into previous_* already;
               # otherwise we will have duplicated data_points in the next collect
@@ -229,7 +239,7 @@ module OpenTelemetry
                     create_new_data_point(attributes, data_points)
                   end
 
-            update_histogram_data_point(hdp, attributes, amount, exemplar_offer: exemplar_offer)
+            update_histogram_data_point(hdp, attributes, amount, data_points, exemplar_offer: exemplar_offer)
             nil
           end
 
@@ -265,8 +275,8 @@ module OpenTelemetry
           end
 
           # rubocop:disable-next Metrics/CyclomaticComplexity,Metrics/MethodLength
-          def update_histogram_data_point(hdp, attributes, amount, exemplar_offer: false)
-            reservior_update(attributes, amount, exemplar_offer)
+          def update_histogram_data_point(hdp, attributes, amount, stream_key, exemplar_offer: false)
+            reservior_update(attributes, amount, exemplar_offer, stream_key)
 
             if @record_min_max
               hdp.max = amount if amount > hdp.max
@@ -289,11 +299,11 @@ module OpenTelemetry
             # Reset scale to max_scale if transitioning from all-zeros to first non-zero value
             if buckets.counts == [0] && hdp.scale == 0 && hdp.count > hdp.zero_count
               hdp.scale = @scale
-              @mappings.delete(attributes) # Clear any cached mapping
+              @mappings[stream_key].delete(attributes) # Clear any cached mapping
             end
 
             # Get or create mapping for this attribute set
-            mapping = @mappings[attributes] ||= new_mapping(hdp.scale)
+            mapping = @mappings[stream_key][attributes] ||= new_mapping(hdp.scale)
             bucket_index = mapping.map_to_index(amount)
 
             rescaling_needed = false
@@ -320,7 +330,7 @@ module OpenTelemetry
               downscale(scale_change, hdp.positive, hdp.negative)
               new_scale = mapping.scale - scale_change
               mapping = new_mapping(new_scale)
-              @mappings[attributes] = mapping # Update cache
+              @mappings[stream_key][attributes] = mapping # Update cache
               bucket_index = mapping.map_to_index(amount)
 
               OpenTelemetry.logger.debug "Rescaled with new scale #{new_scale} from #{low} and #{high}; bucket_index is updated to #{bucket_index}"
@@ -352,12 +362,12 @@ module OpenTelemetry
             buckets.grow(span + 1, @size)
           end
 
-          def reservior_update(attributes, amount, exemplar_offer)
-            reservoir = @exemplar_reservoir_storage[attributes]
+          def reservior_update(attributes, amount, exemplar_offer, stream_key)
+            reservoir = @exemplar_reservoir_storage[stream_key][attributes]
             unless reservoir
               reservoir = @exemplar_reservoir.dup
               reservoir.reset
-              @exemplar_reservoir_storage[attributes] = reservoir
+              @exemplar_reservoir_storage[stream_key][attributes] = reservoir
             end
 
             return unless exemplar_offer

data/lib/opentelemetry/sdk/metrics/aggregation/last_value.rb

@@ -10,6 +10,8 @@ module OpenTelemetry
       module Aggregation
         # Contains the implementation of the LastValue aggregation
         class LastValue
+          include StreamScopedStorage
+
           OVERFLOW_ATTRIBUTE_SET = { 'otel.metric.overflow' => true }.freeze
           attr_reader :exemplar_reservoir
 
@@ -19,15 +21,17 @@ module OpenTelemetry
 
           def initialize(exemplar_reservoir: nil)
             @exemplar_reservoir = exemplar_reservoir || DEFAULT_RESERVOIR
-            @exemplar_reservoir_storage = {}
+            @exemplar_reservoir_storage = new_stream_storage
           end
 
           # Returns the current data points, clearing them for delta temporality.
           def collect(start_time, end_time, data_points)
+            stream_exemplar_reservoir_storage = @exemplar_reservoir_storage[data_points]
+
             ndps = data_points.values.map! do |ndp|
               ndp.start_time_unix_nano = start_time
               ndp.time_unix_nano = end_time
-              reservoir = @exemplar_reservoir_storage[ndp.attributes]
+              reservoir = stream_exemplar_reservoir_storage[ndp.attributes]
               ndp.exemplars = reservoir&.collect(attributes: ndp.attributes, aggregation_temporality: :delta)
               ndp
             end
@@ -46,7 +50,7 @@ module OpenTelemetry
                     create_new_data_point(attributes, data_points)
                   end
 
-            update_number_data_point(ndp, increment, exemplar_offer: exemplar_offer)
+            update_number_data_point(ndp, increment, data_points, exemplar_offer: exemplar_offer)
             nil
           end
 
@@ -63,17 +67,17 @@ module OpenTelemetry
             )
           end
 
-          def update_number_data_point(ndp, increment, exemplar_offer: false)
+          def update_number_data_point(ndp, increment, stream_key, exemplar_offer: false)
             ndp.value = increment
-            reservior_update(ndp.attributes, increment, exemplar_offer)
+            reservior_update(ndp.attributes, increment, exemplar_offer, stream_key)
           end
 
-          def reservior_update(attributes, increment, exemplar_offer)
-            reservoir = @exemplar_reservoir_storage[attributes]
+          def reservior_update(attributes, increment, exemplar_offer, stream_key)
+            reservoir = @exemplar_reservoir_storage[stream_key][attributes]
             unless reservoir
               reservoir = @exemplar_reservoir.dup
               reservoir.reset
-              @exemplar_reservoir_storage[attributes] = reservoir
+              @exemplar_reservoir_storage[stream_key][attributes] = reservoir
             end
 
             return unless exemplar_offer

data/lib/opentelemetry/sdk/metrics/aggregation/stream_scoped_storage.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+# Copyright The OpenTelemetry Authors
+#
+# SPDX-License-Identifier: Apache-2.0
+
+module OpenTelemetry
+  module SDK
+    module Metrics
+      module Aggregation
+        # Builds the nested storage aggregations use to keep per-stream state
+        # apart, since a wildcard or regex view shares one aggregation instance
+        # across every stream it matches.
+        module StreamScopedStorage
+          private
+
+          # Streams are keyed by their +data_points+ hash, which is mutable, so
+          # the outer hash must compare by identity rather than by value.
+          def new_stream_storage
+            Hash.new { |h, k| h[k] = {} }.compare_by_identity
+          end
+        end
+      end
+    end
+  end
+end

data/lib/opentelemetry/sdk/metrics/aggregation/sum.rb

@@ -10,6 +10,8 @@ module OpenTelemetry
       module Aggregation
         # Contains the implementation of the Sum aggregation
         class Sum
+          include StreamScopedStorage
+
           OVERFLOW_ATTRIBUTE_SET = { 'otel.metric.overflow' => true }.freeze
           attr_reader :exemplar_reservoir
 
@@ -24,18 +26,20 @@ module OpenTelemetry
             @aggregation_temporality = AggregationTemporality.determine_temporality(aggregation_temporality: aggregation_temporality, instrument_kind: instrument_kind, default: :cumulative)
             @monotonic = monotonic
             @exemplar_reservoir = exemplar_reservoir || DEFAULT_RESERVOIR
-            @exemplar_reservoir_storage = {}
+            @exemplar_reservoir_storage = new_stream_storage
           end
 
           # Returns the current sum data points, clearing them for delta temporality.
           def collect(start_time, end_time, data_points)
+            stream_exemplar_reservoir_storage = @exemplar_reservoir_storage[data_points]
+
             if @aggregation_temporality.delta?
               # Set timestamps and 'move' data point values to result.
               ndps = data_points.values.map! do |ndp|
                 ndp.start_time_unix_nano = start_time
                 ndp.time_unix_nano = end_time
-                reservoir = @exemplar_reservoir_storage[ndp.attributes]
-                ndp.exemplars = reservoir&.collect(attributes: ndp.attributes, aggregation_temporality: @aggregation_temporality)
+                reservoir = stream_exemplar_reservoir_storage[ndp.attributes]
+                ndp.exemplars = reservoir&.collect(attributes: ndp.attributes, aggregation_temporality: @aggregation_temporality.temporality)
                 ndp
               end
               data_points.clear
@@ -45,8 +49,8 @@ module OpenTelemetry
               data_points.values.map! do |ndp|
                 ndp.start_time_unix_nano ||= start_time # Start time of a data point is from the first observation.
                 ndp.time_unix_nano = end_time
-                reservoir = @exemplar_reservoir_storage[ndp.attributes]
-                ndp.exemplars = reservoir&.collect(attributes: ndp.attributes, aggregation_temporality: @aggregation_temporality)
+                reservoir = stream_exemplar_reservoir_storage[ndp.attributes]
+                ndp.exemplars = reservoir&.collect(attributes: ndp.attributes, aggregation_temporality: @aggregation_temporality.temporality)
                 ndp.dup
               end
             end
@@ -65,7 +69,7 @@ module OpenTelemetry
                     create_new_data_point(attributes, data_points)
                   end
 
-            update_number_data_point(ndp, increment, exemplar_offer: exemplar_offer)
+            update_number_data_point(ndp, increment, data_points, exemplar_offer: exemplar_offer)
             nil
           end
 
@@ -92,17 +96,17 @@ module OpenTelemetry
             )
           end
 
-          def update_number_data_point(ndp, increment, exemplar_offer: false)
-            reservior_update(ndp.attributes, increment, exemplar_offer)
+          def update_number_data_point(ndp, increment, stream_key, exemplar_offer: false)
+            reservior_update(ndp.attributes, increment, exemplar_offer, stream_key)
             ndp.value += increment
           end
 
-          def reservior_update(attributes, increment, exemplar_offer)
-            reservoir = @exemplar_reservoir_storage[attributes]
+          def reservior_update(attributes, increment, exemplar_offer, stream_key)
+            reservoir = @exemplar_reservoir_storage[stream_key][attributes]
             unless reservoir
               reservoir = @exemplar_reservoir.dup
               reservoir.reset
-              @exemplar_reservoir_storage[attributes] = reservoir
+              @exemplar_reservoir_storage[stream_key][attributes] = reservoir
             end
 
             return unless exemplar_offer

data/lib/opentelemetry/sdk/metrics/aggregation.rb

@@ -16,6 +16,7 @@ module OpenTelemetry
 end
 
 require 'opentelemetry/sdk/metrics/aggregation/aggregation_temporality'
+require 'opentelemetry/sdk/metrics/aggregation/stream_scoped_storage'
 require 'opentelemetry/sdk/metrics/aggregation/number_data_point'
 require 'opentelemetry/sdk/metrics/aggregation/histogram_data_point'
 require 'opentelemetry/sdk/metrics/aggregation/explicit_bucket_histogram'

data/lib/opentelemetry/sdk/metrics/export/metric_reader.rb

@@ -12,12 +12,27 @@ module OpenTelemetry
         # It is not required to subclass this class to provide an implementation
         # of MetricReader, provided the interface is satisfied.
         class MetricReader
+          # Raised when a reader is registered with a second MeterProvider.
+          SINGLE_PROVIDER_ERROR = 'MetricReader cannot be registered with more than one MeterProvider'
+
+          private_constant :SINGLE_PROVIDER_ERROR
+
           attr_reader :metric_store
 
           def initialize(aggregation_cardinality_limit: nil)
+            @mutex = Mutex.new
             @metric_store = OpenTelemetry::SDK::Metrics::State::MetricStore.new(cardinality_limit: aggregation_cardinality_limit)
           end
 
+          # Registers this reader with a MeterProvider.
+          def register_meter_provider(meter_provider)
+            @mutex.synchronize do
+              raise ArgumentError, SINGLE_PROVIDER_ERROR if @meter_provider && !@meter_provider.equal?(meter_provider)
+
+              @meter_provider = meter_provider
+            end
+          end
+
           # Collects and returns the current metrics from the metric store.
           def collect
             @metric_store.collect

data/lib/opentelemetry/sdk/metrics/instrument/asynchronous_instrument.rb

@@ -53,7 +53,9 @@ module OpenTelemetry
           # The API MUST support creation of asynchronous instruments by passing zero or more callback functions
           # to be permanently registered to the newly created instrument.
           def init_callback(callback)
-            if callback.instance_of?(Proc)
+            if callback.nil?
+              nil # zero callbacks permanently registered at creation is permitted
+            elsif callback.instance_of?(Proc)
               @callbacks << callback
             elsif callback.instance_of?(Array)
               callback.each { |cb| @callbacks << cb if cb.instance_of?(Proc) }

data/lib/opentelemetry/sdk/metrics/meter.rb

@@ -63,12 +63,14 @@ module OpenTelemetry
         end
 
         # Validates the given instrument options and creates the instrument of the given kind.
-        def create_instrument(kind, name, unit, description, callback, exemplar_filter, exemplar_reservoir)
+        # TODO: advisory parameters are accepted but not yet applied to stream configuration.
+        def create_instrument(kind, name, unit, description, callback, exemplar_filter, exemplar_reservoir, advisory)
           raise InstrumentNameError if name.nil?
           raise InstrumentNameError if name.empty?
           raise InstrumentNameError unless NAME_REGEX.match?(name)
-          raise InstrumentUnitError if unit && (!unit.ascii_only? || unit.size > 63)
-          raise InstrumentDescriptionError if description && (description.size > 1023 || !utf8mb3_encoding?(description.dup))
+
+          unit ||= ''
+          description ||= ''
 
           super do
             case kind
@@ -82,12 +84,6 @@ module OpenTelemetry
             end
           end
         end
-
-        # Returns whether string is valid UTF-8 with no 4-byte (utf8mb4) characters.
-        def utf8mb3_encoding?(string)
-          string.force_encoding('UTF-8').valid_encoding? &&
-            string.each_char { |c| return false if c.bytesize >= 4 }
-        end
       end
     end
   end

data/lib/opentelemetry/sdk/metrics/meter_provider.rb

@@ -13,6 +13,11 @@ module OpenTelemetry
       # rubocop:disable-next Metrics/ClassLength
       class MeterProvider < OpenTelemetry::Metrics::MeterProvider
         EMPTY_ATTRIBUTES = {}.freeze
+        READER_OWNERS = ObjectSpace::WeakMap.new
+        READER_OWNERS_MUTEX = Mutex.new
+        READER_OWNERSHIP_ERROR = 'MetricReader cannot be registered with more than one MeterProvider'
+
+        private_constant :READER_OWNERS, :READER_OWNERS_MUTEX, :READER_OWNERSHIP_ERROR
 
         Key = Struct.new(:name, :version, :attributes)
         private_constant(:Key)
@@ -118,6 +123,7 @@ module OpenTelemetry
             if @stopped
               OpenTelemetry.logger.warn('calling MetricProvider#add_metric_reader after shutdown.')
             else
+              register_metric_reader(metric_reader)
               @metric_readers.push(metric_reader)
               @meter_registry.each_value { |meter| meter.add_metric_reader(metric_reader) }
             end
@@ -126,6 +132,18 @@ module OpenTelemetry
           end
         end
 
+        def register_metric_reader(metric_reader)
+          READER_OWNERS_MUTEX.synchronize do
+            owner = READER_OWNERS[metric_reader]
+            raise ArgumentError, READER_OWNERSHIP_ERROR if owner && !owner.equal?(self)
+
+            READER_OWNERS[metric_reader] = self
+          end
+
+          metric_reader.register_meter_provider(self) if metric_reader.respond_to?(:register_meter_provider)
+        end
+        private :register_metric_reader
+
         # @api private
         def register_synchronous_instrument(instrument)
           @mutex.synchronize do

data/lib/opentelemetry/sdk/metrics/version.rb

@@ -8,7 +8,7 @@ module OpenTelemetry
   module SDK
     module Metrics
       # Current OpenTelemetry metrics sdk version
-      VERSION = '0.18.0'
+      VERSION = '0.19.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: opentelemetry-metrics-sdk
 version: !ruby/object:Gem::Version
-  version: 0.18.0
+  version: 0.19.0
 platform: ruby
 authors:
 - OpenTelemetry Authors
@@ -78,6 +78,7 @@ files:
 - lib/opentelemetry/sdk/metrics/aggregation/histogram_data_point.rb
 - lib/opentelemetry/sdk/metrics/aggregation/last_value.rb
 - lib/opentelemetry/sdk/metrics/aggregation/number_data_point.rb
+- lib/opentelemetry/sdk/metrics/aggregation/stream_scoped_storage.rb
 - lib/opentelemetry/sdk/metrics/aggregation/sum.rb
 - lib/opentelemetry/sdk/metrics/configurator_patch.rb
 - lib/opentelemetry/sdk/metrics/exemplar.rb
@@ -121,10 +122,10 @@ homepage: https://github.com/open-telemetry/opentelemetry-ruby
 licenses:
 - Apache-2.0
 metadata:
-  changelog_uri: https://rubydoc.info/gems/opentelemetry-metrics-sdk/0.18.0/file/CHANGELOG.md
-  source_code_uri: https://github.com/open-telemetry/opentelemetry-ruby/tree/opentelemetry-metrics-sdk/v0.18.0/metrics_sdk
+  changelog_uri: https://rubydoc.info/gems/opentelemetry-metrics-sdk/0.19.0/file/CHANGELOG.md
+  source_code_uri: https://github.com/open-telemetry/opentelemetry-ruby/tree/opentelemetry-metrics-sdk/v0.19.0/metrics_sdk
   bug_tracker_uri: https://github.com/open-telemetry/opentelemetry-ruby/issues
-  documentation_uri: https://rubydoc.info/gems/opentelemetry-metrics-sdk/0.18.0
+  documentation_uri: https://rubydoc.info/gems/opentelemetry-metrics-sdk/0.19.0
 rdoc_options: []
 require_paths:
 - lib
@@ -139,7 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.16
+rubygems_version: 4.0.20
 specification_version: 4
 summary: A stats collection and distributed tracing framework
 test_files: []