opentelemetry-instrumentation-sinatra 0.21.3 → 0.21.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 822814bc143062681bae4c966a65bc9e2ca8662c6ba68a9d1d9a3ab18eb3686b
-  data.tar.gz: 6a93b2c9632764e5a1faf764c20028e72e86064c2acf0f1d116bc4000ed700df
+  metadata.gz: 85b1b440635f35ac1e5bc03c523595be638bb891410583e0a187b4383f2a6fd3
+  data.tar.gz: 271f907ceada618172ba071a1233c7ab6bea435088576c8a6a7851156eaadf49
 SHA512:
-  metadata.gz: ad23ae956e284ebf96e1d328e4074e834df0fc4bd04fbe9540ac3ee7abdef3d2b414c4142cfda1338504e2595d2384ace4e2c750c706b840dd200cfee5ff8d3d
-  data.tar.gz: 2aa584a56bb111aa5d9a5a08744986e993dc945d43bedf01f4ca1884c7cd7146412e0805a24af3ae71f28f2c3781538ca6b8739738872a70ec11a638210d1b99
+  metadata.gz: 6a80a8025ec62917cc02e837195e8ce986986598a8ca3e32a1c53f9858a2ae5f18d5d958aa74b133592bd5ece74731673c37605b237c66c27146ea5116399f09
+  data.tar.gz: 3e3a1ee118b6befbe56f510e0c6b1befa2692c4aab7c16050a3de8e04a145f5855d5628042eb23b250b9a9a1d4a925b6f0933384a72fc7e0911bc2c716775092

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Release History: opentelemetry-instrumentation-sinatra
 
+### v0.21.4 / 2023-02-08
+
+* CHANGED: incorrect error type being recorded when Sinatra route raises exception [#317](https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/317)
+
 ### v0.21.3 / 2023-01-27
 
 * fix: Check if env['sinatra.error'] exists before recording it

data/lib/opentelemetry/instrumentation/sinatra/middlewares/tracer_middleware.rb

@@ -16,23 +16,17 @@ module OpenTelemetry
           end
 
           def call(env)
-            response = @app.call(env)
+            @app.call(env)
           ensure
-            trace_response(env, response)
+            trace_response(env)
           end
 
-          def trace_response(env, response)
+          def trace_response(env)
             span = OpenTelemetry::Instrumentation::Rack.current_span
             return unless span.recording?
 
             span.set_attribute('http.route', env['sinatra.route'].split.last) if env['sinatra.route']
             span.name = env['sinatra.route'] if env['sinatra.route']
-
-            sinatra_response = ::Sinatra::Response.new([], response.first)
-            return unless sinatra_response.server_error?
-
-            span.record_exception(env['sinatra.error']) if env['sinatra.error']
-            span.status = OpenTelemetry::Trace::Status.error
           end
         end
       end

data/lib/opentelemetry/instrumentation/sinatra/version.rb

@@ -7,7 +7,7 @@
 module OpenTelemetry
   module Instrumentation
     module Sinatra
-      VERSION = '0.21.3'
+      VERSION = '0.21.4'
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opentelemetry-instrumentation-sinatra
 version: !ruby/object:Gem::Version
-  version: 0.21.3
+  version: 0.21.4
 platform: ruby
 authors:
 - OpenTelemetry Authors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-01-27 00:00:00.000000000 Z
+date: 2023-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opentelemetry-api
@@ -256,10 +256,10 @@ homepage: https://github.com/open-telemetry/opentelemetry-ruby-contrib
 licenses:
 - Apache-2.0
 metadata:
-  changelog_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-sinatra/0.21.3/file/CHANGELOG.md
+  changelog_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-sinatra/0.21.4/file/CHANGELOG.md
   source_code_uri: https://github.com/open-telemetry/opentelemetry-ruby-contrib/tree/main/instrumentation/sinatra
   bug_tracker_uri: https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues
-  documentation_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-sinatra/0.21.3
+  documentation_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-sinatra/0.21.4
 post_install_message: 
 rdoc_options: []
 require_paths: