opentelemetry-instrumentation-http_client 0.23.0 → 0.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe6f37521f681de95b88a4fd17616376999983a898255f789d711404d54abe8a
-  data.tar.gz: 4425ea04967fc871beb86cdacd38b8be6bd407ed5ad3aa33147bf59114870448
+  metadata.gz: 60b3ed3e8e11d1726975a033df4ba872f039d45732369de647a8429c2b43df6a
+  data.tar.gz: ad8704c3b61d5c5833b361217c88f1e396264ea5b2c8d5a6275da358e85e4945
 SHA512:
-  metadata.gz: 5bd10af4512744aac6014fb71164891fe862ceb0295c52117c333e903cda8a379112082cd979d483f0382e11795ae69d03e18b2c79c86c9744831a9543613dfa
-  data.tar.gz: f8b5be2ca54a5c14700ecbee6d3ca03b707582c3a8a427939f588f316886d2a835a6f0d79abd00d9a46cbaa2706eee9335eb326c2dfcabadabeedbf8f7a03258
+  metadata.gz: 86fb5beb404148d290b468b46f6d8ff6287b2fd6c4a62e7839267951b58ff264d9698f44af86726b3da763e956c264bc7cfd6f1df3d5ed1c77afa9bbb3ead963
+  data.tar.gz: 01aab5af766e9b0b8c988d52c8673b75cce65574b08e0dc530119eabd80198593708817802d08b3d31838f677ce4d2dff1c35d9eb1c8f42e2cdafcd0c704d951

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Release History: opentelemetry-instrumentation-http_client
 
+### v0.24.0 / 2025-07-29
+
+* ADDED: Add HTTPClient `OTEL_SEMCONV_STABILITY_OPT_IN` environment variable [#1588](https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/1588)
+
 ### v0.23.0 / 2025-01-16
 
 * BREAKING CHANGE: Set minimum supported version to Ruby 3.1

data/README.md

@@ -32,7 +32,7 @@ end
 
 ## Examples
 
-Example usage can be seen in the `./example/trace_demonstration.rb` file [here](https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/main/instrumentation/http_client/example/trace_demonstration.rb)
+Example usage can be seen in the [`./example/trace_demonstration.rb` file](https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/main/instrumentation/http_client/example/trace_demonstration.rb)
 
 ## How can I get involved?
 
@@ -52,3 +52,19 @@ The `opentelemetry-instrumentation-http_client` gem is distributed under the Apa
 [community-meetings]: https://github.com/open-telemetry/community#community-meetings
 [slack-channel]: https://cloud-native.slack.com/archives/C01NWKKMKMY
 [discussions-url]: https://github.com/open-telemetry/opentelemetry-ruby/discussions
+
+## HTTP semantic convention stability
+
+In the OpenTelemetry ecosystem, HTTP semantic conventions have now reached a stable state. However, the initial HttpClient instrumentation was introduced before this stability was achieved, which resulted in HTTP attributes being based on an older version of the semantic conventions.
+
+To facilitate the migration to stable semantic conventions, you can use the `OTEL_SEMCONV_STABILITY_OPT_IN` environment variable. This variable allows you to opt-in to the new stable conventions, ensuring compatibility and future-proofing your instrumentation.
+
+When setting the value for `OTEL_SEMCONV_STABILITY_OPT_IN`, you can specify which conventions you wish to adopt:
+
+- `http` - Emits the stable HTTP and networking conventions and ceases emitting the old conventions previously emitted by the instrumentation.
+- `http/dup` - Emits both the old and stable HTTP and networking conventions, enabling a phased rollout of the stable semantic conventions.
+- Default behavior (in the absence of either value) is to continue emitting the old HTTP and networking conventions the instrumentation previously emitted.
+
+During the transition from old to stable conventions, HttpClient instrumentation code comes in three patch versions: `dup`, `old`, and `stable`. These versions are identical except for the attributes they send. Any changes to HttpClient instrumentation should consider all three patches.
+
+For additional information on migration, please refer to our [documentation](https://opentelemetry.io/docs/specs/semconv/non-normative/http-migration/).

data/lib/opentelemetry/instrumentation/http_client/instrumentation.rb

@@ -12,8 +12,9 @@ module OpenTelemetry
       # The Instrumentation class contains logic to detect and install the HttpClient instrumentation
       class Instrumentation < OpenTelemetry::Instrumentation::Base
         install do |_config|
-          require_dependencies
-          patch
+          patch_type = determine_semconv
+          send(:"require_dependencies_#{patch_type}")
+          send(:"patch_#{patch_type}")
         end
 
         present do
@@ -22,14 +23,47 @@ module OpenTelemetry
 
         private
 
-        def patch
-          ::HTTPClient.prepend(Patches::Client)
-          ::HTTPClient::Session.prepend(Patches::Session)
+        def determine_semconv
+          stability_opt_in = ENV.fetch('OTEL_SEMCONV_STABILITY_OPT_IN', '')
+          values = stability_opt_in.split(',').map(&:strip)
+
+          if values.include?('http/dup')
+            'dup'
+          elsif values.include?('http')
+            'stable'
+          else
+            'old'
+          end
+        end
+
+        def patch_dup
+          ::HTTPClient.prepend(Patches::Dup::Client)
+          ::HTTPClient::Session.prepend(Patches::Dup::Session)
+        end
+
+        def patch_old
+          ::HTTPClient.prepend(Patches::Old::Client)
+          ::HTTPClient::Session.prepend(Patches::Old::Session)
+        end
+
+        def patch_stable
+          ::HTTPClient.prepend(Patches::Stable::Client)
+          ::HTTPClient::Session.prepend(Patches::Stable::Session)
+        end
+
+        def require_dependencies_dup
+          require_relative 'patches/dup/client'
+          require_relative 'patches/dup/session'
+        end
+
+        def require_dependencies_old
+          require_relative 'patches/old/client'
+          require_relative 'patches/old/session'
         end
 
-        def require_dependencies
-          require_relative 'patches/client'
-          require_relative 'patches/session'
+        def require_dependencies_stable
+          require_relative 'patches/stable/client'
+          require_relative 'patches/stable/session'
         end
       end
     end

data/lib/opentelemetry/instrumentation/http_client/patches/dup/client.rb

@@ -0,0 +1,70 @@
+# frozen_string_literal: true
+
+# Copyright The OpenTelemetry Authors
+#
+# SPDX-License-Identifier: Apache-2.0
+
+module OpenTelemetry
+  module Instrumentation
+    module HttpClient
+      module Patches
+        module Dup
+          # Module to prepend to HTTPClient for instrumentation
+          module Client
+            # Constant for the HTTP status range
+            HTTP_STATUS_SUCCESS_RANGE = (100..399)
+
+            private
+
+            def do_get_block(req, proxy, conn, &)
+              uri = req.header.request_uri
+              url = "#{uri.scheme}://#{uri.host}"
+              request_method = req.header.request_method
+
+              attributes = {
+                'http.method' => request_method,
+                'http.scheme' => uri.scheme,
+                'http.target' => uri.path,
+                'http.url' => url,
+                'net.peer.name' => uri.host,
+                'net.peer.port' => uri.port,
+                # stable semantic conventions
+                'http.request.method' => request_method,
+                'url.scheme' => uri.scheme,
+                'url.path' => uri.path,
+                'url.full' => url,
+                'server.address' => uri.host,
+                'server.port' => uri.port
+              }.merge!(OpenTelemetry::Common::HTTP::ClientContext.attributes)
+
+              attributes['url.query'] = uri.query unless uri.query.nil?
+
+              tracer.in_span(request_method, attributes: attributes, kind: :client) do |span|
+                OpenTelemetry.propagation.inject(req.header)
+                super.tap do
+                  response = conn.pop
+                  annotate_span_with_response!(span, response)
+                  conn.push response
+                end
+              end
+            end
+
+            def annotate_span_with_response!(span, response)
+              return unless response&.status_code
+
+              status_code = response.status_code.to_i
+
+              span.set_attribute('http.status_code', status_code)
+              span.set_attribute('http.response.status_code', status_code)
+              span.status = OpenTelemetry::Trace::Status.error unless HTTP_STATUS_SUCCESS_RANGE.cover?(status_code)
+            end
+
+            def tracer
+              HttpClient::Instrumentation.instance.tracer
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/opentelemetry/instrumentation/http_client/patches/dup/session.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+# Copyright The OpenTelemetry Authors
+#
+# SPDX-License-Identifier: Apache-2.0
+
+module OpenTelemetry
+  module Instrumentation
+    module HttpClient
+      module Patches
+        module Dup
+          # Module to prepend to HTTPClient::Session for instrumentation
+          module Session
+            def connect
+              site = @proxy || @dest
+              url = site.addr
+
+              attributes = { 'http.url' => url, 'url.full' => url }.merge!(OpenTelemetry::Common::HTTP::ClientContext.attributes)
+              tracer.in_span('CONNECT', attributes: attributes) do
+                super
+              end
+            end
+
+            private
+
+            def tracer
+              HttpClient::Instrumentation.instance.tracer
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/opentelemetry/instrumentation/http_client/patches/old/client.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+# Copyright The OpenTelemetry Authors
+#
+# SPDX-License-Identifier: Apache-2.0
+
+module OpenTelemetry
+  module Instrumentation
+    module HttpClient
+      module Patches
+        module Old
+          # Module to prepend to HTTPClient for instrumentation
+          module Client
+            # Constant for the HTTP status range
+            HTTP_STATUS_SUCCESS_RANGE = (100..399)
+
+            private
+
+            def do_get_block(req, proxy, conn, &)
+              uri = req.header.request_uri
+              url = "#{uri.scheme}://#{uri.host}"
+              request_method = req.header.request_method
+
+              attributes = {
+                'http.method' => request_method,
+                'http.scheme' => uri.scheme,
+                'http.target' => uri.path,
+                'http.url' => url,
+                'net.peer.name' => uri.host,
+                'net.peer.port' => uri.port
+              }.merge!(OpenTelemetry::Common::HTTP::ClientContext.attributes)
+
+              tracer.in_span("HTTP #{request_method}", attributes: attributes, kind: :client) do |span|
+                OpenTelemetry.propagation.inject(req.header)
+                super.tap do
+                  response = conn.pop
+                  annotate_span_with_response!(span, response)
+                  conn.push response
+                end
+              end
+            end
+
+            def annotate_span_with_response!(span, response)
+              return unless response&.status_code
+
+              status_code = response.status_code.to_i
+
+              span.set_attribute('http.status_code', status_code)
+              span.status = OpenTelemetry::Trace::Status.error unless HTTP_STATUS_SUCCESS_RANGE.cover?(status_code)
+            end
+
+            def tracer
+              HttpClient::Instrumentation.instance.tracer
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/opentelemetry/instrumentation/http_client/patches/old/session.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+# Copyright The OpenTelemetry Authors
+#
+# SPDX-License-Identifier: Apache-2.0
+
+module OpenTelemetry
+  module Instrumentation
+    module HttpClient
+      module Patches
+        module Old
+          # Module to prepend to HTTPClient::Session for instrumentation
+          module Session
+            def connect
+              site = @proxy || @dest
+              url = site.addr
+
+              attributes = { 'http.url' => url }.merge!(OpenTelemetry::Common::HTTP::ClientContext.attributes)
+              tracer.in_span('HTTP CONNECT', attributes: attributes) do
+                super
+              end
+            end
+
+            private
+
+            def tracer
+              HttpClient::Instrumentation.instance.tracer
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/opentelemetry/instrumentation/http_client/patches/stable/client.rb

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+
+# Copyright The OpenTelemetry Authors
+#
+# SPDX-License-Identifier: Apache-2.0
+
+module OpenTelemetry
+  module Instrumentation
+    module HttpClient
+      module Patches
+        module Stable
+          # Module to prepend to HTTPClient for instrumentation
+          module Client
+            # Constant for the HTTP status range
+            HTTP_STATUS_SUCCESS_RANGE = (100..399)
+
+            private
+
+            def do_get_block(req, proxy, conn, &)
+              uri = req.header.request_uri
+              url = "#{uri.scheme}://#{uri.host}"
+              request_method = req.header.request_method
+
+              attributes = {
+                'http.request.method' => request_method,
+                'url.scheme' => uri.scheme,
+                'url.path' => uri.path,
+                'url.full' => url,
+                'server.address' => uri.host,
+                'server.port' => uri.port
+              }.merge!(OpenTelemetry::Common::HTTP::ClientContext.attributes)
+
+              attributes['url.query'] = uri.query unless uri.query.nil?
+
+              tracer.in_span(request_method, attributes: attributes, kind: :client) do |span|
+                OpenTelemetry.propagation.inject(req.header)
+                super.tap do
+                  response = conn.pop
+                  annotate_span_with_response!(span, response)
+                  conn.push response
+                end
+              end
+            end
+
+            def annotate_span_with_response!(span, response)
+              return unless response&.status_code
+
+              status_code = response.status_code.to_i
+
+              span.set_attribute('http.response.status_code', status_code)
+              span.status = OpenTelemetry::Trace::Status.error unless HTTP_STATUS_SUCCESS_RANGE.cover?(status_code)
+            end
+
+            def tracer
+              HttpClient::Instrumentation.instance.tracer
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/opentelemetry/instrumentation/http_client/patches/stable/session.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+# Copyright The OpenTelemetry Authors
+#
+# SPDX-License-Identifier: Apache-2.0
+
+module OpenTelemetry
+  module Instrumentation
+    module HttpClient
+      module Patches
+        module Stable
+          # Module to prepend to HTTPClient::Session for instrumentation
+          module Session
+            def connect
+              site = @proxy || @dest
+              url = site.addr
+
+              attributes = { 'url.full' => url }.merge!(OpenTelemetry::Common::HTTP::ClientContext.attributes)
+              tracer.in_span('CONNECT', attributes: attributes) do
+                super
+              end
+            end
+
+            private
+
+            def tracer
+              HttpClient::Instrumentation.instance.tracer
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/opentelemetry/instrumentation/http_client/version.rb

@@ -7,7 +7,7 @@
 module OpenTelemetry
   module Instrumentation
     module HttpClient
-      VERSION = '0.23.0'
+      VERSION = '0.24.0'
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opentelemetry-instrumentation-http_client
 version: !ruby/object:Gem::Version
-  version: 0.23.0
+  version: 0.24.0
 platform: ruby
 authors:
 - OpenTelemetry Authors
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-16 00:00:00.000000000 Z
+date: 2025-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opentelemetry-api
@@ -38,160 +38,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.23.0
-- !ruby/object:Gem::Dependency
-  name: appraisal
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.5'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.5'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.4'
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
-- !ruby/object:Gem::Dependency
-  name: opentelemetry-sdk
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.1'
-- !ruby/object:Gem::Dependency
-  name: opentelemetry-test-helpers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.3'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.69.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.69.1
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.23.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.23.0
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.17.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.17.1
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.24.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.24.0
-- !ruby/object:Gem::Dependency
-  name: yard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
 description: HttpClient instrumentation for the OpenTelemetry framework
 email:
 - cncf-opentelemetry-contributors@lists.cncf.io
@@ -207,17 +53,21 @@ files:
 - lib/opentelemetry/instrumentation.rb
 - lib/opentelemetry/instrumentation/http_client.rb
 - lib/opentelemetry/instrumentation/http_client/instrumentation.rb
-- lib/opentelemetry/instrumentation/http_client/patches/client.rb
-- lib/opentelemetry/instrumentation/http_client/patches/session.rb
+- lib/opentelemetry/instrumentation/http_client/patches/dup/client.rb
+- lib/opentelemetry/instrumentation/http_client/patches/dup/session.rb
+- lib/opentelemetry/instrumentation/http_client/patches/old/client.rb
+- lib/opentelemetry/instrumentation/http_client/patches/old/session.rb
+- lib/opentelemetry/instrumentation/http_client/patches/stable/client.rb
+- lib/opentelemetry/instrumentation/http_client/patches/stable/session.rb
 - lib/opentelemetry/instrumentation/http_client/version.rb
 homepage: https://github.com/open-telemetry/opentelemetry-ruby-contrib
 licenses:
 - Apache-2.0
 metadata:
-  changelog_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-http_client/0.23.0/file/CHANGELOG.md
+  changelog_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-http_client/0.24.0/file/CHANGELOG.md
   source_code_uri: https://github.com/open-telemetry/opentelemetry-ruby-contrib/tree/main/instrumentation/http_client
   bug_tracker_uri: https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues
-  documentation_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-http_client/0.23.0
+  documentation_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-http_client/0.24.0
 post_install_message:
 rdoc_options: []
 require_paths:

data/lib/opentelemetry/instrumentation/http_client/patches/client.rb

@@ -1,58 +0,0 @@
-# frozen_string_literal: true
-
-# Copyright The OpenTelemetry Authors
-#
-# SPDX-License-Identifier: Apache-2.0
-
-module OpenTelemetry
-  module Instrumentation
-    module HttpClient
-      module Patches
-        # Module to prepend to HTTPClient for instrumentation
-        module Client
-          # Constant for the HTTP status range
-          HTTP_STATUS_SUCCESS_RANGE = (100..399)
-
-          private
-
-          def do_get_block(req, proxy, conn, &block)
-            uri = req.header.request_uri
-            url = "#{uri.scheme}://#{uri.host}"
-            request_method = req.header.request_method
-
-            attributes = {
-              'http.method' => request_method,
-              'http.scheme' => uri.scheme,
-              'http.target' => uri.path,
-              'http.url' => url,
-              'net.peer.name' => uri.host,
-              'net.peer.port' => uri.port
-            }.merge!(OpenTelemetry::Common::HTTP::ClientContext.attributes)
-
-            tracer.in_span("HTTP #{request_method}", attributes: attributes, kind: :client) do |span|
-              OpenTelemetry.propagation.inject(req.header)
-              super.tap do
-                response = conn.pop
-                annotate_span_with_response!(span, response)
-                conn.push response
-              end
-            end
-          end
-
-          def annotate_span_with_response!(span, response)
-            return unless response&.status_code
-
-            status_code = response.status_code.to_i
-
-            span.set_attribute('http.status_code', status_code)
-            span.status = OpenTelemetry::Trace::Status.error unless HTTP_STATUS_SUCCESS_RANGE.cover?(status_code)
-          end
-
-          def tracer
-            HttpClient::Instrumentation.instance.tracer
-          end
-        end
-      end
-    end
-  end
-end

data/lib/opentelemetry/instrumentation/http_client/patches/session.rb

@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-# Copyright The OpenTelemetry Authors
-#
-# SPDX-License-Identifier: Apache-2.0
-
-module OpenTelemetry
-  module Instrumentation
-    module HttpClient
-      module Patches
-        # Module to prepend to HTTPClient::Session for instrumentation
-        module Session
-          def connect
-            site = @proxy || @dest
-            url = site.addr
-
-            attributes = { 'http.url' => url }.merge!(OpenTelemetry::Common::HTTP::ClientContext.attributes)
-            tracer.in_span('HTTP CONNECT', attributes: attributes) do
-              super
-            end
-          end
-
-          private
-
-          def tracer
-            HttpClient::Instrumentation.instance.tracer
-          end
-        end
-      end
-    end
-  end
-end