opentelemetry-instrumentation-active_support 0.4.3 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d434dcacb053fbc80fd50dcbe5696cfa66faabcf2a76a941c5dd52f84de310e2
-  data.tar.gz: 3fb535ec6c52dec4ec4d6fc0643bd1a8ed5023529bfbb37c034c2b5b5a931b40
+  metadata.gz: dd1430bbbad917c43fabd403d83bdf2f5793051541d041b371d9445d347f93d9
+  data.tar.gz: '0269241b82d9ba154bf96b0b5d8a39a71de8f1b28024d4dffadd082008c07c5c'
 SHA512:
-  metadata.gz: eee7e6875c9d830739331dd6a9f2a978f722e8a42e7f7eb3835a58194f1e3fd638b859fcbe173c4348c4b9b3a5c018c09bc61ec40c070ffaabfe898991d9b4e5
-  data.tar.gz: bb789e89cbb0dcde291d320f6655c5aab1ce00406131909442c2ab3236ab4a23025b911491ce738db7b4501d58410e3a42380f196d2fc7cbc3c8ecd1665c9bcd
+  metadata.gz: 762d4ef7a1e5bcadee12e4f2b9b681ec2576d63fdfa34946615cdfb413c1d16d8ecf03c5ff2bc24db42bad01142b0788678f2095ac80012c12afab20e1028561
+  data.tar.gz: 6e392af0651f3fb26ddde4542bdded890b2be435e9804dffebfc2aafc6fde53e273f410ee8002c20f4495b8d04fa435d7f575629276a69199e833c298944ce2b

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Release History: opentelemetry-instrumentation-active_support
 
+### v0.4.4 / 2023-10-31
+
+* FIXED: Remove call to ActiveSupport::Notifications.notifier#synchronize deprecated in Rails 7.2
+
 ### v0.4.3 / 2023-10-16
 
 * FIXED: Add Rails 7.1 compatibility

data/lib/opentelemetry/instrumentation/active_support/span_subscriber.rb

@@ -30,19 +30,23 @@ module OpenTelemetry
 
         subscriber_object = ::ActiveSupport::Notifications.subscribe(pattern, subscriber)
 
-        ::ActiveSupport::Notifications.notifier.synchronize do
-          subscribers = ::ActiveSupport::Notifications.notifier.instance_variable_get(:@string_subscribers)[pattern]
-
-          if subscribers.nil?
-            OpenTelemetry.handle_error(
-              message: 'Unable to move OTEL ActiveSupport Notifications subscriber to the front of the notifications list which may cause incomplete traces.' \
-                       'Please report an issue here: ' \
-                       'https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues/new?labels=bug&template=bug_report.md&title=ActiveSupport%20Notifications%20subscribers%20list%20is%20nil'
-            )
-          else
-            subscribers.unshift(
-              subscribers.delete(subscriber_object)
-            )
+        # this can be removed once we drop support for Rails < 7.2
+        # see https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/707 for more context
+        if ::ActiveSupport::Notifications.notifier.respond_to?(:synchronize)
+          ::ActiveSupport::Notifications.notifier.synchronize do
+            subscribers = ::ActiveSupport::Notifications.notifier.instance_variable_get(:@string_subscribers)[pattern]
+
+            if subscribers.nil?
+              OpenTelemetry.handle_error(
+                message: 'Unable to move OTEL ActiveSupport Notifications subscriber to the front of the notifications list which may cause incomplete traces.' \
+                         'Please report an issue here: ' \
+                         'https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues/new?labels=bug&template=bug_report.md&title=ActiveSupport%20Notifications%20subscribers%20list%20is%20nil'
+              )
+            else
+              subscribers.unshift(
+                subscribers.delete(subscriber_object)
+              )
+            end
           end
         end
         subscriber_object

data/lib/opentelemetry/instrumentation/active_support/version.rb

@@ -7,7 +7,7 @@
 module OpenTelemetry
   module Instrumentation
     module ActiveSupport
-      VERSION = '0.4.3'
+      VERSION = '0.4.4'
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opentelemetry-instrumentation-active_support
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - OpenTelemetry Authors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-10-16 00:00:00.000000000 Z
+date: 2023-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opentelemetry-api
@@ -255,10 +255,10 @@ homepage: https://github.com/open-telemetry/opentelemetry-ruby-contrib
 licenses:
 - Apache-2.0
 metadata:
-  changelog_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-active_support/0.4.3/file/CHANGELOG.md
+  changelog_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-active_support/0.4.4/file/CHANGELOG.md
   source_code_uri: https://github.com/open-telemetry/opentelemetry-ruby-contrib/tree/main/instrumentation/active_support
   bug_tracker_uri: https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues
-  documentation_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-active_support/0.4.3
+  documentation_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-active_support/0.4.4
 post_install_message: 
 rdoc_options: []
 require_paths: