openstudio-extension 0.2.5 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 75c383235ef747996dd9484f715ab090201aeae62521c44f7166e4664057c83b
-  data.tar.gz: dc5e71c966b27041394772057b6c2625a735d34e6f1864e39d46378483743f3e
+  metadata.gz: 0a83259f47fe24c36e89ee7fd01cd1f776949e5a5a4e48777315e3d6ac188d2c
+  data.tar.gz: 404ebaab857a00a4ecb3ccc2a09c2b4e22a436c34a170f0d9bfd834264f2c0c9
 SHA512:
-  metadata.gz: 0bca71f3d261ddd15966a690859f01c5c6344259e96069f844ebf0da0bd395c18d79d6d8e48a680faa74a627e30aae38833c00a4c3ae3f29dfd8f4f47a2499b8
-  data.tar.gz: b50492d24de160505451599128ee177289ceac185bfd9ea560cd2447683ecef7c569699f59094c6b531feaf61810c18e027c0aa8ab11b2c9f9b3748a3fae4ee4
+  metadata.gz: a69ed15632f76aaba2506a1d7f14be462599ef31943c821e21b69d25daeac7735729629bda207b5d7c501db777e9796a70d6f4746264a2ed201239d94a514c8b
+  data.tar.gz: f36b878200be79b9b73b0dabaa84656a227dd0bc66908518e66b22a6742ae5d3a0d06f79ea1be7e9edd198889aa3f7e4f7b723fdeb0b11d1c96d4137069e673e

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # OpenStudio Extension Gem
 
+## Version 0.2.6
+
+- Check that `failed.job` doesn't exist and `finished.job` does exist.
+
+- Fixed [#98](https://github.com/NREL/openstudio-extension-gem/issues/98)
 ## Version 0.2.5
 
 * Support runner options for bundle_install_path and gemfile_path

data/lib/openstudio/extension/runner.rb

@@ -77,16 +77,16 @@ module OpenStudio
           # use the default values overriden with runner.conf values
           @options = @options.merge(runner_config.options)
         end
-        
+
         # use the passed values or defaults overriden by passed options
         @options = @options.merge(options)
-       
+
         puts "Initializing runner with dirname: '#{dirname}' and options: #{@options}"
         @dirname = File.absolute_path(dirname)
-        
+
         # use passed options, otherwise assume @dirname
-        @gemfile_path = (!@options.key?(:gemfile_path) || @options[:gemfile_path] === '') ? File.join(@dirname, 'Gemfile') : @options[:gemfile_path]
-        @bundle_install_path = (!@options.key?(:bundle_install_path) || @options[:bundle_install_path] === '')? File.join(@dirname, '.bundle/install/') : @options[:bundle_install_path]
+        @gemfile_path = !@options.key?(:gemfile_path) || @options[:gemfile_path] === '' ? File.join(@dirname, 'Gemfile') : @options[:gemfile_path]
+        @bundle_install_path = !@options.key?(:bundle_install_path) || @options[:bundle_install_path] === '' ? File.join(@dirname, '.bundle/install/') : @options[:bundle_install_path]
         @original_dir = Dir.pwd
         # puts "DIRNAME: #{@dirname}"
         # puts "@gemfile_path set to: #{@gemfile_path}"
@@ -656,7 +656,16 @@ module OpenStudio
           puts 'simulations are not performed, since to the @options[:run_simulations] is set to false'
         end
 
-        # DLM: this does not always return false for failed CLI runs, consider checking for failed.job file as backup test
+        if @options[:run_simulations]
+          # Additional checks for failed CLI
+          if File.exist?(File.join(run_dir, 'failed.job'))
+            result = false
+          end
+
+          if !File.exist?(File.join(run_dir, 'finished.job'))
+            result = false
+          end
+        end
 
         return result
       end

data/lib/openstudio/extension/version.rb

@@ -35,6 +35,6 @@
 
 module OpenStudio
   module Extension
-    VERSION = '0.2.5'.freeze
+    VERSION = '0.2.6'.freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openstudio-extension
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.2.6
 platform: ruby
 authors:
 - Katherine Fleming
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-08-24 00:00:00.000000000 Z
+date: 2021-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bcl
@@ -218,7 +218,7 @@ licenses: []
 metadata:
   bug_tracker_uri: https://github.com/NREL/openstudio-extension-gem/issues
   changelog_uri: https://github.com/NREL/openstudio-extension-gem/blob/develop/CHANGELOG.md
-  source_code_uri: https://github.com/NREL/openstudio-extension-gem/tree/v0.2.5
+  source_code_uri: https://github.com/NREL/openstudio-extension-gem/tree/v0.2.6
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -234,7 +234,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubyforge_project: 
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: openstudio base gem for creating generic extensions with encapsulated data