openstudio-calibration 0.9.0 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: be0df7d570194eed01d351ecfdd17e247146dfffbbb83cf08805bbbde18db340
-  data.tar.gz: 4894b51e9cfac730ad5e13e70e9412521ba4ff5090bf50c6cd240162603c193f
+  metadata.gz: 1a41048af94db9348e86b3b3a12055d23e173cfff4dfd473752c577c7e05ce3c
+  data.tar.gz: ecf5caa0e04b4b483011452b4228ab742f96958da9bbfca34143fc1a7e914007
 SHA512:
-  metadata.gz: 2f8d4c10fa883f5e9afbb42392cfba46674a485858bcfe827bd9d8e1f9516700d9b29f210eaddbe4de8e3b78f100871a8f8cf1e5c861c05aad94d720f22b9937
-  data.tar.gz: 44ae3592dbf26e616e927395cd009f4b45741a6f777a19036514a22cd16eb5db8eb824cdf110b7ae315eeac4a1edbb384fcdb3476cced9eb29332844ca25cc08
+  metadata.gz: 7cb415a39e6372181e06da99fd1983d180a91e8bd0e8bc148ab2beca66ed967e8ff8140fdb5e0113d41102d17660e11a5eb491290fd6c58daa25116fba71b0fd
+  data.tar.gz: a36ca16622792d53c4b63a5d89d0c872441b0d2120cec92a30495efde1cdce52555604938c46c760bd201a97eb65b8f07afb6b74fe64311fb78586620087e7c7

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # OpenStudio Calibration Measures Gem
 
+## Version 0.10.0
+* Support for OpenStudio 3.8 (upgrade to standards gem 0.6.0, extension gem 0.8.0)
+* Support Ruby 3.2.2
+
 ## Version 0.9.0
 * Updating dependencies and licenses for OpenStudio 3.7 (upgrade to standards gem 0.5.0, extension gem 0.7.0)
 * Fixed [#54]( https://github.com/NREL/openstudio-calibration-gem/issues/54 ), OS API changes break some measures

data/Gemfile

@@ -1,5 +1,6 @@
 source 'http://rubygems.org'
 
+# Specify your gem's dependencies in openstudio-model-articulation.gemspec
 gemspec
 
 # Local gems are useful when developing and integrating the various dependencies.
@@ -10,7 +11,6 @@ gemspec
 # checkout the latest version (develop) from github.
 allow_local = ENV['FAVOR_LOCAL_GEMS']
 
-
 if allow_local && File.exist?('../OpenStudio-extension-gem')
   gem 'openstudio-extension', path: '../OpenStudio-extension-gem'
 elsif allow_local

data/Jenkinsfile

@@ -1,6 +1,6 @@
 //Jenkins pipelines are stored in shared libraries. Please see: https://github.com/NREL/cbci_jenkins_libs
  
-@Library('cbci_shared_libs') _
+@Library('cbci_shared_libs@developExtension') _
 
 // Build for PR to develop branch only. 
 if ((env.CHANGE_ID) && (env.CHANGE_TARGET) ) { // check if set

data/Rakefile

@@ -14,6 +14,9 @@ require 'openstudio/calibration'
 rake_task = OpenStudio::Extension::RakeTask.new
 rake_task.set_extension_class(OpenStudio::Calibration::Extension, 'nrel/openstudio-calibration-gem')
 
+require 'rubocop/rake_task'
+RuboCop::RakeTask.new
+
 require 'openstudio_measure_tester/rake_task'
 OpenStudioMeasureTester::RakeTask.new
 

data/lib/measures/AddMonthlyJSONUtilityData/measure.rb

@@ -121,7 +121,7 @@ class AddMonthlyJSONUtilityData < OpenStudio::Measure::ModelMeasure
     args << set_runperiod
 
     args
-  end # end the arguments method
+  end
 
   # define what happens when the measure is run
   def run(model, runner, user_arguments)
@@ -243,8 +243,8 @@ class AddMonthlyJSONUtilityData < OpenStudio::Measure::ModelMeasure
     runner.registerFinalCondition('Utility bill data has been added to the model.')
 
     true
-  end # end the run method
-end # end the measure
+  end
+end
 
 # this allows the measure to be use by the application
 AddMonthlyJSONUtilityData.new.registerWithApplication

data/lib/measures/AddMonthlyJSONUtilityData/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.0</schema_version>
   <name>add_monthly_json_utility_data</name>
   <uid>6da969e0-4256-49bf-9607-26504cc3d423</uid>
-  <version_id>abd6d2b6-799e-40b0-b2cb-6159c0e448b4</version_id>
-  <version_modified>20230602T154652Z</version_modified>
+  <version_id>6a42029d-22ef-4b35-8a12-c9dfbfbe9724</version_id>
+  <version_modified>20240428T231344Z</version_modified>
   <xml_checksum>057E8D9D</xml_checksum>
   <class_name>AddMonthlyJSONUtilityData</class_name>
   <display_name>Add Monthly JSON Utility Data</display_name>
@@ -158,7 +158,7 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>D58A17FC</checksum>
+      <checksum>CB47CCE7</checksum>
     </file>
   </files>
 </measure>

data/lib/measures/AddMonthlyUtilityData/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.0</schema_version>
   <name>add_monthly_utility_data</name>
   <uid>6da969e0-4256-49bf-9607-26504cc3d421</uid>
-  <version_id>3a7e6f68-43ba-4910-b5e5-b3e770617ed2</version_id>
-  <version_modified>20230602T154653Z</version_modified>
+  <version_id>72fea19f-66f5-4795-b290-5314e9c67982</version_id>
+  <version_modified>20240428T231345Z</version_modified>
   <xml_checksum>9064277D</xml_checksum>
   <class_name>AddMonthlyUtilityData</class_name>
   <display_name>AddMonthlyUtilityData</display_name>
@@ -97,12 +97,6 @@
       <usage_type>license</usage_type>
       <checksum>BFFB1AA6</checksum>
     </file>
-    <file>
-      <filename>AddMonthlyUtilityData_Test.rb</filename>
-      <filetype>rb</filetype>
-      <usage_type>test</usage_type>
-      <checksum>24648035</checksum>
-    </file>
     <file>
       <version>
         <software_program>OpenStudio</software_program>
@@ -114,5 +108,11 @@
       <usage_type>script</usage_type>
       <checksum>C25C9D2C</checksum>
     </file>
+    <file>
+      <filename>AddMonthlyUtilityData_Test.rb</filename>
+      <filetype>rb</filetype>
+      <usage_type>test</usage_type>
+      <checksum>A7E682C1</checksum>
+    </file>
   </files>
 </measure>

data/lib/measures/CalibrationReports/measure.rb

@@ -15,9 +15,7 @@ class CalibrationReports < OpenStudio::Measure::ReportingMeasure
 
   # define the arguments that the user will input
   def arguments
-    args = OpenStudio::Measure::OSArgumentVector.new
-
-    args
+    OpenStudio::Measure::OSArgumentVector.new
   end
 
   # define what happens when the measure is run

data/lib/measures/CalibrationReports/measure.xml

@@ -4,8 +4,8 @@
   <error>wrong number of arguments (given 1, expected 0)</error>
   <name>calibration_reports</name>
   <uid>2baede0a-65f3-47ec-b5f6-9c21d0f91aff</uid>
-  <version_id>566f5610-4142-4d85-a119-9e481396170e</version_id>
-  <version_modified>20230602T154657Z</version_modified>
+  <version_id>718d3fe7-727b-4e36-9d74-b67a53571726</version_id>
+  <version_modified>20240428T231349Z</version_modified>
   <xml_checksum>2C8A3EEF</xml_checksum>
   <class_name>CalibrationReports</class_name>
   <display_name>Calibration Reports</display_name>
@@ -87,13 +87,13 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>20C72976</checksum>
+      <checksum>2647EEDB</checksum>
     </file>
     <file>
       <filename>CalibrationReports_Test.rb</filename>
       <filetype>rb</filetype>
       <usage_type>test</usage_type>
-      <checksum>C8C35A61</checksum>
+      <checksum>125E14F8</checksum>
     </file>
   </files>
 </measure>

data/lib/measures/CalibrationReportsEnhanced/measure.rb

@@ -65,7 +65,7 @@ class CalibrationReportsEnhanced < OpenStudio::Measure::ReportingMeasure
     args << fuel_oil_cvrmse_limit
 
     args
-  end # end the arguments method
+  end
 
   def outputs
     result = OpenStudio::Measure::OSOutputVector.new
@@ -559,6 +559,7 @@ class CalibrationReportsEnhanced < OpenStudio::Measure::ReportingMeasure
       end
 
       next unless os_version >= min_version_feature1
+
       if actual_consumption > 0.0
         runner.registerValue("#{utility_bill_fuel_type}_consumption_actual",
                              actual_consumption,
@@ -579,6 +580,7 @@ class CalibrationReportsEnhanced < OpenStudio::Measure::ReportingMeasure
                              '%')
       end
       next unless !actual_consumption_values.empty? && (actual_consumption_values.size == modeled_consumption_values.size)
+
       sum_squares = 0.0
       actual_consumption_values.each_index do |i|
         sum_squares += (actual_consumption_values[i] - modeled_consumption_values[i])**2
@@ -591,26 +593,23 @@ class CalibrationReportsEnhanced < OpenStudio::Measure::ReportingMeasure
                            actual_consumption_values.size)
       runner.registerValue("#{utility_bill_fuel_type}_rmse",
                            rmse,
-                           utilityBill.consumptionUnit + '^0.5')
+                           "#{utilityBill.consumptionUnit}^0.5")
     end
 
-    if os_version >= min_version_feature1
-      if !all_actual_consumption_values.empty? && (all_actual_consumption_values.size == all_modeled_consumption_values.size)
-        sum_squares = 0.0
-        all_actual_consumption_values.each_index do |i|
-          sum_squares += (all_actual_consumption_values[i] - all_modeled_consumption_values[i])**2
-        end
-        rmse = Math.sqrt(sum_squares / all_actual_consumption_values.size)
-        runner.registerValue('total_sum_of_squares',
-                             sum_squares,
-                             'kBtu')
-        runner.registerValue('total_dof',
-                             all_actual_consumption_values.size)
-        runner.registerValue('total_rmse',
-                             rmse,
-                             'kBtu^0.5')
+    if os_version >= min_version_feature1 && (!all_actual_consumption_values.empty? && (all_actual_consumption_values.size == all_modeled_consumption_values.size))
+      sum_squares = 0.0
+      all_actual_consumption_values.each_index do |i|
+        sum_squares += (all_actual_consumption_values[i] - all_modeled_consumption_values[i])**2
       end
-
+      rmse = Math.sqrt(sum_squares / all_actual_consumption_values.size)
+      runner.registerValue('total_sum_of_squares',
+                           sum_squares,
+                           'kBtu')
+      runner.registerValue('total_dof',
+                           all_actual_consumption_values.size)
+      runner.registerValue('total_rmse',
+                           rmse,
+                           'kBtu^0.5')
     end
 
     elecStartDate = elecStartDate[0..-2]
@@ -728,7 +727,7 @@ class CalibrationReportsEnhanced < OpenStudio::Measure::ReportingMeasure
                        else
                          (cvrmse <= gas_cvrmse_limit)
                        end
-        result_hash[match_data[1] + '_cvrmse_within_limit'] = within_limit
+        result_hash["#{match_data[1]}_cvrmse_within_limit"] = within_limit
         within_limit_i = if within_limit
                            1
                          else
@@ -747,7 +746,7 @@ class CalibrationReportsEnhanced < OpenStudio::Measure::ReportingMeasure
                        else
                          (nmbe.abs <= gas_nmbe_limit)
                        end
-        result_hash[match_data[1] + '_nmbe_within_limit'] = within_limit
+        result_hash["#{match_data[1]}_nmbe_within_limit"] = within_limit
         within_limit_i = if within_limit
                            1
                          else
@@ -761,8 +760,8 @@ class CalibrationReportsEnhanced < OpenStudio::Measure::ReportingMeasure
     end
 
     true
-  end # end the run method
-end # end the measure
+  end
+end
 
 # this allows the measure to be use by the application
 CalibrationReportsEnhanced.new.registerWithApplication

data/lib/measures/CalibrationReportsEnhanced/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.0</schema_version>
   <name>calibration_reports_enhanced</name>
   <uid>e6642d40-7366-4647-8724-53a37991d668</uid>
-  <version_id>8b85be87-ddd0-441f-a4f7-503fbcd28450</version_id>
-  <version_modified>20230602T154652Z</version_modified>
+  <version_id>7cda1e46-566f-46e5-b89c-5bbc797fdda8</version_id>
+  <version_modified>20240428T231344Z</version_modified>
   <xml_checksum>2C8A3EEF</xml_checksum>
   <class_name>CalibrationReportsEnhanced</class_name>
   <display_name>Calibration Reports Enhanced</display_name>
@@ -356,7 +356,7 @@
       <filename>CalibrationReportsEnhanced_Test.rb</filename>
       <filetype>rb</filetype>
       <usage_type>test</usage_type>
-      <checksum>1D6A11A6</checksum>
+      <checksum>97772676</checksum>
     </file>
     <file>
       <version>
@@ -367,7 +367,7 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>C88256BE</checksum>
+      <checksum>AD9FA578</checksum>
     </file>
   </files>
 </measure>

data/lib/measures/CoilCoolingDXSingleSpeedMultiplier/measure.rb

@@ -59,6 +59,7 @@ class CoilCoolingDXSingleSpeedMultiplier < OpenStudio::Measure::ModelMeasure
       components = value.supplyComponents
       components.each do |component|
         next if component.to_CoilCoolingDXSingleSpeed.empty?
+
         show_loop = true
         loop_handles << component.handle.to_s
         loop_display_names << component.name.to_s
@@ -165,28 +166,27 @@ class CoilCoolingDXSingleSpeedMultiplier < OpenStudio::Measure::ModelMeasure
     coils.each do |coil|
       altered_coil = false
       # rated_cooling_capacity_multiplier
-      if rated_cooling_capacity_multiplier != 1.0
-        if coil.ratedTotalCoolingCapacity.is_initialized
-          runner.registerInfo("Applying ratedTotalCoolingCapacity #{rated_cooling_capacity_multiplier}x multiplier to #{coil.name.get}.")
-          coil.setRatedTotalCoolingCapacity(coil.ratedTotalCoolingCapacity.get * rated_cooling_capacity_multiplier)
-          altered_capacity << coil.handle.to_s
-          altered_coil = true
-        end
+      if rated_cooling_capacity_multiplier != 1.0 && coil.ratedTotalCoolingCapacity.is_initialized
+        runner.registerInfo("Applying ratedTotalCoolingCapacity #{rated_cooling_capacity_multiplier}x multiplier to #{coil.name.get}.")
+        coil.setRatedTotalCoolingCapacity(coil.ratedTotalCoolingCapacity.get * rated_cooling_capacity_multiplier)
+        altered_capacity << coil.handle.to_s
+        altered_coil = true
       end
 
       # modify rated_cop_multiplier
       if rated_cop_multiplier != 1.0
-          runner.registerInfo("Applying ratedCOP #{rated_cop_multiplier}x multiplier to #{coil.name.get}.")
-          coil.setRatedCOP(coil.ratedCOP * rated_cop_multiplier)
-          altered_coilefficiency << coil.handle.to_s
-          altered_coil = true
+        runner.registerInfo("Applying ratedCOP #{rated_cop_multiplier}x multiplier to #{coil.name.get}.")
+        coil.setRatedCOP(coil.ratedCOP * rated_cop_multiplier)
+        altered_coilefficiency << coil.handle.to_s
+        altered_coil = true
       end
 
       next unless altered_coil
+
       altered_coils << coil.handle.to_s
       change_name(coil, rated_cop_multiplier, rated_cooling_capacity_multiplier)
       runner.registerInfo("coil name changed to: #{coil.name.get}")
-    end # end coil loop
+    end
 
     # na if nothing in model to look at
     if altered_coils.empty?

data/lib/measures/CoilCoolingDXSingleSpeedMultiplier/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.0</schema_version>
   <name>coil_cooling_dx_single_speed_multiplier</name>
   <uid>97d0dbdf-6245-4cfd-8dfc-a6a5eb853b16</uid>
-  <version_id>f805c6dd-0fb2-4e72-9704-3f3334769ddc</version_id>
-  <version_modified>20230602T154656Z</version_modified>
+  <version_id>d0a60754-bd42-48ae-9cc7-1f6ccacc5433</version_id>
+  <version_modified>20240428T231348Z</version_modified>
   <xml_checksum>8CBDDA1B</xml_checksum>
   <class_name>CoilCoolingDXSingleSpeedMultiplier</class_name>
   <display_name>Cooling Coils DX Single Speed Multiplier</display_name>
@@ -17,10 +17,10 @@
       <type>Choice</type>
       <required>true</required>
       <model_dependent>false</model_dependent>
-      <default_value>{355b65f9-00e5-41dc-843e-930c8c98e8f0}</default_value>
+      <default_value>{a663ea08-96ab-465f-afba-721f4341eca3}</default_value>
       <choices>
         <choice>
-          <value>{355b65f9-00e5-41dc-843e-930c8c98e8f0}</value>
+          <value>{a663ea08-96ab-465f-afba-721f4341eca3}</value>
           <display_name>*All DX Cooling Coils*</display_name>
         </choice>
         <choice>
@@ -88,7 +88,7 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>A4CDE5A7</checksum>
+      <checksum>0C375660</checksum>
     </file>
   </files>
 </measure>

data/lib/measures/CoilCoolingDXSingleSpeedPercentChange/measure.rb

@@ -52,6 +52,7 @@ class CoilCoolingDXSingleSpeedPercentChange < OpenStudio::Measure::ModelMeasure
       components = value.supplyComponents
       components.each do |component|
         next if component.to_CoilCoolingDXSingleSpeed.empty?
+
         show_loop = true
         loop_handles << component.handle.to_s
         loop_display_names << component.name.to_s
@@ -156,28 +157,27 @@ class CoilCoolingDXSingleSpeedPercentChange < OpenStudio::Measure::ModelMeasure
     coils.each do |coil|
       altered_coil = false
       # rated_cooling_capacity_perc_change
-      if rated_cooling_capacity_perc_change != 0.0
-        if coil.ratedTotalCoolingCapacity.is_initialized
-          runner.registerInfo("Applying ratedTotalCoolingCapacity #{rated_cooling_capacity_perc_change} Percent Change to #{coil.name.get}.")
-          coil.setRatedTotalCoolingCapacity(coil.ratedTotalCoolingCapacity.get + coil.ratedTotalCoolingCapacity.get * rated_cooling_capacity_perc_change * 0.01)
-          altered_capacity << coil.handle.to_s
-          altered_coil = true
-        end
+      if rated_cooling_capacity_perc_change != 0.0 && coil.ratedTotalCoolingCapacity.is_initialized
+        runner.registerInfo("Applying ratedTotalCoolingCapacity #{rated_cooling_capacity_perc_change} Percent Change to #{coil.name.get}.")
+        coil.setRatedTotalCoolingCapacity(coil.ratedTotalCoolingCapacity.get + coil.ratedTotalCoolingCapacity.get * rated_cooling_capacity_perc_change * 0.01)
+        altered_capacity << coil.handle.to_s
+        altered_coil = true
       end
 
       # modify rated_cop_perc_change
       if rated_cop_perc_change != 0.0
-          runner.registerInfo("Applying ratedCOP #{rated_cop_perc_change} Percent Change to #{coil.name.get}.")
-          coil.setRatedCOP(coil.ratedCOP + coil.ratedCOP * rated_cop_perc_change * 0.01)
-          altered_coilefficiency << coil.handle.to_s
-          altered_coil = true
+        runner.registerInfo("Applying ratedCOP #{rated_cop_perc_change} Percent Change to #{coil.name.get}.")
+        coil.setRatedCOP(coil.ratedCOP + coil.ratedCOP * rated_cop_perc_change * 0.01)
+        altered_coilefficiency << coil.handle.to_s
+        altered_coil = true
       end
 
       next unless altered_coil
+
       altered_coils << coil.handle.to_s
       change_name(coil, rated_cop_perc_change, rated_cooling_capacity_perc_change)
       runner.registerInfo("coil name changed to: #{coil.name.get}")
-    end # end coil loop
+    end
 
     # na if nothing in model to look at
     if altered_coils.empty?

data/lib/measures/CoilCoolingDXSingleSpeedPercentChange/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.0</schema_version>
   <name>coil_cooling_dx_single_speed_percent_change</name>
   <uid>97d0dbdf-6245-4cfd-8dfc-a6a5eb853b37</uid>
-  <version_id>15e118f5-882c-4875-af35-960173543096</version_id>
-  <version_modified>20230602T154652Z</version_modified>
+  <version_id>ddca5198-d1a1-4484-b664-7bf43c03cba3</version_id>
+  <version_modified>20240428T231344Z</version_modified>
   <xml_checksum>8CBDDA1B</xml_checksum>
   <class_name>CoilCoolingDXSingleSpeedPercentChange</class_name>
   <display_name>Cooling Coils DX Single Speed Percent Change</display_name>
@@ -17,10 +17,10 @@
       <type>Choice</type>
       <required>true</required>
       <model_dependent>false</model_dependent>
-      <default_value>{9e8f05d8-6863-4da4-a3fe-f2883e70a2d8}</default_value>
+      <default_value>{b3bd6e6b-18c0-4637-a6a0-8980d7b32932}</default_value>
       <choices>
         <choice>
-          <value>{9e8f05d8-6863-4da4-a3fe-f2883e70a2d8}</value>
+          <value>{b3bd6e6b-18c0-4637-a6a0-8980d7b32932}</value>
           <display_name>*All DX Cooling Coils*</display_name>
         </choice>
         <choice>
@@ -88,7 +88,7 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>3357E9A0</checksum>
+      <checksum>76DB1539</checksum>
     </file>
   </files>
 </measure>

data/lib/measures/CoilCoolingDXTwoSpeedMultiplier/measure.rb

@@ -65,6 +65,7 @@ class CoilCoolingDXTwoSpeedMultiplier < OpenStudio::Measure::ModelMeasure
       components = value.supplyComponents
       components.each do |component|
         next if component.to_CoilCoolingDXTwoSpeed.empty?
+
         show_loop = true
         loop_handles << component.handle.to_s
         loop_display_names << component.name.to_s
@@ -188,46 +189,43 @@ class CoilCoolingDXTwoSpeedMultiplier < OpenStudio::Measure::ModelMeasure
     coils.each do |coil|
       altered_coil = false
       # rated_highspeed_cooling_capacity_multiplier
-      if rated_highspeed_cooling_capacity_multiplier != 1.0
-        if coil.ratedHighSpeedTotalCoolingCapacity.is_initialized
-          runner.registerInfo("Applying ratedHighSpeedTotalCoolingCapacity #{rated_highspeed_cooling_capacity_multiplier}x multiplier to #{coil.name.get}.")
-          coil.setRatedHighSpeedTotalCoolingCapacity(coil.ratedHighSpeedTotalCoolingCapacity.get * rated_highspeed_cooling_capacity_multiplier)
-          altered_capacity << coil.handle.to_s
-          altered_coil = true
-        end
+      if rated_highspeed_cooling_capacity_multiplier != 1.0 && coil.ratedHighSpeedTotalCoolingCapacity.is_initialized
+        runner.registerInfo("Applying ratedHighSpeedTotalCoolingCapacity #{rated_highspeed_cooling_capacity_multiplier}x multiplier to #{coil.name.get}.")
+        coil.setRatedHighSpeedTotalCoolingCapacity(coil.ratedHighSpeedTotalCoolingCapacity.get * rated_highspeed_cooling_capacity_multiplier)
+        altered_capacity << coil.handle.to_s
+        altered_coil = true
       end
 
       # rated_lowspeed_cooling_capacity_multiplier
-      if rated_lowspeed_cooling_capacity_multiplier != 1.0
-        if coil.ratedLowSpeedTotalCoolingCapacity.is_initialized
-          runner.registerInfo("Applying ratedLowSpeedTotalCoolingCapacity #{rated_lowspeed_cooling_capacity_multiplier}x multiplier to #{coil.name.get}.")
-          coil.setRatedLowSpeedTotalCoolingCapacity(coil.ratedLowSpeedTotalCoolingCapacity.get * rated_lowspeed_cooling_capacity_multiplier)
-          altered_capacity << coil.handle.to_s
-          altered_coil = true
-        end
+      if rated_lowspeed_cooling_capacity_multiplier != 1.0 && coil.ratedLowSpeedTotalCoolingCapacity.is_initialized
+        runner.registerInfo("Applying ratedLowSpeedTotalCoolingCapacity #{rated_lowspeed_cooling_capacity_multiplier}x multiplier to #{coil.name.get}.")
+        coil.setRatedLowSpeedTotalCoolingCapacity(coil.ratedLowSpeedTotalCoolingCapacity.get * rated_lowspeed_cooling_capacity_multiplier)
+        altered_capacity << coil.handle.to_s
+        altered_coil = true
       end
 
       # modify rated_highspeed_cop_multiplier
       if rated_highspeed_cop_multiplier != 1.0
-          runner.registerInfo("Applying ratedHighSpeedCOP #{rated_highspeed_cop_multiplier}x multiplier to #{coil.name.get}.")
-          coil.setRatedHighSpeedCOP(coil.ratedHighSpeedCOP * rated_highspeed_cop_multiplier)
-          altered_coilefficiency << coil.handle.to_s
-          altered_coil = true
+        runner.registerInfo("Applying ratedHighSpeedCOP #{rated_highspeed_cop_multiplier}x multiplier to #{coil.name.get}.")
+        coil.setRatedHighSpeedCOP(coil.ratedHighSpeedCOP * rated_highspeed_cop_multiplier)
+        altered_coilefficiency << coil.handle.to_s
+        altered_coil = true
       end
 
       # modify rated_lowspeed_cop_multiplier
       if rated_lowspeed_cop_multiplier != 1.0
-          runner.registerInfo("Applying ratedLowSpeedCOP #{rated_lowspeed_cop_multiplier}x multiplier to #{coil.name.get}.")
-          coil.setRatedLowSpeedCOP(coil.ratedLowSpeedCOP * rated_lowspeed_cop_multiplier)
-          altered_coilefficiency << coil.handle.to_s
-          altered_coil = true
+        runner.registerInfo("Applying ratedLowSpeedCOP #{rated_lowspeed_cop_multiplier}x multiplier to #{coil.name.get}.")
+        coil.setRatedLowSpeedCOP(coil.ratedLowSpeedCOP * rated_lowspeed_cop_multiplier)
+        altered_coilefficiency << coil.handle.to_s
+        altered_coil = true
       end
 
       next unless altered_coil
+
       altered_coils << coil.handle.to_s
       change_name(coil, rated_highspeed_cop_multiplier, rated_highspeed_cooling_capacity_multiplier, rated_lowspeed_cop_multiplier, rated_lowspeed_cooling_capacity_multiplier)
       runner.registerInfo("coil name changed to: #{coil.name.get}")
-    end # end coil loop
+    end
 
     # na if nothing in model to look at
     if altered_coils.empty?

data/lib/measures/CoilCoolingDXTwoSpeedMultiplier/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.0</schema_version>
   <name>coil_cooling_dx_two_speed_multiplier</name>
   <uid>fe4f36db-e296-4c9f-8199-19f2249384dd</uid>
-  <version_id>cc90b0ec-94fb-476a-9e8e-0cafdd02ba1d</version_id>
-  <version_modified>20230602T154653Z</version_modified>
+  <version_id>2598fa9c-5b97-4efc-a524-91fa9ace0b32</version_id>
+  <version_modified>20240428T231345Z</version_modified>
   <xml_checksum>8CBDDA1B</xml_checksum>
   <class_name>CoilCoolingDXTwoSpeedMultiplier</class_name>
   <display_name>Cooling Coils DX Two Speed Multiplier</display_name>
@@ -17,10 +17,10 @@
       <type>Choice</type>
       <required>true</required>
       <model_dependent>false</model_dependent>
-      <default_value>{59ab48dd-799b-49a3-a439-e60ce92c85fa}</default_value>
+      <default_value>{628948f3-3ab3-454e-966d-4b98e1d0d075}</default_value>
       <choices>
         <choice>
-          <value>{59ab48dd-799b-49a3-a439-e60ce92c85fa}</value>
+          <value>{628948f3-3ab3-454e-966d-4b98e1d0d075}</value>
           <display_name>*All DX Cooling Coils*</display_name>
         </choice>
         <choice>
@@ -106,7 +106,7 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>0E58BAD2</checksum>
+      <checksum>CCD99D0A</checksum>
     </file>
   </files>
 </measure>