openskill 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b2559ed1bbd59204cee9143bc49fc51ce1c0048abc5a84b03ba4793d437a4d31
-  data.tar.gz: 692090c1a809b7645f8acb0bd10be874ec01a32ae2d8d4177d1eacfebfbc041b
+  metadata.gz: f012ac1b290e25006cbe383d1ea48aacebc5d4aac2660d5e0388cbeaa91fd16e
+  data.tar.gz: b7de5159790ba4e6cd4017437e75706784906e8381211523c377eeaf31d6610d
 SHA512:
-  metadata.gz: 1533d76307745a38d728ba4a0a35d093f0270cca0e36b77bc21d276bfa250107f10668260748bebd886fc2177e33001479297839e3890ba158235d2216a8c8d8
-  data.tar.gz: '09866e5514cac8a47f4534c404871cd8e15a15b8d94e4d00fe9b6c31cc907852c31ed3f2cd4b1320cd38636df49a5968085de62a1c2580171adb27a9853fef63'
+  metadata.gz: dd0515dac71798ba088d399f3a888a028106444803a9faaaa7e584aa7e05cdd5363729e923a34207c26c6eae98a736410920007385f578a47cb917781c2ca069
+  data.tar.gz: 3710b5bff94f1ae66799e390874580b3d40c7257b2e1465068ac9cb9afaef807ed50ed206eb52a9784359bab23fbb4f0e2086aa3481aa44dc5ce9fdadb4f6f3a

data/lib/openskill/models/bradley_terry_full.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require 'securerandom'
-require_relative '../statistics/normal'
-require_relative 'common'
+require "securerandom"
+require_relative "../statistics/normal"
+require_relative "common"
 
 module OpenSkill
   module Models
@@ -71,8 +71,8 @@ module OpenSkill
       # @raise [ArgumentError] if rating_array is invalid
       def load_rating(rating_array, name: nil)
         raise ArgumentError, "Rating must be an Array, got #{rating_array.class}" unless rating_array.is_a?(Array)
-        raise ArgumentError, 'Rating array must have exactly 2 elements' unless rating_array.size == 2
-        raise ArgumentError, 'Rating values must be numeric' unless rating_array.all? { |v| v.is_a?(Numeric) }
+        raise ArgumentError, "Rating array must have exactly 2 elements" unless rating_array.size == 2
+        raise ArgumentError, "Rating values must be numeric" unless rating_array.all? { |v| v.is_a?(Numeric) }
 
         Rating.new(mu: rating_array[0], sigma: rating_array[1], name: name)
       end
@@ -92,7 +92,7 @@ module OpenSkill
         validate_scores!(teams, scores) if scores
         validate_weights!(teams, weights) if weights
 
-        raise ArgumentError, 'Cannot provide both ranks and scores' if ranks && scores
+        raise ArgumentError, "Cannot provide both ranks and scores" if ranks && scores
 
         # Deep copy teams to avoid mutating input
         original_teams = teams
@@ -299,25 +299,25 @@ module OpenSkill
         end
 
         def <(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal < other.ordinal
         end
 
         def >(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal > other.ordinal
         end
 
         def <=(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal <= other.ordinal
         end
 
         def >=(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal >= other.ordinal
         end
@@ -376,8 +376,8 @@ module OpenSkill
 
       # Validate teams structure
       def validate_teams!(teams)
-        raise ArgumentError, 'Teams must be an Array' unless teams.is_a?(Array)
-        raise ArgumentError, 'Must have at least 2 teams' if teams.size < 2
+        raise ArgumentError, "Teams must be an Array" unless teams.is_a?(Array)
+        raise ArgumentError, "Must have at least 2 teams" if teams.size < 2
 
         teams.each_with_index do |team, idx|
           raise ArgumentError, "Team #{idx} must be an Array" unless team.is_a?(Array)
@@ -392,7 +392,7 @@ module OpenSkill
       # Validate ranks
       def validate_ranks!(teams, ranks)
         raise ArgumentError, "Ranks must be an Array, got #{ranks.class}" unless ranks.is_a?(Array)
-        raise ArgumentError, 'Ranks must have same length as teams' if ranks.size != teams.size
+        raise ArgumentError, "Ranks must have same length as teams" if ranks.size != teams.size
 
         ranks.each do |rank|
           raise ArgumentError, "All ranks must be numeric, got #{rank.class}" unless rank.is_a?(Numeric)
@@ -402,7 +402,7 @@ module OpenSkill
       # Validate scores
       def validate_scores!(teams, scores)
         raise ArgumentError, "Scores must be an Array, got #{scores.class}" unless scores.is_a?(Array)
-        raise ArgumentError, 'Scores must have same length as teams' if scores.size != teams.size
+        raise ArgumentError, "Scores must have same length as teams" if scores.size != teams.size
 
         scores.each do |score|
           raise ArgumentError, "All scores must be numeric, got #{score.class}" unless score.is_a?(Numeric)
@@ -412,7 +412,7 @@ module OpenSkill
       # Validate weights
       def validate_weights!(teams, weights)
         raise ArgumentError, "Weights must be an Array, got #{weights.class}" unless weights.is_a?(Array)
-        raise ArgumentError, 'Weights must have same length as teams' if weights.size != teams.size
+        raise ArgumentError, "Weights must have same length as teams" if weights.size != teams.size
 
         weights.each_with_index do |team_weights, idx|
           raise ArgumentError, "Weights for team #{idx} must be an Array" unless team_weights.is_a?(Array)
@@ -450,11 +450,11 @@ module OpenSkill
 
           sorted_team.each do |player|
             balance_weight = if @balance
-                               ordinal_diff = max_ordinal - player.ordinal
-                               1 + (ordinal_diff / (max_ordinal + @kappa))
-                             else
-                               1.0
-                             end
+              ordinal_diff = max_ordinal - player.ordinal
+              1 + (ordinal_diff / (max_ordinal + @kappa))
+            else
+              1.0
+            end
 
             mu_sum += player.mu * balance_weight
             sigma_squared_sum += (player.sigma * balance_weight)**2
@@ -474,10 +474,10 @@ module OpenSkill
         return [] if game.empty?
 
         team_scores = if ranks
-                        ranks.each_with_index.map { |rank, idx| rank || idx }
-                      else
-                        game.each_index.to_a
-                      end
+          ranks.each_with_index.map { |rank, idx| rank || idx }
+        else
+          game.each_index.to_a
+        end
 
         sorted_scores = team_scores.sort
         rank_map = {}
@@ -535,12 +535,12 @@ module OpenSkill
 
             # Calculate s based on rank comparison
             s = if team_q.rank > team_i.rank
-                  1.0 # team_i won
-                elsif team_q.rank == team_i.rank
-                  0.5 # draw
-                else
-                  0.0 # team_i lost
-                end
+              1.0 # team_i won
+            elsif team_q.rank == team_i.rank
+              0.5 # draw
+            else
+              0.0 # team_i lost
+            end
 
             # Accumulate omega
             omega += sigma_squared_to_ciq * (s - piq)

data/lib/openskill/models/bradley_terry_part.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require 'securerandom'
-require_relative '../statistics/normal'
-require_relative 'common'
+require "securerandom"
+require_relative "../statistics/normal"
+require_relative "common"
 
 module OpenSkill
   module Models
@@ -74,8 +74,8 @@ module OpenSkill
       # @raise [ArgumentError] if rating_array is invalid
       def load_rating(rating_array, name: nil)
         raise ArgumentError, "Rating must be an Array, got #{rating_array.class}" unless rating_array.is_a?(Array)
-        raise ArgumentError, 'Rating array must have exactly 2 elements' unless rating_array.size == 2
-        raise ArgumentError, 'Rating values must be numeric' unless rating_array.all? { |v| v.is_a?(Numeric) }
+        raise ArgumentError, "Rating array must have exactly 2 elements" unless rating_array.size == 2
+        raise ArgumentError, "Rating values must be numeric" unless rating_array.all? { |v| v.is_a?(Numeric) }
 
         Rating.new(mu: rating_array[0], sigma: rating_array[1], name: name)
       end
@@ -95,7 +95,7 @@ module OpenSkill
         validate_scores!(teams, scores) if scores
         validate_weights!(teams, weights) if weights
 
-        raise ArgumentError, 'Cannot provide both ranks and scores' if ranks && scores
+        raise ArgumentError, "Cannot provide both ranks and scores" if ranks && scores
 
         # Deep copy teams to avoid mutating input
         original_teams = teams
@@ -302,25 +302,25 @@ module OpenSkill
         end
 
         def <(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal < other.ordinal
         end
 
         def >(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal > other.ordinal
         end
 
         def <=(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal <= other.ordinal
         end
 
         def >=(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal >= other.ordinal
         end
@@ -379,8 +379,8 @@ module OpenSkill
 
       # Validate teams structure
       def validate_teams!(teams)
-        raise ArgumentError, 'Teams must be an Array' unless teams.is_a?(Array)
-        raise ArgumentError, 'Must have at least 2 teams' if teams.size < 2
+        raise ArgumentError, "Teams must be an Array" unless teams.is_a?(Array)
+        raise ArgumentError, "Must have at least 2 teams" if teams.size < 2
 
         teams.each_with_index do |team, idx|
           raise ArgumentError, "Team #{idx} must be an Array" unless team.is_a?(Array)
@@ -395,7 +395,7 @@ module OpenSkill
       # Validate ranks
       def validate_ranks!(teams, ranks)
         raise ArgumentError, "Ranks must be an Array, got #{ranks.class}" unless ranks.is_a?(Array)
-        raise ArgumentError, 'Ranks must have same length as teams' if ranks.size != teams.size
+        raise ArgumentError, "Ranks must have same length as teams" if ranks.size != teams.size
 
         ranks.each do |rank|
           raise ArgumentError, "All ranks must be numeric, got #{rank.class}" unless rank.is_a?(Numeric)
@@ -405,7 +405,7 @@ module OpenSkill
       # Validate scores
       def validate_scores!(teams, scores)
         raise ArgumentError, "Scores must be an Array, got #{scores.class}" unless scores.is_a?(Array)
-        raise ArgumentError, 'Scores must have same length as teams' if scores.size != teams.size
+        raise ArgumentError, "Scores must have same length as teams" if scores.size != teams.size
 
         scores.each do |score|
           raise ArgumentError, "All scores must be numeric, got #{score.class}" unless score.is_a?(Numeric)
@@ -415,7 +415,7 @@ module OpenSkill
       # Validate weights
       def validate_weights!(teams, weights)
         raise ArgumentError, "Weights must be an Array, got #{weights.class}" unless weights.is_a?(Array)
-        raise ArgumentError, 'Weights must have same length as teams' if weights.size != teams.size
+        raise ArgumentError, "Weights must have same length as teams" if weights.size != teams.size
 
         weights.each_with_index do |team_weights, idx|
           raise ArgumentError, "Weights for team #{idx} must be an Array" unless team_weights.is_a?(Array)
@@ -453,11 +453,11 @@ module OpenSkill
 
           sorted_team.each do |player|
             balance_weight = if @balance
-                               ordinal_diff = max_ordinal - player.ordinal
-                               1 + (ordinal_diff / (max_ordinal + @kappa))
-                             else
-                               1.0
-                             end
+              ordinal_diff = max_ordinal - player.ordinal
+              1 + (ordinal_diff / (max_ordinal + @kappa))
+            else
+              1.0
+            end
 
             mu_sum += player.mu * balance_weight
             sigma_squared_sum += (player.sigma * balance_weight)**2
@@ -477,10 +477,10 @@ module OpenSkill
         return [] if game.empty?
 
         team_scores = if ranks
-                        ranks.each_with_index.map { |rank, idx| rank || idx }
-                      else
-                        game.each_index.to_a
-                      end
+          ranks.each_with_index.map { |rank, idx| rank || idx }
+        else
+          game.each_index.to_a
+        end
 
         sorted_scores = team_scores.sort
         rank_map = {}
@@ -536,12 +536,12 @@ module OpenSkill
 
             # Calculate s based on rank comparison
             s = if team_q.rank > team_i.rank
-                  1.0 # team_i won
-                elsif team_q.rank == team_i.rank
-                  0.5 # draw
-                else
-                  0.0 # team_i lost
-                end
+              1.0 # team_i won
+            elsif team_q.rank == team_i.rank
+              0.5 # draw
+            else
+              0.0 # team_i lost
+            end
 
             # Accumulate omega and delta
             omega_sum += (team_i.sigma_squared / c_iq) * (s - piq)
@@ -563,8 +563,8 @@ module OpenSkill
           end
 
           # Average over comparisons
-          omega = comparisons > 0 ? omega_sum / comparisons : 0.0
-          delta = comparisons > 0 ? delta_sum / comparisons : 0.0
+          omega = (comparisons > 0) ? omega_sum / comparisons : 0.0
+          delta = (comparisons > 0) ? delta_sum / comparisons : 0.0
 
           # Update each player in the team
           team_i.team.each_with_index.map do |player, j|

data/lib/openskill/models/common.rb

@@ -84,7 +84,7 @@ module OpenSkill
         denominator = Statistics::Normal.cdf(xt)
 
         if denominator < Float::EPSILON
-          return x < 0 ? 1.0 : 0.0
+          return (x < 0) ? 1.0 : 0.0
         end
 
         v_val = v(x, t)
@@ -102,11 +102,11 @@ module OpenSkill
         b = Statistics::Normal.cdf(t - xx) - Statistics::Normal.cdf(-t - xx)
 
         if b < 1e-5
-          return x < 0 ? (-x - t) : (-x + t)
+          return (x < 0) ? (-x - t) : (-x + t)
         end
 
         a = Statistics::Normal.pdf(-t - xx) - Statistics::Normal.pdf(t - xx)
-        (x < 0 ? -a : a) / b
+        ((x < 0) ? -a : a) / b
       end
 
       # The W-tilde function for draws as defined in Weng-Lin 2011

data/lib/openskill/models/plackett_luce.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require 'securerandom'
-require_relative '../statistics/normal'
-require_relative 'common'
+require "securerandom"
+require_relative "../statistics/normal"
+require_relative "common"
 
 module OpenSkill
   module Models
@@ -71,8 +71,8 @@ module OpenSkill
       # @raise [ArgumentError] if rating_array is invalid
       def load_rating(rating_array, name: nil)
         raise ArgumentError, "Rating must be an Array, got #{rating_array.class}" unless rating_array.is_a?(Array)
-        raise ArgumentError, 'Rating array must have exactly 2 elements' unless rating_array.size == 2
-        raise ArgumentError, 'Rating values must be numeric' unless rating_array.all? { |v| v.is_a?(Numeric) }
+        raise ArgumentError, "Rating array must have exactly 2 elements" unless rating_array.size == 2
+        raise ArgumentError, "Rating values must be numeric" unless rating_array.all? { |v| v.is_a?(Numeric) }
 
         Rating.new(mu: rating_array[0], sigma: rating_array[1], name: name)
       end
@@ -93,7 +93,7 @@ module OpenSkill
         validate_weights!(teams, weights) if weights
 
         # Can't have both ranks and scores
-        raise ArgumentError, 'Cannot provide both ranks and scores' if ranks && scores
+        raise ArgumentError, "Cannot provide both ranks and scores" if ranks && scores
 
         # Deep copy teams to avoid mutating input
         original_teams = teams
@@ -300,25 +300,25 @@ module OpenSkill
         end
 
         def <(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal < other.ordinal
         end
 
         def >(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal > other.ordinal
         end
 
         def <=(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal <= other.ordinal
         end
 
         def >=(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal >= other.ordinal
         end
@@ -377,8 +377,8 @@ module OpenSkill
 
       # Validate teams structure
       def validate_teams!(teams)
-        raise ArgumentError, 'Teams must be an Array' unless teams.is_a?(Array)
-        raise ArgumentError, 'Must have at least 2 teams' if teams.size < 2
+        raise ArgumentError, "Teams must be an Array" unless teams.is_a?(Array)
+        raise ArgumentError, "Must have at least 2 teams" if teams.size < 2
 
         teams.each_with_index do |team, idx|
           raise ArgumentError, "Team #{idx} must be an Array" unless team.is_a?(Array)
@@ -393,7 +393,7 @@ module OpenSkill
       # Validate ranks
       def validate_ranks!(teams, ranks)
         raise ArgumentError, "Ranks must be an Array, got #{ranks.class}" unless ranks.is_a?(Array)
-        raise ArgumentError, 'Ranks must have same length as teams' if ranks.size != teams.size
+        raise ArgumentError, "Ranks must have same length as teams" if ranks.size != teams.size
 
         ranks.each do |rank|
           raise ArgumentError, "All ranks must be numeric, got #{rank.class}" unless rank.is_a?(Numeric)
@@ -403,7 +403,7 @@ module OpenSkill
       # Validate scores
       def validate_scores!(teams, scores)
         raise ArgumentError, "Scores must be an Array, got #{scores.class}" unless scores.is_a?(Array)
-        raise ArgumentError, 'Scores must have same length as teams' if scores.size != teams.size
+        raise ArgumentError, "Scores must have same length as teams" if scores.size != teams.size
 
         scores.each do |score|
           raise ArgumentError, "All scores must be numeric, got #{score.class}" unless score.is_a?(Numeric)
@@ -413,7 +413,7 @@ module OpenSkill
       # Validate weights
       def validate_weights!(teams, weights)
         raise ArgumentError, "Weights must be an Array, got #{weights.class}" unless weights.is_a?(Array)
-        raise ArgumentError, 'Weights must have same length as teams' if weights.size != teams.size
+        raise ArgumentError, "Weights must have same length as teams" if weights.size != teams.size
 
         weights.each_with_index do |team_weights, idx|
           raise ArgumentError, "Weights for team #{idx} must be an Array" unless team_weights.is_a?(Array)
@@ -481,7 +481,7 @@ module OpenSkill
               comparison_count += 1
             end
 
-            adjusted_mu += comparison_count > 0 ? (margin_adjustment / comparison_count) : margin_adjustment
+            adjusted_mu += (comparison_count > 0) ? (margin_adjustment / comparison_count) : margin_adjustment
           end
 
           summed = Math.exp(adjusted_mu / c_value)
@@ -516,11 +516,11 @@ module OpenSkill
 
           sorted_team.each do |player|
             balance_weight = if @balance
-                               ordinal_diff = max_ordinal - player.ordinal
-                               1 + (ordinal_diff / (max_ordinal + @kappa))
-                             else
-                               1.0
-                             end
+              ordinal_diff = max_ordinal - player.ordinal
+              1 + (ordinal_diff / (max_ordinal + @kappa))
+            else
+              1.0
+            end
 
             mu_sum += player.mu * balance_weight
             sigma_squared_sum += (player.sigma * balance_weight)**2
@@ -540,10 +540,10 @@ module OpenSkill
         return [] if game.empty?
 
         team_scores = if ranks
-                        ranks.each_with_index.map { |rank, idx| rank || idx }
-                      else
-                        game.each_index.to_a
-                      end
+          ranks.each_with_index.map { |rank, idx| rank || idx }
+        else
+          game.each_index.to_a
+        end
 
         sorted_scores = team_scores.sort
         rank_map = {}
@@ -603,7 +603,7 @@ module OpenSkill
               comparison_count += 1
             end
 
-            adjusted_mu_i += comparison_count > 0 ? (margin_adjustment / comparison_count) : margin_adjustment
+            adjusted_mu_i += (comparison_count > 0) ? (margin_adjustment / comparison_count) : margin_adjustment
           end
 
           i_mu_over_c = Math.exp(adjusted_mu_i / c_value)

data/lib/openskill/models/thurstone_mosteller_full.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require 'securerandom'
-require_relative '../statistics/normal'
-require_relative 'common'
+require "securerandom"
+require_relative "../statistics/normal"
+require_relative "common"
 
 module OpenSkill
   module Models
@@ -74,8 +74,8 @@ module OpenSkill
       # @raise [ArgumentError] if rating_array is invalid
       def load_rating(rating_array, name: nil)
         raise ArgumentError, "Rating must be an Array, got #{rating_array.class}" unless rating_array.is_a?(Array)
-        raise ArgumentError, 'Rating array must have exactly 2 elements' unless rating_array.size == 2
-        raise ArgumentError, 'Rating values must be numeric' unless rating_array.all? { |v| v.is_a?(Numeric) }
+        raise ArgumentError, "Rating array must have exactly 2 elements" unless rating_array.size == 2
+        raise ArgumentError, "Rating values must be numeric" unless rating_array.all? { |v| v.is_a?(Numeric) }
 
         Rating.new(mu: rating_array[0], sigma: rating_array[1], name: name)
       end
@@ -95,7 +95,7 @@ module OpenSkill
         validate_scores!(teams, scores) if scores
         validate_weights!(teams, weights) if weights
 
-        raise ArgumentError, 'Cannot provide both ranks and scores' if ranks && scores
+        raise ArgumentError, "Cannot provide both ranks and scores" if ranks && scores
 
         # Deep copy teams to avoid mutating input
         original_teams = teams
@@ -302,25 +302,25 @@ module OpenSkill
         end
 
         def <(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal < other.ordinal
         end
 
         def >(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal > other.ordinal
         end
 
         def <=(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal <= other.ordinal
         end
 
         def >=(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal >= other.ordinal
         end
@@ -379,8 +379,8 @@ module OpenSkill
 
       # Validate teams structure
       def validate_teams!(teams)
-        raise ArgumentError, 'Teams must be an Array' unless teams.is_a?(Array)
-        raise ArgumentError, 'Must have at least 2 teams' if teams.size < 2
+        raise ArgumentError, "Teams must be an Array" unless teams.is_a?(Array)
+        raise ArgumentError, "Must have at least 2 teams" if teams.size < 2
 
         teams.each_with_index do |team, idx|
           raise ArgumentError, "Team #{idx} must be an Array" unless team.is_a?(Array)
@@ -395,7 +395,7 @@ module OpenSkill
       # Validate ranks
       def validate_ranks!(teams, ranks)
         raise ArgumentError, "Ranks must be an Array, got #{ranks.class}" unless ranks.is_a?(Array)
-        raise ArgumentError, 'Ranks must have same length as teams' if ranks.size != teams.size
+        raise ArgumentError, "Ranks must have same length as teams" if ranks.size != teams.size
 
         ranks.each do |rank|
           raise ArgumentError, "All ranks must be numeric, got #{rank.class}" unless rank.is_a?(Numeric)
@@ -405,7 +405,7 @@ module OpenSkill
       # Validate scores
       def validate_scores!(teams, scores)
         raise ArgumentError, "Scores must be an Array, got #{scores.class}" unless scores.is_a?(Array)
-        raise ArgumentError, 'Scores must have same length as teams' if scores.size != teams.size
+        raise ArgumentError, "Scores must have same length as teams" if scores.size != teams.size
 
         scores.each do |score|
           raise ArgumentError, "All scores must be numeric, got #{score.class}" unless score.is_a?(Numeric)
@@ -415,7 +415,7 @@ module OpenSkill
       # Validate weights
       def validate_weights!(teams, weights)
         raise ArgumentError, "Weights must be an Array, got #{weights.class}" unless weights.is_a?(Array)
-        raise ArgumentError, 'Weights must have same length as teams' if weights.size != teams.size
+        raise ArgumentError, "Weights must have same length as teams" if weights.size != teams.size
 
         weights.each_with_index do |team_weights, idx|
           raise ArgumentError, "Weights for team #{idx} must be an Array" unless team_weights.is_a?(Array)
@@ -453,11 +453,11 @@ module OpenSkill
 
           sorted_team.each do |player|
             balance_weight = if @balance
-                               ordinal_diff = max_ordinal - player.ordinal
-                               1 + (ordinal_diff / (max_ordinal + @kappa))
-                             else
-                               1.0
-                             end
+              ordinal_diff = max_ordinal - player.ordinal
+              1 + (ordinal_diff / (max_ordinal + @kappa))
+            else
+              1.0
+            end
 
             mu_sum += player.mu * balance_weight
             sigma_squared_sum += (player.sigma * balance_weight)**2
@@ -477,10 +477,10 @@ module OpenSkill
         return [] if game.empty?
 
         team_scores = if ranks
-                        ranks.each_with_index.map { |rank, idx| rank || idx }
-                      else
-                        game.each_index.to_a
-                      end
+          ranks.each_with_index.map { |rank, idx| rank || idx }
+        else
+          game.each_index.to_a
+        end
 
         sorted_scores = team_scores.sort
         rank_map = {}

data/lib/openskill/models/thurstone_mosteller_part.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require 'securerandom'
-require_relative '../statistics/normal'
-require_relative 'common'
+require "securerandom"
+require_relative "../statistics/normal"
+require_relative "common"
 
 module OpenSkill
   module Models
@@ -77,8 +77,8 @@ module OpenSkill
       # @raise [ArgumentError] if rating_array is invalid
       def load_rating(rating_array, name: nil)
         raise ArgumentError, "Rating must be an Array, got #{rating_array.class}" unless rating_array.is_a?(Array)
-        raise ArgumentError, 'Rating array must have exactly 2 elements' unless rating_array.size == 2
-        raise ArgumentError, 'Rating values must be numeric' unless rating_array.all? { |v| v.is_a?(Numeric) }
+        raise ArgumentError, "Rating array must have exactly 2 elements" unless rating_array.size == 2
+        raise ArgumentError, "Rating values must be numeric" unless rating_array.all? { |v| v.is_a?(Numeric) }
 
         Rating.new(mu: rating_array[0], sigma: rating_array[1], name: name)
       end
@@ -98,7 +98,7 @@ module OpenSkill
         validate_scores!(teams, scores) if scores
         validate_weights!(teams, weights) if weights
 
-        raise ArgumentError, 'Cannot provide both ranks and scores' if ranks && scores
+        raise ArgumentError, "Cannot provide both ranks and scores" if ranks && scores
 
         # Deep copy teams to avoid mutating input
         original_teams = teams
@@ -305,25 +305,25 @@ module OpenSkill
         end
 
         def <(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal < other.ordinal
         end
 
         def >(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal > other.ordinal
         end
 
         def <=(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal <= other.ordinal
         end
 
         def >=(other)
-          raise ArgumentError, 'comparison with non-Rating' unless other.is_a?(Rating)
+          raise ArgumentError, "comparison with non-Rating" unless other.is_a?(Rating)
 
           ordinal >= other.ordinal
         end
@@ -382,8 +382,8 @@ module OpenSkill
 
       # Validate teams structure
       def validate_teams!(teams)
-        raise ArgumentError, 'Teams must be an Array' unless teams.is_a?(Array)
-        raise ArgumentError, 'Must have at least 2 teams' if teams.size < 2
+        raise ArgumentError, "Teams must be an Array" unless teams.is_a?(Array)
+        raise ArgumentError, "Must have at least 2 teams" if teams.size < 2
 
         teams.each_with_index do |team, idx|
           raise ArgumentError, "Team #{idx} must be an Array" unless team.is_a?(Array)
@@ -398,7 +398,7 @@ module OpenSkill
       # Validate ranks
       def validate_ranks!(teams, ranks)
         raise ArgumentError, "Ranks must be an Array, got #{ranks.class}" unless ranks.is_a?(Array)
-        raise ArgumentError, 'Ranks must have same length as teams' if ranks.size != teams.size
+        raise ArgumentError, "Ranks must have same length as teams" if ranks.size != teams.size
 
         ranks.each do |rank|
           raise ArgumentError, "All ranks must be numeric, got #{rank.class}" unless rank.is_a?(Numeric)
@@ -408,7 +408,7 @@ module OpenSkill
       # Validate scores
       def validate_scores!(teams, scores)
         raise ArgumentError, "Scores must be an Array, got #{scores.class}" unless scores.is_a?(Array)
-        raise ArgumentError, 'Scores must have same length as teams' if scores.size != teams.size
+        raise ArgumentError, "Scores must have same length as teams" if scores.size != teams.size
 
         scores.each do |score|
           raise ArgumentError, "All scores must be numeric, got #{score.class}" unless score.is_a?(Numeric)
@@ -418,7 +418,7 @@ module OpenSkill
       # Validate weights
       def validate_weights!(teams, weights)
         raise ArgumentError, "Weights must be an Array, got #{weights.class}" unless weights.is_a?(Array)
-        raise ArgumentError, 'Weights must have same length as teams' if weights.size != teams.size
+        raise ArgumentError, "Weights must have same length as teams" if weights.size != teams.size
 
         weights.each_with_index do |team_weights, idx|
           raise ArgumentError, "Weights for team #{idx} must be an Array" unless team_weights.is_a?(Array)
@@ -456,11 +456,11 @@ module OpenSkill
 
           sorted_team.each do |player|
             balance_weight = if @balance
-                               ordinal_diff = max_ordinal - player.ordinal
-                               1 + (ordinal_diff / (max_ordinal + @kappa))
-                             else
-                               1.0
-                             end
+              ordinal_diff = max_ordinal - player.ordinal
+              1 + (ordinal_diff / (max_ordinal + @kappa))
+            else
+              1.0
+            end
 
             mu_sum += player.mu * balance_weight
             sigma_squared_sum += (player.sigma * balance_weight)**2
@@ -480,10 +480,10 @@ module OpenSkill
         return [] if game.empty?
 
         team_scores = if ranks
-                        ranks.each_with_index.map { |rank, idx| rank || idx }
-                      else
-                        game.each_index.to_a
-                      end
+          ranks.each_with_index.map { |rank, idx| rank || idx }
+        else
+          game.each_index.to_a
+        end
 
         sorted_scores = team_scores.sort
         rank_map = {}
@@ -567,8 +567,8 @@ module OpenSkill
           end
 
           # Average over comparisons
-          omega = comparisons > 0 ? omega_sum / comparisons : 0.0
-          delta = comparisons > 0 ? delta_sum / comparisons : 0.0
+          omega = (comparisons > 0) ? omega_sum / comparisons : 0.0
+          delta = (comparisons > 0) ? delta_sum / comparisons : 0.0
 
           # Update each player in the team
           team_i.team.each_with_index.map do |player, j|

data/lib/openskill/statistics/normal.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'distribution'
+require "distribution"
 
 module OpenSkill
   module Statistics

data/lib/openskill/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OpenSkill
-  VERSION = '1.0.0'
+  VERSION = "1.0.1"
 end

data/lib/openskill.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
-require_relative 'openskill/version'
-require_relative 'openskill/statistics/normal'
-require_relative 'openskill/models/common'
-require_relative 'openskill/models/plackett_luce'
-require_relative 'openskill/models/bradley_terry_full'
-require_relative 'openskill/models/bradley_terry_part'
-require_relative 'openskill/models/thurstone_mosteller_full'
-require_relative 'openskill/models/thurstone_mosteller_part'
+require_relative "openskill/version"
+require_relative "openskill/statistics/normal"
+require_relative "openskill/models/common"
+require_relative "openskill/models/plackett_luce"
+require_relative "openskill/models/bradley_terry_full"
+require_relative "openskill/models/bradley_terry_part"
+require_relative "openskill/models/thurstone_mosteller_full"
+require_relative "openskill/models/thurstone_mosteller_part"
 
 module OpenSkill
   class Error < StandardError; end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openskill
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Tamas Erdos
@@ -10,45 +10,45 @@ cert_chain: []
 date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: bigdecimal
+  name: distribution
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '0.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
-  name: distribution
+  name: bigdecimal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: prime
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.1'
 - !ruby/object:Gem::Dependency
@@ -79,6 +79,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '13.0'
+- !ruby/object:Gem::Dependency
+  name: standardrb
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A Ruby implementation of the OpenSkill rating system, providing Bayesian
   skill ratings for multiplayer games
 email:
@@ -116,7 +130,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.20
 specification_version: 4
 summary: Multiplayer rating system for Ruby
 test_files: []