openproject-primer_view_components 0.63.0 → 0.64.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1a157780e81b4a84c0814e2b933b4f2e2fcf6ad74d549353b058fc8012b57fea
-  data.tar.gz: 3ab915e6a83249d059e8a95b6a21e3739c8ac6b73bf22486ae2601020e2971e3
+  metadata.gz: c14efbdaa174fe50a4ab8910f0d4d15b7395e9cb13f10c437a733205f31a713a
+  data.tar.gz: '06395f1e3999aad177aed7b3312f0ce397fdc02893cca1ed55b8788d58ba915f'
 SHA512:
-  metadata.gz: a0b70e6823a3bc2d69de91864ccde36d0d8063fda209c829f041e8ba63105c1f3d97acfbed26bba8b8fd53c4e6ddf3f4486199a245653988d308bdceaca5f742
-  data.tar.gz: 026dbfd7490dfa3e53e43802e45947089ee1c5776d9db4e6eda22e20d914ae979cc7af3b0afb4a0a2266f5d2594d370265c1052072f997642c6a300672e8579a
+  metadata.gz: 2c24a2a4acee0ffe10644fa9d1195b2640fac91f77159c9919359b0585e72931d4b541676f3021dcc921c0523a829f21963eda4fb62024fb72d9be700540985b
+  data.tar.gz: 8785b506bc36848f1251bff3d7e85631fa9a5b9dd3a4c6b21e1d2333bf79ae8dcef228b6d023b9909a7b051dfb430e1815273b4370618b81e19d7ce9a7b02989

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # CHANGELOG
 
+## 0.64.0
+
+### Minor Changes
+
+- [#3466](https://github.com/primer/view_components/pull/3466) [`57f6c41`](https://github.com/opf/primer_view_components/commit/57f6c41025de70dfcd6880dab7e881d182e3cbd9) Thanks [@manuelpuyol](https://github.com/manuelpuyol)! - Create Primer::CurrentAttributes allowing apps to set request specific context to components. Update IncludeFragment to add data-nonce when a current nonce is present.
+
+### Patch Changes
+
+- [#3447](https://github.com/primer/view_components/pull/3447) [`c2b88cb`](https://github.com/opf/primer_view_components/commit/c2b88cb1d75e86fc0b410e3fc597e48326f471a5) Thanks [@bsatarnejad](https://github.com/bsatarnejad)! - Add a new custom label for close button in dialog header
+
+- [#3450](https://github.com/primer/view_components/pull/3450) [`5e86bf4`](https://github.com/opf/primer_view_components/commit/5e86bf422b13a3818def5ceab464f8e362f9021b) Thanks [@francinelucca](https://github.com/francinelucca)! - Fix(SelectPanel): incorrect padding when no filter
+
 ## 0.63.0
 
 ### Minor Changes

data/app/components/primer/alpha/dialog/header.html.erb

@@ -13,7 +13,7 @@
       <% end %>
     </div>
     <div class="Overlay-actionWrap">
-      <%= render Primer::Beta::CloseButton.new(classes: "Overlay-closeButton", "data-close-dialog-id": @id) %>
+      <%= render Primer::Beta::CloseButton.new(classes: "Overlay-closeButton", "data-close-dialog-id": @id, aria: { label: @close_label }) %>
     </div>
   </div>
   <%= filter %>

data/app/components/primer/alpha/dialog/header.rb

@@ -16,6 +16,8 @@ module Primer
         }.freeze
         VARIANT_OPTIONS = VARIANT_MAPPINGS.keys
 
+        DEFAULT_CLOSE_LABEL = "Close"
+
         # Optional filter slot for adding a filter input to the header.
         #
         # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
@@ -48,6 +50,7 @@ module Primer
         # @param show_divider [Boolean] Show a divider between the header and body.
         # @param visually_hide_title [Boolean] Visually hide the `title` while maintaining a label for assistive technologies.
         # @param variant [Symbol] <%= one_of(Primer::Alpha::Dialog::Header::VARIANT_OPTIONS) %>
+        # @param close_label [String] The aria-label text of the close "x" button.
         # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
         def initialize(
           id:,
@@ -56,12 +59,14 @@ module Primer
           show_divider: false,
           visually_hide_title: false,
           variant: DEFAULT_VARIANT,
+          close_label: DEFAULT_CLOSE_LABEL,
           **system_arguments
         )
           @id = id
           @title = title
           @subtitle = subtitle
           @visually_hide_title = visually_hide_title
+          @close_label = close_label
           @system_arguments = deny_tag_argument(**system_arguments)
           @system_arguments[:tag] = :div
 

data/app/components/primer/alpha/include_fragment.rb

@@ -8,14 +8,27 @@ module Primer
     class IncludeFragment < Primer::Component
       status :alpha
 
+      ALLOWED_LOADING_VALUES = [:lazy, :eager].freeze
+      DEFAULT_LOADING = :eager
+
       # @param src [String] The URL  from which to retrieve an HTML element fragment.
       # @param loading [Symbol] <%= one_of([:lazy, :eager]) %>
+      # @param accept [String] What to send as the Accept header.
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
-      def initialize(src: nil, loading: :eager, **system_arguments)
+      def initialize(src: nil, loading: nil, accept: nil, **system_arguments)
         @system_arguments = system_arguments
         @system_arguments[:tag] = "include-fragment"
         @system_arguments[:loading] = loading
         @system_arguments[:src] = src
+        @system_arguments[:accept] = accept if accept
+
+        if loading
+          @system_arguments[:loading] = fetch_or_fallback(ALLOWED_LOADING_VALUES, loading.to_sym, DEFAULT_LOADING)
+        end
+
+        if Primer::CurrentAttributes.nonce
+          @system_arguments[:"data-nonce"] = Primer::CurrentAttributes.nonce
+        end
       end
 
       def call

data/app/components/primer/alpha/select_panel.html.erb

@@ -50,7 +50,7 @@
           <% end %>
         <% end %>
       <% end %>
-      <%= render Primer::Alpha::Dialog::Body.new(mt: show_filter? ? 0 : 2, p: 0) do %>
+      <%= render Primer::Alpha::Dialog::Body.new(p: 0) do %>
         <focus-group direction="vertical" mnemonics retain>
           <live-region data-target="select-panel.liveRegion"></live-region>
           <%= render(Primer::BaseComponent.new(

data/app/lib/primer/current_attributes.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module Primer
+  # `Primer::CurrentAttributes` can be used by controllers to set request-bound data
+  # that can be propagated to components.
+  class CurrentAttributes < ActiveSupport::CurrentAttributes
+    attribute :nonce
+  end
+end

data/lib/primer/view_components/version.rb

@@ -5,7 +5,7 @@ module Primer
   module ViewComponents
     module VERSION
       MAJOR = 0
-      MINOR = 63
+      MINOR = 64
       PATCH = 0
 
       STRING = [MAJOR, MINOR, PATCH].join(".")

data/previews/primer/alpha/dialog_preview/with_header_close_button_label.html.erb

@@ -0,0 +1,5 @@
+<%= render(Primer::Alpha::Dialog.new(id: "my-dialog", title: title, subtitle: subtitle, visually_hide_title: false)) do |dialog| %>
+  <% dialog.with_header(show_divider: show_divider, close_label: close_label) %>
+  <% dialog.with_show_button_content(button_text) %>
+  <% dialog.with_body_content("Hello World") %>
+<% end %>

data/previews/primer/alpha/dialog_preview/without_header_close_button_label.html.erb

@@ -0,0 +1,8 @@
+<%= render(Primer::Alpha::Dialog.new(id: "my-dialog", title: title, subtitle: subtitle, visually_hide_title: false)) do |dialog| %>
+  <% dialog.with_header(show_divider: show_divider, close_scheme: :none) %>
+  <% dialog.with_show_button_content(button_text) %>
+  <% dialog.with_body_content("Hello World") %>
+  <% dialog.with_footer do %>
+    <%= render(Primer::Beta::Button.new(data: { "close-dialog-id": "my-dialog" })) { "Close" } %>
+  <% end %>
+<% end %>

data/previews/primer/alpha/dialog_preview.rb

@@ -302,6 +302,38 @@ module Primer
       def with_header_filter
         render_with_template(locals: {})
       end
+
+      # @label With custom label for close button of header
+      #
+      # @param title [String] text
+      # @param subtitle [String] text
+      # @param button_text [String] text
+      # @param show_divider [Boolean] toggle
+      # @param close_label [String] text
+      def with_header_close_button_label(title: "Test Dialog", subtitle: nil, button_text: "Show Dialog", show_divider: true, close_label: "Close me!")
+        render_with_template(locals: {
+          title: title,
+          subtitle: subtitle,
+          button_text: button_text,
+          show_divider: show_divider,
+          close_label: close_label
+        })
+      end
+
+      # @label Without custom label for close button of header
+      #
+      # @param title [String] text
+      # @param subtitle [String] text
+      # @param button_text [String] text
+      # @param show_divider [Boolean] toggle
+      def without_header_close_button_label(title: "Test Dialog", subtitle: nil, button_text: "Show Dialog", show_divider: true)
+        render_with_template(locals: {
+          title: title,
+          subtitle: subtitle,
+          button_text: button_text,
+          show_divider: show_divider
+        })
+      end
     end
   end
 end

data/previews/primer/open_project/page_header_preview/playground.html.erb

@@ -10,7 +10,7 @@
   <%= header.with_breadcrumbs(breadcrumb_items) %>
   <% if with_actions %>
     <% header.with_action_icon_button(icon: 'pencil', mobile_icon: 'pencil', label: 'Edit') %>
-    <% header.with_action_menu(menu_arguments: { anchor_align: :end }, button_arguments: { icon: "op-kebab-vertical", "aria-label": "Menu" }) do |menu, button| %>
+    <% header.with_action_menu(menu_arguments: { anchor_align: :end }, button_arguments: { icon: "kebab-horizontal", "aria-label": "Menu" }) do |menu, button| %>
       <% menu.with_item(label: "Subitem 1") do |item| %>
         <% item.with_leading_visual_icon(icon: :unlock) %>
       <% end %>

data/previews/primer/open_project/sub_header_preview/action_menu_buttons.html.erb

@@ -3,7 +3,7 @@
 
   <% component.with_action_component do %>
     <%= render Primer::Alpha::ActionMenu.new(menu_id: "menu-1") do |menu|
-      menu.with_show_button(icon: :"op-kebab-vertical", "aria-label": "Menu")
+      menu.with_show_button(icon: :"kebab-horizontal", "aria-label": "Menu")
       menu.with_item(label: "Subitem 1") do |item|
         item.with_leading_visual_icon(icon: :paste)
       end

data/static/arguments.json

@@ -1070,6 +1070,12 @@
         "default": "`:medium`",
         "description": "One of `:large` or `:medium`."
       },
+      {
+        "name": "close_label",
+        "type": "String",
+        "default": "`Close`",
+        "description": "The aria-label text of the close \"x\" button."
+      },
       {
         "name": "system_arguments",
         "type": "Hash",
@@ -1374,9 +1380,15 @@
       {
         "name": "loading",
         "type": "Symbol",
-        "default": "`:eager`",
+        "default": "`nil`",
         "description": "One of `:eager` or `:lazy`."
       },
+      {
+        "name": "accept",
+        "type": "String",
+        "default": "`nil`",
+        "description": "What to send as the Accept header."
+      },
       {
         "name": "system_arguments",
         "type": "Hash",

data/static/constants.json

@@ -323,6 +323,7 @@
     "GeneratedSlotMethods": "Primer::Alpha::Dialog::Footer::GeneratedSlotMethods"
   },
   "Primer::Alpha::Dialog::Header": {
+    "DEFAULT_CLOSE_LABEL": "Close",
     "DEFAULT_VARIANT": "medium",
     "GeneratedSlotMethods": "Primer::Alpha::Dialog::Header::GeneratedSlotMethods",
     "VARIANT_MAPPINGS": {
@@ -392,6 +393,11 @@
     "GeneratedSlotMethods": "Primer::Alpha::Image::GeneratedSlotMethods"
   },
   "Primer::Alpha::IncludeFragment": {
+    "ALLOWED_LOADING_VALUES": [
+      "lazy",
+      "eager"
+    ],
+    "DEFAULT_LOADING": "eager",
     "GeneratedSlotMethods": "Primer::Alpha::IncludeFragment::GeneratedSlotMethods"
   },
   "Primer::Alpha::Layout": {

data/static/info_arch.json

@@ -3646,6 +3646,32 @@
             "color-contrast"
           ]
         }
+      },
+      {
+        "preview_path": "primer/alpha/dialog/with_header_close_button_label",
+        "name": "with_header_close_button_label",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
+      },
+      {
+        "preview_path": "primer/alpha/dialog/without_header_close_button_label",
+        "name": "without_header_close_button_label",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
       }
     ],
     "subcomponents": [
@@ -3699,6 +3725,12 @@
             "default": "`:medium`",
             "description": "One of `:large` or `:medium`."
           },
+          {
+            "name": "close_label",
+            "type": "String",
+            "default": "`Close`",
+            "description": "The aria-label text of the close \"x\" button."
+          },
           {
             "name": "system_arguments",
             "type": "Hash",
@@ -4702,9 +4734,15 @@
       {
         "name": "loading",
         "type": "Symbol",
-        "default": "`:eager`",
+        "default": "`nil`",
         "description": "One of `:eager` or `:lazy`."
       },
+      {
+        "name": "accept",
+        "type": "String",
+        "default": "`nil`",
+        "description": "What to send as the Accept header."
+      },
       {
         "name": "system_arguments",
         "type": "Hash",

data/static/previews.json

@@ -3717,6 +3717,32 @@
             "color-contrast"
           ]
         }
+      },
+      {
+        "preview_path": "primer/alpha/dialog/with_header_close_button_label",
+        "name": "with_header_close_button_label",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
+      },
+      {
+        "preview_path": "primer/alpha/dialog/without_header_close_button_label",
+        "name": "without_header_close_button_label",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
       }
     ]
   },

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openproject-primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.63.0
+  version: 0.64.0
 platform: ruby
 authors:
 - GitHub Open Source
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-04-17 00:00:00.000000000 Z
+date: 2025-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -45,14 +45,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 19.23.0
+        version: 19.25.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 19.23.0
+        version: 19.25.0
 - !ruby/object:Gem::Dependency
   name: view_component
   requirement: !ruby/object:Gem::Requirement
@@ -653,6 +653,7 @@ files:
 - app/lib/primer/css/layout.css.json
 - app/lib/primer/css/utilities.css
 - app/lib/primer/css/utilities.css.json
+- app/lib/primer/current_attributes.rb
 - app/lib/primer/experimental_render_helpers.rb
 - app/lib/primer/experimental_slot_helpers.rb
 - app/lib/primer/fetch_or_fallback_helper.rb
@@ -890,8 +891,10 @@ files:
 - previews/primer/alpha/dialog_preview/with_footer.html.erb
 - previews/primer/alpha/dialog_preview/with_form.html.erb
 - previews/primer/alpha/dialog_preview/with_header.html.erb
+- previews/primer/alpha/dialog_preview/with_header_close_button_label.html.erb
 - previews/primer/alpha/dialog_preview/with_header_filter.html.erb
 - previews/primer/alpha/dialog_preview/with_text_input.html.erb
+- previews/primer/alpha/dialog_preview/without_header_close_button_label.html.erb
 - previews/primer/alpha/dropdown_preview.rb
 - previews/primer/alpha/form_control_preview.rb
 - previews/primer/alpha/form_control_preview/playground.html.erb