opengraph_transporter 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f61770592a17b75bd0d83fb77cfa8333bb8d47b7
-  data.tar.gz: fd922a9770ee3f0b21ae06005cbdf961289b60cf
+  metadata.gz: d9dfbf1c2f753ed6527becf7c583032a64c7edd1
+  data.tar.gz: 1d86006b6e2d7c0fc5759a1610b15256235b6fc9
 SHA512:
-  metadata.gz: f717d8e5f1f76d3def9a3e3f4ee7bd8dc019d33f640240da06776745f002bcfeb9f98cd0d91c761d2437416ee54dc15a59849d61c4edb678c4b15338ace27909
-  data.tar.gz: 33228276e66562e2d670e1d9b4fa7227339028663b3c82146f5655cf34403dc78ad12a8eb5482e0010acf4c87c3145282d30d41b6f0ba5e192b51ddf380c2d23
+  metadata.gz: f288df21619bd8146375bd324cd9b1271afb990213a1f3a2ea0c997bf2b760606013853886a2aa08e5de76d98f411d4b886866fc2854240ea9b908a109918e82
+  data.tar.gz: 3be213e978d3cf21ed462035a438df46ed70ccab6d5e278792624e77384881e6d047fc4bb128c3c1e2ec76ff1a75351c87261c91e585f1065922874f040cd68e

data/README.md

@@ -27,20 +27,34 @@ Or install it yourself as:
 ### Facebook 
 * Admin Role on Facebook Developer Applications used in translations export process.
 * Translation process is dependent on English(US) primary language selection (this will be configurable in future releases).
+* Consistent Destination App Open Graph story configuration.
 
 ## Usage
 
 1. Run opengraph_transporter
 2. Enter Source Facebook Developer App ID and App Secret
 3. Enter Destination Facebook Developer App ID and App Secret
-4. Enter App translations locale.
-5. Follow the prompts.
+4. Enter Facebook translations Primary Locale (primary language locale - generally defaults to en_US).
+5. Enter Facebook translations App locale.
+6. Follow the prompts.
 
 
 ```
+$ Please Enter Source Application Id
+  619023458209241
+
+$ Please Enter Source Application Secret
+  2a1c3c1a878e8f52a8b7788dfe89g15f
+
+$ Please Enter Destination Application Id
+  639876543218648
+
 $ Please Enter Destination Application Secret
-  29ae3b7d426106eae639754eb6855ef1
-  
+  29ae3c3bd62106eae636132be8676eb2
+
+$ Please Enter Primary Locale
+  en_US
+
 $ Please Enter App Locale
   pt_BR
 ```

data/lib/opengraph_transporter/base.rb

@@ -48,9 +48,9 @@ module OpengraphTransporter
       end
 
       def run_export
-       translation[:dst_translation_arr] = Scraper.ingest_app_translations(translation[:destination_application_id], translation[:app_locale])
+       translation[:dst_translation_arr] = Scraper.ingest_app_translations(translation[:destination_application_id], translation[:app_locale], translation[:primary_locale])
        if translation[:dst_translation_arr].length == 0
-         say("No destination app <%= color('(#{Base.translation[:dst_app_name]})', RED, BOLD) %> Open Graph Translations found, please check that Open Graph stories exist and localization.")  
+         say("No destination app <%= color('(#{Base.translation[:dst_app_name]})', RED, BOLD) %> Open Graph Translations found, please check that Open Graph stories exist and locales are correct.")  
        else
          translation[:src_translation_arr] = Scraper.update_display_names!(translation[:src_translation_arr], translation[:src_app_name].to_s, translation[:dst_app_name].to_s)
          translations_cleanup
@@ -123,10 +123,15 @@ module OpengraphTransporter
         end
         if translation[:app_locale].empty? 
           error_keys << "app_locale"
+        elsif translation[:primary_locale].empty? 
+          error_keys << "primary_locale"
         else
           if !locales.include?(translation[:app_locale])
             error_keys << "app_locale"
           end
+          if !locales.include?(translation[:primary_locale])
+            error_keys << "primary_locale"
+          end
         end
   
         if !error_keys.empty?
@@ -169,7 +174,7 @@ module OpengraphTransporter
       end
 
       def initialize_translation
-        @@translation ||= {:source_application_id => '', :source_application_secret => '', :destination_application_id => '', :destination_application_secret => '', :app_locale => '' }
+        @@translation ||= {:source_application_id => '', :source_application_secret => '', :destination_application_id => '', :destination_application_secret => '', :primary_locale => '', :app_locale => '' }
       end
 
       def translations_cleanup

data/lib/opengraph_transporter/browser.rb

@@ -2,6 +2,7 @@ module OpengraphTransporter
   class Browser
 
     MAX_TRANSLATION_PAGE_LIMIT = 30
+    DEFAULT_PRIMARY_LOCALE = "en_US"
 
     class << self
 
@@ -15,7 +16,11 @@ module OpengraphTransporter
           @translation_arr = @translation [:dst_translation_arr].clone
           fb_login
 
-          developer_translations_home_uri = "https://www.facebook.com/translations/admin/browse.php?search=&sloc=en_US&aloc=#{@translation[:app_locale]}&app=#{@translation[:destination_application_id]}"
+          if @translation[:primary_locale].nil?
+            primary_locale = DEFAULT_PRIMARY_LOCALE
+          end
+
+          developer_translations_home_uri = "https://www.facebook.com/translations/admin/browse.php?search=&sloc=#{primary_locale}&aloc=#{@translation[:app_locale]}&app=#{@translation[:destination_application_id]}"
           @browser.goto developer_translations_home_uri
           GracefulQuit.enable
           parse_translation_rows

data/lib/opengraph_transporter/common.rb

@@ -69,6 +69,7 @@ module OpengraphTransporter
         say("<%= color('\n***********************************************************************************************************', YELLOW, BOLD) %>")
         say("Source Application ID:      <%= color('#{Base.translation[:source_application_id]}', YELLOW, BOLD) %>     Application Name: <%= color('#{Base.translation[:src_app_name]}', YELLOW, BOLD) %>")
         say("Destination Application ID: <%= color('#{Base.translation[:destination_application_id]}', YELLOW, BOLD) %>     Application Name: <%= color('#{Base.translation[:dst_app_name]}', YELLOW, BOLD) %>")
+        say("Primary Locale:      <%= color('#{Base.translation[:primary_locale]}', YELLOW, BOLD) %>")
         say("Selected Locale:      <%= color('#{Base.translation[:app_locale]}', YELLOW, BOLD) %>")
         say("<%= color('***********************************************************************************************************\n', YELLOW, BOLD) %>")
       end

data/lib/opengraph_transporter/scraper.rb

@@ -3,13 +3,18 @@ module OpengraphTransporter
 
     MAX_FB_LOGIN_ATTEMPTS = 3
     MAX_TRANSLATION_PAGE_LIMIT = 30
+    DEFAULT_PRIMARY_LOCALE = "en_US"
  
     class << self
   
-      def ingest_app_translations(app_id, locale)
+      def ingest_app_translations(app_id, locale, primary_locale)
+        if primary_locale.nil?
+          primary_locale = DEFAULT_PRIMARY_LOCALE
+        end
         @agent = Mechanize.new
         # Defaulting to en_US native locale
-        source_app_uri = "https://www.facebook.com/translations/admin/browse.php?search&sloc=en_US&aloc=#{locale}&app=#{app_id}"
+        source_app_uri = "https://www.facebook.com/translations/admin/browse.php?search&sloc=#{primary_locale}&aloc=#{locale}&app=#{app_id}"
+        
         @agent.get(source_app_uri)
         login_attempt = 1
         login(login_attempt) do |continue|
@@ -119,7 +124,7 @@ module OpengraphTransporter
       end
 
       def get_user_credentials
-        Base.user[:fb_username] = ask("Facebook Username:  ", lambda { |u| u.to_s.strip } ) do |q|
+        Base.user[:fb_username] = ask("Facebook Email:  ", lambda { |u| u.to_s.strip } ) do |q|
           q.validate              = lambda { |p|  (p =~ /^.+@.+$/) != nil }
           q.responses[:not_valid] = "Please enter a valid email address."
         end

data/lib/opengraph_transporter/version.rb

@@ -1,3 +1,3 @@
 module OpengraphTransporter
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: opengraph_transporter
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Barry Quigley