opener-opinion-detector-basic 3.2.5 → 3.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7768f85ad9e9b1641fccc5a5abc5448bce4ca4909c296ba38585395f252460ae
-  data.tar.gz: a0fffe7f7b235421b8a64714779842d92632a2aecdc2d811a463c3c181781089
+  metadata.gz: 7bf885ed5d9cd309933e3419dc00f13073e42038e102bf58ed029e9ac6762101
+  data.tar.gz: c9b7248d4a8dd672b6d0246994e643d845ebbc73af4e8f427bde80154755a310
 SHA512:
-  metadata.gz: '09e412db194cf4542d8a48d2b30fbb19e05f92b62f811907c40b0b11fea46a918c914e83c31b8f8459025455acec60be1937acd9509f60b0a18d34066f1ac638'
-  data.tar.gz: 32c7cefda90fdb8662a1bbac25c4747548ff6fc75b8b84850d391046c5d880c35dfcc547789f173f3a1de9e50311eae48bbb40ee4ed389a2b8d14aa145dc6a60
+  metadata.gz: 2caf7e13cb13f4574446e4deaa246212b7a54630f94ba883803a360fb81a4e43c2d77b8dd140eaa5582d25efe1793d67145385f49acec275e1399cd52c3d1785
+  data.tar.gz: 16346fb5631e18212bcc690353f384da813f4baa6f48e7f32263183e2f86dee39293876954dedaddd05baa3aa32d970e361e2a8ef6f7f8de7feff96991c90b2b

data/lib/opener/opinion_detector_basic/kaf/opinion.rb

@@ -126,43 +126,16 @@ module Opener
             @left_candidates = filter_candidates(sentence_terms[min..max])
           end
 
-          unless right_candidates.empty?
-            candidate = right_candidates.first
-            @target_ids << candidate.id
+          if right_candidates.any?
+            @target_ids << right_candidates.first.id
           end
-
-          if target_ids.empty?
-            list = mix_lists(right_candidates, left_candidates)
-            list.each do |l|
-              @target_ids << l.id
-              break
-            end
+          if left_candidates.any?
+            @target_ids << left_candidates.first.id
           end
         end
 
         protected
 
-        ##
-        # If there are no opinion targets, right and left candidates
-        # are mixed into one list and the first one is picked as the target.
-        #
-        # @return [Array]
-        #
-        def mix_lists(lista, listb)
-          list = []
-          min = [lista.count, listb.count].min
-          (0..min).each do |i|
-            list << lista[i]
-            list << listb[i]
-            if lista.count > listb.count
-              list << lista[min]
-            elsif listb.count > lista.count
-              list << listb[min]
-            end
-          end
-          return list.compact
-        end
-
         ##
         # Filters candidate terms depending on their part of speech and if
         # they are already part of the expression.

data/lib/opener/opinion_detector_basic/kaf/term.rb

@@ -16,7 +16,7 @@ module Opener
           'es' => %w{, y e},
           'it' => %w{, e ed},
           'de' => %w{, und},
-          'fr' => %w{, et}
+          'fr' => %w{, et},
         }
 
         def initialize node, document, language
@@ -74,6 +74,10 @@ module Opener
           @pos ||= node.attr('pos')
         end
 
+        def xpos
+          @xpos ||= node.attr('xpos')
+        end
+
         def lexicon_id
           @lexicon_id ||= node.attr('lexicon-id')
         end
@@ -161,11 +165,11 @@ module Opener
 
         ##
         # Checks if a term is a conjunction.
-        #
-        # @return [TrueClass|FalseClass]
+        # Comma is identified as conjunction by default
+        # Sometimes, comma comes with space after it
         #
         def is_conjunction?(language)
-          pos == 'J' || CONJUNCTIONS[language]&.include?(lemma)
+          pos == 'J' || xpos == ',' || CONJUNCTIONS[language]&.include?(lemma)
         end
 
         private

data/lib/opener/opinion_detector_basic/version.rb

@@ -1,7 +1,7 @@
 module Opener
   class OpinionDetectorBasic
 
-    VERSION = '3.2.5'
+    VERSION = '3.2.6'
 
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opener-opinion-detector-basic
 version: !ruby/object:Gem::Version
-  version: 3.2.5
+  version: 3.2.6
 platform: ruby
 authors:
 - development@olery.com
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-04 00:00:00.000000000 Z
+date: 2021-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opener-daemons