opener-ned 2.0.3 → 2.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d35edcc5163e7ee4acf369a40f5ed7ffc6cfed6b
-  data.tar.gz: dfa909cba69922c488a5facd694f1971fd4cc0d0
+  metadata.gz: ee1efe28b8ebe6ded998c4c332d54d223373696a
+  data.tar.gz: 442d071af7a75fae2dc59199106944c269196168
 SHA512:
-  metadata.gz: 42524f900603fdad922bff9a40a5f50ca69b3e6c9466706f42f6d8f5608b1cb5f59b81460d57249eabe489a55cbbd46cb90c515d3134a59040e0050e5d411014
-  data.tar.gz: e9e2f0e4ab781a3c853b6883549923239c531751036e2a9501d13918a6b801fd7631016ec4783ad1bfb15f674a11465801124dcaecd54e5dc97c749de32da7c4
+  metadata.gz: 4c68995447104271cc30b3cd0e94a560c8c931c86274735c2a9091fa3dc1455a0219328c4bed28e909c5d3fcb18a2d13355a28c6759d3f4a5064de0f67dd1647
+  data.tar.gz: edae0c4ca159a514d809fcd67f5ca75db2eed3df88d394e1095147cdac59d607c9bd2d37f78d59cebd91388648dbc523736892a8aa6795bc79d70a9ba7224a6c

data/README.md

@@ -97,7 +97,7 @@ Language Extension
 Where to go from here
 ---------------------
 
-* [Check the project websitere](http://opener-project.github.io)
+* [Check the project website](http://opener-project.github.io)
 * [Checkout the webservice](http://opener.olery.com/ned)
 
 Report problem/Get help

data/lib/opener/ned.rb

@@ -7,6 +7,7 @@ require File.expand_path('../../../core/target/ehu-ned-1.0.jar', __FILE__)
 
 require_relative 'ned/version'
 require_relative 'ned/cli'
+require_relative 'ned/error_layer'
 
 import 'java.io.InputStreamReader'
 
@@ -60,25 +61,30 @@ module Opener
     end
 
     def run(input)
-      if !input or input.strip.empty?
-        raise ArgumentError, 'No input specified'
-      end
+      begin
+        if !input or input.strip.empty?
+          raise ArgumentError, 'No input specified'
+        end
 
-      language = language_from_kaf(input)
+        language = language_from_kaf(input)
 
-      input_io  = StringIO.new(input)
-      reader    = InputStreamReader.new(input_io.to_inputstream)
-      document  = KAFDocument.create_from_stream(reader)
-      annotator = Java::ehu.ned.Annotate.new
+        input_io  = StringIO.new(input)
+        reader    = InputStreamReader.new(input_io.to_inputstream)
+        document  = KAFDocument.create_from_stream(reader)
+        annotator = Java::ehu.ned.Annotate.new
 
-      endpoint = @options.fetch(:endpoint, uri_for_language(language))
+        endpoint = @options.fetch(:endpoint, uri_for_language(language))
 
-      annotator.disambiguateNEsToKAF(
-        document,
-        endpoint.to_s
-      )
+        annotator.disambiguateNEsToKAF(
+          document,
+          endpoint.to_s
+        )
 
-      return document.to_string
+        return document.to_string
+        
+      rescue Exception => error
+        return ErrorLayer.new(input, error.message, self.class).add
+      end
     end
 
     private

data/lib/opener/ned/error_layer.rb

@@ -0,0 +1,89 @@
+module Opener
+  class Ned
+    ##
+    # Add Error Layer to KAF file instead of throwing an error.
+    #
+    class ErrorLayer
+      attr_accessor :input, :document, :error, :klass
+      
+      def initialize(input, error, klass)
+        @input    = input.to_s
+        # Make sure there is always a document, even if it is empty.
+        @document = Nokogiri::XML(input) rescue Nokogiri::XML(nil)
+        @error    = error
+        @klass    = klass
+      end
+      
+      def add
+        if is_xml?
+          unless has_errors_layer?
+            add_errors_layer
+          end
+        else
+          add_root
+          add_text
+          add_errors_layer
+        end
+        add_error
+        
+        xml = !!document.encoding ? document.to_xml : document.to_xml(:encoding => "UTF-8")
+        
+        return xml
+      end
+      
+      ##
+      # Check if the document is a valid XML file.
+      #
+      def is_xml?
+        !!document.root
+      end
+      
+      ##
+      # Add root element to the XML file.
+      #
+      def add_root
+        root = Nokogiri::XML::Node.new "KAF", document
+        document.add_child(root)
+      end
+      
+      ##
+      # Check if the document already has an errors layer.
+      #
+      def has_errors_layer?
+        !!document.at('errors')
+      end
+      
+      ##
+      # Add errors element to the XML file.
+      #
+      def add_errors_layer
+        node = Nokogiri::XML::Node.new "errors", document
+        document.root.add_child(node)
+      end
+      
+      ##
+      # Add the text file incase it is not a valid XML document. More
+      # info for debugging.
+      #
+      def add_text
+        node = Nokogiri::XML::Node.new "raw", document
+        node.inner_html = input
+        document.root.add_child(node)
+        
+      end
+      
+      ##
+      # Add the actual error to the errors layer.
+      #
+      def add_error
+        node = document.at('errors')
+        error_node = Nokogiri::XML::Node.new "error", node
+        error_node['class']   = klass.to_s
+        error_node['version'] = klass::VERSION
+        error_node.inner_html = error
+        node.add_child(error_node)
+      end     
+      
+    end # ErrorLayer
+  end # Ned
+end # Opener

data/lib/opener/ned/version.rb

@@ -1,5 +1,5 @@
 module Opener
   class Ned
-    VERSION = '2.0.3'
+    VERSION = '2.0.4'
   end # Ned
 end # Opener

data/opener-ned.gemspec

@@ -29,6 +29,6 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'opener-daemons'
   gem.add_dependency 'opener-core', ['>= 0.1.2']
 
-  gem.add_development_dependency 'opener-build-tools'
   gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'cliver'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opener-ned
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.4
 platform: ruby
 authors:
 - development@olery.com
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-05-23 00:00:00.000000000 Z
+date: 2014-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sinatra
@@ -109,7 +109,7 @@ dependencies:
   prerelease: false
   type: :runtime
 - !ruby/object:Gem::Dependency
-  name: opener-build-tools
+  name: rake
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -123,7 +123,7 @@ dependencies:
   prerelease: false
   type: :development
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: cliver
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -154,6 +154,7 @@ files:
 - exec/ned.rb
 - lib/opener/ned.rb
 - lib/opener/ned/cli.rb
+- lib/opener/ned/error_layer.rb
 - lib/opener/ned/public/markdown.css
 - lib/opener/ned/server.rb
 - lib/opener/ned/version.rb
@@ -183,4 +184,3 @@ signing_key:
 specification_version: 4
 summary: NED client using DBpedia
 test_files: []
-has_rdoc: yard