openc3 6.9.1 → 6.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 83838350c2ec54b5fcd1b6108f42fe9d7f45fd24f6de04fb7c5c98855251b9b9
-  data.tar.gz: c1b89314a5af6f7740857228d01c0ab9e2b2e03e59c209b0e646fefb4f281425
+  metadata.gz: 4d4fd7006c78d3a21531579d68d42bc5cba596c92091e8cd7895c4b42ecff569
+  data.tar.gz: 85fdaa738dafbfafcc16fb463abb5d86517f9f1edefb4bbef9a5e7171738211c
 SHA512:
-  metadata.gz: 35be666ae0ea4d134fa6c7d54d79ee323e5d878918c25706d17514b1db8b28b6ca05c6c0f175426f285227e6fd16d6b90ccbf21316c71057aaaf958660a7c8a7
-  data.tar.gz: 3c0f703c797d6fbd1be90d526a91ac94a06ec6d9ad042e3ea1212da4c73557be6e4634be73ca49f17c8277f7b7052154e0283b0a994f84f91cf96422811155ac
+  metadata.gz: 419ddee4f6203f3500c9d3eb45347824dfa57a074527086fd8bfdaee16c4dc10ec07b3b78122e1a753a064913bbb1193f29344e260ba7a04b029cdb11682a9e7
+  data.tar.gz: 961d67c9c972a2cdf60c31c9279b69a7e1fc315e62813935eb66fefbbd853cf931c633c36aa6b9606cb1eedfd66ef8ba2db07b34f24acf99967aa6983755deb3

data/bin/openc3cli

@@ -875,6 +875,22 @@ if not ARGV[0].nil? # argument(s) given
   case ARGV[0].downcase
 
   when 'irb'
+    if ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli irb"
+      puts ""
+      puts "Start an interactive Ruby (IRB) session with COSMOS libraries loaded"
+      puts ""
+      puts "This provides access to all COSMOS classes and methods for interactive"
+      puts "debugging and exploration. Use 'exit' or Ctrl-D to quit the IRB session."
+      puts ""
+      puts "Example:"
+      puts "  cli irb"
+      puts "  > require 'openc3'"
+      puts "  > OpenC3::System.targets"
+      puts ""
+      puts "Note: For IRB-specific options, start IRB first then type 'help'"
+      exit 0
+    end
     ARGV.clear
     IRB.start
 
@@ -882,6 +898,29 @@ if not ARGV[0].nil? # argument(s) given
     cli_script(ARGV[1..-1])
 
   when 'rake'
+    # Check for --help first, before checking for Rakefile
+    if ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli rake [RAKE_OPTIONS] [TASKS...]"
+      puts ""
+      puts "Run rake tasks in the current directory"
+      puts ""
+      puts "This runs the standard Ruby rake tool with all COSMOS libraries available."
+      puts "A Rakefile must exist in the current directory."
+      puts ""
+      puts "Common rake options:"
+      puts "  -T, --tasks              List all available rake tasks with descriptions"
+      puts "  -D, --describe PATTERN   Describe tasks matching PATTERN"
+      puts "  -h, --help               Show rake's full help message"
+      puts ""
+      puts "Examples:"
+      puts "  cli rake -T              # List all available tasks"
+      puts "  cli rake build           # Run the 'build' task"
+      puts "  cli rake test            # Run tests"
+      puts ""
+      puts "Note: Must be run in a directory containing a Rakefile"
+      exit 0
+    end
+    # Now check for Rakefile existence
     if File.exist?('Rakefile')
       puts `rake #{ARGV[1..-1].join(' ')}`
     else
@@ -889,9 +928,70 @@ if not ARGV[0].nil? # argument(s) given
     end
 
   when 'validate'
+    if ARGV[1].nil? || ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli validate PLUGIN.gem [SCOPE] [VARIABLES.json]"
+      puts ""
+      puts "Validate a COSMOS plugin gem file"
+      puts ""
+      puts "Arguments:"
+      puts "  PLUGIN.gem        Plugin gem file to validate (required)"
+      puts "  SCOPE             Scope for validation (optional, default: DEFAULT)"
+      puts "  VARIABLES.json    Variables JSON file (optional)"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit(ARGV[1].nil? ? 1 : 0)
+    end
     validate_plugin(ARGV[1], scope: ARGV[2], variables_file: ARGV[3])
 
   when 'load'
+    # Check for help flag or missing arguments
+    if ARGV[1].nil? || ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage:"
+      puts "  cli load PLUGIN.gem"
+      puts "  cli load PLUGIN.gem --variables VARIABLES.json"
+      puts "  cli load PLUGIN.gem SCOPE PLUGIN_HASH.json [force]"
+      puts "  cli load PLUGIN.gem --variables VARIABLES.json SCOPE PLUGIN_HASH.json [force]"
+      puts ""
+      puts "Load a COSMOS plugin gem file"
+      puts ""
+      puts "Common Usage (Auto-detect):"
+      puts "  cli load PLUGIN.gem"
+      puts "    - Installs new plugin in DEFAULT scope"
+      puts "    - Automatically detects and upgrades if plugin already exists"
+      puts "    - Skips installation if same version already installed"
+      puts ""
+      puts "  cli load PLUGIN.gem --variables VARIABLES.json"
+      puts "    - Same as above, but provides variables for plugin configuration"
+      puts ""
+      puts "Advanced Usage (Manual Control):"
+      puts "  cli load PLUGIN.gem SCOPE PLUGIN_HASH.json [force]"
+      puts "    - Used by Admin UI for plugin create/edit/upgrade operations"
+      puts "    - Requires PLUGIN_HASH.json (output from install_phase1)"
+      puts "    - 'force' argument forces reinstall even if version unchanged"
+      puts ""
+      puts "Arguments:"
+      puts "  PLUGIN.gem           Plugin gem file to load (required)"
+      puts "  SCOPE                Scope to install plugin in (default: DEFAULT)"
+      puts "  PLUGIN_HASH.json     Plugin hash JSON file from install_phase1 (optional)"
+      puts "  force                Force plugin installation even if no changes (optional)"
+      puts ""
+      puts "Options:"
+      puts "  --variables FILE     Variables JSON file for plugin installation"
+      puts "  -h, --help           Show this help message"
+      puts ""
+      puts "IMPORTANT LIMITATION:"
+      puts "  To specify SCOPE without PLUGIN_HASH.json, you must use the --variables"
+      puts "  option (even with an empty JSON file) to prevent argument misinterpretation."
+      puts ""
+      puts "Examples:"
+      puts "  cli load my-plugin-1.0.0.gem"
+      puts "  cli load my-plugin-1.0.0.gem --variables vars.json"
+      puts "  cli load my-plugin-1.0.0.gem DEFAULT plugin_hash.json"
+      puts "  cli load my-plugin-1.0.0.gem DEFAULT plugin_hash.json force"
+      exit(ARGV[1].nil? ? 1 : 0)
+    end
+
     # force is a boolean so if they pass 'force' it is true
     # See plugins_controller.rb install for usage
     variables_option = ARGV.find_index('--variables')
@@ -908,15 +1008,68 @@ if not ARGV[0].nil? # argument(s) given
     load_plugin(ARGV[1], scope: scope, plugin_hash_file: plugin_hash_file, force: force, variables_file: variables_file)
 
   when 'list'
+    if ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli list [SCOPE]"
+      puts ""
+      puts "List all installed plugins in the specified scope"
+      puts ""
+      puts "Arguments:"
+      puts "  SCOPE             Scope to list plugins from (optional, default: DEFAULT)"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit 0
+    end
     list_plugins(scope: ARGV[1])
 
   when 'unload'
+    if ARGV[1].nil? || ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli unload PLUGIN_NAME [SCOPE]"
+      puts ""
+      puts "Unload a COSMOS plugin"
+      puts ""
+      puts "Arguments:"
+      puts "  PLUGIN_NAME       Name of the plugin to unload (required)"
+      puts "  SCOPE             Scope to unload from (optional, default: DEFAULT)"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit(ARGV[1].nil? ? 1 : 0)
+    end
     unload_plugin(ARGV[1], scope: ARGV[2])
 
   when 'pkginstall', 'geminstall'
+    if ARGV[1].nil? || ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli pkginstall PACKAGE_NAME [SCOPE]"
+      puts "       cli geminstall GEM_NAME [SCOPE]"
+      puts ""
+      puts "Install a package/gem into a loaded plugin"
+      puts ""
+      puts "Arguments:"
+      puts "  PACKAGE_NAME      Name of the package to install (required)"
+      puts "  SCOPE             Scope for installation (optional, default: DEFAULT)"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit(ARGV[1].nil? ? 1 : 0)
+    end
     cli_pkg_install(ARGV[1], scope: ARGV[2])
 
   when 'pkguninstall', 'gemuninstall'
+    if ARGV[1].nil? || ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli pkguninstall PACKAGE_NAME [SCOPE]"
+      puts "       cli gemuninstall GEM_NAME [SCOPE]"
+      puts ""
+      puts "Uninstall a package/gem from a loaded plugin"
+      puts ""
+      puts "Arguments:"
+      puts "  PACKAGE_NAME      Name of the package to uninstall (required)"
+      puts "  SCOPE             Scope for uninstallation (optional, default: DEFAULT)"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit(ARGV[1].nil? ? 1 : 0)
+    end
     cli_pkg_uninstall(ARGV[1], scope: ARGV[2])
 
   when 'generate'
@@ -934,6 +1087,19 @@ if not ARGV[0].nil? # argument(s) given
     xtce_converter(ARGV[1..-1])
 
   when 'bridge'
+    if ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli bridge [FILENAME] [PARAMS...]"
+      puts ""
+      puts "Run a COSMOS bridge from a bridge configuration file"
+      puts ""
+      puts "Arguments:"
+      puts "  FILENAME          Bridge config file (optional, default: bridge.txt)"
+      puts "  PARAMS            Additional parameters to pass to bridge"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit 0
+    end
     ENV['OPENC3_NO_STORE'] = '1'
     filename = ARGV[1]
     filename = 'bridge.txt' unless filename
@@ -942,6 +1108,19 @@ if not ARGV[0].nil? # argument(s) given
     run_bridge(filename, params)
 
   when 'bridgegem'
+    if ARGV[1].nil? || ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli bridgegem GEM_NAME [PARAMS...]"
+      puts ""
+      puts "Run a COSMOS bridge from a gem's bridge.txt file"
+      puts ""
+      puts "Arguments:"
+      puts "  GEM_NAME          Name of the gem containing bridge.txt (required)"
+      puts "  PARAMS            Additional parameters to pass to bridge"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit(ARGV[1].nil? ? 1 : 0)
+    end
     ENV['OPENC3_NO_STORE'] = '1'
     filename = nil
     gem_name = ARGV[1]
@@ -967,6 +1146,18 @@ if not ARGV[0].nil? # argument(s) given
     run_bridge(filename, params)
 
   when 'bridgesetup'
+    if ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli bridgesetup [FILENAME]"
+      puts ""
+      puts "Generate a default bridge configuration file"
+      puts ""
+      puts "Arguments:"
+      puts "  FILENAME          Output filename (optional, default: bridge.txt)"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit 0
+    end
     ENV['OPENC3_NO_STORE'] = '1'
     filename = ARGV[1]
     filename = 'bridge.txt' unless filename
@@ -978,10 +1169,36 @@ if not ARGV[0].nil? # argument(s) given
     print_usage()
 
   when 'redis'
+    if ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli redis COMMAND [ARGS...]"
+      puts ""
+      puts "Interact with the Redis database"
+      puts ""
+      puts "Commands:"
+      puts "  keys              Get all Redis keys"
+      puts "  hget HASH KEY     Get a value from a Redis hash"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit 0
+    end
     case (ARGV[1])
     when 'keys'
       get_redis_keys()
     when 'hget'
+      if ARGV[2].nil? || ARGV[3].nil? || ARGV[2] == '--help' || ARGV[2] == '-h'
+        puts "Usage: cli redis hget HASH KEY"
+        puts ""
+        puts "Get a value from a Redis hash"
+        puts ""
+        puts "Arguments:"
+        puts "  HASH              Redis hash name (required)"
+        puts "  KEY               Key within the hash (required)"
+        puts ""
+        puts "Options:"
+        puts "  -h, --help        Show this help message"
+        exit(ARGV[2].nil? || ARGV[3].nil? ? 1 : 0)
+      end
       redis = Redis.new(url: $redis_url, username: ENV['OPENC3_REDIS_USERNAME'], password: ENV['OPENC3_REDIS_PASSWORD'])
       puts JSON.parse(redis.hget(ARGV[2], ARGV[3]), allow_nan: true, create_additions: true)
     else
@@ -990,6 +1207,16 @@ if not ARGV[0].nil? # argument(s) given
     end
 
   when 'removebase'
+    if ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli removebase"
+      puts ""
+      puts "Remove non-enterprise tool base and admin plugins from all scopes"
+      puts "This is typically used to support enterprise upgrades"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit 0
+    end
     # Used to remove tool base to better support enterprise upgrade
     scopes = OpenC3::ScopeModel.all
     scopes.each do |scope_name, _scope|
@@ -1005,6 +1232,16 @@ if not ARGV[0].nil? # argument(s) given
     end
 
   when 'removeenterprise'
+    if ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli removeenterprise"
+      puts ""
+      puts "Remove all enterprise plugins from all scopes"
+      puts "This is typically used to support downgrades"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit 0
+    end
     # Used to remove enterprise plugins to better support downgrade
     scopes = OpenC3::ScopeModel.all
     scopes.each do |scope_name, _scope|
@@ -1017,6 +1254,19 @@ if not ARGV[0].nil? # argument(s) given
     end
 
   when 'createqueue'
+    if ARGV[1].nil? || ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli createqueue QUEUE_NAME [SCOPE]"
+      puts ""
+      puts "Create a new queue in the specified scope"
+      puts ""
+      puts "Arguments:"
+      puts "  QUEUE_NAME        Name of the queue to create (required)"
+      puts "  SCOPE             Scope for the queue (optional, default: DEFAULT)"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit(ARGV[1].nil? ? 1 : 0)
+    end
     queue = OpenC3::QueueModel.get(name: ARGV[1], scope: ARGV[2])
     unless queue
       queue = OpenC3::QueueModel.new(name: ARGV[1], state: 'RELEASE', scope: ARGV[2])
@@ -1024,13 +1274,43 @@ if not ARGV[0].nil? # argument(s) given
     end
 
   when 'destroyscope'
+    if ARGV[1].nil? || ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli destroyscope SCOPE_NAME"
+      puts ""
+      puts "Destroy a scope and all its associated data"
+      puts ""
+      puts "Arguments:"
+      puts "  SCOPE_NAME        Name of the scope to destroy (required)"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit(ARGV[1].nil? ? 1 : 0)
+    end
     scope = OpenC3::ScopeModel.get_model(name: ARGV[1])
     scope.destroy
 
   when 'localinit'
+    if ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli localinit"
+      puts ""
+      puts "Initialize local mode configuration"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit 0
+    end
     OpenC3::LocalMode.local_init()
 
   when 'initbuckets'
+    if ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli initbuckets"
+      puts ""
+      puts "Initialize all configured COSMOS buckets"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit 0
+    end
     client = OpenC3::Bucket.getClient()
     ENV.map do |key, value|
       if key.match(/^OPENC3_(.+)_BUCKET$/) && !value.empty?
@@ -1040,6 +1320,15 @@ if not ARGV[0].nil? # argument(s) given
     client.ensure_public(ENV['OPENC3_TOOLS_BUCKET'])
 
   when 'runmigrations'
+    if ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli runmigrations"
+      puts ""
+      puts "Run database migrations"
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit 0
+    end
     run_migrations(ARGV[1])
 
   else # Unknown task

data/lib/openc3/interfaces.rb

@@ -34,14 +34,16 @@ module OpenC3
   autoload(:TcpipServerInterface, 'openc3/interfaces/tcpip_server_interface.rb')
   autoload(:UdpInterface, 'openc3/interfaces/udp_interface.rb')
 
-  autoload(:Protocol, 'openc3/interfaces/protocols/protocol.rb')
   autoload(:BurstProtocol, 'openc3/interfaces/protocols/burst_protocol.rb')
+  autoload(:CmdResponseProtocol, 'openc3/interfaces/protocols/cmd_response_protocol.rb')
+  autoload(:CobsProtocol, 'openc3/interfaces/protocols/cobs_protocol.rb')
+  autoload(:CrcProtocol, 'openc3/interfaces/protocols/crc_protocol.rb')
   autoload(:FixedProtocol, 'openc3/interfaces/protocols/fixed_protocol.rb')
+  autoload(:IgnorePacketProtocol, 'openc3/interfaces/protocols/ignore_packet_protocol.rb')
   autoload(:LengthProtocol, 'openc3/interfaces/protocols/length_protocol.rb')
   autoload(:PreidentifiedProtocol, 'openc3/interfaces/protocols/preidentified_protocol.rb')
+  autoload(:Protocol, 'openc3/interfaces/protocols/protocol.rb')
+  autoload(:SlipProtocol, 'openc3/interfaces/protocols/slip_protocol.rb')
   autoload(:TemplateProtocol, 'openc3/interfaces/protocols/template_protocol.rb')
   autoload(:TerminatedProtocol, 'openc3/interfaces/protocols/terminated_protocol.rb')
-  autoload(:CmdResponseProtocol, 'openc3/interfaces/protocols/cmd_response_protocol.rb')
-  autoload(:CrcProtocol, 'openc3/interfaces/protocols/crc_protocol.rb')
-  autoload(:IgnorePacketProtocol, 'openc3/interfaces/protocols/ignore_packet_protocol.rb')
 end

data/lib/openc3/microservices/interface_microservice.rb

@@ -231,6 +231,8 @@ module OpenC3
           cmd_name = msg_hash['cmd_name']
           manual = ConfigParser.handle_true_false(msg_hash['manual'])
           cmd_params = nil
+          range_check = true
+          raw = false
           cmd_buffer = nil
           hazardous_check = nil
           if msg_hash['cmd_params']
@@ -288,14 +290,13 @@ module OpenC3
             if @critical_commanding and @critical_commanding != 'OFF' and not release_critical
               restricted = command.restricted
               if hazardous or restricted or (@critical_commanding == 'ALL' and manual)
+                cmd_type = 'NORMAL'
                 if hazardous
-                  type = 'HAZARDOUS'
+                  cmd_type = 'HAZARDOUS'
                 elsif restricted
-                  type = 'RESTRICTED'
-                else
-                  type = 'NORMAL'
+                  cmd_type = 'RESTRICTED'
                 end
-                model = CriticalCmdModel.new(name: SecureRandom.uuid, type: type, interface_name: @interface.name, username: msg_hash['username'], cmd_hash: msg_hash, scope: @scope)
+                model = CriticalCmdModel.new(name: SecureRandom.uuid, type: cmd_type, interface_name: @interface.name, username: msg_hash['username'], cmd_hash: msg_hash, scope: @scope)
                 model.create
                 @logger.info("Critical Cmd Pending: #{msg_hash['cmd_string']}", user: msg_hash['username'], scope: @scope)
                 next "CriticalCmdError\n#{model.name}"
@@ -428,10 +429,12 @@ module OpenC3
               params = JSON.parse(msg_hash['params'], allow_nan: true, create_additions: true)
             end
             @router = @tlm.attempting(*params)
+            next 'SUCCESS'
           end
           if msg_hash['disconnect']
             @logger.info "#{@router.name}: Disconnect requested"
             @tlm.disconnect(false)
+            next 'SUCCESS'
           end
           if msg_hash.key?('log_stream')
             if msg_hash['log_stream'] == 'true'
@@ -441,6 +444,7 @@ module OpenC3
               @logger.info "#{@router.name}: Disable stream logging"
               @router.stop_raw_logging
             end
+            next 'SUCCESS'
           end
           if msg_hash.key?('router_cmd')
             params = JSON.parse(msg_hash['router_cmd'], allow_nan: true, create_additions: true)

data/lib/openc3/microservices/queue_microservice.rb

@@ -18,6 +18,7 @@
 
 require 'openc3/microservices/microservice'
 require 'openc3/topics/queue_topic'
+require 'openc3/models/queue_model'
 require 'openc3/utilities/authentication'
 require 'openc3/api/api'
 
@@ -90,15 +91,22 @@ module OpenC3
       @queue_name = @name.split('__')[2]
 
       initial_state = 'HOLD'
-      (@config['options'] || []).each do |option|
-        case option[0].upcase
-        when 'QUEUE_STATE'
-          initial_state = option[1]
-        else
-          @logger.error("Unknown option passed to microservice #{@name}: #{option}")
+      # See if the queue already exists to get its state
+      queue = OpenC3::QueueModel.get(name: @queue_name, scope: @scope)
+      if queue
+        initial_state = queue['state']
+      else
+        (@config['options'] || []).each do |option|
+          case option[0].upcase
+          when 'QUEUE_STATE'
+            initial_state = option[1]
+          else
+            @logger.error("Unknown option passed to microservice #{@name}: #{option}")
+          end
         end
       end
 
+      @logger.info "Creating QueueMicroservice in scope #{@scope} for queue #{@queue_name} with initial state #{initial_state}"
       @processor = QueueProcessor.new(name: @queue_name, state: initial_state, logger: @logger, scope: @scope)
       @processor_thread = nil
       @read_topic = true

data/lib/openc3/models/plugin_model.rb

@@ -56,6 +56,13 @@ module OpenC3
     attr_accessor :plugin_txt_lines
     attr_accessor :needs_dependencies
     attr_accessor :store_id
+    attr_accessor :title
+    attr_accessor :description
+    attr_accessor :licenses
+    attr_accessor :homepage
+    attr_accessor :repository
+    attr_accessor :keywords
+    attr_accessor :img_path
 
     # NOTE: The following three class methods are used by the ModelController
     # and are reimplemented to enable various Model class methods to work
@@ -179,11 +186,31 @@ module OpenC3
             raise "Invalid screen filename: #{filename}. Screen filenames must be lowercase."
           end
         end
+
+        # Process app store metadata
+        plugin_model.title = pkg.spec.metadata['openc3_store_title'] || pkg.spec.summary.strip
+        plugin_model.description = pkg.spec.metadata['openc3_store_description'] || pkg.spec.description.strip
+        plugin_model.licenses = pkg.spec.licenses
+        plugin_model.homepage = pkg.spec.homepage
+        plugin_model.repository = pkg.spec.metadata['source_code_uri'] # this key because it's in the official gemspec examples
+        plugin_model.keywords = pkg.spec.metadata['openc3_store_keywords']&.split(/, ?/)
+        img_path = pkg.spec.metadata['openc3_store_image']
+        unless img_path
+          default_img_path = 'public/store_img.png'
+          full_default_path = File.join(gem_path, default_img_path)
+          img_path = default_img_path if File.exist? full_default_path
+        end
+        plugin_model.img_path = File.join('gems', gem_name.split(".gem")[0], img_path) if img_path # convert this filesystem path to volumes mount path
+        plugin_model.update() unless validate_only
+
         needs_dependencies = pkg.spec.runtime_dependencies.length > 0
         needs_dependencies = true if Dir.exist?(File.join(gem_path, 'lib'))
 
-        # Handle python requirements.txt
-        if File.exist?(File.join(gem_path, 'requirements.txt'))
+        # Handle python dependencies (pyproject.toml or requirements.txt)
+        pyproject_path = File.join(gem_path, 'pyproject.toml')
+        requirements_path = File.join(gem_path, 'requirements.txt')
+        
+        if File.exist?(pyproject_path) || File.exist?(requirements_path)
           begin
             pypi_url = get_setting('pypi_url', scope: scope)
             if pypi_url
@@ -202,11 +229,20 @@ module OpenC3
             end
           end
           unless validate_only
-            Logger.info "Installing python packages from requirements.txt with pypi_url=#{pypi_url}"
-            if ENV['PIP_ENABLE_TRUSTED_HOST'].nil?
-              pip_args = "--no-warn-script-location -i #{pypi_url} -r #{File.join(gem_path, 'requirements.txt')}"
+            if File.exist?(pyproject_path)
+              Logger.info "Installing python packages from pyproject.toml with pypi_url=#{pypi_url}"
+              if ENV['PIP_ENABLE_TRUSTED_HOST'].nil?
+                pip_args = "--no-warn-script-location -i #{pypi_url} #{gem_path}"
+              else
+                pip_args = "--no-warn-script-location -i #{pypi_url} --trusted-host #{URI.parse(pypi_url).host} #{gem_path}"
+              end
             else
-              pip_args = "--no-warn-script-location -i #{pypi_url} --trusted-host #{URI.parse(pypi_url).host} -r #{File.join(gem_path, 'requirements.txt')}"
+              Logger.info "Installing python packages from requirements.txt with pypi_url=#{pypi_url}"
+              if ENV['PIP_ENABLE_TRUSTED_HOST'].nil?
+                pip_args = "--no-warn-script-location -i #{pypi_url} -r #{requirements_path}"
+              else
+                pip_args = "--no-warn-script-location -i #{pypi_url} --trusted-host #{URI.parse(pypi_url).host} -r #{requirements_path}"
+              end
             end
             puts `/openc3/bin/pipinstall #{pip_args}`
           end
@@ -302,6 +338,13 @@ module OpenC3
       plugin_txt_lines: [],
       needs_dependencies: false,
       store_id: nil,
+      title: nil,
+      description: nil,
+      keywords: nil,
+      licenses: nil,
+      homepage: nil,
+      repository: nil,
+      img_path: nil,
       updated_at: nil,
       scope:
     )
@@ -310,6 +353,13 @@ module OpenC3
       @plugin_txt_lines = plugin_txt_lines
       @needs_dependencies = ConfigParser.handle_true_false(needs_dependencies)
       @store_id = store_id
+      @title = title
+      @description = description
+      @keywords = keywords
+      @licenses = licenses
+      @homepage = homepage
+      @repository = repository
+      @img_path = img_path
     end
 
     def create(update: false, force: false, queued: false)
@@ -329,6 +379,13 @@ module OpenC3
         'plugin_txt_lines' => @plugin_txt_lines,
         'needs_dependencies' => @needs_dependencies,
         'store_id' => @store_id,
+        'title' => @title,
+        'description' => @description,
+        'keywords' => @keywords,
+        'licenses' => @licenses,
+        'homepage' => @homepage,
+        'repository' => @repository,
+        'img_path' => @img_path,
         'updated_at' => @updated_at
       }
     end

data/lib/openc3/models/reaction_model.rb

@@ -143,7 +143,7 @@ module OpenC3
       unless triggers.is_a?(Array)
         raise ReactionInputError.new "invalid triggers, must be array of hashes: #{triggers}"
       end
-      trigger_hash = Hash.new()
+      trigger_hash = {}
       triggers.each do | trigger |
         unless trigger.is_a?(Hash)
           raise ReactionInputError.new "invalid trigger, must be hash: #{trigger}"

data/lib/openc3/models/target_model.rb

@@ -166,10 +166,14 @@ module OpenC3
     end
 
     def self.download(target_name, scope:)
+      # Validate target_name to not allow directory traversal
+      if target_name.include?('..') || target_name.include?('/') || target_name.include?('\\')
+        raise ArgumentError, "Invalid target_name: #{target_name.inspect}"
+      end
       tmp_dir = Dir.mktmpdir
       zip_filename = File.join(tmp_dir, "#{target_name}.zip")
       Zip.continue_on_exists_proc = true
-      zip = Zip::File.open(zip_filename, Zip::File::CREATE)
+      zip = Zip::File.open(zip_filename, create: true)
 
       if ENV['OPENC3_LOCAL_MODE']
         OpenC3::LocalMode.zip_target(target_name, zip, scope: scope)
@@ -756,7 +760,7 @@ module OpenC3
       prefix = File.dirname(target_folder) + '/'
       output_file = File.join(temp_dir, @name + '_' + @id + '.zip')
       Zip.continue_on_exists_proc = true
-      Zip::File.open(output_file, Zip::File::CREATE) do |zipfile|
+      Zip::File.open(output_file, create: true) do |zipfile|
         target_files.each do |target_file|
           zip_file_path = target_file.delete_prefix(prefix)
           if File.directory?(target_file)
@@ -807,7 +811,7 @@ module OpenC3
             Logger.error("Invalid text present in #{target_name} #{packet_name} tlm packet")
             raise e
           end
-          json_hash = Hash.new
+          json_hash = {}
           packet.sorted_items.each do |item|
             json_hash[item.name] = nil
             TargetModel.add_to_target_allitems_list(target_name, item.name, scope: @scope)