openapi_parser 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d37b73f1501e0230ab8b3bf5f8a7482809d0d1bcbc5e52ae6975442993496ffb
-  data.tar.gz: 709cb3b9f0f65ea74abe91ff6639d8feb11f33b0c9fd2839589064b000cdc6ff
+  metadata.gz: 7480b22f5a7f1e12c9c1d2b21dbcc50b711bb06fba8f31e7cdff9f340f7f6fe8
+  data.tar.gz: d9fecd50469f7e3f8bf88cf5076c8b78df24a5d825920748f518bcbd38ca0677
 SHA512:
-  metadata.gz: ea0e14b6b8110a0afe331bc77608d3ec7b530a8d6539d4433ed17ecf77eefaf7e0af9c56df1368a17ba65d4db75b085a57a1d5ddbb6e758202413a225c3faaac
-  data.tar.gz: 44559dc45ab5ecaa6630d4eb848b3746a8cbce90c31d313ad9a652b188e83584aa3773b89248865510de559a9dda0f0d38575e65fae5be18195a0aec0aca80eb
+  metadata.gz: 18af5156bd11cd2388608f2c835cfc44a049f55e5729c25997d44a7e434f00f9278ea1b39ef5490044aa950252148585e101f021659d34fa023046af03f96401
+  data.tar.gz: e706defe789e26b503018653b8be22671a0155a2bbc39ac62c29603e7bd9a58f1cb923c9f7b51a858dde34ae06397860c1c68345828fff5be386866a2f6ca236

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## Unreleased
 
+## 0.6.1 (2019-10-12)
+* Bugfix: validate non-nullable response header #54
+* Improve grammar in error messages #55
+* fix object validator in case of properties missing #56
+
 ## 0.6.0 (2019-10-05)
 * add email format validation on string #51
 

data/lib/openapi_parser/errors.rb

@@ -13,7 +13,7 @@ module OpenAPIParser
     end
 
     def message
-      "#{@data} class is #{@data.class} but it's not valid #{@type} in #{@reference}"
+      "#{@reference} expected #{@type}, but received #{@data.class}: #{@data}"
     end
 
     class << self
@@ -28,7 +28,7 @@ module OpenAPIParser
 
   class NotNullError < OpenAPIError
     def message
-      "#{@reference} don't allow null"
+      "#{@reference} does not allow null values"
     end
   end
 
@@ -39,7 +39,7 @@ module OpenAPIParser
     end
 
     def message
-      "required parameters #{@keys.join(",")} not exist in #{@reference}"
+      "#{@reference} missing required parameters: #{@keys.join(", ")}"
     end
   end
 
@@ -50,7 +50,7 @@ module OpenAPIParser
     end
 
     def message
-      "properties #{@keys.join(",")} are not defined in #{@reference}"
+      "#{@reference} does not define properties: #{@keys.join(", ")}"
     end
   end
 
@@ -117,7 +117,7 @@ module OpenAPIParser
     end
 
     def message
-      "#{@value} cannot be less than minimum value in #{@reference}"
+      "#{@reference} #{@value} is less than minimum value"
     end
   end
 
@@ -128,7 +128,7 @@ module OpenAPIParser
     end
 
     def message
-      "#{@value} cannot be less than or equal to exclusive minimum value in #{@reference}"
+      "#{@reference} #{@value} cannot be less than or equal to exclusive minimum value"
     end
   end
 
@@ -139,7 +139,7 @@ module OpenAPIParser
     end
 
     def message
-      "#{@value} cannot be more than maximum value in #{@reference}"
+      "#{@reference} #{@value} is more than maximum value"
     end
   end
 
@@ -150,7 +150,7 @@ module OpenAPIParser
     end
 
     def message
-      "#{@value} cannot be more than or equal to exclusive maximum value in #{@reference}"
+      "#{@reference} #{@value} cannot be more than or equal to exclusive maximum value"
     end
   end
 
@@ -162,7 +162,7 @@ module OpenAPIParser
     end
 
     def message
-      "#{@value} isn't match #{@pattern} in #{@reference}"
+      "#{@reference} pattern #{@pattern} does not match value: #{@value}"
     end
   end
 
@@ -173,19 +173,19 @@ module OpenAPIParser
     end
 
     def message
-      "#{@value} is not a valid email address format in #{@reference}"
+      "#{@reference} email address format does not match value: #{@value}"
     end
   end
 
   class NotExistStatusCodeDefinition < OpenAPIError
     def message
-      "don't exist status code definition in #{@reference}"
+      "#{@reference} status code definition does not exist"
     end
   end
 
   class NotExistContentTypeDefinition < OpenAPIError
     def message
-      "don't exist response definition #{@reference}"
+      "#{@reference} response definition does not exist"
     end
   end
 
@@ -196,7 +196,7 @@ module OpenAPIParser
     end
 
     def message
-      "#{@value} cannot be more than max length in #{@reference}"
+      "#{@reference} #{@value} is longer than max length"
     end
   end
 
@@ -207,7 +207,7 @@ module OpenAPIParser
     end
 
     def message
-      "#{@value} cannot be less than min length in #{@reference}"
+      "#{@reference} #{@value} is shorter than min length"
     end
   end
 
@@ -218,7 +218,7 @@ module OpenAPIParser
     end
 
     def message
-      "#{@value} cannot be more than max items in #{@reference}"
+      "#{@reference} #{@value} contains more than max items"
     end
   end
 
@@ -229,7 +229,7 @@ module OpenAPIParser
     end
 
     def message
-      "#{@value} cannot be less than min items in #{@reference}"
+      "#{@reference} #{@value} contains fewer than min items"
     end
   end
 end

data/lib/openapi_parser/schema_validators/object_validator.rb

@@ -7,13 +7,13 @@ class OpenAPIParser::SchemaValidator
     def coerce_and_validate(value, schema, parent_all_of: false, discriminator_property_name: nil)
       return OpenAPIParser::ValidateError.build_error_result(value, schema) unless value.kind_of?(Hash)
 
-      return [value, nil] unless schema.properties
+      properties = schema.properties || {}
 
       required_set = schema.required ? schema.required.to_set : Set.new
       remaining_keys = value.keys
 
       coerced_values = value.map do |name, v|
-        s = schema.properties[name]
+        s = properties[name]
         coerced, err = if s
                          remaining_keys.delete(name)
                          validatable.validate_schema(v, s)

data/lib/openapi_parser/schemas/response.rb

@@ -43,11 +43,11 @@ module OpenAPIParser::Schemas
       def validate_header(response_headers)
         return unless headers
 
-        headers.each do |k, v|
-          h = response_headers[k]
-          next unless h
+        headers.each do |name, schema|
+          next unless response_headers.key?(name)
 
-          v.validate(h)
+          value = response_headers[name]
+          schema.validate(value)
         end
       end
   end

data/lib/openapi_parser/version.rb

@@ -1,3 +1,3 @@
 module OpenAPIParser
-  VERSION = '0.6.0'.freeze
+  VERSION = '0.6.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: openapi_parser
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - ota42y
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-10-05 00:00:00.000000000 Z
+date: 2019-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler