openapi_first 3.2.0 → 3.2.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 3d95e7c0085b398b3ec034554d30cf4bd6e9dc488c5cc19d7777ec88aa5ed9ec
4
- data.tar.gz: 323d16c0d405b4233ebe4377cb1a9960db84d19033193d3ccf9badb052a00f24
3
+ metadata.gz: b961989b161d89284ee34052dad18d93190f6c844377fd5d3fdc30e61254ab60
4
+ data.tar.gz: '08b6df291a7172842e698c78b56cb453e514bf2dee8915f7aded306e88dedadf'
5
5
  SHA512:
6
- metadata.gz: d80c5803dcb0746cdf9def8e1b470394b424926a2a0235da90bc47e3f748f74fdbf278cd8e7640b157aabe279e2028e80581f4a7ebcde4b4d1238e9ee0040618
7
- data.tar.gz: 1022635f98bd37c776d137315fd61f9ba82dd72831ca16ef2e834f45bcba0456e90614eebc85df1fd08b7e03183daa16beaa098575d4161f74b54e3d1ef998b6
6
+ metadata.gz: 56a10d73bf0a1f2625a663396c36ad569b558ff3204ded4aa5d378a85da72aef6194baee26cd92212f23ebb027fc4da75ef38d21c0196f3eeb681393ac81515c
7
+ data.tar.gz: 59659f2434ff18dafabfd6703b12d67820f35b7e47016eb20338da3ad1e3217df94cf37d51a86d99803f9fa544e540bd3cfbfa7151b99e398ef87c90f6b58468
data/CHANGELOG.md CHANGED
@@ -2,6 +2,10 @@
2
2
 
3
3
  ## Unreleased
4
4
 
5
+ ## 3.2.1
6
+
7
+ - Don't raise `UnknownQueryParameterError` if request is ignored in tests. Fixes [#441](https://github.com/ahx/openapi_first/issues/441).
8
+
5
9
  ## 3.2.0
6
10
 
7
11
  ### Changed
@@ -88,7 +88,7 @@ module OpenapiFirst
88
88
  return false if @ignore_request_error&.call(validated_request)
89
89
  return false if ignore_unknown_requests? && validated_request.unknown?
90
90
 
91
- validated_request.unknown?
91
+ true
92
92
  end
93
93
 
94
94
  def raise_response_error?(validated_response, rack_request)
@@ -106,9 +106,12 @@ module OpenapiFirst
106
106
  OpenapiFirst.configure do |config|
107
107
  @after_request_validation = config.after_request_validation do |validated_request, oad|
108
108
  next unless registered?(oad)
109
- raise validated_request.error.exception if raise_request_error?(validated_request)
110
109
 
111
- check_unknown_query_parameters(validated_request)
110
+ if configuration.raise_request_error?(validated_request)
111
+ raise validated_request.error.exception if validated_request.unknown?
112
+
113
+ check_unknown_query_parameters(validated_request)
114
+ end
112
115
 
113
116
  Coverage.track_request(validated_request, oad)
114
117
  end
@@ -152,12 +155,6 @@ module OpenapiFirst
152
155
  "Unknown query parameter#{s} #{list} for #{validated_request.fullpath}"
153
156
  end
154
157
 
155
- def raise_request_error?(validated_request)
156
- return false if validated_request.valid?
157
-
158
- configuration.raise_request_error?(validated_request)
159
- end
160
-
161
158
  def many?(array) = array.length > 1
162
159
 
163
160
  def raise_response_error?(validated_response, rack_request)
@@ -33,6 +33,7 @@ module OpenapiFirst
33
33
  def_delegator :request_definition, :operation
34
34
 
35
35
  # @return [Hash] Query parameters and values that are not defined in the OpenAPI spec.
36
+ # FIXME: Optimize this so it does not have to parse the query string a second time to find unknown parameters
36
37
  def unknown_query_parameters
37
38
  @query_parser&.unknown_values(query_string)
38
39
  end
@@ -1,5 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  module OpenapiFirst
4
- VERSION = '3.2.0'
4
+ VERSION = '3.2.1'
5
5
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: openapi_first
3
3
  version: !ruby/object:Gem::Version
4
- version: 3.2.0
4
+ version: 3.2.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Andreas Haller