open_lighting 0.1.2 → 0.1.3

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## Open Lighting 0.1.2 ##
+
+* fix nasty bug when calling named points multiple times
+* DmxController.close! method for explicitly closing the read/write pipes
+
 ## Open Lighting 0.1.1 ##
 
 * add named points after initialization

data/lib/open_lighting/dmx_controller.rb

@@ -55,6 +55,7 @@ module OpenLighting
 
     def write!(values=current_values)
       self.write_pipe ||= IO.popen(self.cmd, "w")
+      self.write_pipe.sync = true
 
       # DMX only wants integer inputs
       values.map!{|i| i.to_i}
@@ -99,7 +100,7 @@ module OpenLighting
       warn "[DEPRECATION] `transition!` is deprecated. Use `begin_animation!` instead."
     end
 
-    def begin_animation!(options = {}, &block)
+    def animate!(options = {}, &block)
       previous = current_values
       buffer(options)
 
@@ -113,6 +114,10 @@ module OpenLighting
       end
     end
 
+    def begin_animation!(options = {}, &block)
+      animate!(options, &block)
+    end
+
     def interpolate(first, last, total, i)
       results = []
       first.count.times do |j|
@@ -138,7 +143,7 @@ module OpenLighting
         # causes controller.center! to convert to controller.instant!(:point => :center)
         instant! :point => meth_without_bang
       elsif capabilities.include? meth
-        buffer meth => args
+        buffer meth => args.first
       elsif capabilities.include? meth_without_bang
         instant! meth_without_bang => args.first
       else

data/lib/open_lighting/version.rb

@@ -1,3 +1,3 @@
 module OpenLighting
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/spec/open_lighting/dmx_controller_spec.rb

@@ -191,7 +191,7 @@ module OpenLighting
       end
 
       it "should write interpolated values to the pipe" do
-        @controller.begin_animation!(:seconds => 5, :pan => 25)
+        @controller.animate!(:seconds => 5, :pan => 25)
         @controller.read_pipe.gets.should == "5,0,0,5,0,0\n"
         @controller.read_pipe.gets.should == "10,0,0,10,0,0\n"
         @controller.read_pipe.gets.should == "15,0,0,15,0,0\n"
@@ -212,6 +212,13 @@ module OpenLighting
         @controller.read_pipe.gets.should == "25,0,0,50,0,0\n"
         @controller.write_pipe.close
       end
+
+      it "should allow sequential calls to method_missing and animate" do
+        @controller.dimmer(50)
+        @controller.to_dmx.should == "0,0,50,0,0,50"
+        @controller.animate!(:seconds => 1, :dimmer => 127)
+        @controller.read_pipe.gets.should == "0,0,127,0,0,127\n"
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: open_lighting
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-04 00:00:00.000000000 Z
+date: 2012-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json