open_gem 1.4.0 → 1.4.2

data/CHANGELOG.markdown

@@ -1,6 +1,11 @@
 OpenGem
 ========
-...
+1.4.2
+---
+* Respect the VISUAL environment variable above EDITOR. (cwninja)
+* Use Launchy gem to read rdocs (ngauthier)
+
+1.4
 ---
 * Updating to use GemCutter to host gems now...
 

data/Rakefile

@@ -19,6 +19,7 @@ begin
     
     # Testing
     s.test_files = FileList["test/**/*_test.rb"]
+    s.add_dependency 'launchy', '~> 0.3.5'
     s.add_development_dependency 'mocha', '~> 0.9.5'
   end
 
@@ -32,4 +33,4 @@ Rake::TestTask.new do |t|
   t.verbose = false
 end
 
-task :default => :test
+task :default => :test

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :minor: 4
-:patch: 0
+:patch: 2
 :major: 1

data/lib/rubygems/commands/open_command.rb

@@ -33,9 +33,9 @@ class Gem::Commands::OpenCommand < Gem::Command
   end
 
   def open_gem(path)
-    editor = options[:command] || ENV['GEM_OPEN_EDITOR'] || ENV['EDITOR']
+    editor = options[:command] || ENV['GEM_OPEN_EDITOR'] || ENV['VISUAL'] || ENV['EDITOR']
     if !editor
-      say "Either set $EDITOR, or use -c <command_name>"
+      say "Either set $GEM_OPEN_EDITOR, $VISUAL, $EDITOR, or use -c <command_name>"
     else
       command_parts = Shellwords.shellwords(editor)
       command_parts << path

data/lib/rubygems/commands/read_command.rb

@@ -1,3 +1,4 @@
+require 'launchy'
 # ReadCommand will open a gem's rdoc
 class Gem::Commands::ReadCommand < Gem::Command
   include OpenGem::CommonOptions
@@ -40,22 +41,17 @@ class Gem::Commands::ReadCommand < Gem::Command
     Gem::DocManager.new(spec).generate_rdoc
   end
   
-  def rdoc_reader
-    options[:command] || case RUBY_PLATFORM.downcase
-      when /darwin/ then 'open'
-      when /mswin/  then 'explorer'
-      when /linux/  then 'firefox'
-      else               'firefox' # Come on, if you write ruby, you probably have firefox installed ;)
-    end
-  end
-  
   def read_gem(path)
-    command_parts = Shellwords.shellwords(rdoc_reader)
-    command_parts << path
-    success = system(*command_parts)
-    if !success 
-      raise Gem::CommandLineError, "Could not run '#{rdoc_reader} #{path}', exit code: #{$?.exitstatus}"
+    if options[:command]
+      command_parts = Shellwords.shellwords(options[:command])
+      command_parts << path
+      success = system(*command_parts)
+      if !success 
+        raise Gem::CommandLineError, "Could not run '#{rdoc_reader} #{path}', exit code: #{$?.exitstatus}"
+      end
+    else
+      Launchy::Browser.run("file://"+path)
     end
   end
   
-end
+end

metadata

@@ -1,7 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: open_gem
 version: !ruby/object:Gem::Version 
-  version: 1.4.0
+  prerelease: false
+  segments: 
+  - 1
+  - 4
+  - 2
+  version: 1.4.2
 platform: ruby
 authors: 
 - Adam Sanderson
@@ -9,19 +14,37 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-10-09 00:00:00 -07:00
+date: 2010-04-23 00:00:00 -07:00
 default_executable: 
 dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: launchy
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        segments: 
+        - 0
+        - 3
+        - 5
+        version: 0.3.5
+  type: :runtime
+  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: mocha
-  type: :development
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
+        - 9
+        - 5
         version: 0.9.5
-    version: 
+  type: :development
+  version_requirements: *id002
 description: "      Open a gem's source directory with either the default editor, or a specified command.\n"
 email: netghost@gmail.com
 executables: []
@@ -40,7 +63,7 @@ files:
 - lib/rubygems/commands/read_command.rb
 - lib/rubygems_plugin.rb
 - test/open_command_test.rb
-has_rdoc: true
+has_rdoc: false
 homepage: http://github.com/adamsanderson/open_gem
 licenses: []
 
@@ -53,18 +76,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: opengem
-rubygems_version: 1.3.5
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: Gem Command to easily open a ruby gem with the editor of your choice.