open4 0.9.1 → 0.9.2

data/README

@@ -10,6 +10,9 @@ SYNOPSIS
 
 HISTORY
 
+  0.9.2:
+    - fixed a descriptor leak.  thanks Andre Nathan.
+
   0.9.1:
     - fixed warning with '-w' : @cid not initialized.  thanks blaise tarr.
 

data/leak.rb

@@ -0,0 +1,17 @@
+require 'open4'
+
+pid = Process.pid
+fds = lambda{|pid| Dir["/proc/#{ pid }/fd/*"]}
+
+loop do
+  before = fds[pid] 
+  Open4.popen4 'ruby -e"buf = STDIN.read; STDOUT.puts buf; STDERR.puts buf "' do |p,i,o,e|
+    i.puts 42
+    i.close_write
+    o.read
+    e.read
+  end
+  after = fds[pid] 
+  p(after - before)
+  puts
+end

data/lib/{open4-0.9.1.rb → open4-0.9.2.rb}

@@ -4,7 +4,7 @@ require 'thread'
 
 module Open4
 #--{{{
-  VERSION = '0.9.1'
+  VERSION = '0.9.2'
   def self.version() VERSION end
 
   class Error < ::StandardError; end
@@ -13,6 +13,11 @@ module Open4
 #--{{{
     pw, pr, pe, ps = IO.pipe, IO.pipe, IO.pipe, IO.pipe
 
+%w( pw pr pe ps ).each do |pair|
+  puts "#{ pair }.first.fileno: " => eval(pair).first.fileno 
+  puts "#{ pair }.last.fileno: " => eval(pair).last.fileno 
+end
+
     verbose = $VERBOSE
     begin
       $VERBOSE = nil
@@ -54,6 +59,8 @@ module Open4
       raise(Exception === e ? e : "unknown failure!")
     rescue EOFError # If we get an EOF error, then the exec was successful
       42
+    ensure
+      ps.first.close
     end
 
     pw.last.sync = true

data/lib/open4.rb

@@ -4,7 +4,7 @@ require 'thread'
 
 module Open4
 #--{{{
-  VERSION = '0.9.1'
+  VERSION = '0.9.2'
   def self.version() VERSION end
 
   class Error < ::StandardError; end
@@ -13,6 +13,11 @@ module Open4
 #--{{{
     pw, pr, pe, ps = IO.pipe, IO.pipe, IO.pipe, IO.pipe
 
+%w( pw pr pe ps ).each do |pair|
+  puts "#{ pair }.first.fileno: " => eval(pair).first.fileno 
+  puts "#{ pair }.last.fileno: " => eval(pair).last.fileno 
+end
+
     verbose = $VERBOSE
     begin
       $VERBOSE = nil
@@ -54,6 +59,8 @@ module Open4
       raise(Exception === e ? e : "unknown failure!")
     rescue EOFError # If we get an EOF error, then the exec was successful
       42
+    ensure
+      ps.first.close
     end
 
     pw.last.sync = true

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
-rubygems_version: 0.8.11
+rubygems_version: 0.9.2
 specification_version: 1
 name: open4
 version: !ruby/object:Gem::Version 
-  version: 0.9.1
-date: 2006-10-24 00:00:00.000000 -06:00
+  version: 0.9.2
+date: 2007-03-25 00:00:00 -06:00
 summary: open4
 require_paths: 
-  - lib
+- lib
 email: ara.t.howard@noaa.gov
 homepage: http://codeforpeople.com/lib/ruby/open4/
 rubyforge_project: 
@@ -18,35 +18,43 @@ bindir: bin
 has_rdoc: false
 required_ruby_version: !ruby/object:Gem::Version::Requirement 
   requirements: 
-    - 
-      - ">"
-      - !ruby/object:Gem::Version 
-        version: 0.0.0
+  - - ">"
+    - !ruby/object:Gem::Version 
+      version: 0.0.0
   version: 
 platform: ruby
 signing_key: 
 cert_chain: 
+post_install_message: 
 authors: 
-  - Ara T. Howard
+- Ara T. Howard
 files: 
-  - install.rb
-  - sample
-  - lib
-  - README
-  - gemspec.rb
-  - sample/block.rb
-  - sample/simple.rb
-  - sample/exception.rb
-  - sample/spawn.rb
-  - sample/bg.rb
-  - sample/timeout.rb
-  - sample/stdin_timeout.rb
-  - lib/open4.rb
-  - lib/open4-0.9.1.rb
+- install.rb
+- sample
+- sample/block.rb
+- sample/simple.rb
+- sample/exception.rb
+- sample/spawn.rb
+- sample/bg.rb
+- sample/timeout.rb
+- sample/stdin_timeout.rb
+- lib
+- lib/open4.rb
+- lib/open4-0.9.2.rb
+- README
+- gemspec.rb
+- leak.rb
 test_files: []
+
 rdoc_options: []
+
 extra_rdoc_files: []
+
 executables: []
+
 extensions: []
+
 requirements: []
-dependencies: []
+
+dependencies: []
+