open-companies-house 0.2.4 → 0.2.5

data/lib/companies_house/request.rb

@@ -37,7 +37,12 @@ module CompaniesHouse
     def validate(number)
       number = number.to_s.strip # remove whitespace
 
-      number = "0" + number if number.length == 7 # 0-pad for luck
+      # 0-pad 5 or 7 digit registration number
+      if number.match /(\D{2})(\d{5})$/
+        number = $1 + $2.rjust(6,"0")
+      elsif number.match /(\d{7}$)/
+        number = number.rjust(8, "0")
+      end
 
       companies_house_regex = Regexp.
         new("\\A(#{ALLOWED_PREFIXES * '|'})\\d{6}\\z")

data/lib/companies_house/version.rb

@@ -1,3 +1,3 @@
 module CompaniesHouse
-  VERSION = '0.2.4'.freeze
+  VERSION = '0.2.5'.freeze
 end

data/spec/companies_house/request_spec.rb

@@ -46,11 +46,29 @@ describe CompaniesHouse::Request do
       end
     end
 
+    it "does not 0-pads 8 digit registration numbers" do
+      company = subject.new "17495895"
+      company.instance_variable_get(:@registration_number).
+        should == "17495895"
+    end
+
     it "0-pads 7 digit registration numbers" do
       company = subject.new "7495895"
       company.instance_variable_get(:@registration_number).
         should == "07495895"
     end
+
+    it "0-pads 5 digit NI registration numbers" do
+      company = subject.new "NI27768"
+      company.instance_variable_get(:@registration_number).
+        should == "NI027768"
+    end
+
+    it "does not 0-pads 6 digit NI registration numbers" do
+      company = subject.new "NI127768"
+      company.instance_variable_get(:@registration_number).
+        should == "NI127768"
+    end
   end
 
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: open-companies-house
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-21 00:00:00.000000000 Z
+date: 2012-12-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec