opal 1.8.0 → 1.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ea935af6a628e09fb047d39c25422f717a4a4b9ef442fe7ec06183134b3163a1
-  data.tar.gz: d539d6a55c69651064a272a6110498bdba7d2146fa08704f4e759ee7693c28b2
+  metadata.gz: 8af8b2b4d485065e48d45e66e00075cf3b2f3d58c358355f5cbf5c97c46cd607
+  data.tar.gz: 87b7e4d8443eeb45953d48ca6ebb321b27269d9e7bbe2c4770c5189bcd44bcf9
 SHA512:
-  metadata.gz: 603568ce7472d94e52edc2b4862a5cadb72313e8e1f344c723655a7a691b09cbde1d208e30935a68a2a78c59fa073724d66b24ef7cf56cf69eb8567b9aa851f4
-  data.tar.gz: 7ea6135b1f97d50584259706244705273b429d1eff03c44742f7c165b6caec782a06d33ac209f94545ec2c4f8665c1992367aebbf5699052fc62163414c99e1d
+  metadata.gz: 615891333955fa65566ccad7f18d7a2a65905076db6268775bb5e9f06604b56e4ebfcb8fc05d181353c1bcfbba64c195c2eb4f71b37f805e9f7984f990e56a41
+  data.tar.gz: 1566eb09bf04acbcb49c7386ab9259cd13f8d94810e9dfecadf109b57ad2eaf479d1df419359a4a776b11aba2c7cc97d7df761c9ade46a2b8512d2718503ab69

data/CHANGELOG.md

@@ -16,6 +16,38 @@ Changes are grouped as follows:
 
 
 
+## [1.8.1](https://github.com/opal/opal/compare/v1.8.0...v1.8.1) - 2023-11-09
+
+
+<!--
+### Internal
+### Changed
+### Added
+### Removed
+### Deprecated
+### Performance
+### Fixed
+-->
+
+
+### Fixed
+
+- `Array` methods should handle elements inserted during the iteration ([#2602](https://github.com/opal/opal/pull/2602))
+- Assign correct values to duplicated underscore parameters ([#2606](https://github.com/opal/opal/pull/2606))
+
+
+### Added
+
+- Support an `IO` argument of `Kernel.printf` ([#2605](https://github.com/opal/opal/pull/2605))
+
+
+### Performance
+
+- Fix a performance regression introduced by freezing support ([#2609](https://github.com/opal/opal/pull/2609))
+
+
+
+
 ## [1.8.0](https://github.com/opal/opal/compare/v1.7.4...v1.8.0) - 2023-10-26
 
 

data/lib/opal/nodes/args/parameters.rb

@@ -10,25 +10,28 @@ module Opal
 
         def to_code
           stringified_parameters = @args.map do |arg|
-            public_send(:"on_#{arg.type}", *arg)
+            public_send(:"on_#{arg.type}", arg)
           end
 
           "[#{stringified_parameters.compact.join(', ')}]"
         end
 
-        def on_arg(arg_name)
+        def on_arg(arg)
+          arg_name = arg.meta[:arg_name]
           %{['req', '#{arg_name}']}
         end
 
-        def on_mlhs(*)
+        def on_mlhs(_arg)
           %{['req']}
         end
 
-        def on_optarg(arg_name, _default_value)
+        def on_optarg(arg)
+          arg_name = arg.meta[:arg_name]
           %{['opt', '#{arg_name}']}
         end
 
-        def on_restarg(arg_name = nil)
+        def on_restarg(arg)
+          arg_name = arg.meta[:arg_name]
           if arg_name
             arg_name = :* if arg_name == :fwd_rest_arg
             %{['rest', '#{arg_name}']}
@@ -37,15 +40,18 @@ module Opal
           end
         end
 
-        def on_kwarg(arg_name)
+        def on_kwarg(arg)
+          arg_name = arg.meta[:arg_name]
           %{['keyreq', '#{arg_name}']}
         end
 
-        def on_kwoptarg(arg_name, _default_value)
+        def on_kwoptarg(arg)
+          arg_name = arg.meta[:arg_name]
           %{['key', '#{arg_name}']}
         end
 
-        def on_kwrestarg(arg_name = nil)
+        def on_kwrestarg(arg)
+          arg_name = arg.meta[:arg_name]
           if arg_name
             %{['keyrest', '#{arg_name}']}
           else
@@ -53,16 +59,17 @@ module Opal
           end
         end
 
-        def on_blockarg(arg_name)
+        def on_blockarg(arg)
+          arg_name = arg.meta[:arg_name]
           arg_name = :& if arg_name == :fwd_block_arg
           %{['block', '#{arg_name}']}
         end
 
-        def on_kwnilarg
+        def on_kwnilarg(_arg)
           %{['nokey']}
         end
 
-        def on_shadowarg(_arg_name); end
+        def on_shadowarg(_arg); end
       end
     end
   end

data/lib/opal/nodes/args.rb

@@ -25,40 +25,12 @@ module Opal
     class ArgsNode < Base
       handle :args
 
-      # ruby allows for args with the same name, if the arg starts with a '_', like:
-      #   def funny_method_name(_, _)
-      #     puts _
-      #   end
-      # but javascript in strict mode does not allow for args with the same name
-      # ruby assigns the value of the first arg given
-      #   funny_method_name(1, 2) => 1
-      # 1. check for args starting with '_' and check if they appear multiple times
-      # 2. leave the first appearance as it is and rename the other ones
-      # compiler result:
-      #   function $$funny_method_name(_, __$2)
-
       def compile
-        same_arg_counter = {}
         children.each_with_index do |arg, idx|
-          if multiple_underscore?(arg)
-            same_arg_counter[arg] ||= 0
-            same_arg_counter[arg]  += 1
-            if same_arg_counter[arg] > 1
-              arg = s(arg.type, :"#{arg.children[0]}_$#{same_arg_counter[arg]}")
-            end
-          end
-
           push ', ' if idx != 0
           push process(arg)
         end
       end
-
-      def multiple_underscore?(arg)
-        arg.type == :arg &&
-          arg.children.count == 1 &&
-          arg.children.first.to_s.start_with?('_') &&
-          children.count(arg) > 1
-      end
     end
   end
 end

data/lib/opal/nodes/super.rb

@@ -176,7 +176,6 @@ module Opal
       def implicit_arglist
         args = []
         kwargs = []
-        same_arg_counter = Hash.new(0)
 
         def_scope.original_args.children.each do |sexp|
           lvar_name = sexp.children[0]
@@ -184,14 +183,6 @@ module Opal
           case sexp.type
           when :arg, :optarg
             arg_node = s(:lvar, lvar_name)
-            #   def m(_, _)
-            # is compiled to
-            #   function $$m(_, __$2)
-            # See Opal::Node::ArgsNode
-            if lvar_name[0] == '_'
-              same_arg_counter[lvar_name] += 1
-              arg_node = s(:js_tmp, "#{lvar_name}_$#{same_arg_counter[lvar_name]}") if same_arg_counter[lvar_name] > 1
-            end
             args << arg_node
           when :restarg
             arg_node = lvar_name ? s(:lvar, lvar_name) : s(:js_tmp, '$rest_arg')

data/lib/opal/rewriter.rb

@@ -11,6 +11,7 @@ require 'opal/rewriters/logical_operator_assignment'
 require 'opal/rewriters/binary_operator_assignment'
 require 'opal/rewriters/hashes/key_duplicates_rewriter'
 require 'opal/rewriters/dump_args'
+require 'opal/rewriters/deduplicate_arg_name'
 require 'opal/rewriters/mlhs_args'
 require 'opal/rewriters/inline_args'
 require 'opal/rewriters/numblocks'
@@ -66,6 +67,7 @@ module Opal
     use Rewriters::BinaryOperatorAssignment
     use Rewriters::Hashes::KeyDuplicatesRewriter
     use Rewriters::ReturnableLogic
+    use Rewriters::DeduplicateArgName
     use Rewriters::DumpArgs
     use Rewriters::MlhsArgs
     use Rewriters::InlineArgs

data/lib/opal/rewriters/deduplicate_arg_name.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+module Opal
+  module Rewriters
+    # Ruby allows for args with the same name, if the arg starts with a '_', like:
+    #   def funny_method_name(_, _)
+    #     puts _
+    #   end
+    # but JavaScript in strict mode does not allow for args with the same name
+    # Ruby assigns the value of the first arg given
+    #   funny_method_name(1, 2) => 1
+    # leave the first appearance as it is and rename the other ones
+    # compiler result:
+    #   function $$funny_method_name(_, __$2)
+    class DeduplicateArgName < Base
+      def on_args(node)
+        @arg_name_count = Hash.new(0)
+
+        children = node.children.map do |arg|
+          rename_arg(arg)
+        end
+
+        super(node.updated(nil, children))
+      end
+
+      def rename_arg(arg)
+        case arg.type
+        when :arg, :restarg, :kwarg, :kwrestarg, :blockarg
+          name = arg.children[0]
+          name ? arg.updated(nil, [unique_name(name)]) : arg
+        when :optarg, :kwoptarg
+          name, value = arg.children
+          arg.updated(nil, [unique_name(name), value])
+        when :mlhs
+          new_children = arg.children.map { |child| rename_arg(child) }
+          arg.updated(nil, new_children)
+        else
+          arg
+        end
+      end
+
+      def unique_name(name)
+        count = (@arg_name_count[name] += 1)
+        count > 1 ? :"#{name}_$#{count}" : name
+      end
+    end
+  end
+end

data/lib/opal/rewriters/inline_args.rb

@@ -91,7 +91,6 @@ module Opal
           @initialization = []
 
           @type = type
-          @underscore_found = false
 
           STEPS.each do |step|
             send(step)
@@ -120,20 +119,9 @@ module Opal
           @args.args.each do |arg|
             if @type == :iter
               # block args are not required,
-              # so we neeed to tell compiler that required args
+              # so we need to tell compiler that required args
               # must be initialized with nil-s
               @initialization << arg.updated(:initialize_iter_arg)
-
-              if arg.children[0] == :_
-                if @underscore_found
-                  # for proc { |_, _| _ }.call(1, 2) result must be 1
-                  # here we convert all underscore args starting from the 2nd
-                  # to a "fake" arg
-                  arg = s(:fake_arg)
-                end
-
-                @underscore_found = true
-              end
             else
               # required inline def argument like 'def m(req)'
               # no initialization is required

data/lib/opal/version.rb

@@ -3,5 +3,5 @@
 module Opal
   # WHEN RELEASING:
   # Remember to update RUBY_ENGINE_VERSION in opal/corelib/constants.rb too!
-  VERSION = '1.8.0'
+  VERSION = '1.8.1'
 end

data/opal/corelib/array.rb

@@ -47,7 +47,7 @@ class ::Array < `Array`
     function filterIf(self, filter, block) {
       var value, raised = null, updated = new Array(self.length);
 
-      for (var i = 0, i2 = 0, length = self.length; i < length; i++) {
+      for (var i = 0, i2 = 0; i < self.length; i++) {
         if (!raised) {
           try {
             value = $yield1(block, self[i])
@@ -708,10 +708,9 @@ class ::Array < `Array`
     return enum_for(:collect) { size } unless block_given?
 
     %x{
-      var length = self.length;
-      var result = new Array(length);
+      var result = [];
 
-      for (var i = 0; i < length; i++) {
+      for (var i = 0; i < self.length; i++) {
         var value = $yield1(block, self[i]);
         result[i] = value;
       }
@@ -726,7 +725,7 @@ class ::Array < `Array`
     %x{
       $deny_frozen_access(self);
 
-      for (var i = 0, length = self.length; i < length; i++) {
+      for (var i = 0; i < self.length; i++) {
         var value = $yield1(block, self[i]);
         self[i] = value;
       }
@@ -988,8 +987,8 @@ class ::Array < `Array`
     return enum_for(:each) { size } unless block_given?
 
     %x{
-      for (var i = 0, length = self.length; i < length; i++) {
-        var value = $yield1(block, self[i]);
+      for (var i = 0; i < self.length; i++) {
+        $yield1(block, self[i]);
       }
     }
 
@@ -1000,8 +999,8 @@ class ::Array < `Array`
     return enum_for(:each_index) { size } unless block_given?
 
     %x{
-      for (var i = 0, length = self.length; i < length; i++) {
-        var value = $yield1(block, i);
+      for (var i = 0; i < self.length; i++) {
+        $yield1(block, i);
       }
     }
 
@@ -1348,7 +1347,7 @@ class ::Array < `Array`
         }
       }
       else if (block !== nil) {
-        for (i = 0, length = self.length; i < length; i++) {
+        for (i = 0; i < self.length; i++) {
           value = block(self[i]);
 
           if (value !== false && value !== nil) {
@@ -1789,7 +1788,7 @@ class ::Array < `Array`
     %x{
       var result = [];
 
-      for (var i = 0, length = self.length, value; i < length; i++) {
+      for (var i = 0, value; i < self.length; i++) {
         value = block(self[i]);
 
         if (value === false || value === nil) {
@@ -1839,7 +1838,11 @@ class ::Array < `Array`
   def reverse_each(&block)
     return enum_for(:reverse_each) { size } unless block_given?
 
-    reverse.each(&block)
+    %x{
+      for (var i = self.length - 1; i >= 0; i--) {
+        $yield1(block, self[i]);
+      }
+    }
     self
   end
 
@@ -2048,7 +2051,7 @@ class ::Array < `Array`
     %x{
       var result = [];
 
-      for (var i = 0, length = self.length, item, value; i < length; i++) {
+      for (var i = 0, item, value; i < self.length; i++) {
         item = self[i];
 
         value = $yield1(block, item);
@@ -2293,7 +2296,7 @@ class ::Array < `Array`
     %x{
       var result = [];
 
-      for (var i = 0, length = self.length, item, value; i < length; i++) {
+      for (var i = 0, item, value; i < self.length; i++) {
         item = self[i];
 
         value = block(item);
@@ -2389,7 +2392,7 @@ class ::Array < `Array`
         }
       }
       else {
-        for (i = 0, length = self.length; i < length; i++) {
+        for (i = 0; i < self.length; i++) {
           item = self[i];
           key = $yield1(block, item);
           if ($hash_get(hash, key) === undefined) {
@@ -2406,23 +2409,24 @@ class ::Array < `Array`
     %x{
       $deny_frozen_access(self);
 
-      var original_length = self.length, hash = #{{}}, i, length, item, key;
+      var hash = #{{}}, i, item, key, delete_indexes = [];
 
-      for (i = 0, length = original_length; i < length; i++) {
+      for (i = 0; i < self.length; i++) {
         item = self[i];
         key = (block === nil ? item : $yield1(block, item));
 
         if ($hash_get(hash, key) === undefined) {
           $hash_put(hash, key, item);
-          continue;
+        } else {
+          delete_indexes.push(i);
         }
+      }
 
-        self.splice(i, 1);
-        length--;
-        i--;
+      for (i = delete_indexes.length - 1; i >= 0; i--) {
+        self.splice(delete_indexes[i], 1);
       }
 
-      return self.length === original_length ? nil : self;
+      return delete_indexes.length === 0 ? nil : self;
     }
   end
 

data/opal/corelib/constants.rb

@@ -1,8 +1,8 @@
 ::RUBY_PLATFORM       = 'opal'
 ::RUBY_ENGINE         = 'opal'
 ::RUBY_VERSION        = '3.2.0'
-::RUBY_ENGINE_VERSION = '1.8.0'
-::RUBY_RELEASE_DATE   = '2023-10-26'
+::RUBY_ENGINE_VERSION = '1.8.1'
+::RUBY_RELEASE_DATE   = '2023-11-09'
 ::RUBY_PATCHLEVEL     = 0
 ::RUBY_REVISION       = '0'
 ::RUBY_COPYRIGHT      = 'opal - Copyright (C) 2011-2023 Adam Beynon and the Opal contributors'

data/opal/corelib/kernel.rb

@@ -1,4 +1,4 @@
-# helpers: truthy, coerce_to, respond_to, Opal, deny_frozen_access, freeze, freeze_props, jsid
+# helpers: truthy, coerce_to, respond_to, Opal, deny_frozen_access, freeze, freeze_props, jsid, each_ivar
 # use_strict: true
 # backtick_javascript: true
 
@@ -369,18 +369,14 @@ module ::Kernel
 
   def instance_variables
     %x{
-      var result = [], ivar;
+      var result = [], name;
 
-      for (var name in self) {
-        if (self.hasOwnProperty(name) && name.charAt(0) !== '$') {
-          if (name.substr(-1) === '$') {
-            ivar = name.slice(0, name.length - 1);
-          } else {
-            ivar = name;
-          }
-          result.push('@' + ivar);
+      $each_ivar(self, function(name) {
+        if (name.substr(-1) === '$') {
+          name = name.slice(0, name.length - 1);
         }
-      }
+        result.push('@' + name);
+      });
 
       return result;
     }
@@ -610,9 +606,10 @@ module ::Kernel
   end
 
   def printf(*args)
-    if args.any?
-      print format(*args)
-    end
+    return if args.empty?
+
+    io = `args[0].$$is_string` ? $stdout : args.shift
+    io.write format(*args)
 
     nil
   end

data/opal/corelib/module.rb

@@ -1,4 +1,4 @@
-# helpers: truthy, coerce_to, const_set, Object, return_ivar, assign_ivar, ivar, deny_frozen_access, freeze, prop, jsid
+# helpers: truthy, coerce_to, const_set, Object, return_ivar, assign_ivar, ivar, deny_frozen_access, freeze, prop, jsid, each_ivar
 # backtick_javascript: true
 
 class ::Module
@@ -744,11 +744,11 @@ class ::Module
     %x{
       var result = [];
 
-      for (var name in self) {
-        if (self.hasOwnProperty(name) && name.charAt(0) !== '$' && name !== 'constructor' && !#{consts.include?(`name`)}) {
+      $each_ivar(self, function(name) {
+        if (name !== 'constructor' && !#{consts.include?(`name`)}) {
           result.push('@' + name);
         }
-      }
+      });
 
       return result;
     }

data/opal/corelib/proc.rb

@@ -1,4 +1,4 @@
-# helpers: slice
+# helpers: slice, each_ivar
 # backtick_javascript: true
 
 class ::Proc < `Function`
@@ -181,11 +181,9 @@ class ::Proc < `Function`
             return original_proc.apply(this, arguments);
           };
 
-      for (var prop in self) {
-        if (self.hasOwnProperty(prop)) {
-          proc[prop] = self[prop];
-        }
-      }
+      $each_ivar(self, function(prop) {
+        proc[prop] = self[prop];
+      });
 
       return proc;
     }

data/opal/corelib/runtime.js

@@ -2580,33 +2580,42 @@
     return obj;
   };
 
-  // freze props, make setters of instance variables throw FrozenError
-  Opal.freeze_props = function(obj) {
-    var prop, prop_type, desc;
+  // Iterate over every instance variable and call func for each one
+  // giving name of the ivar and optionally the property descriptor.
+  function $each_ivar(obj, func) {
+    var own_props = Object.getOwnPropertyNames(obj), own_props_length = own_props.length, i, prop, desc;
 
-    for(prop in obj) {
-      prop_type = typeof(prop);
+    for(i = 0; i < own_props_length; i++) {
+      prop = own_props[i];
 
-      // prop_type "object" here is a String(), skip $ props
-      if ((prop_type === "string" || prop_type === "object") && prop[0] === '$') {
-        continue;
-      }
+      if (prop[0] === '$') continue;
 
       desc = Object.getOwnPropertyDescriptor(obj, prop);
-      if (desc && desc.enumerable && desc.writable) {
-        // create closure to retain current value as cv
-        // for Opal 2.0 let for cv should do the trick, instead of a function
-        (function() {
-          // set v to undefined, as if the property is not set
-          var cv = obj[prop];
-          Object.defineProperty(obj, prop, {
-            get: function() { return cv; },
-            set: function(_val) { $deny_frozen_access(obj); },
-            enumerable: true
-          });
-        })();
+
+      if (desc && desc.enumerable) {
+        func(prop, desc);
       }
     }
+  }
+
+  Opal.each_ivar = $each_ivar;
+
+  // freze props, make setters of instance variables throw FrozenError
+  Opal.freeze_props = function(obj) {
+    var dp_template = {
+      get: null,
+      set: function(_val) { $deny_frozen_access(obj); },
+      enumerable: true
+    };
+
+    $each_ivar(obj, function(prop, desc) {
+      if (!desc.writable) return;
+
+      // Redefine a property with a setter that raises an error.
+      dp_template.get = $return_val(desc.value);
+
+      Object.defineProperty(obj, prop, dp_template);
+    });
   };
 
   // Regexps

data/spec/filters/bugs/array.rb

@@ -8,43 +8,19 @@ opal_filter "Array" do
   fails "Array#[] raises a RangeError if passed a range with a bound that is too large" # Expected RangeError but no exception was raised (nil was returned)
   fails "Array#[] raises a type error if a range is passed with a length" # Expected TypeError but no exception was raised ([2, 3] was returned)
   fails "Array#all? ignores the block if there is an argument" # Expected warning to match: /given block not used/ but got: ""
-  fails "Array#all? tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
   fails "Array#any? when given a pattern argument ignores the block if there is an argument" # Expected warning to match: /given block not used/ but got: ""
-  fails "Array#any? with a block given tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#collect tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#collect! tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#count when a block argument given tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#delete_if tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
   fails "Array#drop raises a TypeError when the passed argument isn't an integer and #to_int returns non-Integer" # Expected TypeError but no exception was raised ([1, 2] was returned)
-  fails "Array#drop_while tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#each does not yield elements deleted from the end of the array" # Expected [2, 3, nil] == [2, 3] to be truthy but was false
-  fails "Array#each tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#each yields each element to the block even if the array is changed during iteration" # Expected [1, 2, 3, 4, 5] == [1, 2, 3, 4, 5, 7, 9] to be truthy but was false
-  fails "Array#each yields elements added to the end of the array by the block" # Expected [2] == [2, 0, 0] to be truthy but was false
-  fails "Array#each yields elements based on an internal index" # NoMethodError: undefined method `even?' for nil
-  fails "Array#each yields only elements that are still in the array" # NoMethodError: undefined method `even?' for nil
-  fails "Array#each yields the same element multiple times if inserting while iterating" # Expected [1, 1] == [1, 1, 2] to be truthy but was false
-  fails "Array#each_index tolerates increasing an array size during iteration" # Expected [0, 1, 2] == [0,  1,  2,  3,  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100,  101,  102] to be truthy but was false
   fails "Array#fill with (filler, index, length) raises a TypeError when the length is not numeric" # Expected TypeError (/no implicit conversion of Symbol into Integer/) but got: TypeError (no implicit conversion of String into Integer)
   fails "Array#fill with (filler, range) works with endless ranges" # Expected [1, 2, 3, 4] == [1, 2, 3, "x"] to be truthy but was false
   fails "Array#filter returns a new array of elements for which block is true" # Expected [1] == [1, 4, 6] to be truthy but was false
-  fails "Array#filter tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#filter! tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#find_index tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
   fails "Array#flatten does not call #to_ary on elements beyond the given level" # Mock '1' expected to receive to_ary("any_args") exactly 0 times but received it 1 times
   fails "Array#flatten performs respond_to? and method_missing-aware checks when coercing elements to array" # NoMethodError: undefined method `respond_to?' for #<BasicObject:0x2698>
   fails "Array#flatten with a non-Array object in the Array calls #method_missing if defined" # Expected [#<MockObject:0x2730 @name="Array#flatten", @null=nil>] == [1, 2, 3] to be truthy but was false
-  fails "Array#index tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
   fails "Array#initialize with no arguments does not use the given block" # Expected warning to match: /ruby\/core\/array\/initialize_spec.rb:57: warning: given block not used/ but got: ""
   fails "Array#inspect does not call #to_str on the object returned from #to_s when it is not a String" # Exception: Cannot convert object to primitive value
   fails "Array#intersect? tries to convert the passed argument to an Array using #to_ary" # Expected false == true to be truthy but was false
-  fails "Array#keep_if tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#map tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#map! tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
   fails "Array#none? ignores the block if there is an argument" # Expected warning to match: /given block not used/ but got: ""
-  fails "Array#none? tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
   fails "Array#one? ignores the block if there is an argument" # Expected warning to match: /given block not used/ but got: ""
-  fails "Array#one? tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
   fails "Array#pack with format 'A' ignores comments in the format string" # RuntimeError: Unsupported pack directive "m" (no chunk reader defined)
   fails "Array#pack with format 'A' warns that a directive is unknown" # Expected warning to match: /unknown pack directive 'R'/ but got: ""
   fails "Array#pack with format 'C' ignores comments in the format string" # RuntimeError: Unsupported pack directive "m" (no chunk reader defined)
@@ -67,13 +43,8 @@ opal_filter "Array" do
   fails "Array#product returns converted arguments using :method_missing" # TypeError: no implicit conversion of ArraySpecs::ArrayMethodMissing into Array
   fails "Array#rassoc calls elem == obj on the second element of each contained array" # Expected [1, "foobar"] == [2, #<MockObject:0x4a6b4 @name="foobar", @null=nil>] to be truthy but was false
   fails "Array#rassoc does not check the last element in each contained but specifically the second" # Expected [1, "foobar", #<MockObject:0x4a37e @name="foobar", @null=nil>] == [2, #<MockObject:0x4a37e @name="foobar", @null=nil>, 1] to be truthy but was false
-  fails "Array#reject tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#reject! tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#reverse_each tolerates increasing an array size during iteration" # Expected ["c", "b", "a"] == ["c", "a", 1] to be truthy but was false
   fails "Array#sample returns nil for an empty array when called without n and a Random is given" # ArgumentError: invalid argument - 0
   fails "Array#select returns a new array of elements for which block is true" # Expected [1] == [1, 4, 6] to be truthy but was false
-  fails "Array#select tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#select! tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
   fails "Array#shuffle! matches CRuby with random:" # Expected [7, 4, 5, 0, 3, 9, 2, 8, 10, 1, 6] == [2, 6, 8, 5, 7, 10, 3, 1, 0, 4, 9] to be truthy but was false
   fails "Array#shuffle! matches CRuby with srand" # Expected ["d", "j", "g", "f", "i", "e", "c", "k", "b", "h", "a"] == ["a", "e", "f", "h", "i", "j", "d", "b", "g", "k", "c"] to be truthy but was false
   fails "Array#slice can be sliced with Enumerator::ArithmeticSequence has endless range with start outside of array's bounds" # Expected [] == nil to be truthy but was false
@@ -81,15 +52,8 @@ opal_filter "Array" do
   fails "Array#slice raises TypeError if to_int returns non-integer" # Expected TypeError but no exception was raised ([1, 2, 3, 4] was returned)
   fails "Array#slice raises a RangeError if passed a range with a bound that is too large" # Expected RangeError but no exception was raised (nil was returned)
   fails "Array#slice raises a type error if a range is passed with a length" # Expected TypeError but no exception was raised ([2, 3] was returned)
-  fails "Array#sort_by! tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
   fails "Array#sum calls + on the init value" # NoMethodError: undefined method `-' for #<MockObject:0x7f7c2 @name="b" @null=nil>
-  fails "Array#sum tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#take_while tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#to_h tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
   fails "Array#to_s does not call #to_str on the object returned from #to_s when it is not a String" # Exception: Cannot convert object to primitive value
-  fails "Array#uniq tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
-  fails "Array#uniq! properly handles recursive arrays" # Expected [1, "two", 3, [...], [...], [...]] == [1, "two", 3, [1, "two", 3, [...], [...], [...]]] to be truthy but was false
-  fails "Array#uniq! tolerates increasing an array size during iteration" # Expected [1, 2, 3] == [1,  2,  3,  "a",  "b",  "c",  4,  5,  6,  7,  8,  9,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  100] to be truthy but was false
   fails "Array#zip raises TypeError when some argument isn't Array and doesn't respond to #to_ary and #to_enum" # Expected TypeError (wrong argument type Object (must respond to :each)) but got: NoMethodError (undefined method `each' for #<Object:0x6273e>)
   fails "Array.new with no arguments does not use the given block" # Expected warning to match: /warning: given block not used/ but got: ""
   fails "Array.try_convert sends #to_ary to the argument and raises TypeError if it's not a kind of Array" # Expected TypeError (can't convert MockObject to Array (MockObject#to_ary gives Object)) but got: TypeError (can't convert MockObject into Array (MockObject#to_ary gives Object))

data/spec/filters/bugs/enumerable.rb

@@ -17,14 +17,12 @@ opal_filter "Enumerable" do
   fails "Enumerable#grep_v does not set $~ when given no block" # Expected "e" == "z" to be truthy but was false
   fails "Enumerable#inject ignores the block if two arguments" # Expected warning to match: /ruby\/core\/enumerable\/shared\/inject.rb:23: warning: given block not used/ but got: ""
   fails "Enumerable#inject raises an ArgumentError when no parameters or block is given" # Expected ArgumentError but got: Exception (Cannot read properties of undefined (reading '$inspect'))
-  fails "Enumerable#inject tolerates increasing a collection size during iterating Array" # Expected ["a", "b", "c"] == [0,  1,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  2,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  3,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  4,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  5,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  6,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  7,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  8,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  9,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  "a",  "b",  "c"] to be truthy but was false
   fails "Enumerable#map reports the same arity as the given block" # Exception: Cannot read properties of undefined (reading '$$is_array')
   fails "Enumerable#map yields 2 arguments for a Hash when block arity is 2" # ArgumentError: [#register] wrong number of arguments (given 1, expected 2)
   fails "Enumerable#none? when given a pattern argument ignores the block if there is an argument" # Expected warning to match: /given block not used/ but got: ""
   fails "Enumerable#one? when given a pattern argument ignores the block if there is an argument" # Expected warning to match: /given block not used/ but got: ""
   fails "Enumerable#reduce ignores the block if two arguments" # Expected warning to match: /ruby\/core\/enumerable\/shared\/inject.rb:23: warning: given block not used/ but got: ""
   fails "Enumerable#reduce raises an ArgumentError when no parameters or block is given" # Expected ArgumentError but got: Exception (Cannot read properties of undefined (reading '$inspect'))
-  fails "Enumerable#reduce tolerates increasing a collection size during iterating Array" # Expected ["a", "b", "c"] == [0,  1,  10,  11,  12,  13,  14,  15,  16,  17,  18,  19,  2,  20,  21,  22,  23,  24,  25,  26,  27,  28,  29,  3,  30,  31,  32,  33,  34,  35,  36,  37,  38,  39,  4,  40,  41,  42,  43,  44,  45,  46,  47,  48,  49,  5,  50,  51,  52,  53,  54,  55,  56,  57,  58,  59,  6,  60,  61,  62,  63,  64,  65,  66,  67,  68,  69,  7,  70,  71,  72,  73,  74,  75,  76,  77,  78,  79,  8,  80,  81,  82,  83,  84,  85,  86,  87,  88,  89,  9,  90,  91,  92,  93,  94,  95,  96,  97,  98,  99,  "a",  "b",  "c"] to be truthy but was false
   fails "Enumerable#reverse_each gathers whole arrays as elements when each yields multiple" # Expected [6, 3, 1] == [[6, 7, 8, 9], [3, 4, 5], [1, 2]] to be truthy but was false
   fails "Enumerable#slice_when when an iterator method yields more than one value processes all yielded values" # Expected [] == [[[1, 2]]] to be truthy but was false
   fails "Enumerable#slice_when when given a block doesn't yield an empty array on a small enumerable" # Expected [] == [[42]] to be truthy but was false
@@ -34,6 +32,6 @@ opal_filter "Enumerable" do
   fails "Enumerable#tally counts values as gathered array when yielded with multiple arguments" # Expected {[]=>3, 0=>1, [0, 1]=>2, [0, 1, 2]=>3, nil=>1, "default_arg"=>1, [0]=>1} == {nil=>2, 0=>1, [0, 1]=>2, [0, 1, 2]=>3, "default_arg"=>1, []=>2, [0]=>1} to be truthy but was false
   fails "Enumerable#tally with a hash calls #to_hash to convert argument to Hash implicitly if passed not a Hash" # NoMethodError: undefined method `fetch' for #<Object:0x8def0>
   fails "Enumerable#uniq uses eql? semantics" # Expected [1] == [1, 1] to be truthy but was false
-  fails "Enumerable#zip passes each element of the result array to a block and return nil if a block is given" # Expected [[1, 4, 7], [2, 5, 8], [3, 6, 9]] == nil to be truthy but was false  
+  fails "Enumerable#zip passes each element of the result array to a block and return nil if a block is given" # Expected [[1, 4, 7], [2, 5, 8], [3, 6, 9]] == nil to be truthy but was false
   fails "Enumerable#zip raises TypeError when some argument isn't Array and doesn't respond to #to_ary and #to_enum" # Expected TypeError (wrong argument type Object (must respond to :each)) but got: NoMethodError (undefined method `each' for #<Object:0x2e1e6>)
 end

data/spec/filters/bugs/kernel.rb

@@ -352,14 +352,12 @@ opal_filter "Kernel" do
   fails "Kernel.printf formatting io is not specified other formats c tries to convert argument to Integer with to_int" # NoMethodError: undefined method `respond_to?' for #<BasicObject:0x4080e>
   fails "Kernel.printf formatting io is not specified other formats c tries to convert argument to String with to_str" # NoMethodError: undefined method `respond_to?' for #<BasicObject:0x40800>
   fails "Kernel.printf formatting io is not specified other formats s preserves encoding of the format string" # Expected #<Encoding:UTF-8> == #<Encoding:US-ASCII> to be truthy but was false
-  fails "Kernel.printf formatting io is specified other formats c raises TypeError if argument is nil" # Expected TypeError (/no implicit conversion from nil to integer/) but got: Exception (format_string.indexOf is not a function)
-  fails "Kernel.printf formatting io is specified other formats c raises TypeError if argument is not String or Integer and cannot be converted to them" # Expected TypeError (/no implicit conversion of Array into Integer/) but got: Exception (format_string.indexOf is not a function)
-  fails "Kernel.printf formatting io is specified other formats c raises TypeError if converting to Integer with to_int returns non-Integer" # Expected TypeError (/can't convert BasicObject to String/) but got: Exception (format_string.indexOf is not a function)
-  fails "Kernel.printf formatting io is specified other formats c raises TypeError if converting to String with to_str returns non-String" # Expected TypeError (/can't convert BasicObject to String/) but got: Exception (format_string.indexOf is not a function)
-  fails "Kernel.printf formatting io is specified other formats c tries to convert argument to Integer with to_int" # Exception: format_string.indexOf is not a function
-  fails "Kernel.printf formatting io is specified other formats c tries to convert argument to String with to_str" # Exception: format_string.indexOf is not a function
-  fails "Kernel.printf formatting io is specified other formats s formats nil with precision" # Exception: format_string.indexOf is not a function
-  fails "Kernel.printf formatting io is specified other formats s formats nil with width" # Exception: format_string.indexOf is not a function
+  fails "Kernel.printf formatting io is specified other formats c raises TypeError if argument is nil" # Expected TypeError (/no implicit conversion from nil to integer/) but got: TypeError (no implicit conversion of NilClass into Integer)
+  fails "Kernel.printf formatting io is specified other formats c raises TypeError if argument is not String or Integer and cannot be converted to them" # Expected TypeError (/no implicit conversion of Array into Integer/) but got: ArgumentError (too few arguments)
+  fails "Kernel.printf formatting io is specified other formats c raises TypeError if converting to Integer with to_int returns non-Integer" # Expected TypeError (/can't convert BasicObject to Integer/) but got: NoMethodError (undefined method `respond_to?' for #<BasicObject:0x69e>)
+  fails "Kernel.printf formatting io is specified other formats c raises TypeError if converting to String with to_str returns non-String" # Expected TypeError (/can't convert BasicObject to String/) but got: NoMethodError (undefined method `respond_to?' for #<BasicObject:0x6cc>)
+  fails "Kernel.printf formatting io is specified other formats c tries to convert argument to Integer with to_int" # NoMethodError: undefined method `respond_to?' for #<BasicObject:0x6a8>
+  fails "Kernel.printf formatting io is specified other formats c tries to convert argument to String with to_str" # NoMethodError: undefined method `respond_to?' for #<BasicObject:0x6c2>
   fails "Kernel.printf formatting io is specified other formats s preserves encoding of the format string" # Expected #<Encoding:UTF-8> == #<Encoding:US-ASCII> to be truthy but was false
   fails "Kernel.printf writes to stdout when a string is the first argument" # NoMethodError: undefined method `tmp' for #<MSpecEnv:0x4046a @name=nil @stdout=#<IO:0xa @fd=1 @flags="w" @eof=false @closed="both" @write_proc=#<Proc:0x40474> @tty=true>>
   fails "Kernel.proc returned the passed Proc if given an existing Proc" # Expected false to be true

data/spec/filters/bugs/ruby-32.rb

@@ -7,8 +7,8 @@ opal_filter "Ruby 3.2" do
   fails "Kernel#sprintf other formats c displays only the first character if argument is a string of several characters" # ArgumentError: %c requires a character
   fails "Kernel.printf formatting io is not specified other formats c displays no characters if argument is an empty string" # ArgumentError: %c requires a character
   fails "Kernel.printf formatting io is not specified other formats c displays only the first character if argument is a string of several characters" # ArgumentError: %c requires a character
-  fails "Kernel.printf formatting io is specified other formats c displays no characters if argument is an empty string" # Exception: format_string.indexOf is not a function
-  fails "Kernel.printf formatting io is specified other formats c displays only the first character if argument is a string of several characters" # Exception: format_string.indexOf is not a function
+  fails "Kernel.printf formatting io is specified other formats c displays no characters if argument is an empty string" # ArgumentError: %c requires a character
+  fails "Kernel.printf formatting io is specified other formats c displays only the first character if argument is a string of several characters" # ArgumentError: %c requires a character
   fails "Kernel.sprintf other formats c displays no characters if argument is an empty string" # ArgumentError: %c requires a character
   fails "Kernel.sprintf other formats c displays only the first character if argument is a string of several characters" # ArgumentError: %c requires a character
   fails "Keyword arguments delegation does not work with call(*ruby2_keyword_args) with missing ruby2_keywords in between" # Expected [[], {}] == [[{}], {}] to be truthy but was false

data/spec/filters/unsupported/kernel.rb

@@ -21,8 +21,4 @@ opal_unsupported_filter "Kernel" do
   fails "Kernel#warn is a private method" # Expected Kernel to have private instance method 'warn' but it does not
   fails "Kernel.Float raises a TypeError if #to_f returns an Integer" # Expected TypeError but no exception was raised (123 was returned)
   fails "Kernel.lambda when called without a literal block warns when proc isn't a lambda" # Expected warning: "ruby/core/kernel/lambda_spec.rb:142: warning: lambda without a literal block is deprecated; use the proc without lambda instead\n" but got: ""
-  fails "Kernel.printf formatting io is specified other formats s formats nil with width and precision" # Exception: format_string.indexOf is not a function
-  fails "Kernel.printf formatting io is specified other formats s formats string with width and precision" # Exception: format_string.indexOf is not a function
-  fails "Kernel.printf formatting io is specified other formats s formats string with width" # Exception: format_string.indexOf is not a function
-  fails "Kernel.printf formatting io is specified other formats s substitutes '' for nil" # Exception: format_string.indexOf is not a function  
 end

data/spec/opal/core/language/arguments/underscore_arg_spec.rb

@@ -0,0 +1,89 @@
+describe 'duplicated underscore parameter' do
+  it 'assigns the first arg' do
+    klass = Class.new {
+      def req_req(_, _) = _
+      def req_rest_req(_, *, _) = _
+      def rest_req(*_, _) = _
+      def req_opt(_, _ = 0) = _
+      def opt_req(_ = 0, _) = _
+      def req_kwopt(_, _: 0) = _
+      def req_kwrest(_, **_) = _
+      def req_block(_, &_) = _
+      def req_mlhs(_, (_)) = _
+      def mlhs_req((_), _) = _
+      def rest_kw(*_, _:) = _
+      def nested_mlhs(((_), _)) = _
+      def nested_mlhs_rest(((*_, _))) = _
+    }
+    o = klass.new
+
+    o.req_req(1, 2).should == 1
+    o.req_rest_req(1, 2, 3, 4).should == 1
+    o.rest_req(1, 2, 3).should == [1, 2]
+    o.req_opt(1).should == 1
+    o.req_opt(1, 2).should == 1
+    o.opt_req(1).should == 0
+    o.opt_req(1, 2).should == 1
+    o.req_kwopt(1, _: 2).should == 1
+    o.req_kwrest(1, a: 2).should == 1
+    o.req_block(1).should == 1
+    o.req_block(1) {}.should == 1
+    o.req_mlhs(1, [2]).should == 1
+    o.mlhs_req([1], 2).should == 1
+    o.rest_kw(1, 2, _: 3).should == [1, 2]
+    o.nested_mlhs([[1], 2]).should == 1
+    o.nested_mlhs_rest([[1, 2, 3]]).should == [1, 2]
+  end
+
+  context 'in block parameters' do
+    it 'assignes the first arg' do
+      proc { |_, _| _ }.call(1, 2).should == 1
+      proc { |_, *_| _ }.call(1, 2, 3).should == 1
+      proc { |*_, _| _ }.call(1, 2, 3).should == [1, 2]
+      proc { |_, _:| _ }.call(1, _: 2).should == 1
+      proc { |**_, &_| _ }.call(a: 1) {}.should == {a: 1}
+    end
+  end
+
+  it 'distinguishes two arguments starting with _' do
+    klass = Class.new {
+      def foo(_a, _a, _b, _b) = [_a, _b]
+    }
+    o = klass.new
+    o.foo(1, 2, 3, 4).should == [1, 3]
+  end
+
+  it 'works with yield' do
+    klass = Class.new {
+      def foo(_, &_) = yield * 2
+    }
+    o = klass.new
+    o.foo(1) { 2 }.should == 4
+  end
+
+  it 'works with block_given?' do
+    klass = Class.new {
+      def foo(_, &_) = block_given?
+    }
+    o = klass.new
+
+    o.foo(1).should == false
+    o.foo(1) {}.should == true
+  end
+
+  it 'works with zsuper' do
+    parent = Class.new {
+      def foo(*args, **kwargs, &blk)
+        [args, kwargs, blk.call]
+      end
+    }
+    child = Class.new(parent) {
+      def foo(_, _ = 0, *_, _, _:, **_, &_)
+        super
+      end
+    }
+    o = child.new
+
+    o.foo(1, 2, 3, 4, _: 5, a: 6) { 7 }.should == [[1, 2, 3, 4], {_: 5, a: 6}, 7]
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: opal
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.8.1
 platform: ruby
 authors:
 - Elia Schito
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-10-26 00:00:00.000000000 Z
+date: 2023-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast
@@ -602,6 +602,7 @@ files:
 - lib/opal/rewriters/base.rb
 - lib/opal/rewriters/binary_operator_assignment.rb
 - lib/opal/rewriters/block_to_iter.rb
+- lib/opal/rewriters/deduplicate_arg_name.rb
 - lib/opal/rewriters/dot_js_syntax.rb
 - lib/opal/rewriters/dump_args.rb
 - lib/opal/rewriters/for_rewriter.rb
@@ -909,6 +910,7 @@ files:
 - spec/opal/core/language/DATA/multiple___END___crlf_spec.rb
 - spec/opal/core/language/DATA/multiple___END___spec.rb
 - spec/opal/core/language/arguments/mlhs_arg_spec.rb
+- spec/opal/core/language/arguments/underscore_arg_spec.rb
 - spec/opal/core/language/case_spec.rb
 - spec/opal/core/language/forward_args_spec.rb
 - spec/opal/core/language/if_spec.rb
@@ -1228,10 +1230,10 @@ licenses:
 metadata:
   homepage_uri: https://opalrb.com/
   bug_tracker_uri: https://github.com/opal/opal/issues
-  changelog_uri: https://github.com/opal/opal/blob/v1.8.0/CHANGELOG.md
-  readme_uri: https://github.com/opal/opal/blob/v1.8.0/README.md
-  api_documentation_uri: http://opalrb.com/docs/api/v1.8.0/index.html
-  guides_uri: http://opalrb.com/docs/guides/v1.8.0/index.html
+  changelog_uri: https://github.com/opal/opal/blob/v1.8.1/CHANGELOG.md
+  readme_uri: https://github.com/opal/opal/blob/v1.8.1/README.md
+  api_documentation_uri: http://opalrb.com/docs/api/v1.8.1/index.html
+  guides_uri: http://opalrb.com/docs/guides/v1.8.1/index.html
   chat_uri: https://gitter.im/opal/opal
   source_code_uri: https://github.com/opal/opal
 post_install_message:
@@ -1601,6 +1603,7 @@ test_files:
 - lib/opal/rewriters/base.rb
 - lib/opal/rewriters/binary_operator_assignment.rb
 - lib/opal/rewriters/block_to_iter.rb
+- lib/opal/rewriters/deduplicate_arg_name.rb
 - lib/opal/rewriters/dot_js_syntax.rb
 - lib/opal/rewriters/dump_args.rb
 - lib/opal/rewriters/for_rewriter.rb