opal 1.8.0.alpha1 → 1.8.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c756d4ba883cb8f7c7bdfefa6b88cf4a2db0604d1ef8a906d7c58add76eee1bf
-  data.tar.gz: e88f7de8d6add79b64c7d6b896fbd1c94f51edd34754e6da3ceb59e3fa501134
+  metadata.gz: 506ba9114548fa5c492467950421043dbf46d0b72df49eab40c5a62e6f6c2ce6
+  data.tar.gz: e59c280933851d6de0a63f42b19139e5b16c90f68fe0c4652cf555a5ef7e1968
 SHA512:
-  metadata.gz: 1d9e3b8b4cc8decc9fc5644eb842ee84290bb0c6f231de362d259a691570296ac9fab95e400dccda20d317e12b7f3d58334d816a8f5279b304d0435d15ac699f
-  data.tar.gz: '02883fef4e6869c54b718c370ddd03a934e50698eb37638da6788d212286fbc57ecab6c5e0c2c46bd02931ff75e39455f09a6de462157433b03cb8535d1ce76b'
+  metadata.gz: 8536d4701b9197c3cee876bb35bb3fd34cee5726241069d108fa12f8c83753c43d8bc6ac8f95fd867ee5da23ba98b2c8a1b3e284a56df7b6656ffa17850b36c4
+  data.tar.gz: b0f0283471809563e3ea29afcef0b911109aa7d9d9a1f04701c34f48facc8654f20cacc3bd7061273bf74d837c7ae1256d13249e1eb9371e6faa94e3f54fa22b

data/.eslintrc.js

@@ -32,6 +32,7 @@ module.exports = {
     "Proxy": "readonly",
     "Reflect": "readonly",
     "Uint8Array": "readonly",
+    "Int32Array": "readonly",
     "WeakRef": "readonly",
     "Map": "readonly",
   }

data/README.md

@@ -145,12 +145,7 @@ The test suite can be run using:
 
     $ bundle exec rake
 
-This will command will run all RSpec and MSpec examples in sequence.
-
-#### Automated runs
-
-A `Guardfile` with decent mappings between specs and lib/corelib/stdlib files is in place.
-Run `bundle exec guard -i` to start `guard`.
+This command will run all RSpec and MSpec examples in sequence.
 
 
 ### MSpec
@@ -170,6 +165,11 @@ visit `http://localhost:9292/` in any web browser.
     $ rake rspec
 
 
+### Automated runs
+
+A `Guardfile` with decent mappings between specs and lib/corelib/stdlib files is in place.
+Run `bundle exec guard -i` to start `guard`.
+
 ## Code Overview
 
 What code is supposed to run where?
@@ -247,7 +247,7 @@ Support this project by becoming a sponsor. Your logo will show up here with a l
 
 ### Sponsored Contributions
 
-<a href="https://nebulab.it/?utm_source=github&utm_medium=sponsors" target="_blank"><img src="https://nebulab.com/assets/img/logo-nebulab_black.svg" alt="Nebulab Logo"></a>
+<a href="https://nebulab.it/?utm_source=github&utm_medium=sponsors" target="_blank"><img src="https://raw.githubusercontent.com/solidusio/brand/master/partners/Nebulab/logo-dark-light.svg" alt="Nebulab Logo"></a>
 
 
 ## License

data/UNRELEASED.md

@@ -41,6 +41,8 @@ This release brings a lot of performance improvements, our tests on Asciidoctor
 ### Compatibility
 
 - Add a magic-comment that will disable x-string compilation to JavaScript (#2543)
+- Pass value in `PromiseV2#always` just like `PromiseV1#always` does it (#2579)
+- `#hash` now returns integers #2582)
 
 ### Fixed
 
@@ -53,6 +55,13 @@ This release brings a lot of performance improvements, our tests on Asciidoctor
 - Propagate removal of method from included/prepended modules (#2553)
 - Restore `nodejs/yaml` functionality (#2551)
 - Fix sine `Range#size` edge cases (#2541)
+- Use a Map instead of a POJO for the jsid_cache (#2584)
+- Fix `String#object_id`, `String#__id__`, `String#hash` to match CRuby's behavior (#2576)
+- Lowercase response headers in `SimpleServer` for rack 3.0 compatibility (#2578)
+- Fix `Module#clone` and `Module#dup` to properly copy methods (#2572)
+- Chrome runner fix: support code that contains `</script>` (#2581)
+- Do not skip `$truthy` when left hand side of a comparison is `self` (#2596)
+- Unexpected `return`/`break` should raise `LocalJumpError` (#2591)
 
 ### Added
 
@@ -67,6 +76,7 @@ This release brings a lot of performance improvements, our tests on Asciidoctor
 ### Documentation
 
 - Bridging documentation (#2541)
+- Fix Typo in Running tests Section of README.md File (#2580)
 
 ### Performance
 
@@ -78,6 +88,10 @@ This release brings a lot of performance improvements, our tests on Asciidoctor
 - Optimize argument slicing in runtime for performance (#2555)
 - Closure: Generate a JavaScript object, not an Error, gain up to 15% on Asciidoctor (#2556)
 - Optimize `String#split` and `String#start_with` (#2560)
+- Compute `$@` dynamically (#2592)
+- Optimize the `$prop` helper (#2597)
+- Improve `Array.push()` performance when pushing many items (#2565)
+- 
 
 ### Internal
 

data/docs/releasing.md

@@ -8,21 +8,14 @@ _This guide is a work-in-progress._
 
 All of the following is now covered by `bin/rake release:prepare VERSION=v1.2.3`
 
-### Updating the version
-
-- Update `lib/opal/version.rb`
-- Update `opal/corelib/constants.rb` with the same version number along with release dates
-
-### Updating the changelog
-
-- Ensure all the unreleased changes are documented in UNRELEASED.md
-- [skip for pre-releases] Run `bin/rake changelog VERSION=v1.2.3` specifying the version number you're about to release
-- [skip for pre-releases] Empty UNRELEASED.md
-
-### The commit
-
-- Commit the updated changelog along with the version bump using this commit message:
-  "Release v1.2.3"
+1. Update the version
+  - Update `lib/opal/version.rb`
+  - Update `opal/corelib/constants.rb` with the same version number along with release dates
+2. Update the changelog
+  - Ensure all the unreleased changes are documented in UNRELEASED.md
+  - [skip for pre-releases] Run `bin/rake changelog VERSION=v1.2.3` specifying the version number you're about to release
+  - [skip for pre-releases] Empty UNRELEASED.md
+3. Commit the updated changelog along with the version bump using this commit message: "Release v1.2.3"
 
 ---
 
@@ -56,4 +49,3 @@ All of the following is now covered by `bin/rake release:prepare VERSION=v1.2.3`
 - Create a new pull request that:
   - Updates a version to `v1.x.0.dev` in both `lib/opal/version.rb` and `opal/corelib/constants.rb`
 - Remember to merge that PR before merging anything else next once we decide to not release any more point releases from `master`.
-

data/lib/opal/cli_runners/chrome.rb

@@ -70,6 +70,10 @@ module Opal
         ext = builder.output_extension
         module_type = ' type="module"' if builder.esm?
 
+        # Some maps may contain `</script>` fragment (eg. in strings) which would close our
+        # `<script>` tag prematurely. For this case, we need to escape the `</script>` tag.
+        map_json = map.to_json.gsub(/(<\/scr)(ipt>)/i, '\1"+"\2')
+
         # Chrome can't handle huge data passed to `addScriptToEvaluateOnLoad`
         # https://groups.google.com/a/chromium.org/forum/#!topic/chromium-discuss/U5qyeX_ydBo
         # The only way is to create temporary files and pass them to chrome.
@@ -86,7 +90,7 @@ module Opal
             sourceMapSupport.install({
               retrieveSourceMap: function(path) {
                 return path.endsWith('/index.#{ext}') ? {
-                  url: './index.map', map: #{map.to_json}
+                  url: './index.map', map: #{map_json}
                 } : null;
               }
             });

data/lib/opal/nodes/closure.rb

@@ -102,7 +102,7 @@ module Opal
         def generate_thrower(type, closure, value)
           id = closure.register_catcher(type)
           closure.register_thrower(type, id)
-          push id, '.$throw(', expr_or_empty(value), ')'
+          push id, '.$throw(', expr_or_nil(value), ', ', scope.identify!, '.$$is_lambda)'
           id
         end
 
@@ -113,11 +113,11 @@ module Opal
             id = closure.throwers[type]
           else
             id = compiler.unique_temp('t_')
-            scope = closure.node.scope&.parent || top_scope
-            scope.add_scope_temp("#{id} = $thrower('#{type}')")
+            parent_scope = closure.node.scope&.parent || top_scope
+            parent_scope.add_scope_temp("#{id} = $thrower('#{type}')")
             closure.register_thrower(type, id)
           end
-          push id, '.$throw(', expr_or_empty(value), ')'
+          push id, '.$throw(', expr_or_nil(value), ', ', scope.identify!, '.$$is_lambda)'
           id
         end
 
@@ -132,7 +132,7 @@ module Opal
               if iter_closure
                 generate_thrower_without_catcher(:return, iter_closure, value)
               elsif compiler.eval?
-                push 'Opal.t_eval_return.$throw(', expr_or_empty(value), ')'
+                push 'Opal.t_eval_return.$throw(', expr_or_nil(value), ', false)'
               else
                 error 'Invalid return'
               end
@@ -211,9 +211,11 @@ module Opal
 
           helper :thrower
 
+          catchers_without_eval_return = catchers.grep_v(:eval_return)
+
           push "} catch($e) {"
           indent do
-            @closure.catchers.each do |type|
+            catchers.each do |type|
               case type
               when :eval_return
                 line "if ($e === Opal.t_eval_return) return $e.$v;"
@@ -225,9 +227,15 @@ module Opal
           end
           line "}"
 
+          unless catchers_without_eval_return.empty?
+            push " finally {", *catchers_without_eval_return.map { |type| "$t_#{type}.is_orphan = true;" }, "}"
+          end
+
           unshift "return " if closure_is? SEND
 
-          unshift "var ", catchers.map { |type| "$t_#{type} = $thrower('#{type}')" }.join(", "), "; "
+          unless catchers_without_eval_return.empty?
+            unshift "var ", catchers_without_eval_return.map { |type| "$t_#{type} = $thrower('#{type}')" }.join(", "), "; "
+          end
           unshift "try { "
 
           unless closure_is? JS_FUNCTION

data/lib/opal/nodes/defined.rb

@@ -80,7 +80,7 @@ module Opal
         push '  if (Opal.rescue($err, [Opal.Exception])) {'
         push '    try {'
         push '      return false;'
-        push '    } finally { Opal.pop_exception() }'
+        push '    } finally { Opal.pop_exception($err); }'
         push '  } else { throw $err; }'
         push '}})())'
 

data/lib/opal/nodes/literal.rb

@@ -5,14 +5,10 @@ require 'opal/nodes/base'
 module Opal
   module Nodes
     class ValueNode < Base
-      handle :true, :false, :self, :nil
+      handle :true, :false, :nil
 
       def compile
-        if type == :self
-          push scope.self
-        else
-          push type.to_s
-        end
+        push type.to_s
       end
 
       def self.truthy_optimize?
@@ -20,6 +16,14 @@ module Opal
       end
     end
 
+    class SelfNode < Base
+      handle :self
+
+      def compile
+        push scope.self
+      end
+    end
+
     class NumericNode < Base
       handle :int, :float
 

data/lib/opal/nodes/rescue.rb

@@ -211,7 +211,7 @@ module Opal
               line stmt(rescue_body)
             end
           end
-          line '} finally { Opal.pop_exception(); }'
+          line '} finally { Opal.pop_exception($err); }'
         end
         line '}'
       end

data/lib/opal/simple_server.rb

@@ -51,7 +51,7 @@ class Opal::SimpleServer
     asset = fetch_asset(path)
     [
       200,
-      { 'Content-Type' => 'application/javascript' },
+      { 'content-type' => 'application/javascript' },
       [asset[:data], "\n", asset[:map].to_data_uri_comment],
     ]
   end
@@ -99,6 +99,6 @@ class Opal::SimpleServer
       </html>
       HTML
     end
-    [200, { 'Content-Type' => 'text/html' }, [html]]
+    [200, { 'content-type' => 'text/html' }, [html]]
   end
 end

data/lib/opal/version.rb

@@ -3,5 +3,5 @@
 module Opal
   # WHEN RELEASING:
   # Remember to update RUBY_ENGINE_VERSION in opal/corelib/constants.rb too!
-  VERSION = '1.8.0.alpha1'
+  VERSION = '1.8.0.beta1'
 end

data/opal/corelib/array.rb

@@ -1,4 +1,4 @@
-# helpers: truthy, falsy, hash_ids, yield1, hash_get, hash_put, hash_delete, coerce_to, respond_to, deny_frozen_access, freeze
+# helpers: truthy, falsy, yield1, hash_get, hash_put, hash_delete, coerce_to, respond_to, deny_frozen_access, freeze, opal32_init, opal32_add
 # backtick_javascript: true
 
 require 'corelib/enumerable'
@@ -76,6 +76,22 @@ class ::Array < `Array`
       }
       return #{`array`.to_a};
     }
+
+    function fast_push(arr, objects) {
+      // push.apply() for arrays longer than 32767 may cause various argument errors in browsers
+      // but it is significantly faster than a for loop, which pushes each element separately
+      // but apply() has a overhead by itself, for a small number of elements
+      // the for loop is significantly faster
+      // this is using the best option depending on objects.length
+      var length = objects.length;
+      if (length > 6 && length < 32767) {
+        arr.push.apply(arr, objects);
+      } else {
+        for (var i = 0; i < length; i++) {
+          arr.push(objects[i]);
+        }
+      }
+    }
   }
 
   def self.[](*objects)
@@ -99,7 +115,7 @@ class ::Array < `Array`
       }
 
       if (arguments.length === 0) {
-        self.splice(0, self.length);
+        if (self.length > 0) self.splice(0, self.length);
         return self;
       }
 
@@ -253,7 +269,7 @@ class ::Array < `Array`
     end
 
     %x{
-      if (#{hash} === #{other.hash}) {
+      if (#{self} === #{other}) {
         return 0;
       }
 
@@ -1216,7 +1232,7 @@ class ::Array < `Array`
             result.push(ary);
             break;
           default:
-            result.push.apply(result, _flatten(ary, level - 1));
+            fast_push(result, _flatten(ary, level - 1));
           }
         }
         return result;
@@ -1260,27 +1276,31 @@ class ::Array < `Array`
     `$freeze(self)`
   end
 
+  `var $hash_ids`
+
   def hash
     %x{
       var top = ($hash_ids === undefined),
-          result = ['A'],
+          result = $opal32_init(),
           hash_id = self.$object_id(),
           item, i, key;
 
-      try {
-        if (top) {
-          $hash_ids = Object.create(null);
-        }
+      result = $opal32_add(result, 0xA);
+      result = $opal32_add(result, self.length);
 
-        // return early for recursive structures
-        if ($hash_ids[hash_id]) {
-          return 'self';
-        }
+      if (top) {
+        $hash_ids = Object.create(null);
+      }
+      // return early for recursive structures
+      else if ($hash_ids[hash_id]) {
+        return $opal32_add(result, 0x01010101);
+      }
 
+      try {
         for (key in $hash_ids) {
           item = $hash_ids[key];
           if (#{eql?(`item`)}) {
-            return 'self';
+            return $opal32_add(result, 0x01010101);
           }
         }
 
@@ -1288,10 +1308,10 @@ class ::Array < `Array`
 
         for (i = 0; i < self.length; i++) {
           item = self[i];
-          result.push(item.$hash());
+          result = $opal32_add(result, item.$hash());
         }
 
-        return result.join(',');
+        return result;
       } finally {
         if (top) {
           $hash_ids = undefined;
@@ -1741,9 +1761,7 @@ class ::Array < `Array`
     %x{
       $deny_frozen_access(self);
 
-      for (var i = 0, length = objects.length; i < length; i++) {
-        self.push(objects[i]);
-      }
+      fast_push(self, objects);
     }
 
     self
@@ -1801,8 +1819,8 @@ class ::Array < `Array`
     other = `convertToArray(other)`
 
     %x{
-      self.splice(0, self.length);
-      self.push.apply(self, other);
+      if (self.length > 0) self.splice(0, self.length);
+      fast_push(self, other);
     }
 
     self

data/opal/corelib/class.rb

@@ -24,6 +24,32 @@ class ::Class
     }
   end
 
+  def clone(freeze: nil)
+    unless freeze.nil? || freeze == true || freeze == false
+      raise ArgumentError, "unexpected value for freeze: #{freeze.class}"
+    end
+
+    copy = `Opal.allocate_class(nil, self.$$super)`
+    copy.copy_instance_variables(self)
+    copy.copy_singleton_methods(self)
+    copy.initialize_clone(self, freeze: freeze)
+
+    if freeze == true || (freeze.nil? && frozen?)
+      copy.freeze
+    end
+
+    copy
+  end
+
+  def dup
+    copy = `Opal.allocate_class(nil, self.$$super)`
+
+    copy.copy_instance_variables(self)
+    copy.initialize_dup(self)
+
+    copy
+  end
+
   def descendants
     subclasses + subclasses.map(&:descendants).flatten
   end
@@ -31,14 +57,6 @@ class ::Class
   def inherited(cls)
   end
 
-  def initialize_dup(original)
-    initialize_copy(original)
-    %x{
-      self.$$name = null;
-      self.$$full_name = null;
-    }
-  end
-
   def new(*args, &block)
     %x{
       var object = #{allocate};

data/opal/corelib/complex.rb

@@ -180,7 +180,7 @@ class ::Complex < ::Numeric
   end
 
   def hash
-    "Complex:#{@real}:#{@imag}"
+    [::Complex, @real, @imag].hash
   end
 
   def infinite?

data/opal/corelib/constants.rb

@@ -1,8 +1,8 @@
 ::RUBY_PLATFORM       = 'opal'
 ::RUBY_ENGINE         = 'opal'
 ::RUBY_VERSION        = '3.2.0'
-::RUBY_ENGINE_VERSION = '1.8.0.alpha1'
-::RUBY_RELEASE_DATE   = '2023-08-04'
+::RUBY_ENGINE_VERSION = '1.8.0.beta1'
+::RUBY_RELEASE_DATE   = '2023-10-12'
 ::RUBY_PATCHLEVEL     = 0
 ::RUBY_REVISION       = '0'
 ::RUBY_COPYRIGHT      = 'opal - Copyright (C) 2011-2023 Adam Beynon and the Opal contributors'

data/opal/corelib/enumerator/arithmetic_sequence.rb

@@ -153,7 +153,7 @@ class ::Enumerator
     end
 
     def hash
-      [self.begin, self.end, step, exclude_end?].hash
+      [ArithmeticSequence, self.begin, self.end, step, exclude_end?].hash
     end
 
     def inspect

data/opal/corelib/error.rb

@@ -316,6 +316,16 @@ class ::KeyError
   end
 end
 
+class ::LocalJumpError
+  attr_reader :exit_value, :reason
+
+  def initialize(message, exit_value = nil, reason = :noreason)
+    super message
+    @exit_value = exit_value
+    @reason = reason
+  end
+end
+
 module ::JS
   class Error
   end

data/opal/corelib/hash.rb

@@ -1,4 +1,4 @@
-# helpers: yield1, hash_clone, hash_delete, hash_each, hash_get, hash_put, deny_frozen_access, freeze
+# helpers: yield1, hash_clone, hash_delete, hash_each, hash_get, hash_put, deny_frozen_access, freeze, opal32_init, opal32_add
 # backtick_javascript: true
 
 require 'corelib/enumerable'
@@ -481,41 +481,53 @@ class ::Hash < `Map`
     }
   end
 
+  `var $hash_ids`
+
   def hash
     %x{
-      var top = (Opal.hash_ids === undefined),
+      var top = ($hash_ids === undefined),
           hash_id = self.$object_id(),
-          result = ['Hash'],
-          key, item;
+          result = $opal32_init(),
+          key, item, i,
+          size = self.size, ary = new Int32Array(size);
 
-      try {
-        if (top) {
-          Opal.hash_ids = Object.create(null);
-        }
+      result = $opal32_add(result, 0x4);
+      result = $opal32_add(result, size);
 
-        if (Opal[hash_id]) {
-          return 'self';
-        }
+      if (top) {
+        $hash_ids = Object.create(null);
+      }
+      else if ($hash_ids[hash_id]) {
+        return $opal32_add(result, 0x01010101);
+      }
 
-        for (key in Opal.hash_ids) {
-          item = Opal.hash_ids[key];
+      try {
+        for (key in $hash_ids) {
+          item = $hash_ids[key];
           if (#{eql?(`item`)}) {
-            return 'self';
+            return $opal32_add(result, 0x01010101);
           }
         }
 
-        Opal.hash_ids[hash_id] = self;
+        $hash_ids[hash_id] = self;
+        i = 0
 
         $hash_each(self, false, function(key, value) {
-          result.push([key, value.$hash()]);
+          ary[i] = [0x70414952, key, value].$hash();
+          i++;
           return [false, false];
         });
 
-        return result.sort().join();
+        ary = ary.sort();
+
+        for (i = 0; i < ary.length; i++) {
+          result = $opal32_add(result, ary[i]);
+        }
 
+        return result;
       } finally {
         if (top) {
-          Opal.hash_ids = undefined;
+          $hash_ids = undefined;
         }
       }
     }

data/opal/corelib/kernel.rb

@@ -687,7 +687,6 @@ module ::Kernel
       }
 
       #{$!} = exception;
-      #{$@} = #{`exception`.backtrace};
 
       throw exception;
     }

data/opal/corelib/module.rb

@@ -733,11 +733,50 @@ class ::Module
     }
   end
 
-  def dup
-    copy = super
-    copy.copy_class_variables(self)
-    copy.copy_constants(self)
-    copy
+  %x{
+    function copyInstanceMethods(from, to) {
+      var i, method_names = Opal.own_instance_methods(from);
+      for (i = 0; i < method_names.length; i++) {
+        var name = method_names[i],
+            jsid = $jsid(name),
+            body = from.$$prototype[jsid],
+            wrapped = Opal.wrapMethodBody(body);
+
+        wrapped.$$jsid = name;
+        Opal.defn(to, jsid, wrapped);
+      }
+    }
+
+    function copyIncludedModules(from, to) {
+      var modules = from.$$own_included_modules;
+      for (var i = modules.length - 1; i >= 0; i--) {
+        Opal.append_features(modules[i], to);
+      }
+    }
+
+    function copyPrependedModules(from, to) {
+      var modules = from.$$own_prepended_modules;
+      for (var i = modules.length - 1; i >= 0; i--) {
+        Opal.prepend_features(modules[i], to);
+      }
+    }
+  }
+
+  def initialize_copy(other)
+    %x{
+      copyInstanceMethods(other, self);
+      copyIncludedModules(other, self);
+      copyPrependedModules(other, self);
+      self.$$cloned_from = other.$$cloned_from.concat(other);
+    }
+    copy_class_variables(other)
+    copy_constants(other)
+  end
+
+  def initialize_dup(other)
+    super
+    # Unlike other classes, Module's singleton methods are copied on Object#dup.
+    copy_singleton_methods(other)
   end
 
   def copy_class_variables(other)