opal 1.7.2 → 1.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3221ae5854f26b0d0722ddf2689773633648086a616add372e8fdd617b31d7c0
-  data.tar.gz: b6b4a65b1905bddb6c1fd2310b13c03600ef4bb8fb416fff54e5499bfae8616c
+  metadata.gz: 8af0b92263196be9125b7ba0d1133b9a157aed0da2d91e282320ef8a8ce9a1a3
+  data.tar.gz: 8d05dfd7e6dcc883c27f674ddebc84e57c29e80c33b981d70118f44d869d80d0
 SHA512:
-  metadata.gz: 5a009bcca000c8fef3d73cda99453023b2860615e4c4c7176e328448cd12d5f26bbf6d2809ca040f064e64af7b04ddb94857b35ac36486a0c7996be28a63230b
-  data.tar.gz: d9154247ad9e90fbc770d647524db30fc8132b3fb77f8c5115abb67a3507fe66c0f7306a2965f1aca11bc790b2f6b7308d7db7bda7e9c3443b54bce42a957bab
+  metadata.gz: 52adf7dafb792d434e9d423d0f4340df8d114071e94de6165856e8396476bfca9193ba1831464bf2f701e9978f9a7674de3590680f8a1264e542cd1f0715f2b2
+  data.tar.gz: 6f73fb32a7837daf9ad771a75cb0f549b0a69a968b8f18fa40d1a05f66ac61109dde51b6e9717def8942dd4068c532dc413e0fdb2541d80ab7596db3d6ed4db1

data/CHANGELOG.md

@@ -16,7 +16,7 @@ Changes are grouped as follows:
 
 
 
-## [1.7.2](https://github.com/opal/opal/compare/v1.7.1...v1.7.2) - 2023-01-20
+## [1.7.3](https://github.com/opal/opal/compare/v1.7.2...v1.7.3) - 2023-03-23
 
 
 <!--
@@ -26,9 +26,23 @@ Changes are grouped as follows:
 ### Removed
 ### Deprecated
 ### Performance
-### Fixed
 -->
 
+### Fixed
+
+- Disallow to define a singleton class for Number ([#2521](https://github.com/opal/opal/pull/2521))
+- Fix eval with parser gem v3.2.1 ([#2526](https://github.com/opal/opal/pull/2526))
+- Fix certain encoding issues when using Prefork ([#2527](https://github.com/opal/opal/pull/2527))
+- Fix Chrome CDP interface connection ([#2528](https://github.com/opal/opal/pull/2528))
+- Fix for Opal::Cache::FileCache.dir_writable? ([#2529](https://github.com/opal/opal/pull/2529))
+- Fix Array#sample randomness ([#2530](https://github.com/opal/opal/pull/2530))
+
+
+
+
+## [1.7.2](https://github.com/opal/opal/compare/v1.7.1...v1.7.2) - 2023-01-20
+
+
 ### Fixed
 
 - Fix the `--debug-source-map` CLI option ([#2520](https://github.com/opal/opal/pull/2520))

data/docs/index.md

@@ -8,7 +8,7 @@ The guides for earlier releases are [available here](/docs).
 
 ## Start here
 
-#### [Getting Started with Opal](etting_started.html)
+#### [Getting Started with Opal](getting_started.html)
 
 Everything you need to know to install Opal and create your first application.
 

data/lib/opal/builder_scheduler/prefork.rb

@@ -131,8 +131,8 @@ module Opal
 
       class Fork
         def initialize(forkset)
-          @parent_read, @child_write = IO.pipe
-          @child_read, @parent_write = IO.pipe
+          @parent_read, @child_write = IO.pipe(binmode: true)
+          @child_read, @parent_write = IO.pipe(binmode: true)
           @forkset = forkset
           @in_fork = false
 

data/lib/opal/cache/file_cache.rb

@@ -78,19 +78,16 @@ module Opal
         nil
       end
 
-      # This complex piece of code tries to check if we can robustly mkdir_p a directory.
+      # Check if we can robustly mkdir_p a directory.
       def self.dir_writable?(*paths)
-        dir = nil
-        paths = paths.reduce([]) do |a, b|
-          [*a, dir = a.last ? File.expand_path(b, a.last) : b]
-        end
+        return false unless File.exist?(paths.first)
 
-        File.exist?(paths.first) &&
-          paths.reverse.all? do |i|
-            !File.exist?(i) || (File.directory?(i) && File.writable?(i))
-          end
+        until paths.empty?
+          dir = File.expand_path(paths.shift, dir)
+          ok = File.directory?(dir) && File.writable?(dir) if File.exist?(dir)
+        end
 
-        dir
+        dir if ok
       end
 
       def self.find_dir

data/lib/opal/cli_runners/chrome_cdp_interface.rb

@@ -121,14 +121,16 @@ var server = http.createServer(function(req, res) {
 
 // actual CDP code
 
-CDP.List(options, function(err, targets) {
+CDP.List(options, async function(err, targets) {
   // default CDP port is 9222, Firefox runner is at 9333
   // Lets collect clients for
   // Chrome CDP starting at 9273 ...
   // Firefox CDP starting 9334 ...
   port_offset = targets ? targets.length + 51 : 51; // default CDP port is 9222, Node CDP port 9229, Firefox is at 9333
 
-  return CDP(options, function(browser_client) {
+  const {webSocketDebuggerUrl} = await CDP.Version(options);
+
+  return await CDP({target: webSocketDebuggerUrl}, function(browser_client) {
 
     server.listen({ port: port_offset + options.port, host: options.host });
 

data/lib/opal/cli_runners/firefox_cdp_interface.rb

@@ -94,10 +94,12 @@ var server = http.createServer(function(req, res) {
 
 // actual CDP code
 
-CDP.List(options, function(err, targets) {
+CDP.List(options, async function(err, targets) {
   offset = targets ? targets.length + 1 : 1;
 
-  return CDP(options, function(browser_client) {
+  const {webSocketDebuggerUrl} = await CDP.Version(options);
+
+  return await CDP({target: webSocketDebuggerUrl}, function(browser_client) {
 
     server.listen({port: offset + options.port, host: options.host });
 

data/lib/opal/parser/patch.rb

@@ -13,6 +13,12 @@ if RUBY_ENGINE == 'opal'
       else
         @source_pts = nil
       end
+
+      # Since parser v3.2.1 Parser::Lexer has @strings
+      if @strings
+        @strings.source_buffer = @source_buffer
+        @strings.source_pts = @source_pts
+      end
     end
   end
 

data/lib/opal/version.rb

@@ -3,5 +3,5 @@
 module Opal
   # WHEN RELEASING:
   # Remember to update RUBY_ENGINE_VERSION in opal/corelib/constants.rb too!
-  VERSION = '1.7.2'
+  VERSION = '1.7.3'
 end

data/opal/corelib/array.rb

@@ -1927,9 +1927,9 @@ class ::Array < `Array`
           break;
         case 2:
           i = #{rng.rand(`self.length`)};
-          j = #{rng.rand(`self.length`)};
-          if (i === j) {
-            j = i === 0 ? i + 1 : i - 1;
+          j = #{rng.rand(`self.length - 1`)};
+          if (i <= j) {
+            j++;
           }
           return [self[i], self[j]];
           break;
@@ -1981,7 +1981,7 @@ class ::Array < `Array`
           result = self.slice();
 
           for (var c = 0; c < count; c++) {
-            targetIndex = #{rng.rand(`self.length`)};
+            targetIndex = #{rng.rand(`self.length - c`)} + c;
             oldValue = result[c];
             result[c] = result[targetIndex];
             result[targetIndex] = oldValue;

data/opal/corelib/constants.rb

@@ -1,8 +1,8 @@
 ::RUBY_PLATFORM       = 'opal'
 ::RUBY_ENGINE         = 'opal'
 ::RUBY_VERSION        = '3.2.0'
-::RUBY_ENGINE_VERSION = '1.7.2'
-::RUBY_RELEASE_DATE   = '2023-01-20'
+::RUBY_ENGINE_VERSION = '1.7.3'
+::RUBY_RELEASE_DATE   = '2023-03-23'
 ::RUBY_PATCHLEVEL     = 0
 ::RUBY_REVISION       = '0'
 ::RUBY_COPYRIGHT      = 'opal - Copyright (C) 2011-2023 Adam Beynon and the Opal contributors'

data/opal/corelib/runtime.js

@@ -824,6 +824,9 @@
   // @param object [Object] the ruby object
   // @return [Class] the singleton class for object
   Opal.get_singleton_class = function(object) {
+    if (object.$$is_number) {
+      $raise(Opal.TypeError, "can't define singleton");
+    }
     if (object.$$meta) {
       return object.$$meta;
     }

data/spec/filters/bugs/array.rb

@@ -27,7 +27,6 @@ opal_filter "Array" do
   fails "Array#rassoc calls elem == obj on the second element of each contained array" # Expected [1, "foobar"] == [2, #<MockObject:0x4a6b4 @name="foobar", @null=nil>] to be truthy but was false
   fails "Array#rassoc does not check the last element in each contained but specifically the second" # Expected [1, "foobar", #<MockObject:0x4a37e @name="foobar", @null=nil>] == [2, #<MockObject:0x4a37e @name="foobar", @null=nil>, 1] to be truthy but was false
   fails "Array#sample returns nil for an empty array when called without n and a Random is given" # ArgumentError: invalid argument - 0
-  fails "Array#sample samples evenly" # Expected 15.82 <= 13.277 to be truthy but was false
   fails "Array#select returns a new array of elements for which block is true" # Expected [1] == [1, 4, 6] to be truthy but was false
   fails "Array#slice can be sliced with Enumerator::ArithmeticSequence has endless range with start outside of array's bounds" # Expected [] == nil to be truthy but was false
   fails "Array#slice can be sliced with Enumerator::ArithmeticSequence has range with bounds outside of array" # Expected RangeError but no exception was raised ([0, 2, 4] was returned)

data/spec/filters/bugs/integer.rb

@@ -1,6 +1,5 @@
 # NOTE: run bin/format-filters after changing this file
 opal_filter "Integer" do
-  fails "A singleton class raises a TypeError for Integer's" # Expected TypeError but got: Exception (Object.defineProperty called on non-object)
   fails "Bignum is deprecated" # NameError: uninitialized constant Bignum
   fails "Bignum is unified into Integer" # NameError: uninitialized constant Bignum
   fails "Fixnum is deprecated" # Expected warning to match: /constant ::Fixnum is deprecated/ but got: ""

data/spec/filters/bugs/kernel.rb

@@ -134,7 +134,6 @@ opal_filter "Kernel" do
   fails "Kernel#respond_to? throws a type error if argument can't be coerced into a Symbol" # Expected TypeError (/is not a symbol nor a string/) but no exception was raised (false was returned)
   fails "Kernel#respond_to_missing? causes #respond_to? to return false if called and returning nil" # Expected nil to be false
   fails "Kernel#respond_to_missing? causes #respond_to? to return true if called and not returning false" # Expected "glark" to be true
-  fails "Kernel#singleton_class raises TypeError for Integer" # Expected TypeError but got: Exception (Object.defineProperty called on non-object)
   fails "Kernel#singleton_class raises TypeError for Symbol" # Expected TypeError but no exception was raised (#<Class:#<String:0x53aaa>> was returned)
   fails "Kernel#singleton_method find a method defined on the singleton class" # NoMethodError: undefined method `singleton_method' for #<Object:0x4540a>
   fails "Kernel#singleton_method only looks at singleton methods and not at methods in the class" # Expected NoMethodError == NameError to be truthy but was false

data/spec/filters/bugs/language.rb

@@ -16,7 +16,6 @@ opal_filter "language" do
   fails "A block yielded a single Array when non-symbol keys are in a keyword arguments Hash does not separate non-symbol keys and symbol keys and does not autosplat" # Expected [nil, {"a"=>10, "b"=>2}] == [[{"a"=>10, "b"=>2}], {}] to be truthy but was false
   fails "A block yielded a single Object receives the object if it does not respond to #respond_to?" # NoMethodError: undefined method `respond_to?' for #<BasicObject:0x551e>
   fails "A class definition extending an object (sclass) can use return to cause the enclosing method to return" # Expected "outer" == "inner" to be truthy but was false
-  fails "A class definition extending an object (sclass) raises a TypeError when trying to extend numbers" # Expected TypeError but got: Exception (Object.defineProperty called on non-object)
   fails "A class definition raises TypeError if any constant qualifying the class is not a Module" # Expected TypeError but no exception was raised (nil was returned)
   fails "A class definition raises TypeError if the constant qualifying the class is nil" # Expected TypeError but no exception was raised (nil was returned)
   fails "A class definition raises a TypeError if inheriting from a metaclass" # Expected TypeError but no exception was raised (nil was returned)
@@ -50,7 +49,6 @@ opal_filter "language" do
   fails "A nested method definition creates an instance method when evaluated in an instance method" # NoMethodError: undefined method `an_instance_method' for #<DefSpecNested:0x1064c>
   fails "A number literal can be a decimal literal with trailing 'r' to represent a Rational" # Expected (5404319552844595/18014398509481984) == (3/10) to be truthy but was false
   fails "A number literal can be a float literal with trailing 'r' to represent a Rational" # Expected (5030569068109113/288230376151711740) == (136353847812057/7812500000000000) to be truthy but was false
-  fails "A singleton class doesn't have singleton class" # Expected TypeError but got: Exception (Object.defineProperty called on non-object)
   fails "A singleton class raises a TypeError for symbols" # Expected TypeError but no exception was raised (#<Class:#<String:0x9093e>> was returned)
   fails "A singleton method definition can be declared for a global variable" # TypeError: can't define singleton
   fails "A singleton method definition raises FrozenError with the correct class name" # Expected "can't modify frozen Class: #<Class:#<Object:0x10574>>".start_with? "can't modify frozen object" to be truthy but was false
@@ -325,7 +323,6 @@ opal_filter "language" do
   fails "a method definition that sets more than one default parameter all to the same value treats the argument after the multi-parameter normally" # Expected ArgumentError (wrong number of arguments (given 3, expected 0..2)) but got: ArgumentError ([MSpecEnv#bar] wrong number of arguments (given 3, expected -1))
   fails "kwarg with omitted value in a method call accepts short notation 'kwarg' in method call for definition 'def call(*args, **kwargs) = [args, kwargs]'" # NameError: uninitialized constant SpecEvaluate::a
   fails "kwarg with omitted value in a method call with methods and local variables for definition \n    def call(*args, **kwargs) = [args, kwargs]\n    def bar\n      \"baz\"\n    end\n    def foo(val)\n      call bar:, val:\n    end" # NameError: uninitialized constant SpecEvaluate::bar
-  fails "self in a metaclass body (class << obj) raises a TypeError for numbers" # Expected TypeError but got: Exception (Object.defineProperty called on non-object)
   fails "self in a metaclass body (class << obj) raises a TypeError for symbols" # Expected TypeError but got: Exception (Cannot create property '$$meta' on string 'symbol')
   fails "self.send(:block_given?) returns false when a method defined by define_method is called with a block" # NoMethodError: undefined method `block_given?' for KernelSpecs::SelfBlockGiven
   fails "self.send(:block_given?) returns true if and only if a block is supplied" # NoMethodError: undefined method `block_given?' for KernelSpecs::SelfBlockGiven

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: opal
 version: !ruby/object:Gem::Version
-  version: 1.7.2
+  version: 1.7.3
 platform: ruby
 authors:
 - Elia Schito
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-01-20 00:00:00.000000000 Z
+date: 2023-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast
@@ -1215,10 +1215,10 @@ licenses:
 metadata:
   homepage_uri: https://opalrb.com/
   bug_tracker_uri: https://github.com/opal/opal/issues
-  changelog_uri: https://github.com/opal/opal/blob/v1.7.2/CHANGELOG.md
-  readme_uri: https://github.com/opal/opal/blob/v1.7.2/README.md
-  api_documentation_uri: http://opalrb.com/docs/api/v1.7.2/index.html
-  guides_uri: http://opalrb.com/docs/guides/v1.7.2/index.html
+  changelog_uri: https://github.com/opal/opal/blob/v1.7.3/CHANGELOG.md
+  readme_uri: https://github.com/opal/opal/blob/v1.7.3/README.md
+  api_documentation_uri: http://opalrb.com/docs/api/v1.7.3/index.html
+  guides_uri: http://opalrb.com/docs/guides/v1.7.3/index.html
   chat_uri: https://gitter.im/opal/opal
   source_code_uri: https://github.com/opal/opal
 post_install_message:
@@ -1236,7 +1236,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.3
+rubygems_version: 3.4.5
 signing_key:
 specification_version: 4
 summary: Ruby runtime and core library for JavaScript